Changeset 249671 in webkit


Ignore:
Timestamp:
Sep 9, 2019 3:45:45 PM (5 years ago)
Author:
achristensen@apple.com
Message:

Deprecate unused SPI to preconnect to a server
​https://bugs.webkit.org/show_bug.cgi?id=201558

Reviewed by Youenn Fablet.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::preconnectTo): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/C/WKContext.cpp:

(WKContextPreconnectToServer):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _preconnectToServer:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::preconnectToServer): Deleted.

  • UIProcess/WebProcessPool.h:
Location:
trunk/Source/WebKit
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r249669 r249671  
     12019-09-09  Alex Christensen  <achristensen@webkit.org>
     2
     3        Deprecate unused SPI to preconnect to a server
     4        https://bugs.webkit.org/show_bug.cgi?id=201558
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * NetworkProcess/NetworkProcess.cpp:
     9        (WebKit::NetworkProcess::preconnectTo): Deleted.
     10        * NetworkProcess/NetworkProcess.h:
     11        * NetworkProcess/NetworkProcess.messages.in:
     12        * UIProcess/API/C/WKContext.cpp:
     13        (WKContextPreconnectToServer):
     14        * UIProcess/API/C/WKContextPrivate.h:
     15        * UIProcess/API/Cocoa/WKProcessPool.mm:
     16        (-[WKProcessPool _preconnectToServer:]):
     17        * UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
     18        * UIProcess/WebProcessPool.cpp:
     19        (WebKit::WebProcessPool::preconnectToServer): Deleted.
     20        * UIProcess/WebProcessPool.h:
     21
    1222019-09-09  Per Arne Vollan  <pvollan@apple.com>
    223

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp

    r249637 r249671  
    22242224}
    22252225
    2226 void NetworkProcess::preconnectTo(const URL& url, WebCore::StoredCredentialsPolicy storedCredentialsPolicy)
    2227 {
    2228 #if ENABLE(SERVER_PRECONNECT)
    2229     NetworkLoadParameters parameters { PAL::SessionID::defaultSessionID() };
    2230     parameters.request = ResourceRequest { url };
    2231     parameters.storedCredentialsPolicy = storedCredentialsPolicy;
    2232     parameters.shouldPreconnectOnly = PreconnectOnly::Yes;
    2233 
    2234     new PreconnectTask(*this, WTFMove(parameters));
    2235 #else
    2236     UNUSED_PARAM(url);
    2237     UNUSED_PARAM(storedCredentialsPolicy);
    2238 #endif
    2239 }
    2240 
    22412226void NetworkProcess::registerURLSchemeAsSecure(const String& scheme) const
    22422227{

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.h

    r249637 r249671  
    270270    void cacheStorageRootPath(PAL::SessionID, CacheStorageRootPathCallback&&);
    271271
    272     void preconnectTo(const URL&, WebCore::StoredCredentialsPolicy);
    273 
    274272    void setSessionIsControlledByAutomation(PAL::SessionID, bool);
    275273    bool sessionIsControlledByAutomation(PAL::SessionID) const;

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in

    r249501 r249671  
    8383    CancelPrepareToSuspend()
    8484    ProcessDidResume()
    85 
    86     PreconnectTo(URL url, enum:uint8_t WebCore::StoredCredentialsPolicy storedCredentialsPolicy);
    8785
    8886#if ENABLE(RESOURCE_LOAD_STATISTICS)

  • trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp

    r249622 r249671  
    434434}
    435435
    436 void WKContextPreconnectToServer(WKContextRef contextRef, WKURLRef serverURLRef)
    437 {
    438     WebKit::toImpl(contextRef)->preconnectToServer(URL(URL(), WebKit::toWTFString(serverURLRef)));
     436void WKContextPreconnectToServer(WKContextRef, WKURLRef)
     437{
    439438}
    440439

  • trunk/Source/WebKit/UIProcess/API/C/WKContextPrivate.h

    r248856 r249671  
    110110WK_EXPORT void WKContextSetFontWhitelist(WKContextRef, WKArrayRef);
    111111
    112 WK_EXPORT void WKContextPreconnectToServer(WKContextRef context, WKURLRef serverURL);
     112WK_EXPORT void WKContextPreconnectToServer(WKContextRef context, WKURLRef serverURL) WK_C_API_DEPRECATED;
    113113
    114114WK_EXPORT WKProcessID WKContextGetNetworkProcessIdentifier(WKContextRef context);

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm

    r248846 r249671  
    529529- (void)_preconnectToServer:(NSURL *)serverURL
    530530{
    531     _processPool->preconnectToServer(serverURL);
    532531}
    533532

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h

    r248181 r249671  
    116116+ (void)_forceGameControllerFramework WK_API_AVAILABLE(macos(10.13), ios(11.0));
    117117
    118 - (void)_preconnectToServer:(NSURL *)serverURL WK_API_AVAILABLE(macos(10.13.4), ios(11.3));
     118- (void)_preconnectToServer:(NSURL *)serverURL WK_API_DEPRECATED("If needed, SPI should be added to WKWebsiteDataStore", macos(10.13.4, WK_MAC_TBA), ios(11.3, WK_IOS_TBA));
    119119
    120120// Test only.

  • trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

    r249647 r249671  
    15241524}
    15251525
    1526 void WebProcessPool::preconnectToServer(const URL& url)
    1527 {
    1528     if (!url.isValid() || !url.protocolIsInHTTPFamily())
    1529         return;
    1530 
    1531     ensureNetworkProcess().send(Messages::NetworkProcess::PreconnectTo(url, StoredCredentialsPolicy::Use), 0);
    1532 }
    1533 
    15341526void WebProcessPool::registerURLSchemeAsLocal(const String& urlScheme)
    15351527{

  • trunk/Source/WebKit/UIProcess/WebProcessPool.h

    r249647 r249671  
    269269    void registerURLSchemeAsCanDisplayOnlyIfCanRequest(const String&);
    270270
    271     void preconnectToServer(const URL&);
    272 
    273271    VisitedLinkStore& visitedLinkStore() { return m_visitedLinkStore.get(); }
    274272
Note: See TracChangeset for help on using the changeset viewer.