Changeset 249856 in webkit

Timestamp:

Sep 13, 2019, 3:06:51 PM (5 years ago)

Author:

mark.lam@apple.com

Message:

We should never fail to allocate VA for the Gigacage.
​https://bugs.webkit.org/show_bug.cgi?id=201774
<rdar://problem/55352042>

Reviewed by Yusuke Suzuki.

Unfortunately, this is still not true for OS(LINUX). So, I'll leave the
GIGACAGE_ALLOCATION_CAN_FAIL code in place but disable it for everything else.

• bmalloc/Gigacage.h:

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Gigacage.h (modified) (3 diffs)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2019-09-13  Mark Lam  <mark.lam@apple.com>
+
+        We should never fail to allocate VA for the Gigacage.
+        https://bugs.webkit.org/show_bug.cgi?id=201774
+        <rdar://problem/55352042>
+
+        Reviewed by Yusuke Suzuki.
+
+        Unfortunately, this is still not true for OS(LINUX).  So, I'll leave the
+        GIGACAGE_ALLOCATION_CAN_FAIL code in place but disable it for everything else.
+
+        * bmalloc/Gigacage.h:
+
 2019-09-09  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/bmalloc/bmalloc/Gigacage.h

@@ -72 +72 @@
 constexpr size_t maximumCageSizeReductionForSlide = bmalloc::Sizes::GB / 4;
 constexpr size_t configSizeToProtect = 16 * bmalloc::Sizes::kB;
-#define GIGACAGE_ALLOCATION_CAN_FAIL 1
 #else
 constexpr size_t primitiveGigacageSize = 32 * bmalloc::Sizes::GB;
@@ -78 +77 @@
 constexpr size_t maximumCageSizeReductionForSlide = 4 * bmalloc::Sizes::GB;
 constexpr size_t configSizeToProtect = 4 * bmalloc::Sizes::kB;
-#define GIGACAGE_ALLOCATION_CAN_FAIL 0
 #endif
 
@@ -84 +82 @@
 // So we specify GIGACAGE_ALLOCATION_CAN_FAIL = 1.
 #if BOS(LINUX)
-#undef GIGACAGE_ALLOCATION_CAN_FAIL
 #define GIGACAGE_ALLOCATION_CAN_FAIL 1
+#else
+#define GIGACAGE_ALLOCATION_CAN_FAIL 0
 #endif