Changeset 250264 in webkit

Timestamp:

Sep 23, 2019, 4:33:36 PM (7 years ago)

Author:

mark.lam@apple.com

Message:

Lazy JSGlobalObject property materialization should not use putDirectWithoutTransition.
​https://bugs.webkit.org/show_bug.cgi?id=202122
<rdar://problem/55535249>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/lazy-global-object-property-materialization-should-not-putDirectWithoutTransition.js: Added.

Source/JavaScriptCore:

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/lazy-global-object-property-materialization-should-not-putDirectWithoutTransition.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSGlobalObject.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-09-23  Mark Lam  <mark.lam@apple.com>
+
+        Lazy JSGlobalObject property materialization should not use putDirectWithoutTransition.
+        https://bugs.webkit.org/show_bug.cgi?id=202122
+        <rdar://problem/55535249>
+
+        Reviewed by Yusuke Suzuki.
+
+        * stress/lazy-global-object-property-materialization-should-not-putDirectWithoutTransition.js: Added.
+
 2019-09-23  Caio Lima  <ticaiolima@gmail.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-09-23  Mark Lam  <mark.lam@apple.com>
+
+        Lazy JSGlobalObject property materialization should not use putDirectWithoutTransition.
+        https://bugs.webkit.org/show_bug.cgi?id=202122
+        <rdar://problem/55535249>
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::init):
+
 2019-09-23  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -599 +599 @@
             init.setStructure(JS ## type ## Array::createStructure(init.vm, init.global, init.prototype)); \
             init.setConstructor(JS ## type ## ArrayConstructor::create(init.vm, init.global, JS ## type ## ArrayConstructor::createStructure(init.vm, init.global, init.global->m_typedArraySuperConstructor.get(init.global)), init.prototype, #type "Array"_s, typedArrayConstructorAllocate ## type ## ArrayCodeGenerator(init.vm))); \
-            init.global->putDirectWithoutTransition(init.vm, init.vm.propertyNames->builtinNames().type ## ArrayPrivateName(), init.constructor, static_cast<unsigned>(PropertyAttribute::DontEnum)); \
+            init.global->putDirect(init.vm, init.vm.propertyNames->builtinNames().type ## ArrayPrivateName(), init.constructor, static_cast<unsigned>(PropertyAttribute::DontEnum)); \
         });
     FOR_EACH_TYPED_ARRAY_TYPE_EXCLUDING_DATA_VIEW(INIT_TYPED_ARRAY_LATER)