Changeset 250995 in webkit

Timestamp:

Oct 10, 2019, 4:44:01 PM (6 years ago)

Author:

mark.lam@apple.com

Message:

Modify JSTests/stress/string-overflow-createError-*.js tests to allow an OOME result.
​https://bugs.webkit.org/show_bug.cgi?id=202828

Reviewed by Yusuke Suzuki.

The tests intentionally allocate a very large string. Hence, for some memory
limited configurations, it is perfectly reasonable for the test to throw an Out
Of Memory error.

• stress/string-overflow-createError-builder.js:
• stress/string-overflow-createError-fit.js:

Location:

trunk/JSTests

Files:

• ChangeLog (modified) (1 diff)
• stress/string-overflow-createError-builder.js (modified) (1 diff)
• stress/string-overflow-createError-fit.js (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-10-10  Mark Lam  <mark.lam@apple.com>
+
+        Modify JSTests/stress/string-overflow-createError-*.js tests to allow an OOME result.
+        https://bugs.webkit.org/show_bug.cgi?id=202828
+
+        Reviewed by Yusuke Suzuki.
+
+        The tests intentionally allocate a very large string.  Hence, for some memory
+        limited configurations, it is perfectly reasonable for the test to throw an Out
+        Of Memory error.
+
+        * stress/string-overflow-createError-builder.js:
+        * stress/string-overflow-createError-fit.js:
+
 2019-10-09  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/JSTests/stress/string-overflow-createError-builder.js

@@ -12 +12 @@
 // when the StringBuilder for the error message overflows,
 // "object is not a function" is used as message for the TypeError.
-if (exception.message != "object is not a function.")
+if (exception.message != "object is not a function."
+    && exception != "Error: Out of memory")
     throw "FAILED";

trunk/JSTests/stress/string-overflow-createError-fit.js

@@ -13 +13 @@
 // it still fits into String::MaxLength. Check the start
 // of the error message.
-if (!exception.message.startsWith("foo is not a function"))
+if (!exception.message.startsWith("foo is not a function")
+    && exception != "Error: Out of memory")
     throw "FAILED";