Changeset 251264 in webkit

Timestamp:

Oct 17, 2019, 3:45:35 PM (6 years ago)

Author:

mark.lam@apple.com

Message:

Harden capacity checks in DFG::LocalCSEPhase::SmallMap.
​https://bugs.webkit.org/show_bug.cgi?id=203123
<rdar://problem/56339943>

Change addPure() and addImpure() to use RELEASE_ASSERT in their capacity checks.

Reviewed by Keith Miller.

• dfg/DFGCSEPhase.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGCSEPhase.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-10-17  Mark Lam  <mark.lam@apple.com>
+
+        Harden capacity checks in DFG::LocalCSEPhase::SmallMap.
+        https://bugs.webkit.org/show_bug.cgi?id=203123
+        <rdar://problem/56339943>
+
+        Change addPure() and addImpure() to use RELEASE_ASSERT in their capacity checks.
+
+        Reviewed by Keith Miller.
+
+        * dfg/DFGCSEPhase.cpp:
+
 2019-10-17  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp

@@ -386 +386 @@
             }
         
-            ASSERT(m_pureLength < capacity);
+            RELEASE_ASSERT(m_pureLength < capacity);
             m_pureMap[m_pureLength++] = WTF::KeyValuePair<PureValue, Node*>(value, node);
             return nullptr;
@@ -408 +408 @@
             if (LazyNode result = findReplacement(location))
                 return result;
-            ASSERT(m_impureLength < capacity);
+            RELEASE_ASSERT(m_impureLength < capacity);
             m_impureMap[m_impureLength++] = WTF::KeyValuePair<HeapLocation, LazyNode>(location, node);
             return nullptr;