Changeset 251568 in webkit

Timestamp:

Oct 24, 2019, 3:48:40 PM (5 years ago)

Author:

achristensen@apple.com

Message:

REGRESSION(r251409) Service worker connection should not be established without service worker entitlement
​https://bugs.webkit.org/show_bug.cgi?id=203385
<rdar://problem/37790257>

Reviewed by Chris Dumez.

r251409 introduced a new call to establishSWServerConnection that should have an entitlement check.
This was caught by a unit test in CI that is not easy to reproduce in WebKit's test. See the radar.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/NetworkConnectionToWebProcess.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-10-24  Alex Christensen  <achristensen@webkit.org>
+
+        REGRESSION(r251409) Service worker connection should not be established without service worker entitlement
+        https://bugs.webkit.org/show_bug.cgi?id=203385
+        <rdar://problem/37790257>
+
+        Reviewed by Chris Dumez.
+
+        r251409 introduced a new call to establishSWServerConnection that should have an entitlement check.
+        This was caught by a unit test in CI that is not easy to reproduce in WebKit's test.  See the radar.
+
+        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
+        (WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
+
 2019-10-24  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

@@ -107 +107 @@
 
 #if ENABLE(SERVICE_WORKER)
-    establishSWServerConnection();
+    if (networkProcess.parentProcessHasServiceWorkerEntitlement())
+        establishSWServerConnection();
 #endif
 }