Changeset 252558 in webkit

Timestamp:

Nov 18, 2019 12:35:59 PM (5 years ago)

Author:

mark.lam@apple.com

Message:

Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e. state Uninitialized).
​https://bugs.webkit.org/show_bug.cgi?id=204309

Reviewed by Saam Barati.

Added a RELEASE_ASSERT in OptionRange::operator=() to enforce that it should
never be called with any value other than 0.

• runtime/OptionsList.h:

(JSC::OptionRange::operator= ):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/OptionsList.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-11-18  Mark Lam  <mark.lam@apple.com>
+
+        Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e. state Uninitialized).
+        https://bugs.webkit.org/show_bug.cgi?id=204309
+
+        Reviewed by Saam Barati.
+
+        Added a RELEASE_ASSERT in OptionRange::operator=() to enforce that it should
+        never be called with any value other than 0.
+
+        * runtime/OptionsList.h:
+        (JSC::OptionRange::operator= ):
+
 2019-11-18  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/OptionsList.h

@@ -552 +552 @@
     enum RangeState { Uninitialized, InitError, Normal, Inverted };
 public:
-    OptionRange& operator= (const int& rhs)
-    { // Only needed for initialization
-        if (!rhs) {
-            m_state = Uninitialized;
-            m_rangeString = 0;
-            m_lowLimit = 0;
-            m_highLimit = 0;
-        }
+    OptionRange& operator=(int value)
+    {
+        // Only used for initialization to state Uninitialized.
+        // OptionsList specifies OptionRange options with default value 0.
+        RELEASE_ASSERT(!value);
+
+        m_state = Uninitialized;
+        m_rangeString = 0;
+        m_lowLimit = 0;
+        m_highLimit = 0;
         return *this;
     }