Changeset 256845 in webkit

Timestamp:

Feb 18, 2020, 11:55:39 AM (5 years ago)

Author:

achristensen@apple.com

Message:

Unreviewed, rolling out r254873.
​https://bugs.webkit.org/show_bug.cgi?id=205751

This is reverting r254081 which is effectively re-landing part of r254873 that was reverted
supposing that would be related to the fix for rdar://problem/59136037 but it was not.
Re-landing this is a step towards rdar://problem/56027111

Reverted changeset:

"Revert suppressesConnectionTerminationOnSystemChange part of
r254081"
​https://bugs.webkit.org/show_bug.cgi?id=205751
​https://trac.webkit.org/changeset/254873

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/NetworkProcess.h (modified) (2 diffs)
• NetworkProcess/NetworkProcessCreationParameters.cpp (modified) (2 diffs)
• NetworkProcess/NetworkProcessCreationParameters.h (modified) (1 diff)
• NetworkProcess/cocoa/NetworkProcessCocoa.mm (modified) (1 diff)
• NetworkProcess/cocoa/NetworkSessionCocoa.mm (modified) (1 diff)
• UIProcess/API/APIProcessPoolConfiguration.cpp (modified) (1 diff)
• UIProcess/API/APIProcessPoolConfiguration.h (modified) (2 diffs)
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h (modified) (1 diff)
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm (modified) (1 diff)
• UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, rolling out r254873.
+        https://bugs.webkit.org/show_bug.cgi?id=205751
+
+        This is reverting r254081 which is effectively re-landing part of r254873 that was reverted
+        supposing that would be related to the fix for rdar://problem/59136037 but it was not.
+        Re-landing this is a step towards rdar://problem/56027111
+
+        Reverted changeset:
+
+        "Revert suppressesConnectionTerminationOnSystemChange part of
+        r254081"
+        https://bugs.webkit.org/show_bug.cgi?id=205751
+        https://trac.webkit.org/changeset/254873
+
 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/NetworkProcess/NetworkProcess.h

@@ -187 +187 @@
 
 #if PLATFORM(COCOA)
-    bool suppressesConnectionTerminationOnSystemChange() const { return m_suppressesConnectionTerminationOnSystemChange; }
     RetainPtr<CFDataRef> sourceApplicationAuditData() const;
 #endif
@@ -538 +537 @@
     // In the future using WorkQueue and a counting semaphore would work, as would WorkQueue supporting the libdispatch concept of "work groups".
     dispatch_group_t m_clearCacheDispatchGroup { nullptr };
-    bool m_suppressesConnectionTerminationOnSystemChange { false };
 #endif
 

trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp

@@ -56 +56 @@
     IPC::encode(encoder, networkATSContext.get());
     encoder << storageAccessAPIEnabled;
-    encoder << suppressesConnectionTerminationOnSystemChange;
 #endif
     encoder << defaultDataStoreParameters;
@@ -121 +120 @@
     if (!decoder.decode(result.storageAccessAPIEnabled))
         return false;
-    if (!decoder.decode(result.suppressesConnectionTerminationOnSystemChange))
-        return false;
 #endif
 

trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h

@@ -71 +71 @@
     RetainPtr<CFDataRef> networkATSContext;
     bool storageAccessAPIEnabled;
-    bool suppressesConnectionTerminationOnSystemChange;
 #endif
 

trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm

@@ -101 +101 @@
 
     WebCore::NetworkStorageSession::setStorageAccessAPIEnabled(parameters.storageAccessAPIEnabled);
-    m_suppressesConnectionTerminationOnSystemChange = parameters.suppressesConnectionTerminationOnSystemChange;
 
     // FIXME: Most of what this function does for cache size gets immediately overridden by setCacheModel().

trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

@@ -1108 +1108 @@
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS_FAMILY)
     // FIXME: Replace @"kCFStreamPropertyAutoErrorOnSystemChange" with a constant from the SDK once rdar://problem/40650244 is in a build.
-    if (networkProcess.suppressesConnectionTerminationOnSystemChange() || parameters.suppressesConnectionTerminationOnSystemChange)
+    if (parameters.suppressesConnectionTerminationOnSystemChange)
         configuration._socketStreamProperties = @{ @"kCFStreamPropertyAutoErrorOnSystemChange" : @NO };
 #endif

trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp

@@ -68 +68 @@
     copy->m_usesWebProcessCache = this->m_usesWebProcessCache;
     copy->m_usesBackForwardCache = this->m_usesBackForwardCache;
-#if PLATFORM(COCOA)
-    copy->m_suppressesConnectionTerminationOnSystemChange = this->m_suppressesConnectionTerminationOnSystemChange;
-#endif
     copy->m_customWebContentServiceBundleIdentifier = this->m_customWebContentServiceBundleIdentifier;
     copy->m_usesSingleWebProcess = m_usesSingleWebProcess;

trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h

@@ -144 +144 @@
     void setCustomWebContentServiceBundleIdentifier(const WTF::String& customWebContentServiceBundleIdentifier) { m_customWebContentServiceBundleIdentifier = customWebContentServiceBundleIdentifier; }
 
-#if PLATFORM(COCOA)
-    bool suppressesConnectionTerminationOnSystemChange() const { return m_suppressesConnectionTerminationOnSystemChange; }
-    void setSuppressesConnectionTerminationOnSystemChange(bool suppressesConnectionTerminationOnSystemChange) { m_suppressesConnectionTerminationOnSystemChange = suppressesConnectionTerminationOnSystemChange; }
-#endif
-
 private:
     WTF::String m_injectedBundlePath;
@@ -179 +174 @@
     bool m_isJITEnabled { true };
     bool m_usesSingleWebProcess { false };
-#if PLATFORM(COCOA)
-    bool m_suppressesConnectionTerminationOnSystemChange { false };
-#endif
 };
 

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h

@@ -68 +68 @@
 @property (nonatomic) BOOL usesWebProcessCache WK_API_AVAILABLE(macos(10.14.4), ios(12.2));
 @property (nonatomic) BOOL pageCacheEnabled WK_API_AVAILABLE(macos(10.14), ios(12.0));
-@property (nonatomic) BOOL suppressesConnectionTerminationOnSystemChange WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration.suppressesConnectionTerminationOnSystemChange", macos(10.14, WK_MAC_TBA), ios(12.0, WK_IOS_TBA));
 @property (nonatomic, getter=isJITEnabled) BOOL JITEnabled WK_API_AVAILABLE(macos(10.14.4), ios(12.2));
 @property (nonatomic, nullable, copy, setter=setHSTSStorageDirectory:) NSURL *hstsStorageDirectory WK_API_AVAILABLE(macos(10.15), ios(13.0));

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm

@@ -332 +332 @@
 }
 
-- (BOOL)suppressesConnectionTerminationOnSystemChange
-{
-    return _processPoolConfiguration->suppressesConnectionTerminationOnSystemChange();
-}
-
-- (void)setSuppressesConnectionTerminationOnSystemChange:(BOOL)suppressesConnectionTerminationOnSystemChange
-{
-    _processPoolConfiguration->setSuppressesConnectionTerminationOnSystemChange(suppressesConnectionTerminationOnSystemChange);
-}
-
 - (BOOL)isJITEnabled
 {

trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -462 +462 @@
 
     parameters.storageAccessAPIEnabled = storageAccessAPIEnabled();
-    parameters.suppressesConnectionTerminationOnSystemChange = m_configuration->suppressesConnectionTerminationOnSystemChange();
 
     NSNumber *databaseEnabledValue = [defaults objectForKey:[NSString stringWithFormat:@"InternalDebug%@", WebPreferencesKey::isITPDatabaseEnabledKey().createCFString().get()]];