Changeset 258062 in webkit

Timestamp:

Mar 6, 2020, 9:53:34 PM (5 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r258038): Build failure on Windows 10 bots
<​https://bugs.webkit.org/show_bug.cgi?id=208731>
<rdar://problem/59222568>

• assembler/testmasm.cpp:

(JSC::testCompareDouble):
(JSC::testCompareDoubleSameArg):
(JSC::testMoveConditionallyFloatingPoint):
(JSC::testMoveConditionallyFloatingPointSameArg):

• Add RELEASE_ASSERT_NOT_REACHED() statements to try to fix the bots.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/testmasm.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-03-06  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r258038): Build failure on Windows 10 bots
+        <https://bugs.webkit.org/show_bug.cgi?id=208731>
+        <rdar://problem/59222568>
+
+        * assembler/testmasm.cpp:
+        (JSC::testCompareDouble):
+        (JSC::testCompareDoubleSameArg):
+        (JSC::testMoveConditionallyFloatingPoint):
+        (JSC::testMoveConditionallyFloatingPointSameArg):
+        - Add RELEASE_ASSERT_NOT_REACHED() statements to try to fix the
+          bots.
+
 2020-03-06  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/assembler/testmasm.cpp

@@ -530 +530 @@
             return isUnordered(a) || isUnordered(b) || (a <= b);
         } // switch
+        RELEASE_ASSERT_NOT_REACHED();
     };
 
@@ -601 +602 @@
             return isUnordered(a) || (a <= a);
         } // switch
+        RELEASE_ASSERT_NOT_REACHED();
     };
 
@@ -725 +727 @@
             return isUnordered(a) || isUnordered(b) || (a <= b) ? selectionA : selectionB;
         } // switch
+        RELEASE_ASSERT_NOT_REACHED();
     };
 
@@ -1297 +1300 @@
             return isUnordered(a) || (a <= a) ? selectionA : selectionB;
         } // switch
+        RELEASE_ASSERT_NOT_REACHED();
     };