Changeset 262176 in webkit

Timestamp:

May 26, 2020, 9:44:51 PM (5 years ago)

Author:

mark.lam@apple.com

Message:

JSC stress tests that require --useLLInt=0 should be skipped on --no-jit test runs.
​https://bugs.webkit.org/show_bug.cgi?id=212400

Reviewed by Saam Barati.

That's because using --useLLInt=0 and --useJIT=0 together is not a "coherent"
(read "valid") configuration. We should be able to do a --no-jit test run with
the JSC_useJIT=0 environmental variable set. Before this patch, the following
tests will all fail. This patch skips them.

• stress/delete-property-poly-proto.js:
• stress/dfg-compare-eq-via-nonSpeculativeNonPeepholeCompareNullOrUndefined.js:
• stress/getter-setter-inlining-should-emit-movhint.js:
• stress/merging-ic-variants-should-bail-if-structures-overlap.js:
• stress/poly-proto-setter-adds-setter-in-middle.js:
• stress/poly-proto-setter-changes-setter-2.js:
• stress/poly-proto-setter-changes-setter.js:
• stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js:
• stress/regress-192717.js:
• stress/retry-cache-later.js:

Location:

trunk/JSTests

Files:

• ChangeLog (modified) (1 diff)
• stress/delete-property-poly-proto.js (modified) (1 diff)
• stress/dfg-compare-eq-via-nonSpeculativeNonPeepholeCompareNullOrUndefined.js (modified) (1 diff)
• stress/getter-setter-inlining-should-emit-movhint.js (modified) (1 diff)
• stress/merging-ic-variants-should-bail-if-structures-overlap.js (modified) (1 diff)
• stress/poly-proto-setter-adds-setter-in-middle.js (modified) (1 diff)
• stress/poly-proto-setter-changes-setter-2.js (modified) (1 diff)
• stress/poly-proto-setter-changes-setter.js (modified) (1 diff)
• stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js (modified) (1 diff)
• stress/regress-192717.js (modified) (1 diff)
• stress/retry-cache-later.js (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-05-26  Mark Lam  <mark.lam@apple.com>
+
+        JSC stress tests that require --useLLInt=0 should be skipped on --no-jit test runs.
+        https://bugs.webkit.org/show_bug.cgi?id=212400
+
+        Reviewed by Saam Barati.
+
+        That's because using --useLLInt=0 and --useJIT=0 together is not a "coherent"
+        (read "valid") configuration.  We should be able to do a --no-jit test run with
+        the JSC_useJIT=0 environmental variable set.  Before this patch, the following
+        tests will all fail.  This patch skips them.
+
+        * stress/delete-property-poly-proto.js:
+        * stress/dfg-compare-eq-via-nonSpeculativeNonPeepholeCompareNullOrUndefined.js:
+        * stress/getter-setter-inlining-should-emit-movhint.js:
+        * stress/merging-ic-variants-should-bail-if-structures-overlap.js:
+        * stress/poly-proto-setter-adds-setter-in-middle.js:
+        * stress/poly-proto-setter-changes-setter-2.js:
+        * stress/poly-proto-setter-changes-setter.js:
+        * stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js:
+        * stress/regress-192717.js:
+        * stress/retry-cache-later.js:
+
 2020-05-26  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/JSTests/stress/delete-property-poly-proto.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ requireOptions("--forcePolyProto=1", "--useLLInt=0")
 

trunk/JSTests/stress/dfg-compare-eq-via-nonSpeculativeNonPeepholeCompareNullOrUndefined.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ runDefault("--collectContinuously=true", "--collectContinuouslyPeriodMS=0.15", "--useLLInt=false", "--useFTLJIT=false", "--jitPolicyScale=0")
 

trunk/JSTests/stress/getter-setter-inlining-should-emit-movhint.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ runDefault("--useRandomizingFuzzerAgent=1", "--usePolymorphicCallInliningForNonStubStatus=1", "--seedOfRandomizingFuzzerAgent=2896922505", "--useLLInt=0", "--useConcurrentJIT=0")
+
 function foo(o) {
     o.f = 0;

trunk/JSTests/stress/merging-ic-variants-should-bail-if-structures-overlap.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ runDefault("--validateGraphAtEachPhase=1", "--useLLInt=0")
 

trunk/JSTests/stress/poly-proto-setter-adds-setter-in-middle.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ requireOptions("--forcePolyProto=1", "--useLLInt=0", "--repatchBufferingCountdown=0")
+
 let correct = false
 

trunk/JSTests/stress/poly-proto-setter-changes-setter-2.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ requireOptions("--forcePolyProto=1", "--useLLInt=0", "--repatchBufferingCountdown=0")
+
 function assert_eq(a, b) {
     

trunk/JSTests/stress/poly-proto-setter-changes-setter.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ requireOptions("--forcePolyProto=1", "--useLLInt=0", "--repatchBufferingCountdown=0")
+
 function assert_eq(a, b) {
     if (a !== b)

trunk/JSTests/stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ runDefault("--numberOfGCMarkers=1", "--useDFGJIT=false", "--useLLInt=false")
 

trunk/JSTests/stress/regress-192717.js

@@ -1 @@
-//@ skip if $memoryLimited or $buildType == "debug"
+//@ skip if $memoryLimited or $buildType == "debug" or not $jitTests
 //@ runDefault("--useLLInt=false", "--forceCodeBlockToJettisonDueToOldAge=true", "--maxPerThreadStackUsage=200000", "--exceptionStackTraceLimit=1", "--defaultErrorStackTraceLimit=1")
 

trunk/JSTests/stress/retry-cache-later.js

@@ +1 @@
+//@ skip if not $jitTests
 //@ runNoCJIT("--useLLInt=false", "--useDFGJIT=false")