Changeset 262387 in webkit

Timestamp:

Jun 1, 2020 11:21:50 AM (4 years ago)

Author:

achristensen@apple.com

Message:

Make CustomDisplayName and DefaultDisplayName API tests fail instead of timing out when something changes
​https://bugs.webkit.org/show_bug.cgi?id=212480

This saves time when debugging and running all the tests.

• TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:

(TestWebKitAPI::checkUntilDisplayNameIs):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-06-01  Alex Christensen  <achristensen@webkit.org>
+
+        Make CustomDisplayName and DefaultDisplayName API tests fail instead of timing out when something changes
+        https://bugs.webkit.org/show_bug.cgi?id=212480
+
+        This saves time when debugging and running all the tests.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
+        (TestWebKitAPI::checkUntilDisplayNameIs):
+
 2020-06-01  Philippe Normand  <pnormand@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm

@@ -42 +42 @@
 
 #if PLATFORM(MAC)
-static void checkUntilDisplayNameIs(WKWebView *webView, NSString *expectedName, bool* done)
+static void checkUntilDisplayNameIs(WKWebView *webView, NSString *expectedName, bool* done, size_t iterations = 20)
 {
     [webView _getProcessDisplayNameWithCompletionHandler:^(NSString *name) {
         if ([name isEqualToString:expectedName])
             *done = true;
-        else
-            checkUntilDisplayNameIs(webView, expectedName, done);
+        else if (!iterations) {
+            EXPECT_FALSE(true);
+            *done = true;
+        } else
+            checkUntilDisplayNameIs(webView, expectedName, done, iterations - 1);
     }];
 }