Changeset 262649 in webkit

Timestamp:

Jun 5, 2020 1:15:51 PM (4 years ago)

Author:

achristensen@apple.com

Message:

Fix PDF opening after r262592
​https://bugs.webkit.org/show_bug.cgi?id=212795

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
(WebKit::WebPageProxy::openPDFFromTemporaryFolderWithNativeApplication):
As Darin mentioned and I was about to discover, my last-minute switching things around got the boolean condition backwards.
We want to do nothing if we're not allowed to open the PDF, and we want to open the PDF if we are allowed to.s

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WebPageProxyMac.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-05  Alex Christensen  <achristensen@webkit.org>
+
+        Fix PDF opening after r262592
+        https://bugs.webkit.org/show_bug.cgi?id=212795
+
+        * UIProcess/mac/WebPageProxyMac.mm:
+        (WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
+        (WebKit::WebPageProxy::openPDFFromTemporaryFolderWithNativeApplication):
+        As Darin mentioned and I was about to discover, my last-minute switching things around got the boolean condition backwards.
+        We want to do nothing if we're not allowed to open the PDF, and we want to open the PDF if we are allowed to.s
+
 2020-06-05  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm

@@ -513 +513 @@
 
     m_uiClient->confirmPDFOpening(*this, WTFMove(frameInfo), [nsPath = WTFMove(nsPath)] (bool allowed) {
-        if (allowed)
+        if (!allowed)
             return;
         [[NSWorkspace sharedWorkspace] openURL:[NSURL fileURLWithPath:nsPath.get() isDirectory:NO]];
@@ -529 +529 @@
 
     m_uiClient->confirmPDFOpening(*this, WTFMove(frameInfo), [pdfFilename = WTFMove(pdfFilename)] (bool allowed) {
-        if (allowed)
+        if (!allowed)
             return;
         [[NSWorkspace sharedWorkspace] openURL:[NSURL fileURLWithPath:pdfFilename isDirectory:NO]];