Changeset 262649 in webkit
- Timestamp:
- Jun 5, 2020 1:15:51 PM (4 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r262648 r262649 1 2020-06-05 Alex Christensen <achristensen@webkit.org> 2 3 Fix PDF opening after r262592 4 https://bugs.webkit.org/show_bug.cgi?id=212795 5 6 * UIProcess/mac/WebPageProxyMac.mm: 7 (WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication): 8 (WebKit::WebPageProxy::openPDFFromTemporaryFolderWithNativeApplication): 9 As Darin mentioned and I was about to discover, my last-minute switching things around got the boolean condition backwards. 10 We want to do nothing if we're not allowed to open the PDF, and we want to open the PDF if we are allowed to.s 11 1 12 2020-06-05 David Kilzer <ddkilzer@apple.com> 2 13 -
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
r262592 r262649 513 513 514 514 m_uiClient->confirmPDFOpening(*this, WTFMove(frameInfo), [nsPath = WTFMove(nsPath)] (bool allowed) { 515 if ( allowed)515 if (!allowed) 516 516 return; 517 517 [[NSWorkspace sharedWorkspace] openURL:[NSURL fileURLWithPath:nsPath.get() isDirectory:NO]]; … … 529 529 530 530 m_uiClient->confirmPDFOpening(*this, WTFMove(frameInfo), [pdfFilename = WTFMove(pdfFilename)] (bool allowed) { 531 if ( allowed)531 if (!allowed) 532 532 return; 533 533 [[NSWorkspace sharedWorkspace] openURL:[NSURL fileURLWithPath:pdfFilename isDirectory:NO]];
Note: See TracChangeset
for help on using the changeset viewer.