Changeset 262845 in webkit


Ignore:
Timestamp:
Jun 10, 2020 10:59:49 AM (4 years ago)
Author:
achristensen@apple.com
Message:

Revert r259770
​https://bugs.webkit.org/show_bug.cgi?id=210097
<rdar://problem/64175992>

Source/WebKit:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r262844 r262845  
     12020-06-10  Alex Christensen  <achristensen@webkit.org>
     2
     3        Revert r259770
     4        https://bugs.webkit.org/show_bug.cgi?id=210097
     5        <rdar://problem/64175992>
     6
     7        * UIProcess/WebPageProxy.cpp:
     8        (WebKit::WebPageProxy::decidePolicyForNavigationAction):
     9
    1102020-06-10  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r262802 r262845  
    52325232                    switch (continueUnsafeLoad) {
    52335233                    case ContinueUnsafeLoad::No:
    5234                         if (!hasCommittedAnyProvisionalLoads() && !m_sessionStateWasRestoredByAPIRequest)
     5234                        if (!hasCommittedAnyProvisionalLoads())
    52355235                            m_uiClient->close(protectedThis.ptr());
    52365236                        completionHandler(PolicyAction::Ignore);

  • trunk/Tools/ChangeLog

    r262837 r262845  
     12020-06-10  Alex Christensen  <achristensen@webkit.org>
     2
     3        Revert r259770
     4        https://bugs.webkit.org/show_bug.cgi?id=210097
     5        <rdar://problem/64175992>
     6
     7        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
     8        (TEST):
     9
    1102020-06-10  Commit Queue  <commit-queue@webkit.org>
    211

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm

    r261390 r262845  
    264264    EXPECT_FALSE(didCloseCalled);
    265265    goBack([webView2 _safeBrowsingWarning]);
    266     EXPECT_FALSE(didCloseCalled);
     266    EXPECT_TRUE(didCloseCalled);
    267267    WKBackForwardList *list = [webView2 backForwardList];
    268268    EXPECT_FALSE(!!list.backItem);
Note: See TracChangeset for help on using the changeset viewer.