Changeset 263408 in webkit

Timestamp:

Jun 23, 2020 11:49:03 AM (4 years ago)

Author:

mark.lam@apple.com

Message:

Handle string overflow in DFG graph dump while validating AI.
​https://bugs.webkit.org/show_bug.cgi?id=213524
<rdar://problem/64635620>

Not reviewed.

Applying refinement suggested by Darin in ​https://bugs.webkit.org/show_bug.cgi?id=213524#c3.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::validateAIState):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ftl/FTLLowerDFGToB3.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-06-23  Mark Lam  <mark.lam@apple.com>
+
+        Handle string overflow in DFG graph dump while validating AI.
+        https://bugs.webkit.org/show_bug.cgi?id=213524
+        <rdar://problem/64635620>
+
+        Not reviewed.
+
+        Applying refinement suggested by Darin in https://bugs.webkit.org/show_bug.cgi?id=213524#c3.
+
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::validateAIState):
+
 2020-06-23  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

@@ -560 +560 @@
             StringPrintStream out;
             m_graph.dump(out);
-            auto expectedString = out.tryToString();
-            m_graphDump = expectedString ? expectedString.value() : String("<out of memory while dumping graph>"_s);
+            m_graphDump = out.tryToString().value_or("<out of memory while dumping graph>"_s);
         }