Changeset 263858 in webkit


Ignore:
Timestamp:
Jul 2, 2020 1:35:14 PM (4 years ago)
Author:
graouts@webkit.org
Message:

visualViewport.addEventListener("scroll"* fires permanently after zoom or orientation change
https://bugs.webkit.org/show_bug.cgi?id=211522
<rdar://problem/62939371>

Reviewed by Simon Fraser.

Source/WebCore:

Correctly set the flag indicating that a scroll event has been dispatched on the visual viewport.

Test: fast/visual-viewport/scroll-event-fired-during-scroll-alone.html

  • dom/Document.cpp:

(WebCore::Document::runScrollSteps):

LayoutTests:

Add a test that checks that after a call to scrollTo() no further "scroll" events are dispatched on window.visualViewport.

  • fast/visual-viewport/scroll-event-fired-during-scroll-alone-expected.txt: Added.
  • fast/visual-viewport/scroll-event-fired-during-scroll-alone.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r263856 r263858  
     12020-07-02  Antoine Quint  <graouts@webkit.org>
     2
     3        visualViewport.addEventListener("scroll"*** fires permanently after zoom or orientation change
     4        https://bugs.webkit.org/show_bug.cgi?id=211522
     5        <rdar://problem/62939371>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Add a test that checks that after a call to scrollTo() no further "scroll" events are dispatched on window.visualViewport.
     10
     11        * fast/visual-viewport/scroll-event-fired-during-scroll-alone-expected.txt: Added.
     12        * fast/visual-viewport/scroll-event-fired-during-scroll-alone.html: Added.
     13
    1142020-07-02  Chris Dumez  <cdumez@apple.com>
    215
  • trunk/Source/WebCore/ChangeLog

    r263855 r263858  
     12020-07-02  Antoine Quint  <graouts@webkit.org>
     2
     3        visualViewport.addEventListener("scroll"*** fires permanently after zoom or orientation change
     4        https://bugs.webkit.org/show_bug.cgi?id=211522
     5        <rdar://problem/62939371>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Correctly set the flag indicating that a scroll event has been dispatched on the visual viewport.
     10
     11        Test: fast/visual-viewport/scroll-event-fired-during-scroll-alone.html
     12
     13        * dom/Document.cpp:
     14        (WebCore::Document::runScrollSteps):
     15
    1162020-07-02  Zalan Bujtas  <zalan@apple.com>
    217
  • trunk/Source/WebCore/dom/Document.cpp

    r263498 r263858  
    41314131    if (m_needsVisualViewportScrollEvent) {
    41324132        LOG_WITH_STREAM(Events, stream << "Document" << this << "sending scroll events to visualViewport");
    4133         m_needsVisualViewportResizeEvent = false;
     4133        m_needsVisualViewportScrollEvent = false;
    41344134        if (auto* window = domWindow())
    41354135            window->visualViewport().dispatchEvent(Event::create(eventNames().scrollEvent, Event::CanBubble::No, Event::IsCancelable::No));
Note: See TracChangeset for help on using the changeset viewer.