Changeset 265431 in webkit

Timestamp:

Aug 10, 2020 9:31:38 AM (4 years ago)

Author:

achristensen@apple.com

Message:

REGRESSION(r261159) PokerBros only shows black screen
​https://bugs.webkit.org/show_bug.cgi?id=215293
<rdar://problem/66073740>

Reviewed by Keith Miller.

The PokerBros app has some logic that was broken by the change in behavior of r261159.
It caused the app do do nothing except show a black screen upon opening.
Revert to the old behavior for this app until they update to iOS14.

• runtime/JSObject.cpp:

(JSC::needsOldStringName):
(JSC::JSObject::toStringName):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSObject.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-08-10  Alex Christensen  <achristensen@webkit.org>
+
+        REGRESSION(r261159) PokerBros only shows black screen
+        https://bugs.webkit.org/show_bug.cgi?id=215293
+        <rdar://problem/66073740>
+
+        Reviewed by Keith Miller.
+
+        The PokerBros app has some logic that was broken by the change in behavior of r261159.
+        It caused the app do do nothing except show a black screen upon opening.
+        Revert to the old behavior for this app until they update to iOS14.
+
+        * runtime/JSObject.cpp:
+        (JSC::needsOldStringName):
+        (JSC::JSObject::toStringName):
+
 2020-08-10  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSObject.cpp

@@ -44 +44 @@
 #include "VMInlines.h"
 #include <wtf/Assertions.h>
+
+#if PLATFORM(IOS)
+#include <wtf/spi/darwin/dyldSPI.h>
+#endif
 
 namespace JSC {
@@ -510 +514 @@
 }
 
+#if PLATFORM(IOS)
+inline static bool isPokerBros()
+{
+    auto bundleID = CFBundleGetIdentifier(CFBundleGetMainBundle());
+    return bundleID
+        && CFEqual(bundleID, CFSTR("com.kpgame.PokerBros"))
+        && dyld_get_program_sdk_version() < DYLD_IOS_VERSION_14_0;
+}
+#endif
+
 String JSObject::toStringName(const JSObject* object, JSGlobalObject* globalObject)
 {
     VM& vm = globalObject->vm();
+#if PLATFORM(IOS)
+    static bool needsOldStringName = isPokerBros();
+    if (UNLIKELY(needsOldStringName)) {
+        const ClassInfo* info = object->classInfo(vm);
+        ASSERT(info);
+        return info->className;
+    }
+#endif
     auto scope = DECLARE_THROW_SCOPE(vm);
     bool objectIsArray = isArray(globalObject, object);