Changeset 265930 in webkit


Ignore:
Timestamp:
Aug 19, 2020 6:50:37 PM (4 years ago)
Author:
achristensen@apple.com
Message:

Fix null pointer crashes in network process after r265835

https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r265916 r265930  
     12020-08-19  Alex Christensen  <achristensen@webkit.org>
     2
     3        Fix null pointer crashes in network process after r265835
     4       ​https://bugs.webkit.org/show_bug.cgi?id=215626
     5        <rdar://problem/67268892>
     6
     7        Call the correct CompletionHandler.  completionHandler has already been moved from at this point.
     8        This crash was being hit in the test, but the test recovered from it.
     9
     10        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
     11        (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):
     12
    1132020-08-19  Kate Cheney  <katherine_cheney@apple.com>
    214
  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

    r265835 r265930  
    15511551        && fastServerTrustEvaluationEnabled()
    15521552        && !networkDataTask->isTopLevelNavigation())
    1553         return completionHandler(AuthenticationChallengeDisposition::Cancel, { });
     1553        return challengeCompletionHandler(AuthenticationChallengeDisposition::Cancel, { });
    15541554
    15551555    networkDataTask->didReceiveChallenge(WTFMove(authenticationChallenge), negotiatedLegacyTLS, WTFMove(challengeCompletionHandler));
Note: See TracChangeset for help on using the changeset viewer.