Changeset 267090 in webkit


Ignore:
Timestamp:
Sep 15, 2020 11:07:18 AM (4 years ago)
Author:
achristensen@apple.com
Message:

Remove unused plumbing for setting whether the storage access API is enabled
​https://bugs.webkit.org/show_bug.cgi?id=216516

Reviewed by Youenn Fablet.

Source/WebCore:

Sending a boolean from the process pool to the network process has been superceded by a preference in WebPreferences.yaml.
The boolean sent to the network process was not even used any more.

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setStorageAccessAPIEnabled): Deleted.

Source/WebKit:

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::setStorageAccessAPIEnabled): Deleted.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetStorageAccessAPIEnabled): Deleted.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetStorageAccessAPIEnabled): Deleted.

  • UIProcess/API/C/WKCookieManager.h:
  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _isStorageAccessAPIEnabled]): Deleted.
(-[WKProcessPool _setStorageAccessAPIEnabled:]): Deleted.

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setStorageAccessAPIEnabled): Deleted.

  • UIProcess/WebProcessPool.h:

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

Location:
trunk
Files:
20 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r267089 r267090  
     12020-09-15  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove unused plumbing for setting whether the storage access API is enabled
     4        https://bugs.webkit.org/show_bug.cgi?id=216516
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Sending a boolean from the process pool to the network process has been superceded by a preference in WebPreferences.yaml.
     9        The boolean sent to the network process was not even used any more.
     10
     11        * platform/network/NetworkStorageSession.h:
     12        * platform/network/cf/NetworkStorageSessionCFNet.cpp:
     13        (WebCore::NetworkStorageSession::setStorageAccessAPIEnabled): Deleted.
     14
    1152020-09-15  Sam Weinig  <weinig@apple.com>
    216

  • trunk/Source/WebCore/platform/network/NetworkStorageSession.h

    r266929 r267090  
    128128    CFURLStorageSessionRef platformSession() { return m_platformSession.get(); }
    129129    WEBCORE_EXPORT RetainPtr<CFHTTPCookieStorageRef> cookieStorage() const;
    130     WEBCORE_EXPORT static void setStorageAccessAPIEnabled(bool);
    131130#elif USE(SOUP)
    132131    WEBCORE_EXPORT explicit NetworkStorageSession(PAL::SessionID);

  • trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp

    r256820 r267090  
    3939
    4040namespace WebCore {
    41 
    42 static bool storageAccessAPIEnabled;
    4341
    4442RetainPtr<CFURLStorageSessionRef> NetworkStorageSession::createCFStorageSessionForIdentifier(CFStringRef identifier)
    … …  
    109107}
    110108
    111 void NetworkStorageSession::setStorageAccessAPIEnabled(bool enabled)
    112 {
    113     storageAccessAPIEnabled = enabled;
    114 }
    115 
    116109} // namespace WebCore

  • trunk/Source/WebKit/ChangeLog

    r267088 r267090  
     12020-09-15  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove unused plumbing for setting whether the storage access API is enabled
     4        https://bugs.webkit.org/show_bug.cgi?id=216516
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * NetworkProcess/NetworkProcess.h:
     9        * NetworkProcess/NetworkProcess.messages.in:
     10        * NetworkProcess/NetworkProcessCreationParameters.cpp:
     11        (WebKit::NetworkProcessCreationParameters::encode const):
     12        (WebKit::NetworkProcessCreationParameters::decode):
     13        * NetworkProcess/NetworkProcessCreationParameters.h:
     14        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
     15        (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
     16        (WebKit::NetworkProcess::setStorageAccessAPIEnabled): Deleted.
     17        * UIProcess/API/C/WKContext.cpp:
     18        (WKContextSetStorageAccessAPIEnabled): Deleted.
     19        * UIProcess/API/C/WKContext.h:
     20        * UIProcess/API/C/WKCookieManager.cpp:
     21        (WKCookieManagerSetStorageAccessAPIEnabled): Deleted.
     22        * UIProcess/API/C/WKCookieManager.h:
     23        * UIProcess/API/Cocoa/WKProcessPool.mm:
     24        (-[WKProcessPool _isStorageAccessAPIEnabled]): Deleted.
     25        (-[WKProcessPool _setStorageAccessAPIEnabled:]): Deleted.
     26        * UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
     27        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
     28        (WebKit::WebProcessPool::platformInitializeNetworkProcess):
     29        * UIProcess/WebProcessPool.cpp:
     30        (WebKit::WebProcessPool::setStorageAccessAPIEnabled): Deleted.
     31        * UIProcess/WebProcessPool.h:
     32
    1332020-09-15  Alex Christensen  <achristensen@webkit.org>
    234

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.h

    r267042 r267090  
    552552#if PLATFORM(COCOA)
    553553    void platformInitializeNetworkProcessCocoa(const NetworkProcessCreationParameters&);
    554     void setStorageAccessAPIEnabled(bool);
    555554
    556555    // FIXME: We'd like to be able to do this without the #ifdef, but WorkQueue + BinarySemaphore isn't good enough since

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in

    r267042 r267090  
    6464#if PLATFORM(COCOA)
    6565    SetQOS(int latencyQOS, int throughputQOS)
    66     SetStorageAccessAPIEnabled(bool enabled)
    6766#endif
    6867    SetAllowsAnySSLCertificateForWebSocket(bool enabled) -> () Synchronous

  • trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp

    r266133 r267090  
    5555    encoder << uiProcessSDKVersion;
    5656    IPC::encode(encoder, networkATSContext.get());
    57     encoder << storageAccessAPIEnabled;
    5857#endif
    5958    encoder << defaultDataStoreParameters;
    … …  
    116115    if (!IPC::decode(decoder, result.networkATSContext))
    117116        return false;
    118     if (!decoder.decode(result.storageAccessAPIEnabled))
    119         return false;
    120117#endif
    121118

  • trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h

    r266133 r267090  
    7070    uint32_t uiProcessSDKVersion { 0 };
    7171    RetainPtr<CFDataRef> networkATSContext;
    72     bool storageAccessAPIEnabled;
    7372#endif
    7473

  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm

    r267042 r267090  
    9494#endif
    9595
    96     WebCore::NetworkStorageSession::setStorageAccessAPIEnabled(parameters.storageAccessAPIEnabled);
    97 
    9896    // FIXME: Most of what this function does for cache size gets immediately overridden by setCacheModel().
    9997    // - memory cache size passed from UI process is always ignored;
    … …  
    219217#endif
    220218
    221 void NetworkProcess::setStorageAccessAPIEnabled(bool enabled)
    222 {
    223     WebCore::NetworkStorageSession::setStorageAccessAPIEnabled(enabled);
    224 }
    225 
    226219void NetworkProcess::flushCookies(const PAL::SessionID& sessionID, CompletionHandler<void()>&& completionHandler)
    227220{

  • trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp

    r267088 r267090  
    399399}
    400400
    401 void WKContextSetStorageAccessAPIEnabled(WKContextRef contextRef, bool enabled)
    402 {
    403     WebKit::toImpl(contextRef)->setStorageAccessAPIEnabled(enabled);
    404 }
    405 
    406401void WKContextSetCustomWebContentServiceBundleIdentifier(WKContextRef contextRef, WKStringRef name)
    407402{

  • trunk/Source/WebKit/UIProcess/API/C/WKContext.h

    r254012 r267090  
    163163WK_EXPORT bool WKContextGetUsesSingleWebProcess(WKContextRef);
    164164
    165 WK_EXPORT void WKContextSetStorageAccessAPIEnabled(WKContextRef, bool enabled);
    166 
    167165WK_EXPORT void WKContextStartMemorySampler(WKContextRef context, WKDoubleRef interval);
    168166WK_EXPORT void WKContextStopMemorySampler(WKContextRef context);

  • trunk/Source/WebKit/UIProcess/API/C/WKCookieManager.cpp

    r249589 r267090  
    6565}
    6666
    67 void WKCookieManagerSetStorageAccessAPIEnabled(WKCookieManagerRef, bool)
    68 {
    69 }
    70 
    7167void WKCookieManagerStartObservingCookieChanges(WKCookieManagerRef)
    7268{

  • trunk/Source/WebKit/UIProcess/API/C/WKCookieManager.h

    r249589 r267090  
    7575WK_EXPORT void WKCookieManagerGetHTTPCookieAcceptPolicy(WKCookieManagerRef cookieManager, void* context, WKCookieManagerGetHTTPCookieAcceptPolicyFunction callback) WK_C_API_DEPRECATED;
    7676
    77 WK_EXPORT void WKCookieManagerSetStorageAccessAPIEnabled(WKCookieManagerRef cookieManager, bool enabled) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextSetStorageAccessAPIEnabled);
    78 
    7977WK_EXPORT void WKCookieManagerStartObservingCookieChanges(WKCookieManagerRef cookieManager) WK_C_API_DEPRECATED;
    8078WK_EXPORT void WKCookieManagerStopObservingCookieChanges(WKCookieManagerRef cookieManager) WK_C_API_DEPRECATED;

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm

    r267088 r267090  
    562562}
    563563
    564 - (BOOL)_isStorageAccessAPIEnabled
    565 {
    566     return _processPool->storageAccessAPIEnabled();
    567 }
    568 
    569 - (void)_setStorageAccessAPIEnabled:(BOOL)enabled
    570 {
    571     _processPool->setStorageAccessAPIEnabled(enabled);
    572 }
    573 
    574564- (void)_synthesizeAppIsBackground:(BOOL)background
    575565{

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h

    r267088 r267090  
    129129
    130130@property (nonatomic, getter=_isCookieStoragePartitioningEnabled, setter=_setCookieStoragePartitioningEnabled:) BOOL _cookieStoragePartitioningEnabled WK_API_DEPRECATED("Partitioned cookies are no longer supported", macos(10.12.3, 10.14.4), ios(10.3, 12.2));
    131 @property (nonatomic, getter=_isStorageAccessAPIEnabled, setter=_setStorageAccessAPIEnabled:) BOOL _storageAccessAPIEnabled WK_API_AVAILABLE(macos(10.13.4), ios(11.3));
    132131- (void)_synthesizeAppIsBackground:(BOOL)background WK_API_AVAILABLE(macos(10.15), ios(13.0));
    133132

  • trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

    r266804 r267090  
    520520#endif
    521521
    522     parameters.storageAccessAPIEnabled = storageAccessAPIEnabled();
    523 
    524522    NSNumber *databaseEnabledValue = [defaults objectForKey:[NSString stringWithFormat:@"InternalDebug%@", WebPreferencesKey::isITPDatabaseEnabledKey().createCFString().get()]];
    525523    if (databaseEnabledValue)

  • trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

    r267088 r267090  
    413413}
    414414
    415 void WebProcessPool::setStorageAccessAPIEnabled(bool enabled)
    416 {
    417     m_storageAccessAPIEnabled = enabled;
    418 #if PLATFORM(COCOA)
    419     sendToNetworkingProcess(Messages::NetworkProcess::SetStorageAccessAPIEnabled(enabled));
    420 #endif
    421 }
    422 
    423415void WebProcessPool::setCustomWebContentServiceBundleIdentifier(const String& customWebContentServiceBundleIdentifier)
    424416{

  • trunk/Source/WebKit/UIProcess/WebProcessPool.h

    r267088 r267090  
    479479    void clearPermanentCredentialsForProtectionSpace(WebCore::ProtectionSpace&&);
    480480#endif
    481     bool storageAccessAPIEnabled() const { return m_storageAccessAPIEnabled; }
    482     void setStorageAccessAPIEnabled(bool);
    483481
    484482    static uint64_t registerProcessPoolCreationListener(Function<void(WebProcessPool&)>&&);
    … …  
    766764    bool m_cookieStoragePartitioningEnabled { false };
    767765#endif
    768     bool m_storageAccessAPIEnabled { false };
    769766
    770767    struct Paths {

  • trunk/Tools/ChangeLog

    r267088 r267090  
     12020-09-15  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove unused plumbing for setting whether the storage access API is enabled
     4        https://bugs.webkit.org/show_bug.cgi?id=216516
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * WebKitTestRunner/TestController.cpp:
     9        (WTR::TestController::resetStateToConsistentValues):
     10
    1112020-09-15  Alex Christensen  <achristensen@webkit.org>
    212

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r267088 r267090  
    10551055
    10561056    WKWebsiteDataStoreSetResourceLoadStatisticsEnabled(websiteDataStore(), true);
    1057     WKContextSetStorageAccessAPIEnabled(platformContext(), true);
    10581057    WKWebsiteDataStoreClearAllDeviceOrientationPermissions(websiteDataStore());
    10591058
Note: See TracChangeset for help on using the changeset viewer.