Changeset 269700 in webkit


Ignore:
Timestamp:
Nov 11, 2020 1:09:42 PM (3 years ago)
Author:
achristensen@apple.com
Message:

Define USE(LEGACY_CFNETWORK_DOWNLOADS)
​https://bugs.webkit.org/show_bug.cgi?id=218814

Reviewed by Geoffrey Garen.

Source/WebKit:

Mojave CFNetwork has a few download bugs I'll need to work around.
With this change I can use USE(LEGACY_CFNETWORK_DOWNLOADS) instead of MAC_OS_X_VERSION_MIN_REQUIRED,
which is more in line with WebKit style. This will be used more in bug 217747.

  • NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::resume):

Source/WTF:

  • wtf/PlatformUse.h:
Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r269696 r269700  
     12020-11-11  Alex Christensen  <achristensen@webkit.org>
     2
     3        Define USE(LEGACY_CFNETWORK_DOWNLOADS)
     4        https://bugs.webkit.org/show_bug.cgi?id=218814
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * wtf/PlatformUse.h:
     9
    1102020-11-11  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Source/WTF/wtf/PlatformUse.h

    r269349 r269700  
    310310#endif
    311311
     312#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
     313#define USE_LEGACY_CFNETWORK_DOWNLOADS 1
     314#endif
     315
    312316#if CPU(ARM64) && CPU(ADDRESS64)
    313317#define USE_JUMP_ISLANDS 1

  • trunk/Source/WebKit/ChangeLog

    r269698 r269700  
     12020-11-11  Alex Christensen  <achristensen@webkit.org>
     2
     3        Define USE(LEGACY_CFNETWORK_DOWNLOADS)
     4        https://bugs.webkit.org/show_bug.cgi?id=218814
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Mojave CFNetwork has a few download bugs I'll need to work around.
     9        With this change I can use USE(LEGACY_CFNETWORK_DOWNLOADS) instead of __MAC_OS_X_VERSION_MIN_REQUIRED,
     10        which is more in line with WebKit style.  This will be used more in bug 217747.
     11
     12        * NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
     13        (WebKit::Download::resume):
     14
    1152020-11-11  Chris Dumez  <cdumez@apple.com>
    216

  • trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm

    r268261 r269700  
    5151
    5252    // FIXME: This is a temporary workaround for <rdar://problem/34745171>. Fixed in iOS 13 and macOS 10.15, but we still need to support macOS 10.14 for now.
    53 #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
     53#if USE(LEGACY_CFNETWORK_DOWNLOADS)
    5454    static NSSet<Class> *plistClasses = nil;
    5555    static dispatch_once_t onceToken;
Note: See TracChangeset for help on using the changeset viewer.