Changeset 270003 in webkit


Ignore:
Timestamp:
Nov 18, 2020 5:37:37 PM (3 years ago)
Author:
ap@apple.com
Message:

Remove IRC bots from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=219111

Reviewed by Jonathan Bedard and Aakash Jain.

We haven't been running any IRC bots for a while, this is dead code.

  • Scripts/webkitpy/common/net/irc: Removed.
  • Scripts/webkitpy/thirdparty/irc: Removed.
  • Scripts/webkitpy/tool/bot/irc_command.py: Removed.
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py: Removed.
  • Scripts/webkitpy/tool/bot/ircbot.py: Removed.
  • Scripts/webkitpy/tool/bot/ircbot_unittest.py: Removed.
  • Scripts/webkitpy/tool/bot/sheriff.py: Removed.
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/newcommitbot.py: Removed.
  • Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/perfalizer.py: Removed.
  • Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/sheriffbot.py: Removed.
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: Removed.
  • Scripts/webkitpy/tool/main.py:

(WebKitPatch):
(WebKitPatch.init):
(WebKitPatch.path):
(WebKitPatch.command_completed):
(WebKitPatch.handle_global_options):
(WebKitPatch.ensure_irc_connected): Deleted.
(WebKitPatch.irc): Deleted.

  • Scripts/webkitpy/tool/mocktool.py:

(MockTool.init):
(MockTool.path):
(MockTool.ensure_irc_connected): Deleted.
(MockTool.irc): Deleted.

Location:
trunk/Tools
Files:
14 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r270002 r270003  
     12020-11-18  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Remove IRC bots from webkitpy
     4        https://bugs.webkit.org/show_bug.cgi?id=219111
     5
     6        Reviewed by Jonathan Bedard and Aakash Jain.
     7
     8        We haven't been running any IRC bots for a while, this is dead code.
     9
     10        * Scripts/webkitpy/common/net/irc: Removed.
     11        * Scripts/webkitpy/thirdparty/irc: Removed.
     12        * Scripts/webkitpy/tool/bot/irc_command.py: Removed.
     13        * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Removed.
     14        * Scripts/webkitpy/tool/bot/ircbot.py: Removed.
     15        * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Removed.
     16        * Scripts/webkitpy/tool/bot/sheriff.py: Removed.
     17        * Scripts/webkitpy/tool/bot/sheriff_unittest.py: Removed.
     18        * Scripts/webkitpy/tool/commands/__init__.py:
     19        * Scripts/webkitpy/tool/commands/newcommitbot.py: Removed.
     20        * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Removed.
     21        * Scripts/webkitpy/tool/commands/perfalizer.py: Removed.
     22        * Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Removed.
     23        * Scripts/webkitpy/tool/commands/sheriffbot.py: Removed.
     24        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: Removed.
     25        * Scripts/webkitpy/tool/main.py:
     26        (WebKitPatch):
     27        (WebKitPatch.__init__):
     28        (WebKitPatch.path):
     29        (WebKitPatch.command_completed):
     30        (WebKitPatch.handle_global_options):
     31        (WebKitPatch.ensure_irc_connected): Deleted.
     32        (WebKitPatch.irc): Deleted.
     33        * Scripts/webkitpy/tool/mocktool.py:
     34        (MockTool.__init__):
     35        (MockTool.path):
     36        (MockTool.ensure_irc_connected): Deleted.
     37        (MockTool.irc): Deleted.
     38
    1392020-11-18  Wenson Hsieh  <wenson_hsieh@apple.com>
    240

  • trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py

    r203479 r270003  
    1010from webkitpy.tool.commands.findusers import FindUsers
    1111from webkitpy.tool.commands.gardenomatic import GardenOMatic
    12 from webkitpy.tool.commands.newcommitbot import NewCommitBot
    1312from webkitpy.tool.commands.openbugs import OpenBugs
    14 from webkitpy.tool.commands.perfalizer import Perfalizer
    1513from webkitpy.tool.commands.prettydiff import PrettyDiff
    1614from webkitpy.tool.commands.queries import *
    … …  
    1917from webkitpy.tool.commands.rebaselineserver import RebaselineServer
    2018from webkitpy.tool.commands.setupgitclone import SetupGitClone
    21 from webkitpy.tool.commands.sheriffbot import *
    2219from webkitpy.tool.commands.upload import *
    2320from webkitpy.tool.commands.suggestnominations import *

  • trunk/Tools/Scripts/webkitpy/tool/main.py

    r261408 r270003  
    3636from webkitpy.common.config.ports import DeprecatedPort
    3737from webkitpy.common.host import Host
    38 from webkitpy.common.net.irc import ircproxy
    3938from webkitpy.common.net.ewsserver import EWSServer
    4039from webkitpy.tool.multicommandtool import MultiCommandTool
    … …  
    4645        make_option("-v", "--verbose", action="store_true", dest="verbose", default=False, help="enable all logging"),
    4746        make_option("-d", "--directory", action="append", dest="patch_directories", default=[], help="Directory to look at for changed files"),
    48         make_option("--irc-password", action="store", dest="irc_password", type="string", help="Password to use when communicating via IRC."),
    4947        make_option("--seconds-to-sleep", action="store", default=120, type="int", help="Number of seconds to sleep in the task queue."),
    5048        make_option("--port", action="store", dest="port", default=None, help="Specify a port (e.g., mac, gtk, ...)."),
    … …  
    5856
    5957        self.wakeup_event = threading.Event()
    60         self._irc = None
    6158        self._deprecated_port = None
    6259
    … …  
    6764        return self._path
    6865
    69     def ensure_irc_connected(self, irc_delegate):
    70         if not self._irc:
    71             self._irc = ircproxy.IRCProxy(irc_delegate)
    72 
    73     def irc(self):
    74         # We don't automatically construct IRCProxy here because constructing
    75         # IRCProxy actually connects to IRC.  We want clients to explicitly
    76         # connect to IRC.
    77         return self._irc
    78 
    7966    def command_completed(self):
    80         if self._irc:
    81             self._irc.disconnect()
     67        pass
    8268
    8369    def should_show_in_main_help(self, command):
    … …  
    9177    def handle_global_options(self, options):
    9278        self.initialize_scm(options.patch_directories)
    93         if options.irc_password:
    94             self.irc_password = options.irc_password
    9579        # If options.port is None, we'll get the default port for this platform.
    9680        self._deprecated_port = DeprecatedPort.port(options.port)

  • trunk/Tools/Scripts/webkitpy/tool/mocktool.py

    r261408 r270003  
    3333from webkitpy.common.net.buildbot.buildbot_mock import MockBuildBot
    3434from webkitpy.common.net.ewsserver_mock import MockEWSServer
    35 from webkitpy.common.net.irc.irc_mock import MockIRC
    3635
    3736# FIXME: Old-style "Ports" need to die and be replaced by modern layout_tests.port which needs to move to common.
    … …  
    6968        self.ews_server = MockEWSServer()
    7069
    71         self._irc = None
    72         self.irc_password = "MOCK irc password"
    7370        self.wakeup_event = threading.Event()
    7471
    … …  
    7875    def path(self):
    7976        return "echo"
    80 
    81     def ensure_irc_connected(self, delegate):
    82         if not self._irc:
    83             self._irc = MockIRC()
    84 
    85     def irc(self):
    86         return self._irc
Note: See TracChangeset for help on using the changeset viewer.