Changeset 272383 in webkit

Timestamp:

Feb 4, 2021 1:54:48 PM (3 years ago)

Author:

achristensen@apple.com

Message:

Don't launch a network process when registering URL schemes
​https://bugs.webkit.org/show_bug.cgi?id=221427

Reviewed by Chris Dumez.

Source/WebKit:

When Safari on macOS is launching, it calls registerURLSchemeAsSecure and registerURLSchemeAsBypassingContentSecurityPolicy.
This causes the network process to launch before the app has finished launching. Since values are stored in the UI process
and sent in NetworkProcessCreationParameters whenever a network process starts, so it's not necessary to start the network
process when calling these two functions. This should decrease Safari's launch time.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::registerURLSchemeAsSecure):
(WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/WebProcessPool.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-02-04  Alex Christensen  <achristensen@webkit.org>
+
+        Don't launch a network process when registering URL schemes
+        https://bugs.webkit.org/show_bug.cgi?id=221427
+
+        Reviewed by Chris Dumez.
+
+        When Safari on macOS is launching, it calls registerURLSchemeAsSecure and registerURLSchemeAsBypassingContentSecurityPolicy.
+        This causes the network process to launch before the app has finished launching.  Since values are stored in the UI process
+        and sent in NetworkProcessCreationParameters whenever a network process starts, so it's not necessary to start the network
+        process when calling these two functions.  This should decrease Safari's launch time.
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::registerURLSchemeAsSecure):
+        (WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):
+
 2021-02-04  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -1266 +1266 @@
     sendToAllProcesses(Messages::WebProcess::RegisterURLSchemeAsSecure(urlScheme));
     WebsiteDataStore::forEachWebsiteDataStore([urlScheme] (WebsiteDataStore& dataStore) {
-        dataStore.networkProcess().send(Messages::NetworkProcess::RegisterURLSchemeAsSecure(urlScheme), 0);
+        if (auto* networkProcess = dataStore.networkProcessIfExists())
+            networkProcess->send(Messages::NetworkProcess::RegisterURLSchemeAsSecure(urlScheme), 0);
     });
 }
@@ -1275 +1276 @@
     sendToAllProcesses(Messages::WebProcess::RegisterURLSchemeAsBypassingContentSecurityPolicy(urlScheme));
     WebsiteDataStore::forEachWebsiteDataStore([urlScheme] (WebsiteDataStore& dataStore) {
-        dataStore.networkProcess().send(Messages::NetworkProcess::RegisterURLSchemeAsBypassingContentSecurityPolicy(urlScheme), 0);
+        if (auto* networkProcess = dataStore.networkProcessIfExists())
+            networkProcess->send(Messages::NetworkProcess::RegisterURLSchemeAsBypassingContentSecurityPolicy(urlScheme), 0);
     });
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2021-02-04  Alex Christensen  <achristensen@webkit.org>
+
+        Don't launch a network process when registering URL schemes
+        https://bugs.webkit.org/show_bug.cgi?id=221427
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
+        (TEST):
+
 2021-02-04  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm

@@ -29 +29 @@
 #import "TestWKWebView.h"
 #import "Utilities.h"
+#import <WebKit/WKProcessPoolPrivate.h>
 #import <WebKit/WKWebsiteDataStorePrivate.h>
 #import <wtf/BlockPtr.h>
@@ -84 +85 @@
     auto webView = [[WKWebView new] autorelease];
     webView.configuration.websiteDataStore._resourceLoadStatisticsEnabled = YES;
+    [webView.configuration.processPool _registerURLSchemeAsSecure:@"test"];
+    [webView.configuration.processPool _registerURLSchemeAsBypassingContentSecurityPolicy:@"test"];
     EXPECT_FALSE([webView.configuration.websiteDataStore _networkProcessExists]);
 }