Changeset 272825 in webkit


Ignore:
Timestamp:
Feb 12, 2021, 5:27:47 PM (4 years ago)
Author:
mark.lam@apple.com
Message:

Remove some unused methods in MarkedBlock and PreciseAllocation.
​https://bugs.webkit.org/show_bug.cgi?id=221864

Reviewed by Yusuke Suzuki.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::visitWeakSet): Deleted.
(JSC::MarkedBlock::Handle::reapWeakSet): Deleted.

  • heap/PreciseAllocation.cpp:

(JSC::PreciseAllocation::shrink): Deleted.
(JSC::PreciseAllocation::visitWeakSet): Deleted.
(JSC::PreciseAllocation::reapWeakSet): Deleted.

  • heap/PreciseAllocation.h:
Location:
trunk/Source/JavaScriptCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r272823 r272825  
     12021-02-12  Mark Lam  <mark.lam@apple.com>
     2
     3        Remove some unused methods in MarkedBlock and PreciseAllocation.
     4        https://bugs.webkit.org/show_bug.cgi?id=221864
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        * heap/MarkedBlock.h:
     9        (JSC::MarkedBlock::Handle::visitWeakSet): Deleted.
     10        (JSC::MarkedBlock::Handle::reapWeakSet): Deleted.
     11        * heap/PreciseAllocation.cpp:
     12        (JSC::PreciseAllocation::shrink): Deleted.
     13        (JSC::PreciseAllocation::visitWeakSet): Deleted.
     14        (JSC::PreciseAllocation::reapWeakSet): Deleted.
     15        * heap/PreciseAllocation.h:
     16
    1172021-02-12  Michael Saboff  <msaboff@apple.com>
    218

  • trunk/Source/JavaScriptCore/heap/MarkedBlock.h

    r267820 r272825  
    22 *  Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
    33 *  Copyright (C) 2001 Peter Kelly (pmk@post.com)
    4  *  Copyright (C) 2003-2019 Apple Inc. All rights reserved.
     4 *  Copyright (C) 2003-2021 Apple Inc. All rights reserved.
    55 *
    66 *  This library is free software; you can redistribute it and/or
    … …  
    151151       
    152152        void shrink();
    153            
    154         void visitWeakSet(SlotVisitor&);
    155         void reapWeakSet();
    156153           
    157154        // While allocating from a free list, MarkedBlock temporarily has bogus
    … …  
    499496}
    500497
    501 inline void MarkedBlock::Handle::visitWeakSet(SlotVisitor& visitor)
    502 {
    503     return m_weakSet.visit(visitor);
    504 }
    505 
    506 inline void MarkedBlock::Handle::reapWeakSet()
    507 {
    508     m_weakSet.reap();
    509 }
    510 
    511498inline size_t MarkedBlock::Handle::cellSize()
    512499{

  • trunk/Source/JavaScriptCore/heap/PreciseAllocation.cpp

    r267304 r272825  
    11/*
    2  * Copyright (C) 2016-2020 Apple Inc. All rights reserved.
     2 * Copyright (C) 2016-2021 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    196196}
    197197
    198 void PreciseAllocation::shrink()
    199 {
    200     m_weakSet.shrink();
    201 }
    202 
    203 void PreciseAllocation::visitWeakSet(SlotVisitor& visitor)
    204 {
    205     m_weakSet.visit(visitor);
    206 }
    207 
    208 void PreciseAllocation::reapWeakSet()
    209 {
    210     return m_weakSet.reap();
    211 }
    212 
    213198void PreciseAllocation::flip()
    214199{

  • trunk/Source/JavaScriptCore/heap/PreciseAllocation.h

    r267820 r272825  
    11/*
    2  * Copyright (C) 2016-2019 Apple Inc. All rights reserved.
     2 * Copyright (C) 2016-2021 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    8080    unsigned indexInSpace() { return m_indexInSpace; }
    8181    void setIndexInSpace(unsigned indexInSpace) { m_indexInSpace = indexInSpace; }
    82    
    83     void shrink();
    84    
    85     void visitWeakSet(SlotVisitor&);
    86     void reapWeakSet();
    8782   
    8883    void clearNewlyAllocated() { m_isNewlyAllocated = false; }
Note: See TracChangeset for help on using the changeset viewer.