Changeset 273081 in webkit

Timestamp:

Feb 18, 2021 9:52:28 AM (3 years ago)

Author:

achristensen@apple.com

Message:

Disable RangeResponseGenerator again.
​https://bugs.webkit.org/show_bug.cgi?id=221072

Source/WebCore:

It seems to be causing GPU process crashes. Needs more investigating.

• platform/network/cocoa/RangeResponseGenerator.mm:

(WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Disable RangeResponseGenerator again.
+        https://bugs.webkit.org/show_bug.cgi?id=221072
+
+        It seems to be causing GPU process crashes.  Needs more investigating.
+
+        * platform/network/cocoa/RangeResponseGenerator.mm:
+        (WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):
+
 2021-02-18  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm

@@ -280 +280 @@
 bool RangeResponseGenerator::willSynthesizeRangeResponses(WebCoreNSURLSessionDataTask *task, PlatformMediaResource& resource, const ResourceResponse& response)
 {
+    bool rangeResponseGeneratorDisabled = true;
+     if (rangeResponseGeneratorDisabled)
+         return false;
+
     ASSERT(isMainThread());
     NSURLRequest *originalRequest = task.originalRequest;

trunk/Tools/ChangeLog

@@ +1 @@
+2021-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Disable RangeResponseGenerator again.
+        https://bugs.webkit.org/show_bug.cgi?id=221072
+
+        * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
+        (TestWebKitAPI::TEST):
+
 2021-02-18  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm

@@ -153 +153 @@
         {"/video.mp4", { testVideoBytes() }}
     });
-    runVideoTest(server.request(), "playing");
+    runVideoTest(server.request(), "error");
     EXPECT_EQ(server.totalRequests(), 2u);
 }