Changeset 274491 in webkit

Timestamp:

Mar 16, 2021 10:41:40 AM (3 years ago)

Author:

achristensen@apple.com

Message:

Terminate network process when making new WebProcessPool in Lutron App
​https://bugs.webkit.org/show_bug.cgi?id=223194
<rdar://74674915>

Reviewed by Geoff Garen.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isLutron):

• platform/cocoa/VersionChecks.h:

Source/WebKit:

The Lutron App uses allocation of a new WKProcessPool as a way to stop using old session cookies.
Since r267763 we keep the session cookies for the lifetime of a WKWebsiteDataStore instead of making a new process for each WKProcessPool.
Add a quirk for this app until they update to use a new WKWebsiteDataStore or use WKHTTPCookieStore API to clear the cookies properly.
I manually verified this causes the logging out to succeed.

• UIProcess/WebProcessPool.cpp:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/RuntimeApplicationChecks.h (modified) (1 diff)
• WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (modified) (1 diff)
• WebCore/platform/cocoa/VersionChecks.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/WebProcessPool.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-16  Alex Christensen  <achristensen@webkit.org>
+
+        Terminate network process when making new WebProcessPool in Lutron App
+        https://bugs.webkit.org/show_bug.cgi?id=223194
+        <rdar://74674915>
+
+        Reviewed by Geoff Garen.
+
+        * platform/RuntimeApplicationChecks.h:
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::IOSApplication::isLutron):
+        * platform/cocoa/VersionChecks.h:
+
 2021-03-16  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/RuntimeApplicationChecks.h

@@ -127 +127 @@
 WEBCORE_EXPORT bool isCrunchyroll();
 bool isWechat();
+WEBCORE_EXPORT bool isLutron();
 
 } // IOSApplication

trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

@@ -435 +435 @@
 }
 
+bool IOSApplication::isLutron()
+{
+    static bool isLutronApp = applicationBundleIsEqualTo("com.lutron.lsb"_s);
+    return isLutronApp;
+}
+
 #endif
 

trunk/Source/WebCore/platform/cocoa/VersionChecks.h

@@ -71 +71 @@
     FirstWithoutWeChatScrollingQuirk = DYLD_IOS_VERSION_14_5,
     FirstWithDOMWindowReuseRestriction  = DYLD_IOS_VERSION_14_5,
+    FirstWithSharedNetworkProcess = DYLD_IOS_VERSION_14_5,
 #elif PLATFORM(MAC)
     FirstWithNetworkCache = DYLD_MACOSX_VERSION_10_11,

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-03-16  Alex Christensen  <achristensen@webkit.org>
+
+        Terminate network process when making new WebProcessPool in Lutron App
+        https://bugs.webkit.org/show_bug.cgi?id=223194
+        <rdar://74674915>
+
+        Reviewed by Geoff Garen.
+
+        The Lutron App uses allocation of a new WKProcessPool as a way to stop using old session cookies.
+        Since r267763 we keep the session cookies for the lifetime of a WKWebsiteDataStore instead of making a new process for each WKProcessPool.
+        Add a quirk for this app until they update to use a new WKWebsiteDataStore or use WKHTTPCookieStore API to clear the cookies properly.
+        I manually verified this causes the logging out to succeed.
+
+        * UIProcess/WebProcessPool.cpp:
+
 2021-03-16  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -325 +325 @@
 
     updateBackForwardCacheCapacity();
+
+#if PLATFORM(IOS)
+    if (WebCore::IOSApplication::isLutron() && !WebCore::linkedOnOrAfter(WebCore::SDKVersion::FirstWithSharedNetworkProcess)) {
+        callOnMainRunLoop([] {
+            if (WebsiteDataStore::defaultDataStoreExists())
+                WebsiteDataStore::defaultDataStore()->terminateNetworkProcess();
+        });
+    }
+#endif
 }