Changeset 275229 in webkit

Timestamp:

Mar 30, 2021 1:21:32 PM (3 years ago)

Author:

mark.lam@apple.com

Message:

Add more information to GC verifier verbose dumps.
​https://bugs.webkit.org/show_bug.cgi?id=223951

Reviewed by Yusuke Suzuki.

• heap/VerifierSlotVisitor.cpp:

(JSC::VerifierSlotVisitor::dumpMarkerData):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/VerifierSlotVisitor.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-03-30  Mark Lam  <mark.lam@apple.com>
+
+        Add more information to GC verifier verbose dumps.
+        https://bugs.webkit.org/show_bug.cgi?id=223951
+
+        Reviewed by Yusuke Suzuki.
+
+        * heap/VerifierSlotVisitor.cpp:
+        (JSC::VerifierSlotVisitor::dumpMarkerData):
+
 2021-03-30  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/heap/VerifierSlotVisitor.cpp

@@ -253 +253 @@
             if (isJSCellKind(cell->cellKind()))
                 dataLogLn(JSValue(static_cast<JSCell*>(cell)));
+
+            bool isMarked = heap()->isMarked(cell);
+            const char* wasOrWasNot = isMarked ? "was" : "was NOT";
+            dataLogLn("In the real GC, cell ", RawPointer(cell), " ", wasOrWasNot, " marked.");
+
             if (cell->isPreciseAllocation())
                 markerData = markerDataForPreciseAllocation(cell->preciseAllocation());
@@ -261 +266 @@
                 break;
             }
-            dataLog("Cell ", RawPointer(cell), " was visited");
+            dataLog("In the verifier GC, cell ", RawPointer(cell), " was visited");
 
         } else {
@@ -268 +273 @@
             bool containsOpaqueRoot = heap()->m_opaqueRoots.contains(opaqueRoot);
             const char* wasOrWasNot = containsOpaqueRoot ? "was" : "was NOT";
-            dataLogLn("In the real GC, opaque root", RawPointer(opaqueRoot), " ", wasOrWasNot, " added to the heap's opaque roots.");
+            dataLogLn("In the real GC, opaque root ", RawPointer(opaqueRoot), " ", wasOrWasNot, " added to the heap's opaque roots.");
 
             markerData = markerDataForOpaqueRoot(opaqueRoot);
@@ -275 +280 @@
                 break;
             }
-            dataLog("Opaque root ", RawPointer(opaqueRoot), " was added");
+            dataLog("In the verifier GC, opaque root ", RawPointer(opaqueRoot), " was added");
         }