Changeset 275971 in webkit

Timestamp:

Apr 14, 2021, 2:57:21 PM (4 years ago)

Author:

mark.lam@apple.com

Message:

Apply DeferTermination in some utility functions in the jsc shell.
​https://bugs.webkit.org/show_bug.cgi?id=224572
rdar://76646089

Reviewed by Yusuke Suzuki.

This is to make sure that these functions don't get in the way of testing with
the watchdog. Since these are only test utility functions, just doing the simple
thing of using a DeferTermination scope is the right thing to do here.

• jsc.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jsc.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-04-14  Mark Lam  <mark.lam@apple.com>
+
+        Apply DeferTermination in some utility functions in the jsc shell.
+        https://bugs.webkit.org/show_bug.cgi?id=224572
+        rdar://76646089
+
+        Reviewed by Yusuke Suzuki.
+
+        This is to make sure that these functions don't get in the way of testing with
+        the watchdog.  Since these are only test utility functions, just doing the simple
+        thing of using a DeferTermination scope is the right thing to do here.
+
+        * jsc.cpp:
+
 2021-04-14  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/jsc.cpp

@@ -32 +32 @@
 #include "Completion.h"
 #include "ConfigFile.h"
+#include "DeferTermination.h"
 #include "DeferredWorkTimer.h"
 #include "Disassembler.h"
@@ -2523 +2524 @@
     VM& vm = globalObject->vm();
     JSLockHolder lock(vm);
+    DeferTermination deferScope(vm);
     auto scope = DECLARE_THROW_SCOPE(vm);
 
@@ -2538 +2540 @@
     VM& vm = globalObject->vm();
     JSLockHolder lock(vm);
+    DeferTermination deferScope(vm);
     auto scope = DECLARE_THROW_SCOPE(vm);
     String jsonString;
@@ -2581 +2584 @@
 {
     VM& vm = globalObject->vm();
+    DeferTermination deferScope(vm);
     auto scope = DECLARE_THROW_SCOPE(vm);