⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 277614 in webkit


Ignore:
Timestamp:
May 17, 2021, 4:24:23 PM (5 years ago)
Author:
achristensen@apple.com
Message:

Remove API::Object::Type::BundlePageGroup
​https://bugs.webkit.org/show_bug.cgi?id=225611

Reviewed by Brady Eidson.

Source/WebKit:

Its last use was removed in rdar://77775952

  • Shared/API/APIObject.h:
  • Shared/API/APIPageGroupHandle.cpp: Removed.
  • Shared/API/APIPageGroupHandle.h: Removed.
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • Shared/Cocoa/SharedRingBufferStorage.cpp:

(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::allocate):

  • Shared/UserData.cpp:

(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • Shared/mac/MediaFormatReader/MediaSampleCursor.h:
  • Sources.txt:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:

(-[WKWebProcessPlugInPageGroup identifier]): Deleted.
(-[WKWebProcessPlugInPageGroup dealloc]): Deleted.
(-[WKWebProcessPlugInPageGroup _apiObject]): Deleted.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroupInternal.h: Removed.
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController pageGroup]): Deleted.

  • WebProcess/WebPage/WebPageGroupProxy.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

Tools:

Some tests were trying to encode a page group, but it was unused so I just removed them.

  • TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:

(TestWebKitAPI::TEST):

Location:
trunk
Files:
3 deleted
20 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r277606 r277614  
     12021-05-17  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove API::Object::Type::BundlePageGroup
     4        https://bugs.webkit.org/show_bug.cgi?id=225611
     5
     6        Reviewed by Brady Eidson.
     7
     8        Its last use was removed in rdar://77775952
     9
     10        * Shared/API/APIObject.h:
     11        * Shared/API/APIPageGroupHandle.cpp: Removed.
     12        * Shared/API/APIPageGroupHandle.h: Removed.
     13        * Shared/Cocoa/APIObject.mm:
     14        (API::Object::newObject):
     15        * Shared/Cocoa/SharedRingBufferStorage.cpp:
     16        (WebKit::SharedRingBufferStorage::setStorage):
     17        (WebKit::SharedRingBufferStorage::allocate):
     18        * Shared/UserData.cpp:
     19        (WebKit::UserData::encode):
     20        (WebKit::UserData::decode):
     21        * Shared/mac/MediaFormatReader/MediaSampleCursor.h:
     22        * Sources.txt:
     23        * UIProcess/WebProcessProxy.cpp:
     24        (WebKit::WebProcessProxy::transformHandlesToObjects):
     25        (WebKit::WebProcessProxy::transformObjectsToHandles):
     26        * WebKit.xcodeproj/project.pbxproj:
     27        * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:
     28        * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:
     29        (-[WKWebProcessPlugInPageGroup identifier]): Deleted.
     30        (-[WKWebProcessPlugInPageGroup dealloc]): Deleted.
     31        (-[WKWebProcessPlugInPageGroup _apiObject]): Deleted.
     32        * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroupInternal.h: Removed.
     33        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
     34        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
     35        (-[WKWebProcessPlugInBrowserContextController pageGroup]): Deleted.
     36        * WebProcess/WebPage/WebPageGroupProxy.h:
     37        * WebProcess/WebProcess.cpp:
     38        (WebKit::WebProcess::transformHandlesToObjects):
     39        (WebKit::WebProcess::transformObjectsToHandles):
     40
    1412021-05-17  Alex Christensen  <achristensen@webkit.org>
    242

  • trunk/Source/WebKit/Shared/API/APIObject.h

    r272573 r277614  
    6767        FrameHandle,
    6868        Image,
    69         PageGroupData,
    7069        PageHandle,
    71         PageGroupHandle,
    7270        ProtectionSpace,
    7371        RenderLayer,
    … …  
    205203        BundlePage,
    206204        BundlePageBanner,
    207         BundlePageGroup,
    208205        BundlePageOverlay,
    209206        BundleRangeHandle,
    … …  
    320317        API::Object::Type::FrameHandle,
    321318        API::Object::Type::Image,
    322         API::Object::Type::PageGroupData,
    323319        API::Object::Type::PageHandle,
    324         API::Object::Type::PageGroupHandle,
    325320        API::Object::Type::ProtectionSpace,
    326321        API::Object::Type::ResourceLoadInfo,
    … …  
    456451        API::Object::Type::BundlePage,
    457452        API::Object::Type::BundlePageBanner,
    458         API::Object::Type::BundlePageGroup,
    459453        API::Object::Type::BundlePageOverlay,
    460454        API::Object::Type::BundleRangeHandle,

  • trunk/Source/WebKit/Shared/Cocoa/APIObject.mm

    r277280 r277614  
    6464#import "WKWebProcessPlugInInternal.h"
    6565#import "WKWebProcessPlugInNodeHandleInternal.h"
    66 #import "WKWebProcessPlugInPageGroupInternal.h"
    6766#import "WKWebProcessPlugInRangeHandleInternal.h"
    6867#import "WKWebProcessPlugInScriptWorldInternal.h"
    … …  
    428427        break;
    429428
    430     case Type::BundlePageGroup:
    431         ALLOW_DEPRECATED_DECLARATIONS_BEGIN;
    432         wrapper = [WKWebProcessPlugInPageGroup alloc];
    433         ALLOW_DEPRECATED_DECLARATIONS_END;
    434         break;
    435 
    436429    case Type::BundleRangeHandle:
    437430        wrapper = [WKWebProcessPlugInRangeHandle alloc];

  • trunk/Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp

    r271041 r277614  
    7777}
    7878
    79 void SharedRingBufferStorage::setStorage(RefPtr<SharedMemory>&& storage, const CAAudioStreamDescription& format, size_t frameCount)
     79void SharedRingBufferStorage::setStorage(RefPtr<SharedMemory>&& storage, const WebCore::CAAudioStreamDescription& format, size_t frameCount)
    8080{
    8181    m_storage = WTFMove(storage);
    … …  
    8484}
    8585
    86 void SharedRingBufferStorage::allocate(size_t byteCount, const CAAudioStreamDescription& format, size_t frameCount)
     86void SharedRingBufferStorage::allocate(size_t byteCount, const WebCore::CAAudioStreamDescription& format, size_t frameCount)
    8787{
    8888    auto sharedMemory = SharedMemory::allocate(byteCount + sizeof(FrameBounds));

  • trunk/Source/WebKit/Shared/UserData.cpp

    r264925 r277614  
    3434#include "APIGeometry.h"
    3535#include "APINumber.h"
    36 #include "APIPageGroupHandle.h"
    3736#include "APIPageHandle.h"
    3837#include "APISerializedScriptValue.h"
    … …  
    231230    }
    232231
    233     case API::Object::Type::PageGroupHandle:
    234         static_cast<const API::PageGroupHandle&>(object).encode(encoder);
    235         break;
    236 
    237232    case API::Object::Type::PageHandle:
    238233        static_cast<const API::PageHandle&>(object).encode(encoder);
    … …  
    416411        break;
    417412
    418     case API::Object::Type::PageGroupHandle:
    419         if (!API::PageGroupHandle::decode(decoder, result))
    420             return false;
    421         break;
    422 
    423413    case API::Object::Type::PageHandle:
    424414        if (!API::PageHandle::decode(decoder, result))

  • trunk/Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h

    r271939 r277614  
    3030#include "CoreMediaWrapped.h"
    3131#include <WebCore/SampleMap.h>
     32#include <wtf/Identified.h>
    3233#include <wtf/MediaTime.h>
    3334#include <wtf/Variant.h>

  • trunk/Source/WebKit/Sources.txt

    r277414 r277614  
    239239Shared/API/APIGeometry.cpp
    240240Shared/API/APIObject.cpp
    241 Shared/API/APIPageGroupHandle.cpp
    242241Shared/API/APIPageHandle.cpp
    243242Shared/API/APIURLRequest.cpp

  • trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp

    r277354 r277614  
    2828
    2929#include "APIFrameHandle.h"
    30 #include "APIPageGroupHandle.h"
    3130#include "APIPageHandle.h"
    3231#include "AuthenticatorManager.h"
    … …  
    13411340                return static_cast<const API::PageHandle&>(object).isAutoconverting();
    13421341
    1343             case API::Object::Type::PageGroupHandle:
    13441342#if PLATFORM(COCOA)
    13451343            case API::Object::Type::ObjCObjectGraph:
    … …  
    13581356                ASSERT(static_cast<API::FrameHandle&>(object).isAutoconverting());
    13591357                return m_webProcessProxy.webFrame(static_cast<API::FrameHandle&>(object).frameID());
    1360 
    1361             case API::Object::Type::PageGroupHandle:
    1362                 return WebPageGroup::get(static_cast<API::PageGroupHandle&>(object).webPageGroupData().pageGroupID);
    13631358
    13641359            case API::Object::Type::PageHandle:
    … …  
    14081403            case API::Object::Type::Page:
    14091404                return API::PageHandle::createAutoconverting(static_cast<const WebPageProxy&>(object).identifier(), static_cast<const WebPageProxy&>(object).webPageID());
    1410 
    1411             case API::Object::Type::PageGroup:
    1412                 return API::PageGroupHandle::create(WebPageGroupData(static_cast<const WebPageGroup&>(object).data()));
    14131405
    14141406#if PLATFORM(COCOA)

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r277605 r277614  
    465465                1F7D36C118DA513F00D9D659 /* APIDownloadClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1F7D36C018DA513F00D9D659 /* APIDownloadClient.h */; };
    466466                1FB00AC7185F76460019142E /* WKWebProcessPlugInPageGroup.h in Headers */ = {isa = PBXBuildFile; fileRef = 1FB00AC4185F76460019142E /* WKWebProcessPlugInPageGroup.h */; settings = {ATTRIBUTES = (Private, ); }; };
    467                 1FB00AC9185F76460019142E /* WKWebProcessPlugInPageGroupInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 1FB00AC6185F76460019142E /* WKWebProcessPlugInPageGroupInternal.h */; };
    468467                263172CF18B469490065B9C3 /* NativeWebTouchEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 263172CE18B469490065B9C3 /* NativeWebTouchEvent.h */; };
    469468                2684054418B85A630022C38B /* VisibleContentRectUpdateInfo.h in Headers */ = {isa = PBXBuildFile; fileRef = 2684054218B85A630022C38B /* VisibleContentRectUpdateInfo.h */; };
    … …  
    26542653                1A334DEB16DE8F88006A8E38 /* StorageAreaMapMessageReceiver.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = StorageAreaMapMessageReceiver.cpp; path = DerivedSources/WebKit2/StorageAreaMapMessageReceiver.cpp; sourceTree = BUILT_PRODUCTS_DIR; };
    26552654                1A334DEC16DE8F88006A8E38 /* StorageAreaMapMessages.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = StorageAreaMapMessages.h; path = DerivedSources/WebKit2/StorageAreaMapMessages.h; sourceTree = BUILT_PRODUCTS_DIR; };
    2656                 1A3A73CB1A48C6D4007231B3 /* APIPageGroupHandle.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = APIPageGroupHandle.cpp; sourceTree = "<group>"; };
    2657                 1A3A73CC1A48C6D4007231B3 /* APIPageGroupHandle.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIPageGroupHandle.h; sourceTree = "<group>"; };
    26582655                1A3C887F18A5ABAE00C4C962 /* WKPreferencesInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKPreferencesInternal.h; sourceTree = "<group>"; };
    26592656                1A3CC16418906ACF001E6ED8 /* WKWebView.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKWebView.mm; sourceTree = "<group>"; };
    … …  
    31103107                1FB00AC4185F76460019142E /* WKWebProcessPlugInPageGroup.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKWebProcessPlugInPageGroup.h; sourceTree = "<group>"; };
    31113108                1FB00AC5185F76460019142E /* WKWebProcessPlugInPageGroup.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKWebProcessPlugInPageGroup.mm; sourceTree = "<group>"; };
    3112                 1FB00AC6185F76460019142E /* WKWebProcessPlugInPageGroupInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKWebProcessPlugInPageGroupInternal.h; sourceTree = "<group>"; };
    31133109                263172CE18B469490065B9C3 /* NativeWebTouchEvent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NativeWebTouchEvent.h; sourceTree = "<group>"; };
    31143110                26659AA0185FAAED004303DD /* Info-iOS.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = "Info-iOS.plist"; sourceTree = "<group>"; };
    … …  
    72207216                                1FB00AC4185F76460019142E /* WKWebProcessPlugInPageGroup.h */,
    72217217                                1FB00AC5185F76460019142E /* WKWebProcessPlugInPageGroup.mm */,
    7222                                 1FB00AC6185F76460019142E /* WKWebProcessPlugInPageGroupInternal.h */,
    72237218                                374942191DF1F9FF0033C19F /* WKWebProcessPlugInRangeHandle.h */,
    72247219                                374942181DF1F9FF0033C19F /* WKWebProcessPlugInRangeHandle.mm */,
    … …  
    1086310858                                B63403F814910D57001070B5 /* APIObject.cpp */,
    1086410859                                BCF04C8C11FF9B7D00F86A58 /* APIObject.h */,
    10865                                 1A3A73CB1A48C6D4007231B3 /* APIPageGroupHandle.cpp */,
    10866                                 1A3A73CC1A48C6D4007231B3 /* APIPageGroupHandle.h */,
    1086710860                                1AC1336D18565D2B00F3EC05 /* APIPageHandle.cpp */,
    1086810861                                1AC1336B18565C7A00F3EC05 /* APIPageHandle.h */,
    … …  
    1295912952                                CEC8F9CB1FDF5870002635E7 /* WKWebProcessPlugInNodeHandlePrivate.h in Headers */,
    1296012953                                1FB00AC7185F76460019142E /* WKWebProcessPlugInPageGroup.h in Headers */,
    12961                                 1FB00AC9185F76460019142E /* WKWebProcessPlugInPageGroupInternal.h in Headers */,
    1296212954                                BC04EFFC16E65AFB00E336F0 /* WKWebProcessPlugInPrivate.h in Headers */,
    1296312955                                3749421B1DF1F9FF0033C19F /* WKWebProcessPlugInRangeHandle.h in Headers */,

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h

    r277280 r277614  
    2828#import <Foundation/Foundation.h>
    2929
     30// FIXME: Remove this file once the staging code for rdar://77775952 is removed.
    3031WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKWebProcessPlugInBrowserContextController._groupIdentifier", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))
    3132@interface WKWebProcessPlugInPageGroup : NSObject
    3233
    33 @property (readonly) NSString *identifier;
    34 
    3534@end

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm

    r277280 r277614  
    2525
    2626#import "config.h"
    27 #import "WKWebProcessPlugInPageGroupInternal.h"
     27#import "WKWebProcessPlugInPageGroup.h"
    2828
    29 #import "WKAPICast.h"
    30 #import "WKNSString.h"
    31 #import "WKRetainPtr.h"
    32 #import "WebPageGroupProxy.h"
    33 #import <WebCore/WebCoreObjCExtras.h>
     29// FIXME: Remove this file once the staging code for rdar://77775952 is removed.
    3430
    3531ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    36 @implementation WKWebProcessPlugInPageGroup {
    37     API::ObjectStorage<WebKit::WebPageGroupProxy> _bundlePageGroup;
    38 }
     32@implementation WKWebProcessPlugInPageGroup
    3933ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    4034
    41 - (NSString *)identifier
    42 {
    43     return _bundlePageGroup->identifier();
    44 }
    45 
    46 - (void)dealloc
    47 {
    48     if (WebCoreObjCScheduleDeallocateOnMainRunLoop(WKWebProcessPlugInPageGroup.class, self))
    49         return;
    50     _bundlePageGroup->~WebPageGroupProxy();
    51     [super dealloc];
    52 }
    53 
    54 #pragma mark WKObject protocol implementation
    55 
    56 - (API::Object&)_apiObject
    57 {
    58     return *_bundlePageGroup;
    59 }
    60 
    6135@end

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h

    r277280 r277614  
    3131@class WKDOMRange;
    3232@class WKWebProcessPlugInFrame;
    33 @class WKWebProcessPlugInPageGroup;
    3433@protocol WKWebProcessPlugInLoadDelegate;
    3534
    … …  
    4342@property (readonly) WKWebProcessPlugInFrame *mainFrame;
    4443
    45 @property (readonly) WKWebProcessPlugInPageGroup *pageGroup WK_API_DEPRECATED_WITH_REPLACEMENT("_groupIdentifier", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA));
    46 
    4744@property (weak) id <WKWebProcessPlugInLoadDelegate> loadDelegate;
    4845

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm

    r277280 r277614  
    4949#import "WKWebProcessPlugInLoadDelegate.h"
    5050#import "WKWebProcessPlugInNodeHandleInternal.h"
    51 #import "WKWebProcessPlugInPageGroupInternal.h"
    5251#import "WKWebProcessPlugInRangeHandleInternal.h"
    5352#import "WKWebProcessPlugInScriptWorldInternal.h"
    5453#import "WebPage.h"
     54#import "WebPageGroupProxy.h"
    5555#import "WebProcess.h"
    5656#import "_WKRemoteObjectRegistryInternal.h"
    … …  
    405405}
    406406
    407 - (WKWebProcessPlugInPageGroup *)pageGroup
    408 {
    409     return wrapper(*_page->pageGroup());
    410 }
    411 
    412407#pragma mark WKObject protocol implementation
    413408

  • trunk/Source/WebKit/WebProcess/WebPage/WebPageGroupProxy.h

    r259159 r277614  
    3939class WebUserContentController;
    4040
    41 class WebPageGroupProxy : public API::ObjectImpl<API::Object::Type::BundlePageGroup> {
     41class WebPageGroupProxy : public RefCounted<WebPageGroupProxy> {
    4242public:
    4343    static Ref<WebPageGroupProxy> create(const WebPageGroupData&);

  • trunk/Source/WebKit/WebProcess/WebProcess.cpp

    r277564 r277614  
    2828
    2929#include "APIFrameHandle.h"
    30 #include "APIPageGroupHandle.h"
    3130#include "APIPageHandle.h"
    3231#include "AuthenticationManager.h"
    … …  
    16951694                return static_cast<const API::PageHandle&>(object).isAutoconverting();
    16961695
    1697             case API::Object::Type::PageGroupHandle:
    16981696#if PLATFORM(COCOA)
    16991697            case API::Object::Type::ObjCObjectGraph:
    … …  
    17111709            case API::Object::Type::FrameHandle:
    17121710                return m_webProcess.webFrame(static_cast<const API::FrameHandle&>(object).frameID());
    1713 
    1714             case API::Object::Type::PageGroupHandle:
    1715                 return m_webProcess.webPageGroup(static_cast<const API::PageGroupHandle&>(object).webPageGroupData());
    17161711
    17171712            case API::Object::Type::PageHandle:
    … …  
    17411736            case API::Object::Type::BundleFrame:
    17421737            case API::Object::Type::BundlePage:
    1743             case API::Object::Type::BundlePageGroup:
    17441738#if PLATFORM(COCOA)
    17451739            case API::Object::Type::ObjCObjectGraph:
    … …  
    17601754            case API::Object::Type::BundlePage:
    17611755                return API::PageHandle::createAutoconverting(static_cast<const WebPage&>(object).webPageProxyIdentifier(), static_cast<const WebPage&>(object).identifier());
    1762 
    1763             case API::Object::Type::BundlePageGroup: {
    1764                 WebPageGroupData pageGroupData;
    1765                 pageGroupData.pageGroupID = static_cast<const WebPageGroupProxy&>(object).pageGroupID();
    1766 
    1767                 return API::PageGroupHandle::create(WTFMove(pageGroupData));
    1768             }
    17691756
    17701757#if PLATFORM(COCOA)

  • trunk/Tools/ChangeLog

    r277612 r277614  
     12021-05-17  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove API::Object::Type::BundlePageGroup
     4        https://bugs.webkit.org/show_bug.cgi?id=225611
     5
     6        Reviewed by Brady Eidson.
     7
     8        Some tests were trying to encode a page group, but it was unused so I just removed them.
     9
     10        * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
     11        (TestWebKitAPI::TEST):
     12        * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
     13        (TestWebKitAPI::TEST):
     14        * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
     15        (TestWebKitAPI::TEST):
     16        * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
     17        (TestWebKitAPI::TEST):
     18
    1192021-05-17  Aakash Jain  <aakash_jain@apple.com>
    220

  • trunk/Tools/TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp

    r251220 r277614  
    140140    WKRetainPtr<WKPageGroupRef> pageGroup = adoptWK(WKPageGroupCreateWithIdentifier(WKStringCreateWithUTF8CString("DOMWindowExtensionBasicPageGroup")));
    141141
    142     WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("DOMWindowExtensionBasic", pageGroup.get()));
     142    WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("DOMWindowExtensionBasic"));
    143143
    144144    WKContextInjectedBundleClientV0 injectedBundleClient;

  • trunk/Tools/TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp

    r244390 r277614  
    5151    WKRetainPtr<WKPageGroupRef> pageGroup = adoptWK(WKPageGroupCreateWithIdentifier(WKStringCreateWithUTF8CString("DocumentStartUserScriptAlertCrashTestPageGroup")));
    5252
    53     WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("DocumentStartUserScriptAlertCrashTest", pageGroup.get()));
     53    WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("DocumentStartUserScriptAlertCrashTest"));
    5454    PlatformWebView webView(context.get(), pageGroup.get());
    5555

  • trunk/Tools/TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp

    r244390 r277614  
    5353    WKRetainPtr<WKPageGroupRef> pageGroup = adoptWK(WKPageGroupCreateWithIdentifier(WKStringCreateWithUTF8CString("InjectedBundleNoDisableOverrideBuiltinsBehaviorTestPageGroup")));
    5454
    55     WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("InjectedBundleNoDisableOverrideBuiltinsBehaviorTest", pageGroup.get()));
     55    WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("InjectedBundleNoDisableOverrideBuiltinsBehaviorTest"));
    5656    PlatformWebView webView(context.get(), pageGroup.get());
    5757
    … …  
    8787    WKRetainPtr<WKPageGroupRef> pageGroup = adoptWK(WKPageGroupCreateWithIdentifier(WKStringCreateWithUTF8CString("InjectedBundleDisableOverrideBuiltinsBehaviorTestPageGroup")));
    8888
    89     WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("InjectedBundleDisableOverrideBuiltinsBehaviorTest", pageGroup.get()));
     89    WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("InjectedBundleDisableOverrideBuiltinsBehaviorTest"));
    9090    PlatformWebView webView(context.get(), pageGroup.get());
    9191

  • trunk/Tools/TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp

    r244390 r277614  
    8888    WKRetainPtr<WKPageGroupRef> pageGroup = adoptWK(WKPageGroupCreateWithIdentifier(WKStringCreateWithUTF8CString("InjectedBundleMakeAllShadowRootOpenTestPageGroup")));
    8989
    90     WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("InjectedBundleMakeAllShadowRootOpenTest", pageGroup.get()));
     90    WKRetainPtr<WKContextRef> context = adoptWK(Util::createContextForInjectedBundleTest("InjectedBundleMakeAllShadowRootOpenTest"));
    9191    PlatformWebView webView(context.get(), pageGroup.get());
    9292
Note: See TracChangeset for help on using the changeset viewer.