Changeset 277759 in webkit

Timestamp:

May 19, 2021 3:39:45 PM (3 years ago)

Author:

mark.lam@apple.com

Message:

Speed up debug validation in CacheableIdentifier::createFromIdentifierOwnedByCodeBlock().
​https://bugs.webkit.org/show_bug.cgi?id=225948

Not reviewed.

Build fix after r277727.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hasIdentifier):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/CodeBlock.cpp (modified) (5 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-05-19  Mark Lam  <mark.lam@apple.com>
+
+        Speed up debug validation in CacheableIdentifier::createFromIdentifierOwnedByCodeBlock().
+        https://bugs.webkit.org/show_bug.cgi?id=225948
+
+        Not reviewed.
+
+        Build fix after r277727.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::hasIdentifier):
+
 2021-05-19  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -2888 +2888 @@
     UnlinkedCodeBlock* unlinkedCode = m_unlinkedCode.get();
     size_t unlinkedIdentifiers = unlinkedCode->numberOfIdentifiers();
+#if ENABLE(DFG_JIT)
     size_t numberOfDFGIdentifiers = this->numberOfDFGIdentifiers();
     size_t numberOfIdentifiers = unlinkedIdentifiers + numberOfDFGIdentifiers;
+#else
+    size_t numberOfIdentifiers = unlinkedIdentifiers;
+#endif
 
     if (numberOfIdentifiers > 100) {
@@ -2901 +2905 @@
                 cachedIdentifierUids.add(identifier.impl());
             }
+#if ENABLE(DFG_JIT)
             if (numberOfDFGIdentifiers) {
                 ASSERT(JITCode::isOptimizingJIT(jitType()));
@@ -2909 +2914 @@
                 }
             }
+#endif
             WTF::storeStoreFence();
             m_cachedIdentifierUids = WTFMove(cachedIdentifierUids);
@@ -2920 +2926 @@
             return true;
     }
+#if ENABLE(DFG_JIT)
     ASSERT(JITCode::isOptimizingJIT(jitType()));
     auto& dfgIdentifiers = m_jitCode->dfgCommon()->m_dfgIdentifiers;
@@ -2927 +2934 @@
             return true;
     }
+#endif
     return false;
 }