Changeset 278178 in webkit

Timestamp:

May 27, 2021 2:35:51 PM (3 years ago)

Author:

don.olmstead@sony.com

Message:

[CMake] Add check for timingsafe_bcmp
​https://bugs.webkit.org/show_bug.cgi?id=226347

Reviewed by Chris Dumez.

.:

Adds a symbol check for timingsafe_bcmp and sets HAVE_TIMINGSAFE_BCMP accordingly in the
cmakeconfig.h.

• Source/cmake/OptionsCommon.cmake:

Source/WTF:

Use HAVE(TIMINGSAFE_BCMP) in CryptographicUtilities code. Set its value in PlatformHave for
platforms not using CMake.

• wtf/CryptographicUtilities.cpp:
• wtf/CryptographicUtilities.h:
• wtf/PlatformHave.h:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/CryptographicUtilities.cpp (modified) (1 diff)
• Source/WTF/wtf/CryptographicUtilities.h (modified) (1 diff)
• Source/WTF/wtf/PlatformHave.h (modified) (1 diff)
• Source/cmake/OptionsCommon.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2021-05-27  Don Olmstead  <don.olmstead@sony.com>
+
+        [CMake] Add check for timingsafe_bcmp
+        https://bugs.webkit.org/show_bug.cgi?id=226347
+
+        Reviewed by Chris Dumez.
+
+        Adds a symbol check for timingsafe_bcmp and sets HAVE_TIMINGSAFE_BCMP accordingly in the
+        cmakeconfig.h.
+
+        * Source/cmake/OptionsCommon.cmake:
+
 2021-05-27  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-05-27  Don Olmstead  <don.olmstead@sony.com>
+
+        [CMake] Add check for timingsafe_bcmp
+        https://bugs.webkit.org/show_bug.cgi?id=226347
+
+        Reviewed by Chris Dumez.
+
+        Use HAVE(TIMINGSAFE_BCMP) in CryptographicUtilities code. Set its value in PlatformHave for
+        platforms not using CMake.
+
+        * wtf/CryptographicUtilities.cpp:
+        * wtf/CryptographicUtilities.h:
+        * wtf/PlatformHave.h:
+
 2021-05-27  Mikhail R. Gadelha  <mikhail.ramalho@gmail.com>
 

trunk/Source/WTF/wtf/CryptographicUtilities.cpp

@@ -29 +29 @@
 namespace WTF {
 
-#if !PLATFORM(COCOA) && !OS(OPENBSD) && !OS(FREEBSD)
+#if !HAVE(TIMINGSAFE_BCMP)
 NEVER_INLINE int constantTimeMemcmp(const void* voidA, const void* voidB, size_t length)
 {

trunk/Source/WTF/wtf/CryptographicUtilities.h

@@ -31 +31 @@
 
 // Returns zero if arrays are equal, and non-zero otherwise. Execution time does not depend on array contents.
-#if PLATFORM(COCOA) || OS(OPENBSD) || OS(FREEBSD)
+#if HAVE(TIMINGSAFE_BCMP)
 inline int constantTimeMemcmp(const void* voidA, const void* voidB, size_t length)
 {

trunk/Source/WTF/wtf/PlatformHave.h

@@ -94 +94 @@
 #endif
 
+#if !defined(HAVE_TIMINGSAFE_BCMP) && (PLATFORM(COCOA) || OS(OPENBSD) || OS(FREEBSD))
+#define HAVE_TIMINGSAFE_BCMP 1
+#endif
+
 #if !defined(HAVE_STD_FILESYSTEM)
 #if __has_include(<filesystem>)

trunk/Source/cmake/OptionsCommon.cmake

@@ -145 +145 @@
 WEBKIT_CHECK_HAVE_SYMBOL(HAVE_REGEX_H regexec regex.h)
 if (NOT (${CMAKE_SYSTEM_NAME} STREQUAL "Darwin"))
-WEBKIT_CHECK_HAVE_SYMBOL(HAVE_PTHREAD_MAIN_NP pthread_main_np pthread_np.h)
+    WEBKIT_CHECK_HAVE_SYMBOL(HAVE_PTHREAD_MAIN_NP pthread_main_np pthread_np.h)
 endif ()
+WEBKIT_CHECK_HAVE_SYMBOL(HAVE_TIMINGSAFE_BCMP timingsafe_bcmp string.h)
 # Windows has signal.h but is missing symbols that are used in calls to signal.
 WEBKIT_CHECK_HAVE_SYMBOL(HAVE_SIGNAL_H SIGTRAP signal.h)