Changeset 279025 in webkit

Timestamp:

Jun 17, 2021 5:00:29 PM (3 years ago)

Author:

achristensen@apple.com

Message:

Add assertion in RunLoop::dispatch
​https://bugs.webkit.org/show_bug.cgi?id=227154
<rdar://79243769>

Reviewed by Geoff Garen.

This should help us find what is scheduling null functions.

• wtf/RunLoop.cpp:

(WTF::RunLoop::dispatch):
(WTF::RunLoop::dispatchAfter):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/RunLoop.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-06-17  Alex Christensen  <achristensen@webkit.org>
+
+        Add assertion in RunLoop::dispatch
+        https://bugs.webkit.org/show_bug.cgi?id=227154
+        <rdar://79243769>
+
+        Reviewed by Geoff Garen.
+
+        This should help us find what is scheduling null functions.
+
+        * wtf/RunLoop.cpp:
+        (WTF::RunLoop::dispatch):
+        (WTF::RunLoop::dispatchAfter):
+
 2021-06-17  Ben Nham  <nham@apple.com>
 

trunk/Source/WTF/wtf/RunLoop.cpp

@@ -142 +142 @@
 }
 
-void RunLoop::dispatch(Function<void ()>&& function)
+void RunLoop::dispatch(Function<void()>&& function)
 {
+    RELEASE_ASSERT(function);
     bool needsWakeup = false;
 
@@ -158 +159 @@
 void RunLoop::dispatchAfter(Seconds delay, Function<void()>&& function)
 {
+    RELEASE_ASSERT(function);
     auto timer = new DispatchTimer(*this);
     timer->setFunction([timer, function = WTFMove(function)] {