Changeset 281123 in webkit

Timestamp:

Aug 16, 2021 4:58:07 PM (3 years ago)

Author:

achristensen@apple.com

Message:

Fix null crash after r281110
​https://bugs.webkit.org/show_bug.cgi?id=225737

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::reportResourceTiming):
I saw a nullptr crash here in EWS from bug 229167.
Looks like there's a case where we can call reportResourceTiming without a resource.
Early return if m_resource is null.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/SubresourceLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-16  Alex Christensen  <achristensen@webkit.org>
+
+        Fix null crash after r281110
+        https://bugs.webkit.org/show_bug.cgi?id=225737
+
+        * loader/SubresourceLoader.cpp:
+        (WebCore::SubresourceLoader::reportResourceTiming):
+        I saw a nullptr crash here in EWS from bug 229167.
+        Looks like there's a case where we can call reportResourceTiming without a resource.
+        Early return if m_resource is null.
+
 2021-08-16  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/loader/SubresourceLoader.cpp

@@ -886 +886 @@
 void SubresourceLoader::reportResourceTiming(const NetworkLoadMetrics& networkLoadMetrics)
 {
-    if (!ResourceTimingInformation::shouldAddResourceTiming(*m_resource))
+    if (!m_resource || !ResourceTimingInformation::shouldAddResourceTiming(*m_resource))
         return;