Changeset 288214 in webkit

Timestamp:

Jan 19, 2022 10:07:36 AM (2 years ago)

Author:

achristensen@apple.com

Message:

Unreviewed, reverting r288147.
<rdar://87776311>

broke clean command line builds

Reverted changeset:

"Build WebKitSwift when building with make or build-webkit"
​https://bugs.webkit.org/show_bug.cgi?id=235093
​https://commits.webkit.org/r288147

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Makefile (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/build-webkit (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-01-19  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, reverting r288147.
+        <rdar://87776311>
+
+        broke clean command line builds
+
+        Reverted changeset:
+
+        "Build WebKitSwift when building with make or build-webkit"
+        https://bugs.webkit.org/show_bug.cgi?id=235093
+        https://commits.webkit.org/r288147
+
 2022-01-19  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/Makefile

@@ -1 @@
-export XCODE_TARGET = -target WebKit -target WebKitSwift
 include ../Makefile.shared

trunk/Tools/ChangeLog

@@ +1 @@
+2022-01-19  Alex Christensen  <achristensen@webkit.org>
+
+        Unreviewed, reverting r288147.
+        <rdar://87776311>
+
+        broke clean command line builds
+
+        Reverted changeset:
+
+        "Build WebKitSwift when building with make or build-webkit"
+        https://bugs.webkit.org/show_bug.cgi?id=235093
+        https://commits.webkit.org/r288147
+
 2022-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/Scripts/build-webkit

@@ -351 +351 @@
         push @local_options, XcodeStaticAnalyzerOption() if $shouldRunStaticAnalyzer;
         push @local_options, "WK_LTO_MODE=$ltoMode" if ($ltoMode ne "default");
-
-        # FIXME: Move WebKitSwift to its own directory and remove this hack.
-        if ($dir eq "Source/WebKit") {
-            push @local_options, "-target", "WebKit", "-target", "WebKitSwift"
-        }
-
         my $projectPath = $project =~ /gtest/ ? "xcode/gtest" : $project;
         $result = buildXCodeProject($projectPath, $clean, @local_options, @ARGV);