Changeset 72111 in webkit

Timestamp:

Nov 16, 2010 9:41:25 AM (13 years ago)

Author:

Adam Roben

Message:

Only trigger Windows builds when files that we actually use on Windows are changed

A new Scheduler subclass, PlatformSpecificScheduler, has been added.
It uses the new webkitpy.common.config.build module to determine
whether a particular change should trigger a build on a particular
platform. The Windows builders have been switched to use a
PlatformSpecificScheduler.

The logic to determine whether or not a particular change should
trigger a build on a given platform has only been implemented/tested
for Windows. I tried to make it easy to add more platforms in the
future, but I don't have enough familiarity with all platforms to be
able to implement it for them.

Fixes <​http://webkit.org/b/49407> Windows builders kick off builds for
lots irrelevant changes (e.g., rebaselining Chromium test results)

Reviewed by Eric Seidel.

• BuildSlaveSupport/build.webkit.org-config/config.json: Use a

PlatformSpecificScheduler for the Windows builders.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(PlatformSpecificScheduler.init): Added. Stores our platform, sets
up a ChangeFilter that filters to our branch and will call through to
our filter method, and calls up to our base class.
(PlatformSpecificScheduler.filter): Calls through to
build.should_build to find out whether we should trigger a build for
this change.

• Scripts/webkitpy/common/net/build.py: Added.

(_should_file_trigger_build): Uses a set of directories and regexp
patterns to determine whether the given file should trigger a build on
the given platform. As mentioned earlier, this has only been
implemented for Windows, though I did try to make some guesses about
other platforms.
(should_build): Returns true if any of the files should trigger a
build on the given platform.

• Scripts/webkitpy/common/net/build_unittest.py: Added.

(ShouldBuildTest.test_should_build): Does some basic testing to make
sure we're triggering builds for the right files. It only tests
Windows for now, though I tried to make some guesses about other
platforms.

Location:

trunk/WebKitTools

Files:

• BuildSlaveSupport/build.webkit.org-config/config.json (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (2 diffs)
• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/config/build.py (added)
• Scripts/webkitpy/common/config/build_unittest.py (added)

trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

@@ -215 +215 @@
                       "builderNames": ["Leopard Intel Release (Build)", "Leopard Intel Debug (Build)",
                                        "SnowLeopard Intel Release (Build)", "SnowLeopard Intel Leaks",
-                                       "Windows Release (Build)", "Windows Debug (Build)",
                                        "GTK Linux 32-bit Release", "GTK Linux 32-bit Debug", "GTK Linux 64-bit Debug", "GTK Linux 64-bit Release",
                                        "Qt Linux Release", "Qt Linux Release minimal", "Qt Linux ARMv5 Release", "Qt Linux ARMv7 Release", 
@@ -223 +222 @@
                                        "WinCairo Debug (Build)", "EFL Linux Release (Build)"]
                     },
+                    { "type": "PlatformSpecificScheduler", "platform": "win", "branch": "trunk", "treeStableTimer": 45.0,
+                      "builderNames": ["Windows Release (Build)", "Windows Debug (Build)"]
+                    },
                     { "type": "Triggerable", "name": "leopard-intel-release-tests",
                       "builderNames": ["Leopard Intel Release (Tests)"]

trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -18 +18 @@
 import simplejson
 
+from webkitpy.common.config import build as wkbuild
 from webkitpy.common.net.buildbot import BuildBot as wkbuildbot
 
@@ -479 +480 @@
     TestClass = RunWebKit2Tests
 
+class PlatformSpecificScheduler(AnyBranchScheduler):
+    def __init__(self, platform, branch, **kwargs):
+        self.platform = platform
+        filter = ChangeFilter(branch=[branch, None], filter_fn=self.filter)
+        AnyBranchScheduler.__init__(self, name=platform, change_filter=filter, **kwargs)
+
+    def filter(self, change):
+        return wkbuild.should_build(self.platform, change.files)
+
 trunk_filter = ChangeFilter(branch=["trunk", None])
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-11-16  Adam Roben  <aroben@apple.com>
+
+        Only trigger Windows builds when files that we actually use on Windows
+        are changed
+
+        A new Scheduler subclass, PlatformSpecificScheduler, has been added.
+        It uses the new webkitpy.common.config.build module to determine
+        whether a particular change should trigger a build on a particular
+        platform. The Windows builders have been switched to use a
+        PlatformSpecificScheduler.
+
+        The logic to determine whether or not a particular change should
+        trigger a build on a given platform has only been implemented/tested
+        for Windows. I tried to make it easy to add more platforms in the
+        future, but I don't have enough familiarity with all platforms to be
+        able to implement it for them.
+
+        Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
+        lots irrelevant changes (e.g., rebaselining Chromium test results)
+
+        Reviewed by Eric Seidel.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
+        PlatformSpecificScheduler for the Windows builders.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+        (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
+        up a ChangeFilter that filters to our branch and will call through to
+        our filter method, and calls up to our base class.
+        (PlatformSpecificScheduler.filter): Calls through to
+        build.should_build to find out whether we should trigger a build for
+        this change.
+
+        * Scripts/webkitpy/common/net/build.py: Added.
+        (_should_file_trigger_build): Uses a set of directories and regexp
+        patterns to determine whether the given file should trigger a build on
+        the given platform. As mentioned earlier, this has only been
+        implemented for Windows, though I did try to make some guesses about
+        other platforms.
+        (should_build): Returns true if any of the files should trigger a
+        build on the given platform.
+
+        * Scripts/webkitpy/common/net/build_unittest.py: Added.
+        (ShouldBuildTest.test_should_build): Does some basic testing to make
+        sure we're triggering builds for the right files. It only tests
+        Windows for now, though I tried to make some guesses about other
+        platforms.
+
 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>