Changeset 80808 in webkit

Timestamp:

Mar 10, 2011, 8:22:49 PM (14 years ago)

Author:

eae@chromium.org

Message:

2011-03-10 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically
​https://bugs.webkit.org/show_bug.cgi?id=53860

Add tests for selectedIndex when changing the multiple property on a select element.

• fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt: Added.
• fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html: Added.

2011-03-10 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
​https://bugs.webkit.org/show_bug.cgi?id=53860

Preserve selection when changing between multi-select and single-select
for <select> boxes even if it has not yet been rendered.

Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setMultiple):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt (added)
• LayoutTests/fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLSelectElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog ¶

@@ +1 @@
+2011-03-10  Emil A Eklund  <eae@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically
+        https://bugs.webkit.org/show_bug.cgi?id=53860
+
+        Add tests for selectedIndex when changing the multiple property on a select element.
+
+        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt: Added.
+        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html: Added.
+
 2011-03-10  Rik Cabanier  <cabanier@gmail.com>
 

trunk/Source/WebCore/ChangeLog ¶

@@ +1 @@
+2011-03-10  Emil A Eklund  <eae@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
+        https://bugs.webkit.org/show_bug.cgi?id=53860
+
+        Preserve selection when changing between multi-select and single-select
+        for <select> boxes even if it has not yet been rendered.
+
+        Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::setMultiple):
+
 2011-03-10  Ojan Vafai  <ojan@chromium.org>
 

trunk/Source/WebCore/html/HTMLSelectElement.cpp ¶

@@ -435 +435 @@
 void HTMLSelectElement::setMultiple(bool multiple)
 {
+    int oldSelectedIndex = selectedIndex();
     setAttribute(multipleAttr, multiple ? "" : 0);
+
+    // Restore selectedIndex after changing the multiple flag to preserve
+    // selection as single-line and multi-line has different defaults.
+    setSelectedIndex(oldSelectedIndex);
 }