Changeset 90797 in webkit

Timestamp:

Jul 11, 2011, 5:30:54 PM (14 years ago)

Author:

jer.noble@apple.com

Message:

HTML5 video controller in fullscreen is partly off-screen (at least on youtube) using ClickToFlash
​https://bugs.webkit.org/show_bug.cgi?id=64327

Reviewed by Darin Adler.

No new tests; no change in functionality, so covered by existing tests.

Make the rules from fullscreenQuickTime.css !important so they are not overridden
by page authors.

• css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/fullscreenQuickTime.css (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-11  Jer Noble  <jer.noble@apple.com>
+
+        HTML5 video controller in fullscreen is partly off-screen (at least on youtube) using ClickToFlash
+        https://bugs.webkit.org/show_bug.cgi?id=64327
+
+        Reviewed by Darin Adler.
+
+        No new tests; no change in functionality, so covered by existing tests.
+
+        Make the rules from fullscreenQuickTime.css !important so they are not overridden
+        by page authors.
+
+        * css/fullscreenQuickTime.css:
+        (video:-webkit-full-screen::-webkit-media-controls-panel):
+
 2011-07-11  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/css/fullscreenQuickTime.css

@@ -26 +26 @@
 
 video:-webkit-full-screen::-webkit-media-controls-panel {
-    -webkit-box-align: start;
-    -webkit-box-pack: end;    
-    -webkit-appearance: none;
+    -webkit-box-align: start !important;
+    -webkit-box-pack: end !important;
+    -webkit-appearance: none !important;
 
-    bottom: 50px;
-    left: 50%;
-    margin-left: -220px;
-    padding: 12px 0 0 10px;
-    width: 430px;
-    height: 48px;
+    bottom: 50px !important;
+    left: 50% !important;
+    margin-left: -220px !important;
+    padding: 12px 0 0 10px !important;
+    width: 430px !important;
+    height: 48px !important;
     
     background-image: -webkit-gradient(
@@ -47 +47 @@
         color-stop(0.366, rgba(12, 12, 12, .97)),
         color-stop(1, rgba(19, 19, 19, .97))
-    );
+    ) !important;
 
     -webkit-box-shadow: 
@@ -54 +54 @@
         inset 0 -1px 0 0px   rgba(202, 202, 202, 0.09),
         0  0   0 1px rgba(0, 0, 0, 0.5);
-    -webkit-border-radius: 8px;
+    -webkit-border-radius: 8px !important;
 
-    -webkit-transition: opacity 0.3s linear;
+    -webkit-transition: opacity 0.3s linear !important;
 }