Changeset 91097 in webkit
- Timestamp:
- Jul 15, 2011, 1:03:54 PM (14 years ago)
- Location:
- trunk/Source
- Files:
-
- 46 edited
Legend:
- Unmodified
- Added
- Removed
-
TabularUnified trunk/Source/WebCore/ChangeLog ¶
r91095 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * html/shadow/MediaControlRootElement.cpp: 9 (WebCore::MediaControlRootElement::enteredFullscreen): Hide the mouse cursor immediately when 10 entering full screen. 11 (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide the mouse cursor when 12 hiding the HUD. 13 * loader/EmptyClients.h: 14 (WebCore::EmptyChromeClient::setCursorHiddenUntilMouseMoves): Added empty implementation. 15 * page/Chrome.cpp: 16 (WebCore::Chrome::setCursorHiddenUntilMouseMoves): Added. Calls through to the client. 17 * page/Chrome.h: 18 * page/ChromeClient.h: 19 * platform/HostWindow.h: 20 1 21 2011-07-14 Gavin Barraclough <barraclough@apple.com> 2 22 -
TabularUnified trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp ¶
r88546 r91097 30 30 #include "MediaControlRootElement.h" 31 31 32 #include "Chrome.h" 32 33 #include "MediaControlElements.h" 33 34 #include "MouseEvent.h" … … 454 455 m_panel->setCanBeDragged(true); 455 456 457 if (Page* page = m_mediaElement->document()->page()) 458 page->chrome()->setCursorHiddenUntilMouseMoves(true); 459 456 460 startHideFullscreenControlsTimer(); 457 461 } … … 548 552 if (!shouldHideControls()) 549 553 return; 550 554 555 if (Page* page = m_mediaElement->document()->page()) 556 page->chrome()->setCursorHiddenUntilMouseMoves(true); 557 551 558 makeTransparent(); 552 559 } -
TabularUnified trunk/Source/WebCore/loader/EmptyClients.h ¶
r90872 r91097 206 206 207 207 virtual void setCursor(const Cursor&) { } 208 virtual void setCursorHiddenUntilMouseMoves(bool) { } 208 209 209 210 virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {} -
TabularUnified trunk/Source/WebCore/page/Chrome.cpp ¶
r90164 r91097 488 488 } 489 489 490 void Chrome::setCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves) 491 { 492 m_client->setCursorHiddenUntilMouseMoves(hiddenUntilMouseMoves); 493 } 494 490 495 #if ENABLE(REQUEST_ANIMATION_FRAME) 491 496 void Chrome::scheduleAnimation() -
TabularUnified trunk/Source/WebCore/page/Chrome.h ¶
r90164 r91097 79 79 virtual void scrollbarsModeDidChange() const; 80 80 virtual void setCursor(const Cursor&); 81 virtual void setCursorHiddenUntilMouseMoves(bool); 82 81 83 #if ENABLE(REQUEST_ANIMATION_FRAME) 82 84 virtual void scheduleAnimation(); -
TabularUnified trunk/Source/WebCore/page/ChromeClient.h ¶
r90872 r91097 157 157 virtual void scrollbarsModeDidChange() const = 0; 158 158 virtual void setCursor(const Cursor&) = 0; 159 virtual void setCursorHiddenUntilMouseMoves(bool) = 0; 159 160 #if ENABLE(REQUEST_ANIMATION_FRAME) 160 161 virtual void scheduleAnimation() = 0; -
TabularUnified trunk/Source/WebCore/platform/HostWindow.h ¶
r80716 r91097 69 69 virtual void setCursor(const Cursor&) = 0; 70 70 71 virtual void setCursorHiddenUntilMouseMoves(bool) = 0; 72 71 73 #if ENABLE(REQUEST_ANIMATION_FRAME) 72 74 virtual void scheduleAnimation() = 0; -
TabularUnified trunk/Source/WebKit/chromium/ChangeLog ¶
r91031 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * src/ChromeClientImpl.cpp: 9 (WebKit::ChromeClientImpl::setCursorHiddenUntilMouseMoves): Added this stub. 10 * src/ChromeClientImpl.h: 11 1 12 2011-07-14 Ryosuke Niwa <rniwa@webkit.org> 2 13 -
TabularUnified trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp ¶
r90856 r91097 756 756 } 757 757 758 void ChromeClientImpl::setCursorHiddenUntilMouseMoves(bool) 759 { 760 notImplemented(); 761 } 762 758 763 void ChromeClientImpl::setCursor(const WebCursorInfo& cursor) 759 764 { -
TabularUnified trunk/Source/WebKit/chromium/src/ChromeClientImpl.h ¶
r90856 r91097 145 145 #endif 146 146 virtual void setCursor(const WebCore::Cursor&); 147 virtual void setCursorHiddenUntilMouseMoves(bool); 147 148 virtual void formStateDidChange(const WebCore::Node*); 148 149 #if ENABLE(TOUCH_EVENTS) -
TabularUnified trunk/Source/WebKit/efl/ChangeLog ¶
r91051 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebCoreSupport/ChromeClientEfl.cpp: 9 (WebCore::ChromeClientEfl::setCursorHiddenUntilMouseMoves): Added this stub. 10 * WebCoreSupport/ChromeClientEfl.h: 11 1 12 2011-07-14 Jaehun Lim <ljaehun.lim@samsung.com> 2 13 -
TabularUnified trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp ¶
r90856 r91097 453 453 } 454 454 455 void ChromeClientEfl::setCursorHiddenUntilMouseMoves(bool) 456 { 457 notImplemented(); 458 } 459 455 460 void ChromeClientEfl::requestGeolocationPermissionForFrame(Frame*, Geolocation*) 456 461 { -
TabularUnified trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h ¶
r90856 r91097 138 138 139 139 virtual void setCursor(const Cursor&); 140 virtual void setCursorHiddenUntilMouseMoves(bool); 140 141 141 142 virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { } -
TabularUnified trunk/Source/WebKit/gtk/ChangeLog ¶
r91078 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebCoreSupport/ChromeClientGtk.cpp: 9 (WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub. 10 * WebCoreSupport/ChromeClientGtk.h: 11 1 12 2011-07-15 Martin Robinson <mrobinson@igalia.com> 2 13 -
TabularUnified trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp ¶
r90856 r91097 668 668 } 669 669 670 void ChromeClient::setCursorHiddenUntilMouseMoves(bool) 671 { 672 notImplemented(); 673 } 674 670 675 void ChromeClient::requestGeolocationPermissionForFrame(Frame* frame, Geolocation* geolocation) 671 676 { -
TabularUnified trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h ¶
r90856 r91097 134 134 135 135 virtual void setCursor(const WebCore::Cursor&); 136 virtual void setCursorHiddenUntilMouseMoves(bool); 136 137 137 138 virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const {} -
TabularUnified trunk/Source/WebKit/haiku/ChangeLog ¶
r90856 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebCoreSupport/ChromeClientHaiku.cpp: 9 (WebCore::ChromeClientHaiku::setCursorHiddenUntilMouseMoves): Added this stub. 10 * WebCoreSupport/ChromeClientHaiku.h: 11 1 12 2011-07-12 Joseph Pecoraro <joepeck@webkit.org> 2 13 -
TabularUnified trunk/Source/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp ¶
r90856 r91097 383 383 } 384 384 385 // Notification that the given form element has changed. This function 385 /void ChromeClientHaiku::setCursorHiddenUntilMouseMoves(bool) 386 { 387 notImplemented(); 388 } 389 390 / Notification that the given form element has changed. This function 386 391 // will be called frequently, so handling should be very fast. 387 392 void ChromeClientHaiku::formStateDidChange(const Node*) -
TabularUnified trunk/Source/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h ¶
r90856 r91097 156 156 157 157 virtual void setCursor(const Cursor&); 158 virtual void setCursorHiddenUntilMouseMoves(bool); 158 159 159 160 // Notification that the given form element has changed. This function -
TabularUnified trunk/Source/WebKit/mac/ChangeLog ¶
r91095 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebCoreSupport/WebChromeClient.h: 9 * WebCoreSupport/WebChromeClient.mm: 10 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls 11 +[NSCursor setHiddenUntilMouseMoves:]. 12 1 13 2011-07-14 Gavin Barraclough <barraclough@apple.com> 2 14 -
TabularUnified trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h ¶
r90856 r91097 129 129 130 130 virtual void setCursor(const WebCore::Cursor&); 131 virtual void setCursorHiddenUntilMouseMoves(bool); 131 132 132 133 virtual WebCore::FloatRect customHighlightRect(WebCore::Node*, const WTF::AtomicString& type, -
TabularUnified trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm ¶
r90856 r91097 802 802 } 803 803 804 void WebChromeClient::setCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves) 805 { 806 [NSCursor setHiddenUntilMouseMoves:hiddenUntilMouseMoves]; 807 } 808 804 809 KeyboardUIMode WebChromeClient::keyboardUIMode() 805 810 { -
TabularUnified trunk/Source/WebKit/qt/ChangeLog ¶
r91079 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebCoreSupport/ChromeClientQt.h: 9 (WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub. 10 1 11 2011-07-15 Kenneth Rohde Christiansen <kenneth@webkit.org> 2 12 -
TabularUnified trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h ¶
r90856 r91097 181 181 182 182 virtual void setCursor(const Cursor&); 183 virtual void setCursorHiddenUntilMouseMoves(bool) { } 183 184 184 185 virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { } -
TabularUnified trunk/Source/WebKit/win/ChangeLog ¶
r90856 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebCoreSupport/WebChromeClient.cpp: 9 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub. 10 * WebCoreSupport/WebChromeClient.h: 11 1 12 2011-07-12 Joseph Pecoraro <joepeck@webkit.org> 2 13 -
TabularUnified trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp ¶
r90856 r91097 817 817 } 818 818 819 void WebChromeClient::setCursorHiddenUntilMouseMoves(bool) 820 { 821 notImplemented(); 822 } 823 819 824 void WebChromeClient::setLastSetCursorToCurrentCursor() 820 825 { -
TabularUnified trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h ¶
r90856 r91097 140 140 141 141 virtual void setCursor(const WebCore::Cursor&); 142 virtual void setCursorHiddenUntilMouseMoves(bool); 142 143 virtual void setLastSetCursorToCurrentCursor(); 143 144 -
TabularUnified trunk/Source/WebKit/wince/ChangeLog ¶
r90856 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebCoreSupport/ChromeClientWinCE.cpp: 9 (WebKit::ChromeClientWinCE::setCursorHiddenUntilMouseMoves): Added this stub. 10 * WebCoreSupport/ChromeClientWinCE.h: 11 1 12 2011-07-12 Joseph Pecoraro <joepeck@webkit.org> 2 13 -
TabularUnified trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.cpp ¶
r90856 r91097 362 362 } 363 363 364 void ChromeClientWinCE::setCursorHiddenUntilMouseMoves(bool) 365 { 366 notImplemented(); 367 } 368 364 369 void ChromeClientWinCE::setLastSetCursorToCurrentCursor() 365 370 { -
TabularUnified trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h ¶
r90856 r91097 107 107 virtual void scrollbarsModeDidChange() const; 108 108 virtual void setCursor(const WebCore::Cursor&); 109 virtual void setCursorHiddenUntilMouseMoves(bool); 109 110 // End methods used by HostWindow. 110 111 -
TabularUnified trunk/Source/WebKit/wx/ChangeLog ¶
r90856 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * WebKitSupport/ChromeClientWx.h: 9 (WebCore::ChromeClientWx::setCursorHiddenUntilMouseMoves): Added this stub. 10 1 11 2011-07-12 Joseph Pecoraro <joepeck@webkit.org> 2 12 -
TabularUnified trunk/Source/WebKit/wx/WebKitSupport/ChromeClientWx.h ¶
r90856 r91097 142 142 143 143 virtual void setCursor(const Cursor&); 144 virtual void setCursorHiddenUntilMouseMoves(bool) { } 144 145 145 146 virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {} -
TabularUnified trunk/Source/WebKit2/ChangeLog ¶
r91095 r91097 1 2011-07-15 Dan Bernstein <mitz@apple.com> 2 3 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 4 https://bugs.webkit.org/show_bug.cgi?id=64615 5 6 Reviewed by Anders Carlsson. 7 8 * UIProcess/API/efl/PageClientImpl.cpp: 9 (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added this stub. 10 * UIProcess/API/efl/PageClientImpl.h: 11 * UIProcess/API/gtk/PageClientImpl.cpp: 12 (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Ditto. 13 * UIProcess/API/gtk/PageClientImpl.h: 14 * UIProcess/API/mac/PageClientImpl.h: 15 * UIProcess/API/mac/PageClientImpl.mm: 16 (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added. Calls +[NSCursor setHiddenUntilMouseMoves:]. 17 * UIProcess/PageClient.h: 18 * UIProcess/WebPageProxy.cpp: 19 (WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves): Added. Calls through to the PageClient. 20 * UIProcess/WebPageProxy.h: 21 * UIProcess/WebPageProxy.messages.in: Added SetCursorHiddenUntilMouseMoves message. 22 * UIProcess/win/WebView.cpp: 23 (WebKit::WebView::setCursorHiddenUntilMouseMoves): Added this stub. 24 * WebProcess/WebCoreSupport/WebChromeClient.cpp: 25 (WebKit::WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Sends SetCursorHiddenUntilMouseMoves message 26 to the page proxy. 27 * WebProcess/WebCoreSupport/WebChromeClient.h: 28 1 29 2011-07-14 Gavin Barraclough <barraclough@apple.com> 2 30 -
TabularUnified trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp ¶
r89210 r91097 126 126 } 127 127 128 void PageClientImpl::setCursorHiddenUntilMouseMoves(bool) 129 { 130 notImplemented(); 131 } 132 128 133 void PageClientImpl::setViewportArguments(const WebCore::ViewportArguments&) 129 134 { -
TabularUnified trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.h ¶
r89210 r91097 65 65 66 66 virtual void setCursor(const WebCore::Cursor&); 67 virtual void setCursorHiddenUntilMouseMoves(bool); 67 68 virtual void setViewportArguments(const WebCore::ViewportArguments&); 68 69 -
TabularUnified trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp ¶
r89360 r91097 149 149 } 150 150 151 void PageClientImpl::setCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves) 152 { 153 notImplemented(); 154 } 155 151 156 void PageClientImpl::setViewportArguments(const WebCore::ViewportArguments&) 152 157 { -
TabularUnified trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h ¶
r88669 r91097 69 69 virtual void toolTipChanged(const WTF::String&, const WTF::String&); 70 70 virtual void setCursor(const WebCore::Cursor&); 71 virtual void setCursorHiddenUntilMouseMoves(bool); 71 72 virtual void setViewportArguments(const WebCore::ViewportArguments&); 72 73 virtual void registerEditCommand(PassRefPtr<WebEditCommandProxy>, WebPageProxy::UndoOrRedo); -
TabularUnified trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h ¶
r88669 r91097 66 66 virtual void toolTipChanged(const String& oldToolTip, const String& newToolTip); 67 67 virtual void setCursor(const WebCore::Cursor&); 68 virtual void setCursorHiddenUntilMouseMoves(bool); 68 69 virtual void setViewportArguments(const WebCore::ViewportArguments&); 69 70 -
TabularUnified trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm ¶
r88669 r91097 215 215 } 216 216 217 void PageClientImpl::setCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves) 218 { 219 [NSCursor setHiddenUntilMouseMoves:hiddenUntilMouseMoves]; 220 } 221 217 222 void PageClientImpl::setViewportArguments(const WebCore::ViewportArguments&) 218 223 { -
TabularUnified trunk/Source/WebKit2/UIProcess/PageClient.h ¶
r90750 r91097 111 111 112 112 virtual void setCursor(const WebCore::Cursor&) = 0; 113 virtual void setCursorHiddenUntilMouseMoves(bool) = 0; 113 114 virtual void setViewportArguments(const WebCore::ViewportArguments&) = 0; 114 115 -
TabularUnified trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp ¶
r91085 r91097 2664 2664 } 2665 2665 2666 void WebPageProxy::setCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves) 2667 { 2668 m_pageClient->setCursorHiddenUntilMouseMoves(hiddenUntilMouseMoves); 2669 } 2670 2666 2671 #if MERGE_WHEEL_EVENTS 2667 2672 static bool canCoalesce(const WebWheelEvent& a, const WebWheelEvent& b) -
TabularUnified trunk/Source/WebKit2/UIProcess/WebPageProxy.h ¶
r91085 r91097 740 740 void setToolTip(const String&); 741 741 void setCursor(const WebCore::Cursor&); 742 void setCursorHiddenUntilMouseMoves(bool); 742 743 743 744 void didReceiveEvent(uint32_t opaqueType, bool handled); -
TabularUnified trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in ¶
r91085 r91097 36 36 StopResponsivenessTimer() 37 37 SetCursor(WebCore::Cursor cursor) 38 SetCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves) 38 39 SetStatusText(WTF::String statusText) 39 40 SetToolTip(WTF::String toolTip) -
TabularUnified trunk/Source/WebKit2/UIProcess/win/WebView.cpp ¶
r89164 r91097 33 33 #include "NativeWebMouseEvent.h" 34 34 #include "NativeWebWheelEvent.h" 35 #include "NotImplemented.h" 35 36 #include "Region.h" 36 37 #include "RunLoop.h" … … 1057 1058 } 1058 1059 1060 void WebView::setCursorHiddenUntilMouseMoves(bool) 1061 { 1062 notImplemented(); 1063 } 1064 1059 1065 void WebView::setOverrideCursor(HCURSOR overrideCursor) 1060 1066 { -
TabularUnified trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp ¶
r90856 r91097 650 650 } 651 651 652 void WebChromeClient::setCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves) 653 { 654 m_page->send(Messages::WebPageProxy::SetCursorHiddenUntilMouseMoves(hiddenUntilMouseMoves)); 655 } 656 652 657 void WebChromeClient::formStateDidChange(const Node*) 653 658 { -
TabularUnified trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h ¶
r90856 r91097 173 173 174 174 virtual void setCursor(const WebCore::Cursor&); 175 virtual void setCursorHiddenUntilMouseMoves(bool); 175 176 176 177 // Notification that the given form element has changed. This function
Note:
See TracChangeset
for help on using the changeset viewer.