Changeset 92603 in webkit

Timestamp:

Aug 8, 2011, 10:28:47 AM (14 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/9652350> REGRESSION (r87755): WKView doesn't update when I drag files into a background Safari window
​https://bugs.webkit.org/show_bug.cgi?id=65860

Reviewed by Simon Fraser.

When layer flush scheduling is re-enabled, schedule a layer flush, just in case one was requested while
scheduling was disabled. It doesn’t seem worthwhile to track whether that in fact happened, so do so
unconditionally.

• WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled):

• WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm (modified) (1 diff)
• WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-08-08  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/9652350> REGRESSION (r87755): WKView doesn't update when I drag files into a background Safari window
+        https://bugs.webkit.org/show_bug.cgi?id=65860
+
+        Reviewed by Simon Fraser.
+
+        When layer flush scheduling is re-enabled, schedule a layer flush, just in case one was requested while
+        scheduling was disabled. It doesn’t seem worthwhile to track whether that in fact happened, so do so
+        unconditionally.
+
+        * WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
+        (WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled):
+        * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
+        (WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled):
+
 2011-08-05  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm

@@ -96 +96 @@
     m_layerFlushSchedulingEnabled = layerFlushingEnabled;
 
-    if (m_layerFlushSchedulingEnabled)
+    if (m_layerFlushSchedulingEnabled) {
+        scheduleLayerFlush();
         return;
+    }
 
     if (!m_flushPendingLayerChangesRunLoopObserver)

trunk/Source/WebKit2/WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp

@@ -144 +144 @@
     m_layerFlushSchedulingEnabled = layerFlushingEnabled;
 
-    if (m_layerFlushSchedulingEnabled)
-        return;
+    if (m_layerFlushSchedulingEnabled) {
+        scheduleLayerFlush();
+        return;
+    }
 
     LayerChangesFlusher::shared().cancelPendingFlush(this);