Changeset 98022 in webkit

Timestamp:

Oct 20, 2011 2:27:54 PM (13 years ago)

Author:

mitz@apple.com

Message:

Flipped-blocks writing mode blocks do not hit test their overflow
​https://bugs.webkit.org/show_bug.cgi?id=70546

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/writing-mode/flipped-blocks-hit-test-overflow.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint): Flip the overflow rect if necessary.

LayoutTests:

• fast/writing-mode/flipped-blocks-hit-test-overflow-expected.txt: Added.
• fast/writing-mode/flipped-blocks-hit-test-overflow.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/writing-mode/flipped-blocks-hit-test-overflow-expected.txt (added)
• LayoutTests/fast/writing-mode/flipped-blocks-hit-test-overflow.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-10-20  Dan Bernstein  <mitz@apple.com>
+
+        Flipped-blocks writing mode blocks do not hit test their overflow
+        https://bugs.webkit.org/show_bug.cgi?id=70546
+
+        Reviewed by Sam Weinig.
+
+        * fast/writing-mode/flipped-blocks-hit-test-overflow-expected.txt: Added.
+        * fast/writing-mode/flipped-blocks-hit-test-overflow.html: Added.
+
 2011-10-20  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-20  Dan Bernstein  <mitz@apple.com>
+
+        Flipped-blocks writing mode blocks do not hit test their overflow
+        https://bugs.webkit.org/show_bug.cgi?id=70546
+
+        Reviewed by Sam Weinig.
+
+        Test: fast/writing-mode/flipped-blocks-hit-test-overflow.html
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::nodeAtPoint): Flip the overflow rect if necessary.
+
 2011-10-20  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -4114 +4114 @@
         // Check if we need to do anything at all.
         LayoutRect overflowBox = visualOverflowRect();
+        flipForWritingMode(overflowBox);
         overflowBox.moveBy(adjustedLocation);
         if (!overflowBox.intersects(result.rectForPoint(pointInContainer)))