Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Feb 14, 2008:

11:23 PM Changeset in webkit [30250] by Darin Adler

• 3 edits in trunk/WebCore

• another round of build fixes

• platform/KURL.cpp: (WebCore::appendEncodedHostname): Fix spelling (strLen, not strlen).
• platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Fix a ".." typo and call data instead of characters.

10:45 PM Changeset in webkit [30249] by Darin Adler

• 1 edit
  3 copies in trunk/WebCore

• added back accidentally-removed files

• platform/DeprecatedStringList.cpp: Copied from platform/DeprecatedStringList.cpp.
• platform/DeprecatedStringList.h: Copied from platform/DeprecatedStringList.h.
• platform/mac/DeprecatedStringListMac.mm: Copied from platform/mac/DeprecatedStringListMac.mm.

10:38 PM Changeset in webkit [30248] by Darin Adler

• 4 edits
  3 deletes in trunk/WebCore

• more build fixes

• platform/KURL.cpp: (WebCore::appendEncodedHostname): Use String to make a QString.
• platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
• platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Updated to String rather than DeprecatedString functions.

10:03 PM Changeset in webkit [30247] by oliver@apple.com

• 3 edits in trunk/LayoutTests

Make assign-to-window-status testcase to be more thorough

Reviewed by Jon H

9:36 PM Changeset in webkit [30246] by Darin Adler

• 2 edits in trunk/WebCore

• next Qt build fix

• platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.

9:29 PM Changeset in webkit [30245] by Darin Adler

• 2 edits in trunk/WebCore

• another build fix

• platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.

9:14 PM Changeset in webkit [30244] by Darin Adler

• 2 edits in trunk/WebCore

• first Qt build fix

• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Added a missing string() call.

9:03 PM Changeset in webkit [30243] by Darin Adler

• 177 edits in trunk

WebCore:

Reviewed by Eric Seidel.

Based on work by Marvin Decker <​marv.decker@gmail.com>

• fix ​http://bugs.webkit.org/show_bug.cgi?id=16538 KURL should use String instead of DeprecatedString

• fix ​http://bugs.webkit.org/show_bug.cgi?id=16485 DocLoader::checkForReload will crash if the URL isNull and a similar problem in IconDatabase

• fix ​http://bugs.webkit.org/show_bug.cgi?id=16487 KURL doesn't preserve isNull when constructed with a DeprecatedString

• changed completeURL and various DOM getters to return KURL, to avoid conversion back and forth from KURL to String

• changed the conversion of KURL to NSURL or NSString to be automatic, to ease the use of KURL in Objective C DOM bindings, and eliminated the getNSURL function

• because I had to visit the DOM bindings anyway, eliminated almost all the use of the KJS namespace for things in WebCore

• fixed HTMLOptionElement constructor to check for undefined rather than size of the arguments array

• eliminated some other unnecessary uses of DeprecatedString

• changed String::split to take a Vector parameter instead of returning a Vector, for better performance

• added a couple of missing calls to do layout in SVG image handling; I was able to reproduce these only because I had broken URLs for a while -- not sure how to reproduce them now but the changes are clearly needed

Performance testing shows this to be at least a 1% speedup.

Added a new function protocolIs to efficiently compare protocols
without case errors and a blankURL function so we don't have to
code "about:blank" in multiple places in the code and don't have to
construct a frash KURL each time. Moved decode_string and encode_string
out of KURL and gave them clearer names.

Made KURL constructors explicit to highlight potentially-expensive
operations and the poor semantics of KURL's constructor that takes
a String.

• WebCore.base.exp: Updated.

• bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIs.
• bindings/js/JSAudioConstructor.h: KJS namespace change.
• bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): Ditto.
• bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): Ditto.
• bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): Ditto. (WebCore::JSDocument::setLocation): Updated for KURL change. (WebCore::toJS): KJS namespace change.
• bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Use protocolIs. (WebCore::JSElement::setAttribute): KJS namespace change. (WebCore::JSElement::setAttributeNode): Ditto. (WebCore::JSElement::setAttributeNS): Ditto. (WebCore::JSElement::setAttributeNodeNS): Ditto.
• bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Use protocolIs. (WebCore::JSHTMLFrameElement::setSrc): KJS namespace change. (WebCore::JSHTMLFrameElement::setLocation): Ditto.
• bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Use protocolIs.
• bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): (WebCore::JSHTMLOptionElementConstructor::construct): Cleaned up the structure a bit and changed checking to check for undefined rather than number of arguments.
• bindings/js/JSHTMLOptionElementConstructor.h: KJS namespace change.
• bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Eliminated some DeprecatedString use, and use protocolIs. (WebCore::jsLocationProtoFuncReplace): Ditto. (WebCore::jsLocationProtoFuncReload): Ditto. (WebCore::jsLocationProtoFuncAssign): Ditto.
• bindings/js/JSLocation.h: KJS namespace change.
• bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::canGetItemsForName): Ditto. (WebCore::JSNamedNodeMap::nameGetter): Ditto.
• bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Ditto.
• bindings/js/JSNamedNodesCollection.h: Ditto.
• bindings/js/JSXMLHttpRequest.cpp: (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Removed DeprecatedString use. (WebCore::jsXMLHttpRequestPrototypeFunctionSend): Ditto.
• bindings/js/JSXMLHttpRequest.h: Moved this class into the WebCore namespace.
• bindings/js/JSXSLTProcessor.cpp: Namespace change.
• bindings/js/JSXSLTProcessor.h: Ditto.

• bindings/js/kjs_binding.cpp: Updated for namespace change. (WebCore::jsStringOrNull): Added an overload for KURL to allow DOM classes to return KURL even if the DOM expects a string. (WebCore::jsStringOrUndefined): Ditto. (WebCore::jsStringOrFalse): Ditto.
• bindings/js/kjs_binding.h: Moved everything into the WebCore namespace.

• bindings/js/kjs_css.h: Namespace change.
• bindings/js/kjs_events.cpp: Removed an include.
• bindings/js/kjs_events.h: Namespace change.
• bindings/js/kjs_html.h: Namespace change.

• bindings/js/kjs_navigator.cpp: Moved everything into the WebCore namespace.
• bindings/js/kjs_navigator.h: Ditto.

• bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): Updated for String::split change. (KJS::createWindow): Use protocolIs and removed some DeprecatedString. (KJS::Window::put): Ditto. (KJS::Window::allowsAccessFrom): Ditto. (KJS::windowProtoFuncOpen): Ditto.

• bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]): Removed getNSURL call.
• bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.

• bindings/scripts/CodeGeneratorCOM.pm: Updated includes so conversions from KURL will work.
• bindings/scripts/CodeGeneratorJS.pm: Updated for namespace changes, and also updated includes so conversions from KURL will work.
• bindings/scripts/CodeGeneratorObjC.pm: Updated includes so conversions from KURL will work.

• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Removed getNSURL call. Also streamlined the logic. (AXAttributedStringAppendText): Ditto.

• bridge/mac/WebCoreScriptDebugger.mm: (toNSString): Tweaked. (toNSURL): Removed getNSURL call.

• css/CSSImageValue.cpp: (WebCore::CSSImageValue::image): Removed DeprecatedString use.
• css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Ditto.
• css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Ditto. (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseBackgroundImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto.
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::setEncodedURL): Ditto. (WebCore::checkPseudoState): Ditto.
• css/CSSStyleSelector.h: Ditto.

• css/MediaList.cpp: (WebCore::MediaList::setMediaText): Updated for String::split change.

• css/StyleBase.cpp: (WebCore::StyleBase::baseURL): Return KURL.
• css/StyleBase.h: DItto.

• dom/Document.cpp: (WebCore::Document::~Document): Updated for namespace change. (WebCore::Document::documentURI): Return KURL. (WebCore::Document::setDocumentURI): Removed DeprecatedString use. (WebCore::Document::baseURI): Return KURL. (WebCore::Document::open): Updated to use blankURL. (WebCore::Document::setURL): Take KURL. (WebCore::Document::shouldBeAllowedToLoadLocalResources): Updated for change to use KURL (WebCore::Document::setBaseURL): Take KURL. (WebCore::Document::elementSheet): Updated for KURL change. (WebCore::Document::mappedElementSheet): Ditto. (WebCore::Document::processHttpEquiv): Ditto. (WebCore::Document::recalcStyleSelector): Removed use of DeprecatedString -- also noticed some dead code here! (WebCore::Document::setCookie): Ditto. (WebCore::Document::completeURL): Return KURL.
• dom/Document.h: Use KURL instead of String in a few places.

• dom/DocumentType.cpp: (WebCore::DocumentType::baseURI): Return KURL.
• dom/DocumentType.h: Ditto.

• dom/Element.cpp: (WebCore::Element::baseURI): Return KURL.
• dom/Element.h: Ditto.

• dom/Node.cpp: (WebCore::Node::setDocument): Namespace change. (WebCore::Node::baseURI): Return KURL.
• dom/Node.h: Ditto.

• dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Updated for KURL change.
• dom/StyleElement.cpp: (WebCore::StyleElement::process): Changed to use Vector<UChar> instead of String for better performance. (WebCore::StyleElement::createSheet): Removed use of DeprecateString.
• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Updated for KURL change. (WebCore::XMLTokenizer::end): Ditto. (WebCore::xmlDocPtrForString): Removed use of DeprecateString.
• dom/XMLTokenizer.h: Ditto.

• editing/markup.cpp: Moved appendString to PlatformString.h. (WebCore::appendQuotedURLAttributeValue): Use protocolIs. (WebCore::completeURLs): Removed DeprecatedString use. (WebCore::createFragmentFromMarkup): Use blankURL. (WebCore::fillContainerFromString): Removed DeprecatedString use. (WebCore::createFragmentFromText): Ditto.

• history/HistoryItem.cpp: (WebCore::HistoryItem::url): Removed DeprecatedString use. (WebCore::HistoryItem::originalURL): Ditto.
• history/HistoryItem.h: Removed include.

• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Removed use of DeprecatedString. (WebCore::HTMLAnchorElement::href): Return KURL. (WebCore::HTMLAnchorElement::hash): Removed DeprecatedString use. (WebCore::HTMLAnchorElement::host): Ditto. (WebCore::HTMLAnchorElement::hostname): Ditto. (WebCore::HTMLAnchorElement::pathname): Ditto. (WebCore::HTMLAnchorElement::port): Ditto. (WebCore::HTMLAnchorElement::protocol): Ditto. (WebCore::HTMLAnchorElement::search): Ditto. (WebCore::HTMLAnchorElement::toString): Ditto.
• html/HTMLAnchorElement.h: Ditto.
• html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Updated for KURL change.
• html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::href): Return KURL.
• html/HTMLAreaElement.h: Ditto.
• html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::removedFromDocument): Updated for KURL change. (WebCore::HTMLBaseElement::process): Removed DeprecatedString use.
• html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Updated for KURL change.
• html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed use of DeprecatedString.
• html/HTMLEmbedElement.h: Removed DeprecatedString use.
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formWouldHaveSecureSubmission): Use protocolIs. (WebCore::encodeCString): Updated for change to String::split. (WebCore::HTMLFormElement::dataEncoding): Ditto. (WebCore::HTMLFormElement::formData): Removed DeprecatedString use. (WebCore::HTMLFormElement::isMailtoForm): Use protocolIs. (WebCore::HTMLFormElement::submit): Updated for KURL change. (WebCore::HTMLFormElement::reset): Ditto.
• html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::HTMLFrameElementBase::openURL): Use blankURL. (WebCore::HTMLFrameElementBase::location): Return KURL. (WebCore::HTMLFrameElementBase::src): Return KURL.
• html/HTMLFrameElementBase.h: Ditto.
• html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLImageElement::longDesc): Return KURL. (WebCore::HTMLImageElement::lowsrc): Return KURL. (WebCore::HTMLImageElement::src): Return KURL.
• html/HTMLImageElement.h: Ditto. Also removed imageMap() function.
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::src): Return KURL.
• html/HTMLInputElement.h: Ditto.
• html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLLinkElement::tokenizeRelAttribute): Updated for String::split change. (WebCore::HTMLLinkElement::href): Return KURL.
• html/HTMLLinkElement.h: Ditto.
• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::src): Return KURL. (WebCore::HTMLMediaElement::pickMedia): Updated for KURL change.
• html/HTMLMediaElement.h: Ditto.
• html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Use protocolIs. (WebCore::HTMLObjectElement::data): Return KURL.
• html/HTMLObjectElement.h: Ditto.
• html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText): Removed DeprecatedString use.
• html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole): Updated for KURL change.
• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): Ditto. (WebCore::HTMLScriptElement::text): Changed to use Vector<UChar> instead of String for better performance. (WebCore::HTMLScriptElement::src): Return KURL.
• html/HTMLScriptElement.h: Ditto.
• html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::src): Return KURL.
• html/HTMLSourceElement.h: Ditto.
• html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Updated for KURL change.
• html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): Updated for KURL change.
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Removed DeprecatedString use.
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): Ditto. (WebCore::HTMLTokenizer::notifyFinished): Use protocolIs.
• html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::poster): Return KURL.
• html/HTMLVideoElement.h: Ditto.
• html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addText): Updated for String::split change.

• loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Add an explicit check for an empty URL here to avoid problems using its string as a hash table key later. (WebCore::DocLoader::requestResource): Removed DeprecatedString use.

• loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::createTDForFilename): Updated for KURL change. (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Removed use of DeprecatedString.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use protocolIs. (WebCore::FrameLoader::loadSubframe): Use blankURL. (WebCore::FrameLoader::submitForm): Use protocolIs and removed use of DeprecatedString. (WebCore::FrameLoader::iconURL): Return KURL. Use protcolIs. (WebCore::FrameLoader::didOpenURL): Use protocolIs. (WebCore::FrameLoader::didExplicitOpen): Use blankURL. (WebCore::FrameLoader::executeIfJavaScriptURL): Use protocolIs. Update for name change to decodeURLEscapeSequences. (WebCore::FrameLoader::receivedFirstData): Updated for KURL changes. (WebCore::FrameLoader::begin): Removed DeprecatedString use. Renamed baseurl to baseURL. Updated to use KURL more. (WebCore::FrameLoader::gotoAnchor): Removed use of encodedHtmlRef function, which is no different from ref. (WebCore::FrameLoader::completeURL): Updated for KURL change. (WebCore::FrameLoader::scheduleLocationChange): Ditto. (WebCore::FrameLoader::canCachePage): Use protocolIs. (WebCore::FrameLoader::updatePolicyBaseURL): Update for KURL change. (WebCore::FrameLoader::setPolicyBaseURL): Take KURL. (WebCore::FrameLoader::startRedirectionTimer): Removed use of DeprecatedString. (WebCore::FrameLoader::load): Use protocolIs. (WebCore::FrameLoader::shouldHideReferrer): Use protocolIs. (WebCore::FrameLoader::shouldAllowNavigation): Updated for KURL change. (WebCore::FrameLoader::commitProvisionalLoad): Use blankURL. (WebCore::FrameLoader::open): Use protcolIs. (WebCore::FrameLoader::createHistoryItem): Use blankURL. (WebCore::FrameLoader::createJavaAppletWidget): Updated for KURL change. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Removed DeprecatedString use.
• loader/FrameLoader.h: Ditto.

• loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for KURL change.
• loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Ditto.

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): Added a check for an empty URL before trying to use it as a hash table key.

• loader/icon/IconLoader.h: Tweaked includes.

• loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use protcolIs. Also removed some code to set up a local variable that is never used (and a DeprecatedString on to boot!).

• loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType): Removed unnecessary typecast.

• page/ContextMenuController.cpp: Removed include.

• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks): Use protocolIs.

• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): Removed getNSURL call. (-[WebCoreFrameBridge baseURL]): Ditto.

• platform/KURL.cpp: (WebCore::isSchemeFirstChar): Fixed bug in handling of values >= 0x80. (WebCore::isSchemeChar): Ditto. (WebCore::isPathSegmentEndChar): Ditto. (WebCore::hexDigitValue): Changed parameter type to UChar. (WebCore::copyASCII): Added. (WebCore::findFirstOf): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::KURL): Tightened logic up quite a bit. Changed parameter types from DeprecatedString to String. (WebCore::KURL::init): Changed parameter type to String. Preserved the passed-in string even if the base is invalid. Cleaned up logic to determine if the originalString should be pased in to the parse function. Simplified by calling the new parse overload that takes String in many cases. (WebCore::KURL::lastPathComponent): Return String. (WebCore::KURL::protocol): Ditto. (WebCore::KURL::host): Ditto. (WebCore::KURL::port): Changed logic to use early return for clarity. (WebCore::KURL::pass): Return String. (WebCore::KURL::user): Ditto. (WebCore::KURL::ref): Ditto. (WebCore::assertProtocolIsGood): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::query): Return String. (WebCore::KURL::path): Ditto. (WebCore::KURL::setProtocol): Take String. (WebCore::KURL::setHost): Ditto. (WebCore::KURL::setPort): Use String. (WebCore::KURL::setHostAndPort): Take String. (WebCore::KURL::setUser): Ditto. (WebCore::KURL::setPass): Ditto. (WebCore::KURL::setRef): Ditto. (WebCore::KURL::setQuery): Ditto. (WebCore::KURL::setPath): Ditto. (WebCore::KURL::prettyURL): Return String. Use Vector<UChar> to build it. (WebCore::decodeURLEscapeSequences): Renamed from KURL::decode_string. Return String. Use Vector<UChar> to build it. (WebCore::KURL::isLocalFile): Use protocolIs. (WebCore::KURL::parse): Added an overload that takes a String to replace the use of DeprecatedString::ascii at various call sites. Updated for name change (urlString -> m_string). (WebCore::equalIgnoringRef): Wrote a new implementation that doesn't do any allocation. (WebCore::encodeWithURLEscapeSequences): Renamed from KURL::encode_string. Return String. (WebCore::appendEncodedHostname): Added. Replaces encodeHostname and avoids the need to allocate a string. (WebCore::findHostnamesInMailToURL): Update to use findFirstOf instead of regular expressions. (WebCore::findHostnameInHierarchicalURL): Ditto. (WebCore::encodeHostnames): Use protocolIs and the other helpers above. (WebCore::encodeRelativeString): Changed to put result into a CharBuffer. (WebCore::substituteBackslashes): Updated to use String. (WebCore::KURL::copyToBuffer): Added. (WebCore::protocolIs): Added. (WebCore::blankURL): Added. (WebCore::KURL::print): Updated.
• platform/KURL.h: Added a number of comments. Reorganized the header a bit. Made the string constructors explicit. Changed to use String instead of DeprecatedString. Removed encodedHTMLRef. Renamed and added a few functions.

• platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Streamlined the logic a bit. (WebCore::KURL::createCFURL): Changed to use copyToBuffer.

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Removed getNSURL call. Use protocolIs.
• platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage): Removed getNSURL call.
• platform/mac/CookieJar.mm: (WebCore::cookies): Removed getNSURL call. (WebCore::setCookies): Removed getNSURL call.
• platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Streamlined the logic a bit.
• platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): Removed getNSURL call. (WebCore::Pasteboard::writeImage): Ditto.
• platform/mac/SSLKeyGeneratorMac.mm: (WebCore::signedPublicKeyAndChallengeString): Ditto.

• platform/network/HTTPParsers.cpp: (WebCore::filenameFromHTTPContentDisposition): Updated for String::split.
• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use protocolIs.

• platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::operator CFErrorRef): Removed deprecatedString call.
• platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Ditto. (WebCore::parseDataUrl): Use String instead of DeprecatedString. (WebCore::ResourceHandleManager::startJob): Updated for KURL changes.
• platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*): Removed getNSURL call.
• platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed DeprecatedString use.
• platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Removed getNSURL call.
• platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse): Removed getNSURL call.

• platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL): Removed deprecatedString call.

• platform/text/CString.h: (WebCore::CStringBuffer::length): Fixed size_t/unsigned mismatch to make it possible to compile this on Windows with higher warning level

• platform/text/PlatformString.h: Updated split to modify a result parameter rather than returning a Vector. Added charactersAreAllASCII and an append function that appends a String to a Vector<UChar>.
• platform/text/String.cpp: (WebCore::String::split): Updated.

• platform/win/BString.cpp: (WebCore::BString::BString): Added conversion from KURL.
• platform/win/BString.h: Ditto.

• platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCF_HTML): Removed use of deprecatedString.
• platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): Ditto. (WebCore::createGlobalHDropContent): Ditto. (WebCore::ClipboardWin::setData): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
• platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto.
• plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Ditto. (WebCore::PluginStream::destroyStream): Ditto.
• plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Ditto. (WebCore::PluginView::performRequest): Ditto. (WebCore::PluginView::PluginView): Ditto.

• rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Removed DeprecatedString use. (WebCore::HitTestResult::absoluteLinkURL): Ditto.

• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Fixed comment wording.
• rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): Removed use of DeperecatedString, (WebCore::RenderImage::imageMap): Changed to call useMap instead of imageMap; both do the same thing, and the first is standard DOM.

• rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Rewrote and streamlined to remove DeprecatedString use.
• rendering/RenderObject.h: Changed addPDFURLRect to take const IntRect&.

• rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::RenderPartObject::updateWidget): Updated for KURL change.

• rendering/RenderText.cpp: (WebCore::charactersAreAllASCII): Moved the guts to PlatformString.h.

• rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken.

• rendering/SVGRenderTreeAsText.h: Removed include.

• svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement): Removed DeprecatedString use.

• svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken. (WebCore::SVGImage::dataChanged): Use a null URL rather than an arbitrary string for the document.

• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Removed DeprecatedString use. (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): Ditto. (WebCore::XMLHttpRequest::open): Ditto. (WebCore::XMLHttpRequest::send): Namespace change. (WebCore::XMLHttpRequest::dropProtection): Ditto.
• xml/XMLHttpRequest.h: Removed DeprecatedString use.

• xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet): Removed DeprecatedString use.
• xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): Ditto. (WebCore::XSLStyleSheet::loadChildSheet): Ditto.
• xml/XSLStyleSheet.h: Ditto.
• xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Ditto. (WebCore::xsltStylesheetPointer): Ditto. (WebCore::xmlDocPtrFromNode): Ditto.

WebKit/gtk:

• webkit/webkitwebframe.cpp: Removed DeprecatedString use to try to keep it building.
• webkit/webkitwebview.cpp: Ditto.

WebKit/mac:

Reviewed by Eric Seidel.

• updated for WebCore KURL changes

• History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Removed getNSURL call.
• Misc/WebElementDictionary.mm: (-[WebElementDictionary _absoluteImageURL]): Ditto. (-[WebElementDictionary _absoluteLinkURL]): Ditto.
• Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement): Ditto. (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
• Misc/WebNSURLExtras.mm: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated for function name change.
• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::downloadURL): Removed getNSURL call.
• WebCoreSupport/WebDragClient.mm: (WebDragClient::createDragImageForLink): Ditto.
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto. (WebFrameLoaderClient::startDownload): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto. (WebFrameLoaderClient::cancelledError): Ditto. (WebFrameLoaderClient::blockedError): Ditto. (WebFrameLoaderClient::cannotShowURLError): Ditto. (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto. (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto. (WebFrameLoaderClient::fileDoesNotExistError): Ditto. (WebFrameLoaderClient::willUseArchive): Ditto. (WebFrameLoaderClient::setTitle): Ditto. (WebFrameLoaderClient::actionDictionary): Ditto. (WebFrameLoaderClient::createFrame): Ditto. (WebFrameLoaderClient::objectContentType): Ditto. (WebFrameLoaderClient::createPlugin): Ditto. (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
• WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource _initWithDocumentLoader:]): Ditto. (-[WebDataSource unreachableURL]): Ditto.
• WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

WebKit/win:

• updated for WebCore KURL changes

• MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToKURL): Removed deprecatedString call. (MarshallingHelpers::KURLToBSTR): Tweaked for efficiency.
• WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Updated for KURL changes.
• WebDataSource.cpp: (WebDataSource::unreachableURL): Ditto.
• WebDownload.cpp: (WebDownload::init): Ditto. (WebDownload::initWithRequest): Ditto.
• WebFrame.cpp: (WebFrame::loadData): Ditto. (WebFrame::loadURLIntoChild): Ditto. (WebFrame::objectContentType): Ditto.
• WebResource.cpp: (WebResource::initWithData): Ditto.
• WebURLResponse.cpp: (WebURLResponse::createInstance): Ditto. (WebURLResponse::initWithURL): Ditto.
• WebView.cpp: (WebView::userAgentForURL): Ditto. (WebView::copyURL): Ditto. (WebView::notifyPreferencesChanged): Ditto.

WebKit/wx:

• WebView.cpp: Removed use of DeprecatedString to keep this compiling.

8:32 PM Changeset in webkit [30242] by Darin Adler

• 2 edits in trunk/WebKitTools

• fix Windows build

• DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::setStatusText): Update parameter types to match declaration.

8:30 PM Changeset in webkit [30241] by Darin Adler

• 3 edits in trunk/LayoutTests

• update this test further, so that it succeeds

• fast/dom/assign-to-window-status-expected.txt: Updated.
• fast/dom/assign-to-window-status.html: Updated.

6:17 PM Changeset in webkit [30240] by adachan@apple.com

• 2 edits in trunk/WebCore

<rdar://problem/5744728> Fix leaks of RegularExpression objects in Frame.cpp.

Reviewed by Jon and Darin.

• page/Frame.cpp: (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement):

6:03 PM Changeset in webkit [30239] by Stephanie Lewis

• 6 edits in trunk

2008-02-14 Stephanie Lewis <Stephanie Lewis>

Reviewed by Geoff.

Update order files.

• WebKit.order:
• WebCore.order:
• JavaScriptCore.order:

6:00 PM Changeset in webkit [30238] by oliver@apple.com

• 14 edits
  2 adds in trunk

<rdar://problem/5726608> REGRESSION (r29428): Assigning to window.status does not update status bar

Reviewed by Geoff G and Weinig.

Revert the portions of r29428 responsible for breaking the ability to
set window.status

5:35 PM Changeset in webkit [30237] by andersca@apple.com

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5721790>
Crash in WebCore::DeprecatedString::operator= + 31 at news.google.com

Use pointers in the cache map tables. Otherwise when we rehash,
we will end up destroying Cache objects that node lists might point to.

• dom/Node.cpp: (WebCore::NodeListsNodeData::~NodeListsNodeData): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):

4:30 PM Changeset in webkit [30236] by alp@webkit.org

• 2 edits in trunk/WebCore

2008-02-14 Alp Toker <​alp@atoker.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17353
XMLTokenizer installs global libxml2 callbacks that can break client applications

Patch by Mark Rowe (with a few changes).

The xmlRegisterInputCallbacks/xmlRegisterOutputCallbacks done at
init are global so we need to make sure these callbacks only get used
by XMLTokenizer and never by libxml2 calls in user applications.

This patch modifies the match and open functions to only apply when we
are certain the caller is XMLTokenizer by checking globalDocLoader and
ensuring we're on the correct thread.

Some possible issues remain. See the bug report for details.

• dom/XMLTokenizer.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser):

3:29 PM Changeset in webkit [30235] by ggaren@apple.com

• 3 edits
  3 adds in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Fixed <rdar://problem/5737835> nee ​http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)

Don't reset the "activations" stack in JSGlobalObject::reset, since we
might be executing a script during the call to reset, and the script
needs to safely run to completion.

Instead, initialize the "activations" stack when the global object is
created, and subsequently rely on pushing and popping during normal
execution to maintain the stack's state.

• kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):

LayoutTests:

Reviewed by Sam Weinig.

Layout test for <rdar://problem/5737835> nee ​http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)

• fast/dom/javascript-url-crash-function.html: Added.
• fast/dom/javascript-url-crash-function-expected.txt: Added.
• fast/dom/resources/javascript-url-crash-function-iframe.html: Added.

2:27 PM Changeset in webkit [30234] by mitz@apple.com

• 8 edits in branches/Safari-3-1-branch

WebCore:

Reviewed by Adele Peterson.

• roll out changes to CSS2 system colors from r28775

• css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
• rendering/RenderTheme.cpp:
• rendering/RenderTheme.h:
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

LayoutTests:

Reviewed by Adele Peterson.

• updated results after reverting CSS2 system colors changes from r28775

• platform/mac/tables/mozilla/bugs/bug103533-expected.txt:

1:00 PM Changeset in webkit [30233] by timothy@apple.com

• 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5743768> A deadlock during storage layout tests

Make sure not to hold the m_openDatabaseMapGuard mutex when calling
Database::markAsDeletedAndClose(), since that can cause a deadlock
during the synchronous DatabaseThread call it triggers.

• storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile):

11:45 AM Changeset in webkit [30232] by Nikolas Zimmermann

• 1 edit
  40 adds in trunk/LayoutTests

Reviewed by Oliver.
Add dynamic update tests for SVGEllipseElement.

8:34 AM Changeset in webkit [30231] by Adam Roben

• 2 edits in trunk/WebCore

Improve the efficiency of SecurityOriginHash

Reviewed by Alexey.

• platform/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash): Now takes a const RefPtr<SecurityOrigin>& to reduce ref-count churn. (WebCore::SecurityOriginHash::equal): Ditto.

7:41 AM Changeset in webkit [30230] by ap@webkit.org

• 2 edits in trunk/WebKit/win

• WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to the previous check-in, fixing.

7:36 AM Changeset in webkit [30229] by ap@webkit.org

• 4 edits in trunk/WebKit

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=17207
Database example doesn't work (requires not-yet-released Safari)

• mac/WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.

• win/WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.

4:37 AM Changeset in webkit [30228] by zecke@webkit.org

• 1 edit in trunk/WebKit/gtk/ChangeLog

Correct the e-mail address in the ChangeLog.

4:27 AM Changeset in webkit [30227] by zecke@webkit.org

• 2 edits in trunk/WebKit/gtk

• Make the handling of the coreFrame consistent. We construct the coreFrame at the beginning and it will live until the end. Change the g_return_(val_)if to ASSERTs as having a 0 coreFrame can never happen.

4:26 AM Changeset in webkit [30226] by zecke@webkit.org

• 6 edits in trunk/WebKit/gtk

• Make sure that the WebCore::Frame is living as long as the WebKitWebFrame wrapped around it. All current calls to WebCore::Frame from within the WebKitWebFrame are safe, even in the case where the WebCore::Frame is already detached from the WebCore::Page.
• For the mainFrame the WebKitWebView is holding the initial reference and will unref on destruction.
• For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the frame gets detached from the parent.
• Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren

4:25 AM Changeset in webkit [30225] by zecke@webkit.org

• 2 edits in trunk/WebKit/gtk

WebCore::Frame is RefCounted, do not manually delete it!

4:25 AM Changeset in webkit [30224] by zecke@webkit.org

• 2 edits in trunk/WebKit/gtk

• Plug a leak

4:24 AM Changeset in webkit [30223] by zecke@webkit.org

• 4 edits in trunk/WebKit/gtk

• Update the Copyright Information

Feb 13, 2008:

9:14 PM Changeset in webkit [30222] by justin.garcia@apple.com

• 10 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

Fixes the editing/deleting/5729680.html failure. It succeeds when run by itself
but fails when run with other tests because FramePrivate's m_selectionGranularity
isn't reset when a Frame receives a new document. It was also uninitialized in
the constructor.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Initialize m_selectionGranularity.
• page/Frame.cpp: (WebCore::FramePrivate::FramePrivate): Ditto.

LayoutTests:

Reviewed by Oliver Hunt.

• platform/mac/editing/deleting/table-cells-expected.checksum: Fixed. Before, a space was incorrectly removed by a delete (this isn't a smart delete).
• platform/mac/editing/deleting/table-cells-expected.png:
• platform/mac/editing/deleting/table-cells-expected.txt:
• platform/mac/editing/pasteboard/input-field-1-expected.checksum: Fixed. Before a space was incorrectly added by paste (this isn't a smart paste).
• platform/mac/editing/pasteboard/input-field-1-expected.png:
• platform/mac/editing/pasteboard/input-field-1-expected.txt:

8:46 PM Changeset in webkit [30221] by mrowe@apple.com

• 4 edits in branches/Safari-3-1-branch

Versioning.

8:45 PM Changeset in webkit [30220] by mrowe@apple.com

• 4 edits in tags/Safari-5525.9

Versioning.

8:22 PM Changeset in webkit [30219] by mrowe@apple.com

• 1 copy in tags/Safari-5525.9

New tag.

6:13 PM Changeset in webkit [30218] by jhoneycutt@apple.com

• 3 edits in trunk/WebCore

2008-02-13 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5739282> Hangs after closing video trailer popup with
VLC plugin

VLC hangs on NPP_Destroy if we call NPP_SetWindow with a null window
handle.

• plugins/PluginQuirkSet.h: Added new quirk PluginQuirkDontSetNullWindowHandleOnDestroy. (WebCore::):
• plugins/win/PluginViewWin.cpp: (WebCore::PluginView::stop): Selectively call NPP_SetWindow. (WebCore::PluginView::determineQuirks): Set new quirk for VLC plug-in.

4:15 PM Changeset in webkit [30217] by sfalken@apple.com

• 1 edit in trunk/WebKit/win/ProgIDMacros.h

Versioning.

4:07 PM Changeset in webkit [30216] by sfalken@apple.com

• 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning

3:51 PM Changeset in webkit [30215] by alp@webkit.org

• 2 edits in trunk/WebCore

2008-02-13 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

Fix non-SVG builds.

• css/CSSCursorImageValue.cpp:

2:58 PM Changeset in webkit [30214] by mrowe@apple.com

• 4 edits in trunk

Versioning.

2:00 PM Changeset in webkit [30213] by justin.garcia@apple.com

• 3 edits
  2 adds in trunk

WebCore:

Reviewed by Adam Roben.

<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

• editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): Fixed a typo.

LayoutTests:

Reviewed by Adam Roben.

<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

• editing/deleting/5729680-expected.txt: Added.
• editing/deleting/5729680.html: Added.

1:56 PM Changeset in webkit [30212] by Nikolas Zimmermann

• 37 edits in trunk/LayoutTests

Reviewed by Adam.
Make svg/dynamic-updates/* tests deterministic. s/setTimeout('executTest()', 0)/executeTest/ -- as discussed with Adam.

1:49 PM Changeset in webkit [30211] by Nikolas Zimmermann

• 3 edits in trunk/WebCore

Reviewed by Oliver.

Actually fix the manual-tests/svg-cursor-changes.svg testcase.
I only reran layout tests when fixing the last issues with the patch,
instead of trying the manual-test :( Fixed.

1:31 PM Changeset in webkit [30210] by Adam Roben

• 1 edit
  1 add in trunk/WebKitTools

Windows build fix

• DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.

1:19 PM Changeset in webkit [30209] by Adam Roben

• 4 edits in trunk

Windows/GTK+ build fixes

WebCore:

Windows build fix

• css/CSSCursorImageValue.cpp: #include MathExtras.h to get roundf.

WebKitTools:

Windows/GTK+ build fix

• DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to get isnan.

12:41 PM Changeset in webkit [30208] by Nikolas Zimmermann

• 12 edits
  1 add in trunk/WebCore

Reviewed by Darin & Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=17258 (SVG uses erroneous cursor implementation)

SVG cursors are not well-integrated within the CSS(3) cursor support in WebCore.
SVGCursorElement duplicates CSSCursorImageValue functionality and inherits from
CachedResourceClient itself, handling remote-image acquisation on its own.

RenderStyle's CursorData class holds "IntPoint hotSpot", "CachedImage* image"
and just for SVG a 'String cursorFragmentId' (a reference to a SVG <cursor> element, by id).

SVG stores a reference to a SVGCursorElement, which holds a CachedImage pointer itself -
instead of storing the CachedImage in the CursorData class, as it's supposed to be.
Because of that several places in WebCore contain special SVG cursor handling - which
is unneeded.

Fix all issues by integrating within CSSCursorImageValue, remove 'String cursorFragmentId'
from RenderStyle, kill any special SVG cursor handling in WebCore and fix dynamic attribute
changes through DOM / SVG DOM (scripting of 'x' / 'y' / 'xlink:href' attribute).

12:14 PM Changeset in webkit [30207] by alp@webkit.org

• 4 edits
  1 add in trunk/WebCore

2008-02-13 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

Split out pure-cairo Font code to FontCairo.cpp.

Part of the ongoing work to share code with the Win port.

• GNUmakefile.am:
• WebCore.pro:
• platform/graphics/cairo/FontCairo.cpp: Added. (WebCore::Font::drawGlyphs):
• platform/graphics/gtk/FontGtk.cpp:

11:34 AM Changeset in webkit [30206] by adachan@apple.com

• 2 edits in trunk/WebKit/win

<rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase

Reviewed by Darin.

• WebIconDatabase.cpp: (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag, which already has a ref count of 1.

10:47 AM Changeset in webkit [30205] by beidson@apple.com

• 11 edits
  4 adds in trunk

WebKitTools:

Reviewed by Darin Adler

Add some much needed Database support to DRT

• DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to databases are called (clearAllDatabasesCallback): Allow a test to delete all databases (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get (LayoutTestController::staticFunctions):

• DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::setDumpDatabaseCallbacks):

• DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::clearAllDatabases): (LayoutTestController::setDatabaseQuota):

• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearAllDatabases): Stubbed out (LayoutTestController::setDatabaseQuota): Ditto
• DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::clearAllDatabases): Stubbed out with error message (LayoutTestController::setDatabaseQuota): Ditto

• DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a message with details about the event then return a 5mb quota like before

LayoutTests:

Reviewed by Darin Adler

Added layout tests to cover
​http://trac.webkit.org/projects/webkit/changeset/29983
and
​http://trac.webkit.org/projects/webkit/changeset/30184

• platform/gtk/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• storage/quota-tracking-expected.txt: Added.
• storage/quota-tracking.html: Added.
• storage/success-callback-expected.txt: Added.
• storage/success-callback.html: Added.

9:49 AM Changeset in webkit [30204] by kevino@webkit.org

• 6 edits in trunk

Fix issues with the paint origin when using wxGCDC, with computing the font platform data hash, and Win and wxPython bindings compilation.
​http://bugs.webkit.org/show_bug.cgi?id=17321

9:48 AM Maintenance and architecture list edited by Adam Roben

Mention the clean-header-guards script (diff)

9:34 AM Maintenance and architecture list edited by Darin Adler

(diff)

9:33 AM Maintenance and architecture list edited by Darin Adler

Take out Apple-specific items. (diff)

9:29 AM Maintenance and architecture list created by Darin Adler

9:28 AM Changeset in webkit [30203] by Adam Roben

• 7 edits in trunk

2008-02-13 Rodney Dawes <​dobey@wayofthemonkey.com>

Fix Bug 17220: Illogical dependency between PluginView and PluginDatabase

WebCore:

Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase

<​http://bugs.webkit.org/show_bug.cgi?id=17220>

Reviewed by Adam and Darin.

Rename PluginDatabase::createPluginView to PluginView::create, to make
the illogical dependency between the two, logical
Make PluginDatabase::findPlugin a public method
Update the includes in PluginView and PluginDatabase for the change

• plugins/PluginDatabase.h:
• plugins/PluginView.h:
• plugins/win/PluginDatabaseWin.cpp:
• plugins/win/PluginViewWin.cpp:

WebKit/win:

Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase

<​http://bugs.webkit.org/show_bug.cgi?id=17220>

Reviewed by Adam and Darin.

Update for the rename of PluginDatabase::createPluginView
to PluginView::create

• WebFrame.cpp:

9:20 AM Changeset in webkit [30202] by Adam Roben

• 6 edits in trunk

Windows build fixes

WebCore:

Build fix

• platform/graphics/cg/GraphicsContextCG.cpp: Added missing #include.

WebKit/win:

Windows build fix

• Interfaces/WebKit.idl: Create the typelib version symbol ourselves.

WebKitLibraries:

• win/tools/scripts/auto-version.sh: Removed a redundant symbol.

9:20 AM WikiStart edited by Darin Adler

Adding a new page with to do items for maintenance. (diff)

8:29 AM Changeset in webkit [30201] by alp@webkit.org

• 2 edits in trunk/WebKit/gtk

2008-02-13 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

Fix very small, upside down, inside out text on GTK+/DirectFB.

Based on an initial patch by Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Test the result of gdk_screen_get_resolution() and use a default
fallback in case of failure.

Also remove an unhelpful runtime warning.

• webkit/webkitwebview.cpp:

7:56 AM Changeset in webkit [30200] by Darin Adler

• 1 edit
  2 deletes in trunk/LayoutTests

• platform/mac/svg/hixie/perf/001-expected.txt: Removed.
• platform/mac/svg/hixie/perf/002-expected.txt: Removed.

7:29 AM Changeset in webkit [30199] by pewtermoose@webkit.org

• 2 edits in trunk/WebCore

Not reviewed, build fix.

• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer):

6:25 AM Changeset in webkit [30198] by Darin Adler

• 5 edits in trunk/WebCore

• try to fix Wx build

• platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::paintBuffer): Added.

• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::paintBuffer): Added missing paintingDisabled() check.
• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.
• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.

5:33 AM Changeset in webkit [30197] by Darin Adler

• 2 edits in trunk/WebCore

• try to fix Wx build

• platform/wx/LocalizedStringsWx.cpp: Add missing include.

5:26 AM Changeset in webkit [30196] by Darin Adler

• 8 edits in trunk

WebCore:

• roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

• WebCore.base.exp: Rolled out change.
• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
• page/Settings.cpp: (WebCore::Settings::Settings): Ditto. But keep the initialization of m_fontRenderingMode. (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
• page/Settings.h: (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.

WebKit/mac:

• roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

• Misc/WebKitVersionChecks.h: Removed the constant.

• WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Removed. (-[WebView _preferencesChangedNotification:]): Removed call to setNeedsXcodeVisibilityQuirk.

4:51 AM Changeset in webkit [30195] by ap@webkit.org

• 7 edits
  4 adds in trunk

Reviewed by Darin.

<rdar://problem/5740042> Database termination issues

Test: storage/close-during-stress-test.html

• dom/Document.cpp: (WebCore::Document::databaseThread):
• dom/Document.h: Don't re-create the database thread if it has been already terminated.

• storage/Database.h: (WebCore::Database::document): Changed m_database to a RefPtr to avoid having a hanging reference.

• storage/DatabaseThread.cpp: (WebCore::DatabaseThread::requestTermination):

• storage/SQLTransaction.cpp: (WebCore::SQLTransaction::~SQLTransaction): Removed logging. Transactions are deleted during GC, so it's usually not importatnt to know when it happens.

4:33 AM Changeset in webkit [30194] by Darin Adler

• 1 edit
  2 adds in trunk/LayoutTests

• check in results for these tests

No idea if these are right or not; just what was generated on my computer.
If someone has a better version, feel free to replace these results with correct ones.

• platform/mac/svg/hixie/perf/001-expected.txt: Added.
• platform/mac/svg/hixie/perf/002-expected.txt: Added.

4:27 AM Changeset in webkit [30193] by Darin Adler

• 2 edits in trunk/WebCore

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17340 WebCore/platform/Timer.cpp fails to build with gcc 4.3

• platform/Timer.cpp: Add include of <limits.h> since this file uses UINT_MAX.

4:10 AM Changeset in webkit [30192] by Darin Adler

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

• ​http://bugs.webkit.org/show_bug.cgi?id=17339 JavaScriptCore does not build with gcc 4.3

• kjs/interpreter.cpp: Add include of <unistd.h>, since that's where getpid() comes from.

1:51 AM Changeset in webkit [30191] by oliver@apple.com

• 3 edits
  3 adds in trunk

<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com

Reviewed by Alexey P.

When converting numeric values to booleans we need to account for NaN

Feb 12, 2008:

10:32 PM Changeset in webkit [30190] by timothy@apple.com

• 1 edit in trunk/WebCore/platform/sql/SQLiteDatabase.cpp

Comment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818> to track the issue.

10:04 PM Changeset in webkit [30189] by timothy@apple.com

• 7 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5652560> Can't delete database if the website that
uses it has been opened in this session

Close the Database on the database thread before deleting the file.
Tested and works on Windows and Mac.

• platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::close): Assert we are on the opening thread.
• storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): Unschedule any pending Database tasks, and start and imediate DatabaseCloseTask. (WebCore::Database::close): Close the SQLDatabase.
• storage/Database.h: Renamed markAsDeleted to markAsDeletedAndClose.
• storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): New task. (WebCore::DatabaseCloseTask::doPerformTask): Call close on the Database. (WebCore::DatabaseCloseTask::debugTaskName): Return "DatabaseCloseTask".
• storage/DatabaseTask.h: Add DatabaseCloseTask.
• storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile): Call the renamed markAsDeletedAndClose.

9:12 PM BuildingCairoOnWindows edited by bfulgham@macports.org

(diff)

8:22 PM Changeset in webkit [30188] by oliver@apple.com

• 3 edits in trunk/WebCore

Endeavour to fix qt and gtk builds

7:07 PM Changeset in webkit [30187] by Adam Roben

• 2 edits in trunk/WebKitLibraries

Clean up auto-version.sh a bit

It now does quite a bit less file I/O and many fewer fork/exec pairs.
It's also quite a bit easier to read.

Reviewed by Steve.

• win/tools/scripts/auto-version.sh:

6:53 PM Changeset in webkit [30186] by sfalken@apple.com

• 2 edits
  2 adds in trunk/WebKit/win

Use a precompiled header to build WebKit.

Reviewed by Adam.

• WebKit.vcproj/WebKit.vcproj:
• WebKitPrefix.cpp: Added.
• WebKitPrefix.h: Added.

6:11 PM Changeset in webkit [30185] by oliver@apple.com

• 6 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Remove ifdef's from canvas paint code

Reviewed by Eric S.

By making GraphicsContext aware of the crossplatform ImageBuffer
type we can migrate the ifdef-ified paint code in HTMLCanvasElement
into platform implementations of GraphicsContext.

5:10 PM Changeset in webkit [30184] by beidson@apple.com

• 5 edits in trunk/WebCore

Reviewed by Darin Adler

Fix for <rdar://problem/5737692> - Database API needs to support SuccessCallback

Layout tests will come shortly with a mess of DRT changes

• platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Standardize on "empty string" instead of null string as different paths of constructing a SecurityOrigin were causing different hashes for the "same" SecurityOrigin

• storage/Database.cpp: (WebCore::Database::changeVersion): Pass in the successCallback (WebCore::Database::transaction): Ditto

• storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::debugStepName): (WebCore::SQLTransaction::performNextStep): Update ASSERTs for the new valid steps (WebCore::SQLTransaction::performPendingCallback): Ditto (WebCore::SQLTransaction::postflightAndCommit): Schedule the success callback if it exists - otherwise skip straight to cleanupAfterSuccessCallback() (WebCore::SQLTransaction::deliverSuccessCallback): Deliver success callback on the main thread, then schedule cleanupAfterSuccessCallback() (WebCore::SQLTransaction::cleanupAfterSuccessCallback): Cleanup and end the transaction (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
• storage/SQLTransaction.h:

4:18 PM Changeset in webkit [30183] by sfalken@apple.com

• 2 edits in trunk/WebKitLibraries

Versioning script change.

• win/tools/scripts/auto-version.sh:

4:16 PM Changeset in webkit [30182] by sfalken@apple.com

• 2 edits in trunk/WebCore

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

• bindings/scripts/CodeGeneratorCOM.pm:

4:16 PM Changeset in webkit [30181] by sfalken@apple.com

• 19 edits in trunk/WebKitTools

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

• Drosera/win/BaseDelegate.h:
• Drosera/win/DebuggerClient.cpp:
• Drosera/win/DebuggerDocumentPlatform.cpp:
• Drosera/win/Drosera.cpp:
• Drosera/win/ServerConnection.cpp:
• Drosera/win/ServerConnection.h:
• DumpRenderTree/win/DumpRenderTree.cpp:
• DumpRenderTree/win/EditingDelegate.h:
• DumpRenderTree/win/EventSender.cpp:
• DumpRenderTree/win/FrameLoadDelegate.cpp:
• DumpRenderTree/win/FrameLoadDelegate.h:
• DumpRenderTree/win/GCControllerWin.cpp:
• DumpRenderTree/win/LayoutTestControllerWin.cpp:
• DumpRenderTree/win/PolicyDelegate.h:
• DumpRenderTree/win/ResourceLoadDelegate.h:
• DumpRenderTree/win/UIDelegate.cpp:
• DumpRenderTree/win/UIDelegate.h:
• DumpRenderTree/win/WorkQueueItemWin.cpp:

4:16 PM Changeset in webkit [30180] by sfalken@apple.com

• 122 edits in trunk/WebKit/win

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

• DOMCSSClasses.h:
• DOMCoreClasses.h:
• DOMEventsClasses.h:
• DOMHTMLClasses.h:
• DefaultDownloadDelegate.h:
• DefaultPolicyDelegate.cpp:
• DefaultPolicyDelegate.h:
• GEN_DOMObject.h:
• Interfaces/DOMCSS.idl:
• Interfaces/DOMCore.idl:
• Interfaces/DOMEvents.idl:
• Interfaces/DOMExtensions.idl:
• Interfaces/DOMHTML.idl:
• Interfaces/DOMPrivate.idl:
• Interfaces/DOMRange.idl:
• Interfaces/DOMWindow.idl:
• Interfaces/IGEN_DOMObject.idl:
• Interfaces/IWebArchive.idl:
• Interfaces/IWebBackForwardList.idl:
• Interfaces/IWebBackForwardListPrivate.idl:
• Interfaces/IWebCache.idl:
• Interfaces/IWebDataSource.idl:
• Interfaces/IWebDatabaseManager.idl:
• Interfaces/IWebDocument.idl:
• Interfaces/IWebDownload.idl:
• Interfaces/IWebEditingDelegate.idl:
• Interfaces/IWebError.idl:
• Interfaces/IWebErrorPrivate.idl:
• Interfaces/IWebFormDelegate.idl:
• Interfaces/IWebFrame.idl:
• Interfaces/IWebFrameLoadDelegate.idl:
• Interfaces/IWebFrameLoadDelegatePrivate.idl:
• Interfaces/IWebFramePrivate.idl:
• Interfaces/IWebFrameView.idl:
• Interfaces/IWebHTMLRepresentation.idl:
• Interfaces/IWebHTTPURLResponse.idl:
• Interfaces/IWebHistory.idl:
• Interfaces/IWebHistoryItem.idl:
• Interfaces/IWebHistoryItemPrivate.idl:
• Interfaces/IWebIconDatabase.idl:
• Interfaces/IWebInspector.idl:
• Interfaces/IWebJavaScriptCollector.idl:
• Interfaces/IWebKitStatistics.idl:
• Interfaces/IWebMutableURLRequest.idl:
• Interfaces/IWebMutableURLRequestPrivate.idl:
• Interfaces/IWebNotification.idl:
• Interfaces/IWebNotificationCenter.idl:
• Interfaces/IWebNotificationObserver.idl:
• Interfaces/IWebPolicyDelegate.idl:
• Interfaces/IWebPreferences.idl:
• Interfaces/IWebPreferencesPrivate.idl:
• Interfaces/IWebResource.idl:
• Interfaces/IWebResourceLoadDelegate.idl:
• Interfaces/IWebResourceLoadDelegatePrivate.idl:
• Interfaces/IWebScriptCallFrame.idl:
• Interfaces/IWebScriptDebugListener.idl:
• Interfaces/IWebScriptDebugServer.idl:
• Interfaces/IWebScriptObject.idl:
• Interfaces/IWebScriptScope.idl:
• Interfaces/IWebScrollBarDelegatePrivate.idl:
• Interfaces/IWebScrollBarPrivate.idl:
• Interfaces/IWebSecurityOrigin.idl:
• Interfaces/IWebTextRenderer.idl:
• Interfaces/IWebUIDelegate.idl:
• Interfaces/IWebUIDelegatePrivate.idl:
• Interfaces/IWebURLAuthenticationChallenge.idl:
• Interfaces/IWebURLRequest.idl:
• Interfaces/IWebURLResponse.idl:
• Interfaces/IWebURLResponsePrivate.idl:
• Interfaces/IWebUndoManager.idl:
• Interfaces/IWebUndoTarget.idl:
• Interfaces/IWebView.idl:
• Interfaces/IWebViewPrivate.idl:
• Interfaces/WebKit.idl:
• WebActionPropertyBag.cpp:
• WebBackForwardList.h:
• WebCache.h:
• WebDataSource.cpp:
• WebDataSource.h:
• WebDatabaseManager.h:
• WebDownload.h:
• WebEditorClient.cpp:
• WebEditorClient.h:
• WebError.h:
• WebFrame.cpp:
• WebFrame.h:
• WebFramePolicyListener.h:
• WebHTMLRepresentation.cpp:
• WebHTMLRepresentation.h:
• WebHistory.cpp:
• WebHistory.h:
• WebHistoryItem.h:
• WebIconDatabase.h:
• WebInspector.h:
• WebJavaScriptCollector.h:
• WebKit.vcproj/Interfaces.vcproj:
• WebKit.vcproj/WebKitGUID.vcproj:
• WebKitDLL.cpp:
• WebKitStatistics.h:
• WebMutableURLRequest.cpp:
• WebMutableURLRequest.h:
• WebNotification.h:
• WebNotificationCenter.h:
• WebPreferences.h:
• WebResource.h:
• WebScriptCallFrame.h:
• WebScriptDebugServer.cpp:
• WebScriptDebugServer.h:
• WebScriptDebugger.cpp:
• WebScriptDebugger.h:
• WebScriptObject.h:
• WebScrollBar.h:
• WebSecurityOrigin.h:
• WebTextRenderer.h:
• WebURLAuthenticationChallenge.h:
• WebURLAuthenticationChallengeSender.h:
• WebURLCredential.h:
• WebURLProtectionSpace.h:
• WebURLResponse.h:
• WebView.cpp:
• WebView.h:

3:54 PM Changeset in webkit [30179] by mitz@apple.com

• 2 edits in trunk/WebCore

Reviewed by Adam Roben.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17041 <rdar://problem/5709660> Eastern Asian fonts do not display without specific box in Control Panel

Revised the system fallback font lookup logic to use MLang font linking
again. To avoid reintroducing bug 16548 and <rdar://problem/5280188>,
for CJK characters, try linking based on a single code page at a time,
starting with the user's default code page (if it is one of the CJK
code pages) followed by the other CJK code pages in a prescribed order
that matches what Firefox does.

• platform/graphics/win/FontCacheWin.cpp: (WebCore::getCJKCodePageMasks): Added. Returns the search order for CJK code pages, with the user's default code page first. (WebCore::currentFontContainsCharacter): Factored out of getFontDataForCharacters(). (WebCore::createMLangFont): Ditto. (WebCore::FontCache::getFontDataForCharacters):

3:34 PM Changeset in webkit [30178] by andersca@apple.com

• 2 edits in trunk/WebKit/win

Reviewed by Adam.

Implement imageTitle.

• WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):

1:29 PM Changeset in webkit [30177] by weinig@apple.com

• 2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

<rdar://problem/5659216> REGRESSION: PLT 0.3% slower due to r28868 (caching ClassNodeList and NamedNodeList)

• Tweak the statements in isASCIISpace to account for the statistical distribution of usage in the PLT.

.4% speedup on my machine. Stephanie's machine shows this as .3% speedup.

• wtf/ASCIICType.h: (WTF::isASCIISpace):

1:17 PM Changeset in webkit [30176] by mitz@apple.com

• 2 edits
  2 adds in trunk/LayoutTests

Rubber-stamped by Adam Roben.

• make fast/css/css3-nth-child pass

• fast/css/css3-nth-child.html: Removed spaces that were making the :nth-child selector fail to parse because of <rdar://problem/5733761>.
• platform/mac-leopard/fast/css/css3-nth-child-expected.checksum: Added.
• platform/mac-leopard/fast/css/css3-nth-child-expected.png: Added.

1:04 PM Changeset in webkit [30175] by alp@webkit.org

• 5 edits in trunk

2008-02-12 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

Add -DMAEMO_CHANGES when the hildon CONFIG option is specified
Add hildon-1 to PKGCONFIG when hildon CONFIG option is specified

12:13 PM Changeset in webkit [30174] by mitz@apple.com

• 2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

• <rdar://problem/5738175> Remove workaround for <rdar://problem/5539388> from post-Tiger builds

• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow):

12:11 PM Changeset in webkit [30173] by beidson@apple.com

• 2 edits in trunk/WebCore

Release build fix

• storage/DatabaseTask.cpp:

11:37 AM Changeset in webkit [30172] by ap@webkit.org

• 13 edits
  3 adds in trunk/WebCore

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=17177
<rdar://problem/5729619> Storage tasks are getting lost

<rdar://problem/5729445> REGRESSION: Cannot schedule more than one transaction at a time

<rdar://problem/5729446> Major thread safety issue in Database code

• platform/MessageQueue.h: Added a thread-safe queue abstraction.

• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj: Added MessageQueue.h.

• dom/Document.cpp: (WebCore::Document::~Document): Fixed a race condition resulting in a hanging reference.

• storage/Database.idl: Fixed parameter declarations to actually match implementation (which is custom, so it got out of sync).

• storage/DatabaseTask.h: (WebCore::DatabaseTask::database): (WebCore::DatabaseTransactionTask::transaction): Changed tasks to hold more information internally. Added helpers for better debug logging.

• storage/DatabaseTask.cpp: (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask): (WebCore::DatabaseOpenTask::debugTaskName): (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::doPerformTask): (WebCore::DatabaseTransactionTask::debugTaskName): (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): (WebCore::DatabaseTableNamesTask::doPerformTask): (WebCore::DatabaseTableNamesTask::debugTaskName): Implementation for the above.

(WebCore::DatabaseTask::lockForSynchronousScheduling):
(WebCore::DatabaseTask::waitForSynchronousCompletion):
Fixed a potential race condition: if the task completed before we entered a wait, we'd never
wake up. There was an assertion guarding against this, but no actual guarantee that I could see.

• storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::requestTermination): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): (WebCore::DatabaseThread::unscheduleDatabaseTasks):
• storage/DatabaseThread.h: Changed to use MessageQueue.

• storage/Database.cpp: (WebCore::guidMutex): (WebCore::guidToVersionMap): (WebCore::guidToDatabaseMap): (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::guidForOriginAndName): (WebCore::Database::changeVersion): (WebCore::Database::transaction): (WebCore::Database::scheduleTransaction): (WebCore::Database::scheduleTransactionStep): (WebCore::Database::scheduleTransactionCallback): (WebCore::Database::version): (WebCore::Database::deliverPendingCallback): (WebCore::Database::tableNames):
• storage/Database.h: Changed m_transactionQueue to a MessageQueue. Got rid of callback tracking - these can take care of themselves. Got rid of a DatabaseThread member, as the Document can be asked for it. Moved private static members and helpers out of the header. Lost CurrentThreadSetter debug helper on the way. We may need to re-add something like that later.

• storage/SQLTransaction.h:
• storage/SQLTransaction.cpp: Added a lot of debug logging. (WebCore::SQLTransaction::scheduleToRunStatements): Removed "m_currentStatement = 0" assignment, as it created a race condition. Everything seems to work better without it, although a real fix would be to get rid of this variable - it's evil shared data that isn't even protected in any way.

• manual-tests/database-threading-stress-test-2.html: Added.
• manual-tests/database-threading-stress-test.html: Added.

11:29 AM Changeset in webkit [30171] by Adam Roben

• 3 edits
  3 adds in trunk

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

WebCore:

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

<​http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

Test: fast/loader/local-css-allowed-in-strict-mode.html

• platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Add a case for .css files.

LayoutTests:

Add a test for Bug 17328: REGRESSION (r30147): Inspector is unstyled
on Windows

<​http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

• fast/loader/local-css-allowed-in-strict-mode-expected.txt: Added.
• fast/loader/local-css-allowed-in-strict-mode.html: Added.
• fast/loader/resources/stylesheet.css: Added.

11:17 AM Changeset in webkit [30170] by andersca@apple.com

• 2 edits in trunk/WebCore

Build fix.

• loader/ImageDocument.cpp:

10:53 AM Changeset in webkit [30169] by andersca@apple.com

• 1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop.

10:51 AM Changeset in webkit [30168] by andersca@apple.com

• 15 edits
  2 deletes in trunk

WebCore:

Reviewed by Mitz.

Make the code that sets the image title cross platform.

• WebCore.xcodeproj/project.pbxproj: Remove ImageDocumentMac.

• loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):

• loader/mac/ImageDocumentMac.h: Removed.
• loader/mac/ImageDocumentMac.mm: Removed.

• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreViewFactory.h: Move imageTitleForFilename:size from the bridge to the view factory.

• platform/LocalizedStrings.h: Add imageTitle.

• platform/mac/LocalizedStringsMac.mm: (WebCore::imageTitle): Have imageTitle call the view factory.

• platform/qt/Localizations.cpp: (WebCore::imageTitle):
• platform/wx/LocalizedStringsWx.cpp: (WebCore::imageTitle):
• platform/gtk/LocalizedStringsGtk.cpp: (WebCore::imageTitle): Add stubs.

WebKit/mac:

Reviewed by Mitz.

• WebCoreSupport/WebFrameBridge.mm:
• WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:size:]): Move implementatino from WebFrameBridge to WebViewFactory.

WebKit/win:

Reviewed by Mitz.

• WebCoreLocalizedStrings.cpp: (WebCore::imageTitle): Add stub.

5:23 AM Changeset in webkit [30167] by Nikolas Zimmermann

• 1 edit
  31 adds in trunk/LayoutTests

Not reviewed, adding missing layout test results (that have been r+ already, but not commited)

1:40 AM Changeset in webkit [30166] by oliver@apple.com

• 2 edits in trunk/WebCore

more Qt fixes

1:30 AM Changeset in webkit [30165] by oliver@apple.com

• 2 edits in trunk/WebCore

Yet another attempt to fix Qt

1:21 AM Changeset in webkit [30164] by oliver@apple.com

• 2 edits in trunk/WebCore

Attempt to fix qt build

1:14 AM Changeset in webkit [30163] by oliver@apple.com

• 4 edits in trunk/WebCore

Make canvas use an ImageBuffer for its backing store

Reviewed by Alp Toker.

In order to make the canvas implementation less platform dependent
(and thus reduce the current quagmire of ifdefs) we now use an
ImageBuffer to provide the backing buffer, an immediate consequence
of this is to remove multiple ifdefs in the construction of the
buffer. This patch allows us to further reduce the platform
dependencies in later patches.

Feb 11, 2008:

10:02 PM Changeset in webkit [30162] by mitz@apple.com

• 3 edits
  4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17320 <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

Test: fast/css/last-child-style-sharing.html

• css/CSSGrammar.y: Changed to call setUsesSiblingRules(true) for all CSS3 selectors that require it.

LayoutTests:

Reviewed by Dave Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=17320 <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

• fast/css/last-child-style-sharing.html: Added.
• platform/mac/fast/css/last-child-style-sharing-expected.checksum: Added.
• platform/mac/fast/css/last-child-style-sharing-expected.png: Added.
• platform/mac/fast/css/last-child-style-sharing-expected.txt: Added.

7:02 PM Changeset in webkit [30161] by timothy@apple.com

• 2 edits
  7 deletes in tags/Safari-5525.8/LayoutTests

Merge the LayoutTests part of r30052.

7:01 PM Changeset in webkit [30160] by timothy@apple.com

• 3 edits in tags/Safari-5525.8/WebCore

Merge the WebCore part of r30052.

5:31 PM Changeset in webkit [30159] by timothy@apple.com

• 1 copy in tags/Safari-5525.8

New tag.

5:24 PM Changeset in webkit [30158] by weinig@apple.com

• 4 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

Fixes for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

• Expose the native Object.prototype.toString implementation so that it can be used for cross-domain toString calling.

• JavaScriptCore.exp:
• kjs/object_object.cpp:
• kjs/object_object.h:

4:26 PM Changeset in webkit [30157] by weinig@apple.com

• 21 edits
  1 move
  16 adds
  1 delete in trunk

WebCore:

Reviewed by Darin Adler.

Make the cross-domain security model more closely match Firefox by always returning the
native built-in functions when accessing functions cross-domain.

Fixes for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

Tests: fast/dom/Window/window-custom-prototype-crash.html

fast/dom/Window/window-function-frame-getter-precedence.html
http/tests/security/cross-frame-access-get-override.html
http/tests/security/cross-frame-access-location-get-override.html
http/tests/security/cross-frame-access-location-get.html
http/tests/security/cross-frame-access-location-put.html

• bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
• Return the native-built in version of an cross-domain allowed function (eg. window.focus) whether or not it has been overridden, instead of undefined.
• When doing findEntry lookup, use the the tables directly (JSDOMWindowPrototype::info.propHashTable) instead of calling the virtual classInfo() method to avoid the unnecessary overhead.
• Allow access to the native toString function cross-domain. It always returns "[object Window]".
• Use the new nonCachingStaticFunctionGetter when return allowed functions cross-frame so that the function an overridden function is not inadvertantly returned from the PropertyMap.\

• bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customGetOwnPropertySlot):
• Implement the same model as described above for the History object, always returning the native built-in function cross-domain.
• Allow access to the native toString function cross-domain.
• Clean up the code to make it clear that the custom functionality is only there for cross-domain access.

• bindings/js/JSLocation.cpp: (WebCore::JSLocation::getOwnPropertySlot):
• Match the generated classes by moving all the custom logic into a separate customGetOwnPropertySlot function. This will help moving to a generated class in the future. (WebCore::JSLocation::customGetOwnPropertySlot):
• Implement the same model as described above for the Location object, always returning the native built-in function cross-domain.
• Clean up the code to make it clear that the custom functionality is only there for cross-domain access. (WebCore::JSLocation::put): (WebCore::JSLocation::deleteProperty): (WebCore::JSLocation::getPropertyNames):
• bindings/js/JSLocation.h:
• Clean up to match the rest of the file a little better.

• bindings/js/kjs_binding.cpp: (WebCore::allowsAccessFromFrame): (WebCore::printErrorMessageForFrame): (WebCore::nonCachingStaticFunctionGetter): (WebCore::objectToStringFunctionGetter):
• bindings/js/kjs_binding.h:
• Put common functionality related to cross-domain access here to serve as a central shared point. This includes moving and augmenting the allowsAccessFromFrame method that was in both JSHistoryCustom.cpp and JSLocation.cpp.

• bindings/js/kjs_dom.cpp: (WebCore::checkNodeSecurity):
• Use the new allowsAccessFromFrame method.

• bindings/js/kjs_window.cpp: (KJS::Window::childFrameGetter): Cleanup. (KJS::Window::namedItemGetter): Cleanup. (KJS::Window::getOwnPropertySlot):
• Do the prototype lookup early to match Firefox in having function lookup have a higher precedence than the index or shortcut name getters.
• Cleanup function to make it more understandable and slightly more efficient. (KJS::Window::allowsAccessFrom):
• Add a new variant of this method that takes a reference to a String, which, on failure, will contain the error message to print out. The caller can then pass this to printErrorMessage. This allows for code to check allowsAccessFrom and act on the result without printing out the error message. For convenience, a version with out the String parameter has been left which prints out the message automatically. (KJS::Window::printErrorMessage):
• bindings/js/kjs_window.h:

LayoutTests:

Reviewed by Darin Adler.

Tests for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

• fast/dom/Window/resources/WindowProperties.js: Added.
• fast/dom/Window/window-custom-prototype-crash-expected.txt: Added.
• fast/dom/Window/window-custom-prototype-crash.html: Added.
• fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Added.
• fast/dom/Window/window-function-frame-getter-precedence.html: Added.
• fast/dom/Window/window-function-name-getter-precedence-expected.txt:
• fast/dom/Window/window-function-name-getter-precedence.html:
• http/tests/security/cross-frame-access-custom-expected.txt:
• http/tests/security/cross-frame-access-custom.html:
• http/tests/security/cross-frame-access-get-override-expected.txt: Added.
• http/tests/security/cross-frame-access-get-override.html: Added.
• http/tests/security/cross-frame-access-history-get-override-expected.txt:
• http/tests/security/cross-frame-access-history-get-override.html:
• http/tests/security/cross-frame-access-history-put-expected.txt:
• http/tests/security/cross-frame-access-history-put.html:
• http/tests/security/cross-frame-access-location-expected.txt: Removed.
• http/tests/security/cross-frame-access-location-get-expected.txt: Added.
• http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
• http/tests/security/cross-frame-access-location-get-override.html: Added.
• http/tests/security/cross-frame-access-location-get.html: Copied from http/tests/security/cross-frame-access-location.html.
• http/tests/security/cross-frame-access-location-put-expected.txt: Added.
• http/tests/security/cross-frame-access-location-put.html: Added.
• http/tests/security/cross-frame-access-location.html: Removed.
• http/tests/security/resources/cross-frame-iframe-for-get-override-test.html: Added.
• http/tests/security/resources/cross-frame-iframe-for-get-test.html:
• http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
• http/tests/security/resources/cross-frame-iframe-for-location-get-override-test.html: Added.
• http/tests/security/resources/cross-frame-iframe-for-location-get-test.html: Added.
• http/tests/security/resources/cross-frame-iframe-for-location-put-test.html: Added.

4:16 PM Changeset in webkit [30156] by Darin Adler

• 8 edits in trunk

WebCore:

Reviewed by Mitz.

• fix <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Added an Xcode-specific quirk.

• WebCore.base.exp: Added export for new Settings function.
• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Here's the crazy quirk. If you try to change the visibilty on a node with the class name tab_content, instead it will use display:none.
• page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_needsXcodeVisibilityQuirk. Also initialize m_fontRenderingMode! This seems like it was a bug before, but we probably were getting lucky and always getting 0 on Windows, which is the only place the setting matters. (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Added.
• page/Settings.h: (WebCore::Settings::needsXcodeVisibilityQuirk): Added.

WebKit/mac:

Reviewed by Mitz.

• fix <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Added an Xcode-specific quirk.

• Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after" part of the check.

• WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Added. (-[WebView _preferencesChangedNotification:]): Added a call to setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.

3:38 PM Changeset in webkit [30155] by alp@webkit.org

• 2 edits in trunk/PlanetWebKit

2008-02-11 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

Add my blog's WebKit category, English only posts.

• config.ini:

2:54 PM Changeset in webkit [30154] by timothy@apple.com

• 2 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5733069> Many m_quotaMap uses do not hold the m_quotaMapGuard

• storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::hasEntryForOrigin): Hold m_quotaMapGuard when using m_quotaMap. (WebCore::DatabaseTracker::origins): Ditto. (WebCore::DatabaseTracker::setQuota): Ditto. (WebCore::DatabaseTracker::deleteAllDatabases): Call origins() and itterate over the origins to call deleteOrigin(). (WebCore::DatabaseTracker::deleteOrigin): Hold m_quotaMapGuard when using m_quotaMap.

1:19 PM Changeset in webkit [30153] by hyatt@apple.com

• 2 edits
  4 adds in trunk

Fix for bug 17286, crash accessing a null RenderStyle. Add a simple null check.

Reviewed by aroben

Added fast/css/empty-generated-content.html

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

1:04 PM Changeset in webkit [30152] by rwlbuis@webkit.org

• 2 edits in trunk/WebCore

Reviewed by David Kilzer.

​http://bugs.webkit.org/show_bug.cgi?id=17201
Bug 17201: Use RefPtr in CSSParser::parseFont() to get rid of goto silliness

Gets rid of goto usage in parseFont.

12:26 PM Changeset in webkit [30151] by hyatt@apple.com

• 1 edit in trunk/WebCore/html/HTMLMediaElement.cpp

Back out accidental checkin to HTMLMediaElement.cpp.

12:22 PM Changeset in webkit [30150] by hyatt@apple.com

• 3 adds in trunk/LayoutTests/platform/mac/fast/forms

Add layout test for bug 16798.

12:21 PM Changeset in webkit [30149] by hyatt@apple.com

• 1 add in trunk/LayoutTests/fast/forms/button-submit.html

Add layout test for bug 16798.

12:18 PM Changeset in webkit [30148] by hyatt@apple.com

• 2 adds in trunk/LayoutTests/http/tests/misc

12:17 PM Changeset in webkit [30147] by hyatt@apple.com

• 15 edits in trunk/WebCore

Fix for bug 17298, Acid3 text should be black and not red. Make sure stylesheets with the wrong MIME type
are not accepted in strict mode.

Reviewed by darin

Added http/tests/misc/css-reject-in-strict-mode.html

• css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet):
• css/CSSImportRule.h:
• dom/Document.cpp: (WebCore::Document::setCSSStyleSheet):
• dom/Document.h:
• dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::setCSSStyleSheet):
• dom/ProcessingInstruction.h:
• html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
• html/HTMLLinkElement.h:
• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
• loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::checkNotify): (WebCore::CachedCSSStyleSheet::canUseSheet):
• loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::sheetText):
• loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setCSSStyleSheet):
• loader/mac/UserStyleSheetLoader.cpp: (UserStyleSheetLoader::setCSSStyleSheet):
• loader/mac/UserStyleSheetLoader.h:

11:58 AM Changeset in webkit [30146] by Adam Roben

• 3 edits in trunk/WebCore

Fix Bug 14316: Inspector's Console truncates long strings

<​http://bugs.webkit.org/show_bug.cgi?id=14316>
<rdar://5357695>

We no longer call Object.describe to format all the output of commands
enetered into the Console. The ConsolePanel object now has a set of
formatting functions that append a formatted representation of the
passed-in object to the passed-in container node.

Reviewed by Sam.

• page/inspector/ConsolePanel.js: (WebInspector.ConsolePanel._onEnterPressed): Updated for rename of _outputToNode to _format. (WebInspector.ConsolePanel._format): Renamed from _outputToNode. Use Object.type to get the type of the object, then call the appropriate formatting function. (WebInspector.ConsolePanel._formatvalue): Added. (WebInspector.ConsolePanel._formatstring): Added. This function contains the actual fix for the bug, since it doesn't truncate the string no matter how long it is. (WebInspector.ConsolePanel._formatregexp): Added. (WebInspector.ConsolePanel._formatarray): Added. This is a bit more functional than Object.describe for arrays, since it recursively formats each item in the array. One advantage of this is that Nodes in arrays will be linkified instead of just turning into "[Object HTMLBodyElement]" or similar. (WebInspector.ConsolePanel._formatnode): Added. (WebInspector.ConsolePanel._formatobject): Added. (WebInspector.ConsolePanel.
• page/inspector/utilities.js: (Object.type): Added. Code was pulled out of Object.describe and reorganized slightly. (Object.describe): Call Object.type. There should be no change in behavior of this function.

10:09 AM Changeset in webkit [30145] by alp@webkit.org

• 2 edits in trunk/WebCore

2008-02-11 Alp Toker <​alp@atoker.com>

Wx build fix for breakage introduced in r30142. Spotted by Darin.

• platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):

9:44 AM Changeset in webkit [30144] by Adam Roben

• 2 edits in trunk/PlanetWebKit

Add Brent Fulgham's blog

Rubberstamped by Alp.

• config.ini:

9:38 AM Changeset in webkit [30143] by Darin Adler

• 3 edits in trunk/WebCore

Reviewed and tweaked by Darin

• ​http://bugs.webkit.org/show_bug.cgi?id=17299 a couple compilation fixes for Cairo/Win32 configuration

• platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Turn off XBMImageDecoder for PLATFORM(WIN) configuration.
• rendering/RenderThemeWin.cpp: (WebCore::prepareForDrawing): Added IntRect parameter. (WebCore::doneDrawing): Ditto. (WebCore::RenderThemeWin::paintButton): Ditto. (WebCore::RenderThemeWin::paintTextField): Ditto. (WebCore::RenderThemeWin::paintMenuListButton): Ditto. (WebCore::RenderThemeWin::systemFont): Added.

8:56 AM Changeset in webkit [30142] by alp@webkit.org

• 2 edits in trunk/WebCore

2008-02-11 Alp Toker <​alp@atoker.com>

Reviewed by Alexey.

Acid3 data URL parsing fix for the GTK+ port.

Avoid WebCore's base64Decode() when possible since it's not a
general-purpose Base64 decoder and fails on newlines.

• platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):

7:33 AM Changeset in webkit [30141] by Darin Adler

• 2 edits in trunk/WebCore

• another Qt build fix

• platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): Added explicit RefCounted constructor.

6:37 AM Nightly Builds edited by ryanfelder@yahoo.com

(diff)

5:21 AM QtWebKitTodo edited by zecke2@selfish.org

Printing was implemented by simon (diff)

5:20 AM QtWebKitTodo edited by zecke2@selfish.org

works here (tm), also popping the window properly up is working (diff)

5:19 AM QtWebKitTodo edited by zecke2@selfish.org

Ben fixed that a while ago (diff)

5:18 AM QtWebKitTodo edited by zecke2@selfish.org

We have something that can be used by Assistant, we want something … (diff)

5:17 AM QtWebKitTodo edited by zecke2@selfish.org

We have the first bits of support for InputMethods (diff)

5:16 AM QtWebKitTodo edited by zecke2@selfish.org

We have this paint signal now (diff)

Feb 10, 2008:

11:40 PM Changeset in webkit [30140] by Darin Adler

• 2 edits in trunk/JavaScriptCore

Rubber stamped by Eric.

• kjs/ExecState.h: (KJS::ExecState::takeException): Added.

11:38 PM Changeset in webkit [30139] by Darin Adler

• 2 edits in trunk/WebCore

• another Qt build fix (wish the Qt bot wouldn't stop on the first error)

• platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::FileChooser): Added explicit RefCounted constructor.

11:03 PM Changeset in webkit [30138] by Darin Adler

• 2 edits in trunk/WebCore

• another Qt fix

• platform/graphics/qt/IconQt.cpp: (WebCore::Icon::Icon): Added explicit RefCounted constructor.

10:09 PM Changeset in webkit [30137] by alp@webkit.org

• 2 edits in trunk/WebCore

2008-02-10 Alp Toker <​alp@atoker.com>

Another Win build fix for r30133 breakage.

• plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::PluginPackage):

9:50 PM Changeset in webkit [30136] by alp@webkit.org

• 5 edits in trunk/WebCore

2008-02-10 Alp Toker <​alp@atoker.com>

Build fix GTK+ and prospective build fix for Win breakage introduced
in r30133.

• platform/Cursor.h: (WebCore::SharedCursor::SharedCursor):
• platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::Icon):
• platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::FileChooser):
• platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu):

8:17 PM Changeset in webkit [30135] by Darin Adler

• 7 edits in trunk/WebCore

• try to fix Win, Qt, GTK, and WX builds

• platform/Cursor.h: (WebCore::SharedCursor::SharedCursor): Added explicit RefCounted constructor.
• platform/graphics/win/IconWin.cpp: (WebCore::Icon::Icon): Ditto.
• platform/win/FileChooserWin.cpp: (WebCore::FileChooser::FileChooser): Ditto.
• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Ditto.
• platform/wx/TemporaryLinkStubs.cpp: (FileChooser::FileChooser): Ditto. (PopupMenu::PopupMenu): Ditto. (Icon::Icon): Ditto.
• plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): Ditto.

7:41 PM Changeset in webkit [30134] by mitz@apple.com

• 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig and Anders Carlsson.

• change a test to simply use 'font-family' instead of unnecessary @font-face hackery

• fast/text/atsui-spacing-features.html:
• platform/mac/fast/text/atsui-spacing-features-expected.checksum:
• platform/mac/fast/text/atsui-spacing-features-expected.png:
• platform/mac/fast/text/atsui-spacing-features-expected.txt:

6:03 PM Changeset in webkit [30133] by Darin Adler

• 4 edits in trunk

JavaScriptCore:

Reviewed by Eric.

• ​http://bugs.webkit.org/show_bug.cgi?id=17256 eliminate default ref. count of 0 in RefCounted class

• wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Remove default of 0.

WebKit/wx:

Reviewed by Eric.

• ​http://bugs.webkit.org/show_bug.cgi?id=17256 eliminate default ref. count of 0 in RefCounted class

• WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::FrameLoaderClientWx): Set the count to 0 explicitly (one stray client I missed in my last pass).

4:45 PM BuildingCairoOnWindows edited by bfulgham@macports.org

(diff)

4:37 PM BuildingCairoOnWindows created by bfulgham@macports.org

3:17 PM Changeset in webkit [30132] by mitz@apple.com

• 2 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

• fix a memory leak

• DumpRenderTree/cg/ImageDiffCG.cpp: (getDifferenceBitmap): Use a static CFMutableData instead of allocating and leaking the buffer each time.

3:08 PM Changeset in webkit [30131] by hyatt@apple.com

• 1 edit in trunk/LayoutTests/webarchive/archive-empty-frame-dom-expected.txt

Update test results for iframe fix.

2:43 PM WikiStart edited by bfulgham@macports.org

(diff)

2:33 PM Changeset in webkit [30130] by hyatt@apple.com

• 3 edits in trunk/WebCore

Fix for bug 17082, cssRules should be live.

Reviewed by olliej

Added fast/css/live-cssrules.html

• css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::length): (WebCore::CSSRuleList::item): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::insertRule):
• css/CSSRuleList.h:

2:31 PM Changeset in webkit [30129] by hyatt@apple.com

• 3 adds in trunk/LayoutTests/platform/mac/fast/css

Add layout test for bug 17082.

2:31 PM Changeset in webkit [30128] by hyatt@apple.com

• 1 add in trunk/LayoutTests/fast/css/live-cssrules.html

Add layout test for bug 17082.

2:30 PM Changeset in webkit [30127] by hyatt@apple.com

• 4 edits in trunk/WebCore

Fix for bug 17253. <iframe> contents need to be reflected into the DOM as a single text node.

Reviewed by olliej

fast/frames/iframe-text-contents.html

• html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseTag):
• html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::inIFrame): (WebCore::HTMLTokenizer::State::setInIFrame): (WebCore::HTMLTokenizer::State::inAnySpecial): (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling): (WebCore::HTMLTokenizer::State::):

2:29 PM Changeset in webkit [30126] by hyatt@apple.com

• 3 adds in trunk/LayoutTests/platform/mac/fast/frames

Add layout tests for 17253.

2:29 PM Changeset in webkit [30125] by hyatt@apple.com

• 1 add in trunk/LayoutTests/fast/frames/iframe-text-contents.html

Add layout tests for 17253.

1:28 PM Changeset in webkit [30124] by Darin Adler

• 4 edits
  1 copy in trunk/LayoutTests

• fix a couple of directories that were using our JavaScript template/wrapper system incorrectly

• fast/dom/SelectorAPI/resources/TEMPLATE.html: Fixed relative paths.
• fast/events/event-instanceof.html: Regenerating this file revealed that the path to the stylesheet was wrong. Fixed by running the make-js-test-wrappers script. Didn't affect the text-only results, but the test looked wrong in the browser.
• fast/events/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
• traversal/resources/TEMPLATE.html: Fixed relative paths.

12:13 PM Changeset in webkit [30123] by Darin Adler

• 6 edits in trunk

WebCore:

Reviewed and tweaked by Darin.

DOMRange.surroundContents throws wrong exception (Acid3 bug)
​http://bugs.webkit.org/show_bug.cgi?id=16749

Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
has offsets in characters.

• dom/Range.cpp: (WebCore::Range::surroundContents):

LayoutTests:

Reviewed and tweaked a bit by Darin.

DOMRange.surroundContents throws wrong exception (Acid3 bug)
​http://bugs.webkit.org/show_bug.cgi?id=16749

Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
has offsets in characters

• fast/dom/Range/range-exceptions-expected.txt: Added.
• fast/dom/Range/resources/range-exceptions.js: Added.

11:27 AM Changeset in webkit [30122] by Darin Adler

• 102 edits in trunk

JavaScriptCore:

Reviewed by Eric.

• ​http://bugs.webkit.org/show_bug.cgi?id=17256 Make clients of RefCounted explicitly set the count to 0.

• API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass):
• bindings/runtime_root.cpp: (KJS::Bindings::RootObject::RootObject):

WebCore:

Reviewed by Eric.

• ​http://bugs.webkit.org/show_bug.cgi?id=17256 Make clients of RefCounted explicitly set the count to 0.

• bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapper::JSSVGPODTypeWrapper):
• css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace):
• css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList):
• css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
• css/Counter.h: (WebCore::Counter::Counter):
• css/Pair.h: (WebCore::Pair::Pair):
• css/Rect.h: (WebCore::Rect::Rect):
• css/StyleBase.h: (WebCore::StyleBase::StyleBase):
• css/StyleSheetList.cpp: (WebCore::StyleSheetList::StyleSheetList):
• dom/Attr.cpp: (WebCore::Attr::Attr):
• dom/Attr.h:
• dom/Attribute.h: (WebCore::Attribute::Attribute):
• dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
• dom/DOMImplementation.h: (WebCore::DOMImplementation::DOMImplementation):
• dom/Event.cpp: (WebCore::Event::Event):
• dom/EventListener.h: (WebCore::EventListener::EventListener):
• dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
• dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
• dom/NamedNodeMap.h: (WebCore::NamedNodeMap::NamedNodeMap):
• dom/NodeFilter.h: (WebCore::NodeFilter::NodeFilter):
• dom/NodeFilterCondition.h: (WebCore::NodeFilterCondition::NodeFilterCondition):
• dom/NodeList.h: (WebCore::NodeList::NodeList):
• dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): (WebCore::QualifiedName::ref):
• dom/Range.cpp: (WebCore::Range::Range):
• dom/RegisteredEventListener.cpp: (WebCore::RegisteredEventListener::RegisteredEventListener):
• dom/StyledElement.h:
• dom/Traversal.cpp: (WebCore::Traversal::Traversal):
• editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand):
• history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList):
• history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
• history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
• html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient):
• html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
• html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle):
• html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection):
• html/MediaError.h: (WebCore::MediaError::MediaError):
• html/TimeRanges.cpp: (TimeRanges::TimeRanges):
• html/TimeRanges.h: (WebCore::TimeRanges::TimeRanges):
• html/VoidCallback.h: (WebCore::VoidCallback::VoidCallback):
• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
• loader/FormState.cpp: (WebCore::FormState::FormState):
• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder):
• loader/icon/IconRecord.cpp: (WebCore::IconRecord::IconRecord):
• page/BarInfo.cpp: (WebCore::BarInfo::BarInfo):
• page/Console.cpp: (WebCore::Console::Console):
• page/DOMSelection.cpp: (WebCore::DOMSelection::DOMSelection):
• page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow):
• page/Frame.cpp: (WebCore::Frame::Frame):
• page/History.cpp: (WebCore::History::History):
• page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
• page/Plugin.h: (WebCore::Plugin::Plugin):
• page/Screen.cpp: (WebCore::Screen::Screen):
• platform/ArrayImpl.cpp: (WebCore::ArrayImpl::ArrayPrivate::ArrayPrivate):
• platform/DeprecatedValueListImpl.cpp: (WebCore::DeprecatedValueListImpl::Private::Private):
• platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar):
• platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer):
• platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList):
• platform/graphics/FontFamily.cpp: (WebCore::FontFamily::FontFamily):
• platform/graphics/FontFamily.h: (WebCore::FontFamily::FontFamily):
• platform/graphics/FontSelector.h: (WebCore::FontSelector::FontSelector): (WebCore::FontSelector::~FontSelector):
• platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::GlyphPage):
• platform/graphics/mac/IconMac.mm: (WebCore::Icon::Icon):
• platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
• platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu):
• platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::SharedBuffer):
• platform/network/FormData.cpp: (WebCore::FormData::FormData):
• platform/network/FormData.h: (WebCore::FormData::FormData):
• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle):
• platform/text/CString.h: (WebCore::CStringBuffer::CStringBuffer):
• platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::Private):
• rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
• rendering/RenderStyle.h: (WebCore::TransformOperation::TransformOperation): (WebCore::CursorList::CursorList):
• rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGCharOnPath::SVGCharOnPath):
• rendering/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
• rendering/SVGRenderStyle.h: (WebCore::SVGRenderStyle::SVGRenderStyle):
• rendering/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
• storage/SQLResultSetRowList.h: (WebCore::SQLResultSetRowList::SQLResultSetRowList):
• svg/SVGAngle.cpp: (WebCore::SVGAngle::SVGAngle):
• svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
• svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
• svg/SVGList.h: (WebCore::SVGList::SVGList): (WebCore::SVGPODListItem::SVGPODListItem):
• svg/SVGPathSeg.h: (WebCore::SVGPathSeg::SVGPathSeg):
• svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
• svg/SVGRenderingIntent.h: (WebCore::SVGRenderingIntent::SVGRenderingIntent):
• svg/SVGUnitTypes.h: (WebCore::SVGUnitTypes::SVGUnitTypes):
• svg/graphics/SVGPaintServerGradient.h: (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
• svg/graphics/SVGResource.cpp: (WebCore::SVGResource::SVGResource):
• xml/DOMParser.h: (WebCore::DOMParser::DOMParser):
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest):
• xml/XMLSerializer.h: (WebCore::XMLSerializer::XMLSerializer):
• xml/XPathEvaluator.h: (WebCore::XPathEvaluator::XPathEvaluator):
• xml/XPathExpression.h: (WebCore::XPathExpression::XPathExpression):
• xml/XPathNSResolver.h: (WebCore::XPathNSResolver::XPathNSResolver):
• xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
• xml/XPathValue.h: (WebCore::XPath::ValueData::ValueData):
• xml/XSLTProcessor.h: (WebCore::XSLTProcessor::XSLTProcessor):

11:02 AM Changeset in webkit [30121] by kevino@webkit.org

• 2 edits in trunk/WebCore

Don't call select() for CURL when there are no valid file descriptors.
​http://bugs.webkit.org/show_bug.cgi?id=17178

10:57 AM Changeset in webkit [30120] by Darin Adler

• 2 edits in trunk/WebKit/mac

• fix ​http://bugs.webkit.org/show_bug.cgi?id=17274 REGRESSION: User Agent string broken in r30119

• WebView/WebView.mm: (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Fix wrong variable name. Doh!