Timeline



Jun 9, 2002:

10:32 PM Changeset in webkit [1316] by sullivan
  • 14 edits in trunk/WebKit

WebKit part of fix for 2949646 (Can't drag & drop bookmarks
into auto-expanded folder). To get this to work right, I gave
each bookmark a unique (per-session) identifier.

While working on this, I found and fixed some leaks of bookmarks.

  • Bookmarks.subproj/IFBookmark.h: New -[identifier] method and _identifier ivar.
  • Bookmarks.subproj/IFBookmark.m: (+[IFBookmark _generateUniqueIdentifier]): (-[IFBookmark init]): (-[IFBookmark dealloc]): Remember unique identifier in each bookmark as it is created; delete when dealloc'd.

(-[IFBookmark identifier]): Return unique identifier.

(-[IFBookmark _setParent:]): Don't retain parent, to avoid
circular ownership.

(-[IFBookmark _setGroup:]): Tell coming and going group.

  • Bookmarks.subproj/IFBookmarkGroup.h: New +[bookmarkForIdentifier] method and _bookmarksByID ivar.
  • Bookmarks.subproj/IFBookmarkGroup_Private.h: Declarations of _removedBookmark: and _addedBookmark:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup initWithFile:]): alloc _bookmarksByID. (-[IFBookmarkGroup dealloc]): release _bookmarksByID. (-[IFBookmarkGroup _setTopBookmark:]): Don't bail out early; would now cause leak. (-[IFBookmarkGroup _removedBookmark:]): New method, removes bookmark from _bookmarksByID. (-[IFBookmarkGroup _addedBookmark:]): New method, adds bookmark to _bookmarksByID. (-[IFBookmarkGroup bookmarkForIdentifier:]): Looks up bookmark from _bookmarksByID dictionary. (-[IFBookmarkGroup _loadBookmarkGroupGuts]): autorelease newTopbookmark; this had been leaking.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList _initFromDictionaryRepresentation:withGroup:]): autorelease children before adding them to parent; this had been leaking.

WebBrowser part of fix for 2949646 (Can't drag & drop bookmarks into
auto-expanded folder).

While working on this, I found and fixed some other unreported bugs, including
leaks of bookmarks.

  • BookmarksController.m: (-[BookmarksController windowDidLoad]): Use BookmarkIDListPboardType rather than RowListPboardType.

(-[BookmarksController _endEditing]),
(-[BookmarksController _toggleEdit:]): Broke _endEditing out of _toggleEdit so
it could be called by itself.

(-[BookmarksController _safeRemoveBookmark:]): Workaround for NSOutlineView bug
where removing expanded items leaks.

(-[BookmarksController removeSelectedBookmarks:]),
(-[BookmarksController _redoRemoveBookmarks:]): Call _endEditing to avoid problem
when removing a bookmark that's being edited; call _safeRemoveBookmark to prevent
leak.

(-[BookmarksController _anyAncestorOfRow:inArray:]): removed.
(-[BookmarksController _identifierOfBookmarkOrAnyAncestor:inArray:]):
Changed name from _rowOrAnyAncestor:inArray:, now deals with array of bookmark
identifiers rather than array of row numbers.

(-[BookmarksController outlineView:writeItems:toPasteboard:]),
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]),
(-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Reworked to use
array of bookmark identifiers rather than array of row numbers.

  • Preferences.subproj/English.lproj/ActiveContentPreferences.nib: Added 2nd sentence to "allow JavaScript to open windows automatically" preference at Maciej's wise suggestion.
9:40 PM Changeset in webkit [1315] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Fixed a possible uninitialized variable problem that the compiler and Don caught.
2:16 PM Changeset in webkit [1314] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Add code to handle drawing when are more than LOCAL_GLYPH_BUFFER_SIZE advances. I ran into this loading <http://jersey.apple.com/data/20020606-074404M0.html>. Also fix handling of advances for the obscure case where we hit a non-base character, slowPackGlyphsForCharacters fails, and substituteFontforCharacters returns nil.

Jun 7, 2002:

11:48 PM Changeset in webkit [1313] by darin
  • 11 edits in trunk
  • Makefile.am: Use new shared "embed.am" file so we don't need four copies of the embedding rules for WebFoundation, JavaScriptCore, WebCore, and WebKit.
5:53 PM Changeset in webkit [1312] by mjs
  • 6 edits in trunk/WebCore
  • Tests/libiftest/Makefile.am: Make libiftest a static lib, to avoid concerns over non-libtool libraries named .dylib.

WebCore:

  • Makefile.am: Rename libwebcore.dylib to libwebcore.a; since this target is just a fake for dependency purposes, it doesn't matter what it's called.
  • .cvsignore: Update ignorance.
4:04 PM Changeset in webkit [1311]
  • 2 copies
    38 deletes in branches/jaguar-branch

This commit was manufactured by cvs2svn to create branch
'jaguar-branch'.

4:04 PM Changeset in webkit [1310]
  • 1 copy
    39 deletes in tags/WebFoundation-6~4

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~4'.

4:04 PM Changeset in webkit [1309]
  • 1 copy
    39 deletes in tags/WebFoundation-6~3

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~3'.

4:04 PM Changeset in webkit [1308]
  • 1 copy
    39 deletes in tags/WebFoundation-6~2

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~2'.

4:04 PM Changeset in webkit [1307]
  • 1 copy
    39 deletes in tags/WebFoundation-6~1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~1'.

4:04 PM Changeset in webkit [1306]
  • 1 copy
    39 deletes in tags/WebFoundation-6_1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6_1'.

4:04 PM Changeset in webkit [1305]
  • 1 copy
    39 deletes in tags/WebFoundation-6

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6'.

4:04 PM Changeset in webkit [1304]
  • 2 copies
    38 deletes in tags/JAGUAR_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'JAGUAR_BRANCH_ANCHOR'.

4:04 PM Changeset in webkit [1303] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2949680 (IFURLFileDatabase will not work properly with hard disk quotas)

Rearranges calls through to the code that expires files from the disk cache
when the quota is exceeded. Now, files are deleted before writing a new cache
entry, rather than writing the file first, and deleting files to get back under
the quota.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase performSetObject:forKey:])
3:59 PM Changeset in webkit [1302] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2948819 (Disk cache emptying can be cut off by quitting program)

We kick a thread to delete the disk cache (in order for the cache emptying
function to return immediately). This involves moving the disk cache
directory aside and creating a new (empty) disk cache directory. If a user
quits the apps before the aside directory is completely deleted, it is
orphaned.

This patch does a check upon next startup for such orphaned files and
resumes the delete operation.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase open])
  • Misc.subproj/IFNSFileManagerExtensions.h:
  • Misc.subproj/IFNSFileManagerExtensions.m: (-[NSFileManager _IF_deleteBackgroundRemoveLeftoverFiles:])
3:58 PM Changeset in webkit [1301] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2936755 (.size can get out of synch with actual cache size on disk)

Four separate fixes to make sure the .size file stays in sync with the
cumulative size of the cache files on disk.

These fixes are:

1) Check that usage decrease when a file is removed is only done when removal succeeds.
2) Account for a cache file that gets rewritten to disk with a different size

than the file it is replacing.

3) Remove pending disk operations when the user clears the cache.
4) Make sure usage gets set back to zero on a cache clear.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase writeSizeFile:]) (-[IFURLFileDatabase removeAllObjects]) (-[IFURLFileDatabase performSetObject:forKey:]) (-[IFURLFileDatabase performRemoveObjectForKey:])
3:48 PM Changeset in webkit [1300] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2936676 (IFURLFileDatabase should be smarter about expiring cache files)

This patch adds code to generate a list of cache files sorted by file system
access time. This list is then used to expire least recently used cache
files first.

  • Database.subproj/IFURLFileDatabase.m: (compare_atimes): New function (IFPtrEqual): New function (IFFileAccessTimeRelease): New function (CreateArrayListingFilesSortedByAccessTime): New function (-[IFURLFileDatabase truncateToSizeLimit:]): Uses new functions
3:42 PM Changeset in webkit [1299] by darin
  • 18 edits in trunk/WebCore
  • Makefile.am: I was running into failures in the embed rule, so I made it always remove the framework before copying the new one in. This is better for cases where a header was removed, too, so maybe we should do this in the other directories.
  • kwq/KWQDrawUtil.mm:
  • kwq/KWQKComboBox.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKDebug.mm:
  • kwq/KWQKMessageBox.mm:
  • kwq/KWQKMimeType.mm:
  • kwq/KWQKPrinter.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQObject.mm:
  • kwq/KWQRegExp.mm:
  • kwq/KWQRegion.mm:
  • kwq/KWQScrollView.mm:
  • kwq/KWQStringList.mm: Remove repeated default values for parameters -- the new compiler won't allow these and they are illegal C++.
3:42 PM Changeset in webkit [1298] by darin
  • 3 edits in trunk/WebKit
  • MIME.subproj/IFContentHandler.m: (-[IFContentHandler HTMLDocument]): Fix a warning that shows up with the new C++ compiler (not sure why it is not showing up with the old one).
3:02 PM Changeset in webkit [1297] by cblu
  • 4 edits in trunk/WebKit

Allow plug-ins to make a NPP_*URLNotify request when
the target is _self, _top, _parent or _current. This goes
against the plug-in documentation, but mimics IE.
Need for iTools.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]):
2:23 PM Changeset in webkit [1296] by mjs
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by: Ken Kocienda

Fixed the following bugs:

Radar 2854498 - Cookies are not saved between sessions
Radar 2862120 - -[IFCookie dictionaryRepresentation] is not yet implemented
Radar 2949513 - Session-only cookies should not be saved persistently
Radar 2949514 - Cookies need to be synchronized between multiple processes

Also, I moved the optimistic first try code for creating
directories and files with intermediate directories from the call
points to the functions themselves.

  • CookieManager.subproj/IFCookie.h:
  • CookieManager.subproj/IFCookie.m: (setExpires): (-[IFCookie dictionaryRepresentation]): (+[IFCookie _requestHeadersFromCookieArray:]): (+[IFCookie _cookieArrayFromResponseHeaders:forURL:]): (-[IFCookie _compareForHeaderOrder:]): (-[IFCookie _key]): (-[IFCookie _isExpired]):
  • CookieManager.subproj/IFCookieManager.m: (-[IFCookieManagerPrivate init]): (-[IFCookieManagerPrivate dealloc]): (-[IFCookieManager _registerForCookiePreferenceNotification]): (-[IFCookieManager _connectToCookieStorage]): (setUpOnLoadThread): (runningOnLoadThread): (-[IFCookieManager _scheduleSetupOnLoadThread]): (-[IFCookieManager _waitForLoadThreadSetup]): (-[IFCookieManager _continueSetCookies:context:]): (-[IFCookieManager _internalInit]): (-[IFCookieManager _cookieRequestHeadersForURL:withExtraCookies:]): (-[IFCookieManager cookies]): (-[IFCookieManager setCookie:]): (-[IFCookieManager deleteCookie:]): (-[IFCookieManager setCookiesFromResponseHeaders:forURL:]): (-[IFCookieManager description]):
  • CookieManager.subproj/IFCookiePrivate.h:
  • CookieManager.subproj/IFCookieStorage.h: Added.
  • CookieManager.subproj/IFCookieStorage.m: Added. (-[IFCookieStoragePrivate init]): (-[IFCookieStoragePrivate dealloc]): (-[IFCookieStorage _updateCookiesFromServer]): (-[IFCookieStorage _connectionDidDie:]): (-[IFCookieStorage _establishConnection]): (-[IFCookieStorage init]): (-[IFCookieStorage initWithNotificationObject:]): (-[IFCookieStorage dealloc]): (-[IFCookieStorage setCookies:]): (-[IFCookieStorage deleteCookies:]): (-[IFCookieStorage cookies]): (-[IFCookieStorage cookiesMatchingDomain:path:secure:]):
  • CookieManager.subproj/IFCookieStorageServer.h: Added.
  • CookieManager.subproj/IFCookieStorageServer.m: Added. (-[IFCookieStorageServerPrivate init]): (-[IFCookieStorageServerPrivate dealloc]): (-[IFCookieStorageServer _checkForCookieExpiration:]): (-[IFCookieStorageServer _updateExpirationTimer:]): (-[IFCookieStorageServer _saveCookies]): (-[IFCookieStorageServer _saveCookiesIfScheduled]): (-[IFCookieStorageServer _scheduleSave]): (-[IFCookieStorageServer _notifyChanged]): (-[IFCookieStorageServer _setCookiesWithoutSaving:]): (-[IFCookieStorageServer init]): (-[IFCookieStorageServer dealloc]): (-[IFCookieStorageServer setCookies:]): (-[IFCookieStorageServer deleteCookies:]): (-[IFCookieStorageServer cookies]): (makeCookie): (-[IFCookieStorageServer loadCookies]):
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase performSetObject:forKey:]): (-[IFURLFileDatabase open]):
  • Misc.subproj/IFNSArrayExtensions.h:
  • Misc.subproj/IFNSArrayExtensions.m:
  • Misc.subproj/IFNSFileManagerExtensions.m: (-[NSFileManager _IF_createDirectoryAtPathWithIntermediateDirectories:attributes:]): (-[NSFileManager _IF_createFileAtPathWithIntermediateDirectories:contents:attributes:directoryAttributes:]):
  • WebFoundation.pbproj/project.pbxproj:
1:02 PM Changeset in webkit [1295] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQPtrDictImpl.h: Use CoreFoundation.h -- new compiler is picky about the difference between struct and typedef.
  • kwq/KWQValueListImpl.h: Add a friend declaration that we need because the new compiler is more strict.
  • fix 2949882 -- joecartoon.com crashes
  • khtml/ecma/kjs_window.cpp: (Window::get): Turn off some code that doesn't work for us -- similar to code elsewhere in this file that was also turned off.
12:59 PM Changeset in webkit [1294] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Don't use any warning flags for C that won't work for C++, because PFE uses the C warning flags on a C++ compile.
12:59 PM Changeset in webkit [1293] by darin
  • 4 edits in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Don't use any warning flags for C that won't work for C++, because PFE uses the C warning flags on a C++ compile.
12:49 PM Changeset in webkit [1292] by cblu
  • 60 edits
    9 adds
    4 deletes in trunk

Summary

Made IFWebController a class.
Fixed all places where IFWebController was referred to as a protocol.
Renamed IFBaseWebController files to IFWebController.
IFWebController.h replaces IFWebBaseController.h.

Added support for IEPL plug-ins.

WebCore:

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame):
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
  • kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[URLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::serveRequest):
  • kwq/external.h:

WebKit:

  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels _didStartLoadingURL:inController:]): (-[IFStandardPanels _didStopLoadingURL:inController:]):
  • Panels.subproj/IFStandardPanelsPrivate.h:
  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin _getPluginInfoForResourceFile:]): (-[IFPlugin initWithPath:]): (-[IFPlugin load]): (-[IFPlugin description]):
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]):
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView webController]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFBaseWebController.h: Removed.
  • WebView.subproj/IFBaseWebController.mm: Removed.
  • WebView.subproj/IFBaseWebControllerPrivate.h: Removed.
  • WebView.subproj/IFBaseWebControllerPrivate.mm: Removed.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: Added. (-[IFWebController init]): (-[IFWebController initWithView:provisionalDataSource:]): (-[IFWebController dealloc]): (-[IFWebController setDirectsAllLinksToSystemBrowser:]): (-[IFWebController directsAllLinksToSystemBrowser]): (-[IFWebController createFrameNamed:for:inParent:inScrollView:]): (-[IFWebController setStatusText:forDataSource:]): (-[IFWebController statusTextForDataSource:]): (-[IFWebController openNewWindowWithURL:]): (-[IFWebController receivedProgress:forResource:fromDataSource:]): (-[IFWebController receivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController provideLocationChangeHandlerForFrame:]): (-[IFWebController receivedPageTitle:forDataSource:]): (-[IFWebController serverRedirectTo:forDataSource:]): (-[IFWebController _frameForDataSource:fromFrame:]): (-[IFWebController frameForDataSource:]): (-[IFWebController _frameForView:fromFrame:]): (-[IFWebController frameForView:]): (-[IFWebController frameNamed:]): (-[IFWebController mainFrame]): (-[IFWebController pluginNotFoundForMIMEType:pluginPageURL:]): (-[IFWebController provideLocationChangeHandlerForFrame:andURL:]): (-[IFWebController URLPolicyForURL:]): (-[IFWebController unableToImplementURLPolicyForURL:error:]): (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]): (-[IFWebController stopAnimatedImages]): (-[IFWebController startAnimatedImages]): (-[IFWebController stopAnimatedImageLooping]): (-[IFWebController startAnimatedImageLooping]):
  • WebView.subproj/IFWebControllerPrivate.h: Added.
  • WebView.subproj/IFWebControllerPrivate.mm: Added. (-[IFWebControllerPrivate init]): (-[IFWebControllerPrivate _clearControllerReferences:]): (-[IFWebControllerPrivate dealloc]): (-[IFWebController _receivedProgress:forResource:fromDataSource:]): (-[IFWebController _mainReceivedProgress:forResource:fromDataSource:]): (-[IFWebController _receivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController _mainReceivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController _didStartLoading:]): (-[IFWebController _didStopLoading:]):
  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource controller]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setController:]):
  • WebView.subproj/IFWebFrame.h:
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:view:provisionalDataSource:controller:]): (-[IFWebFrame controller]): (-[IFWebFrame setController:]): (-[IFWebFrame frameNamed:]):
  • WebView.subproj/IFWebFramePrivate.h:
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate setController:]): (-[IFWebFrame _setController:]):
  • WebView.subproj/IFWebView.h:
  • WebView.subproj/IFWebView.mm: (-[IFWebView controller]):
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _setController:]):

WebBrowser:

  • BrowserDocument.h:
  • WebController.h:
  • WebController.m: (-[WebController openNewWindowWithURL:]):
12:13 PM Changeset in webkit [1291]
  • 3 copies
    1 delete in tags/Alexander-8

This commit was manufactured by cvs2svn to create tag 'Alexander-8'.

12:13 PM Changeset in webkit [1290] by sheridan
  • 5 edits in trunk

Alexander-8 version

12:03 PM Changeset in webkit [1289] by sheridan
  • 3 edits in trunk/JavaScriptCore

Alexander-8 version

8:56 AM Changeset in webkit [1288] by darin
  • 5 edits in trunk/WebCore

Try to make Jersey work again.

  • kwq/KWQInvisibleButton.h: Simplify includes.
  • kwq/KWQInvisibleButton.mm: Simplify includes.

Jun 6, 2002:

9:39 PM Changeset in webkit [1287] by darin
  • 9 edits in trunk
  • Makefile.am: Update warning flags for compatibility with new C++.
  • configure.in: Update warning flags for compatibility with new C++.
  • Tools/DiskCachePeek/DiskCachePeek.pbproj/project.pbxproj: Project Builder wants what it wants.

JavaScriptCore:

  • JavaScriptCore.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebKit:

  • WebKit.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.
  • WebCoreSupport.subproj/IFTextRenderer.m: (FillStyleWithAttributes): Remove workaround we copied from AppKit, because it's a workaround for a bug that was fixed in Puma.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.
3:58 PM Changeset in webkit [1286] by cblu
  • 4 edits in trunk/WebKit

2002-06-06 Chris Blumenberg <cblu@apple.com>

Added support for key codes and other encodings.
Send activate to make Java happy.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView keyMessageForEvent:]): added (-[IFPluginView keyUp:]): use above. (-[IFPluginView keyDown:]): use above. (-[IFPluginView windowBecameKey:]): send activate. (-[IFPluginView windowResignedKey:]): send activate.
11:55 AM Changeset in webkit [1285] by sullivan
  • 4 edits in trunk/WebKit

Previous commit didn't seem to take for some reason; trying again.

  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList removeChild:]): Added assert. (-[IFBookmarkList insertChild:atIndex:]): Set the group of the new child, and added assert.

Added Undo in the Bookmarks window for removing items and for changing
the titles and addresses of items. Also changed the image used for
Stop in the Bookmarks window per a conversation with Don and Chris
yesterday.

  • fixed 2927231 -- should be able to Undo deleting bookmarks
  • fixed 2948496 -- should be able to Undo title & address changes in Bookmarks window
  • BookmarksController.m: (-[UndoRemoveInfo initWithBookmark:]), (-[UndoRemoveInfo dealloc]), (+[UndoRemoveInfo infoWithBookmark:]): New little helper class that hangs onto the info needed to put removed bookmarks back in the right places.

(-[BookmarksController _redoRemoveBookmarks:]),
(-[BookmarksController _undoRemoveBookmarks:]): New methods
(-[BookmarksController removeSelectedBookmarks:]): Register for undo.

(-[BookmarksController _undoTitleChange:]),
(-[BookmarksController _changeTitleForBookmark:to:]),
(-[BookmarksController _undoAddressChange:]),
(-[BookmarksController _changeAddressForBookmark:to:]),
New methods used for undo/redo.

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
Register for Undo, but only if the value has actually changed.

(-[BookmarksController windowWillClose:]): Empty undo/redo stack.

  • Resources/Images/red_globe.tiff: Added, used by Stop in Downloads window.
  • Resources/Images/green_globe.tiff: Added, to be used by Resume in Downloads window.
  • Resources/Images/stop.tiff: Removed.
  • DownloadMonitor.m: (-[DownloadMonitor toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Use new Stop image.
  • WebBrowser.pbproj/project.pbxproj: Updated for new image files.
8:18 AM Changeset in webkit [1284] by darin
  • 9 edits in trunk/WebKit
  • MIME.subproj/IFContentHandler.m: (-[IFContentHandler initWithURL:MIMEType:MIMEHandlerType:]): Add call to [super init]. (-[IFContentHandler useTemplate:withGlobal:]): New helper function. Also got rid of <title> from templates, since there's no need for us to provide a fake title if it's just the URL. (-[IFContentHandler HTMLDocument]): Reduce use of copied and pasted code. (-[IFContentHandler dealloc]): Add call to [super dealloc].
  • Resources/image_document_template.html: Remove <title>.
  • Resources/plugin_document_template.html: Remove <title>.
  • Resources/text_document_template.html: Remove <title>.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]): Remove some unneeded type casts.

Jun 5, 2002:

5:45 PM Changeset in webkit [1283] by mjs
  • 6 edits in trunk/WebKit

Fixed Radar 2936155 - crash in IFAuthenticationPanel

  • Panels.subproj/IFAuthenticationPanel.m: (-[IFAuthenticationPanel runAsSheetOnWindow:withRequest:]): Add some assertions.

(-[IFAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
Avoid referencing instance variables after performing a selector
that might release this object. Also, add some assertions.

  • Panels.subproj/IFPanelAuthenticationHandler.m: (-[IFPanelAuthenticationHandler startAuthentication:]): Tweak whitespace.
5:33 PM Changeset in webkit [1282] by darin
  • 14 edits in trunk/WebCore

Some fixes to speed up the citibank.com page, and other related changes.

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Only do a layout if it's actually needed. This speeds things up immensely, and I'm pretty sure it's correct.
  • kwq/KWQListImpl.h: To speed things up, get rid of the "private part" level of indirection. This is particularly vital for list iterators, which are created and destroyed a lot on the stack. Also made trivial functions be inline.
  • kwq/KWQListImpl.mm: (copyList): Now a static function rather than a member of the now-defunct private class. (KWQListImpl::KWQListImpl): Set up all the new members that used to be in the separate private object. (KWQListImpl::~KWQListImpl): Update the iterator-detaching code to do it the new way, with intrusive list. Also, use clear() instead of having our own code to delete the list -- note this is only used after the level above us does a clear() anyway. (KWQListImpl::clear): Use a loop to delete all the nodes rather than making a delete of one node recursively delete the next -- iteration is more efficient, and also easier to understand in this case. Also update all the iterators so they don't point to deleted nodes. (KWQListImpl::containsRef): Update to return the count, rather than just a true or false value, since that's how the class is defined. (KWQListImpl::assign): Delete the items if asked to (fixes a FIXME). Also use a new swap member function since there's more to swap now. (KWQListImpl::addIterator): Rewrite to use an intrusive linked list. (KWQListImpl::removeIterator): Rewrite to use an intrusive linked list; this makes it much faster since it doesn't have to search the list. (KWQListImpl::swap): Implement this private member function used by assign. (KWQListIteratorImpl::KWQListIteratorImpl): Set up the new members that used to be in the separate private object.
  • kwq/qt/qlist.h: Re-add the operator= definition. This would cause a storage leak, although I haven't actually observed the leak.
  • kwq/qt/qbuffer.h: Initialize opened to false. This was causing a test failure.
  • kwq/KWQDictImpl.h:
  • kwq/KWQDictImpl.mm: Streamline implementation a bit by getting rid of unneeded copy constructor definition and making trivial constructor for iterator inline.
  • kwq/KWQPtrDictImpl.h: Remove unneeded include.
  • WebCore-tests.exp: Update for changes in the entry points used by the tests.
4:49 PM Changeset in webkit [1281] by rjw
  • 4 edits in trunk/WebKit

Fixed snafu in recursion over frame tree.

4:49 PM Changeset in webkit [1280] by rjw
  • 8 edits in trunk/WebCore

Fixed 2938552. This required an implementation of KHTMLPart::frames which
is used by the JS window.frames property.

2:22 PM Changeset in webkit [1279] by darin
  • 4 edits in trunk/JavaScriptCore

Fix problem seen as build failure on Jersey.

  • Makefile.am: JavaScriptCore-stamp needs to be a dependency, not a source file, because it doesn't have a corresponding object file. Making it a dependency causes things to compile in the right order.
2:14 PM Changeset in webkit [1278] by rjw
  • 8 edits in trunk/WebCore

Fixed window.top JS property (2939353). This caused funny recursion problems at www.megapixel.net and other pages that try to pop frames.

1:25 PM Changeset in webkit [1277] by rjw
  • 6 edits in trunk/WebCore

Cleaned up call to frameNamed:. Now use frame relative naming.
Fixed various frame related bugs (including www.heinz.com).

1:24 PM Changeset in webkit [1276] by rjw
  • 5 edits in trunk/WebKit

i Normalized frame naming. (We still don't support cross

window name lookups.)

Note: See TracTimeline for information about the timeline view.