Jun 14, 2002:

7:28 PM Changeset in webkit [1366] by rjw
  • 11 edits in trunk/WebKit

i Removed redundant private _isDocumentHTML method.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _addError:forResource:]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
7:12 PM Changeset in webkit [1365] by rjw
  • 7 edits in trunk/WebCore

Changed IFResourceProgressHandler to pass back resource handle instead of
string description. This will address the needs descibed in 2954160.

  • kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::serveRequest):
  • kwq/external.h:
7:12 PM Changeset in webkit [1364] by rjw
  • 45 edits in trunk/WebKit

Added handlers to IFWebController. Should eventually be possible to use
IFWebController w/o subclassing.

Changed IFResourceProgressHandler to pass back resource handle instead of
string description. This will address the needs descibed in 2954160.

Fixed many incorrect references to datasource reps.

  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]):
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebDataSource _bridge]): (-[IFWebCoreBridge createNewFrameNamed:withURL:renderPart:khtml::allowsScrolling:marginWidth:marginHeight:]):
  • WebView.subproj/IFDocument.h:
  • WebView.subproj/IFHTMLRepresentation.h:
  • WebView.subproj/IFHTMLRepresentationPrivate.h:
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): (-[IFHTMLView viewWillStartLiveResize]): (-[IFHTMLView viewDidEndLiveResize]):
  • WebView.subproj/IFImageView.m:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController createFrameNamed:for:inParent:allowsScrolling:]): (-[IFWebController setResourceProgressHandler:]): (-[IFWebController resourceProgressHandler]): (-[IFWebController setPolicyHandler:]): (-[IFWebController policyHandler]): (+[IFWebController defaultURLPolicyForURL:]):
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:]): (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:]): (-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): (-[IFWebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource representation]): (-[IFWebDataSource isDocumentHTML]): (-[IFWebDataSource documentTextFromDOM]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): (-[IFWebDataSource _setRepresentation:]): (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _isDocumentHTML]):
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
5:14 PM Changeset in webkit [1363] by darin
  • 2 edits in trunk/WebKit

real, not read

5:13 PM Changeset in webkit [1362] by darin
  • 5 edits
    4 adds
    2 deletes in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: Use the read PTHREAD_ONCE_INIT, remove the workaround for 2905545.
  • IFWebCoreBridge.h: Moved into WebCoreSupport.subproj.
  • IFWebCoreBridge.mm: Moved into WebCoreSupport.subproj.
  • WebCoreSupport.subproj/IFWebCoreBridge.h: Moved from top level.
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: Moved from top level.
  • WebKit.pbproj/project.pbxproj: Update for new file locations. Also pass -no-c++filt so we get mangled names (more useful for .exp files), and remove PFE_FILE_C_DIALECTS.
5:12 PM Changeset in webkit [1361] by cblu
  • 15 edits in trunk/WebKit


Only allow source to be shown if HTML

  • BrowserDocument.m: (-[BrowserDocument _isDocumentHTML]): added (-[BrowserDocument validateUserInterfaceItem:]): (-[BrowserDocument viewSource:]):


  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): If content type is the default type and there is no extension, assume HTML.

(-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):

  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm:

Made isDocumentHTML public. Changed where needed.

(-[IFWebDataSource isDocumentHTML]):
(-[IFWebDataSource documentSource]):
(-[IFWebDataSource documentTextFromDOM]):

  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _addError:forResource:]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
4:45 PM Changeset in webkit [1360] by darin
  • 4 edits in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: Fix what I broke last time.
4:32 PM Changeset in webkit [1359] by darin
  • 8 edits in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanelsPrivate frontmostWindowLoadingURL:]): Change to call webView instead of view. Not sure why anyone was able to compile this.
  • Plugins.subproj/IFNullPluginView.mm: Remove include of obsolete WCPluginWidget.h.
  • WebView.subproj/IFHTMLRepresentation.mm: (-[IFHTMLRepresentation part]): Call part instead of KHTMLPart. Not sure why anyone was able to compile this.
4:31 PM Changeset in webkit [1358] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQDateTime.mm: Add ifdefs needed to make Deployment build compile.
4:15 PM Changeset in webkit [1357] by darin
  • 67 edits
    6 adds
    2 deletes in trunk


Add the new bridge class that connects us to WebCore in a nicer way.
Started to use it for some things. More to come.

  • WebKit.pbproj/project.pbxproj:
  • IFWebCoreBridge.h: Added.
  • IFWebCoreBridge.mm: Added.
  • Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler initWithDataSource:]): Call [super init]. (-[IFDownloadHandler dealloc]): Call [super dealloc].
  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender initializeWithNPP:functionPointer:window:]): Call [super init]. (-[IFPluginNullEventSender dealloc]): Call [super dealloc].
  • WebView.subproj/IFDOMNode.mm: (-[IFDOMNode dealloc]): Call [super dealloc].
  • WebView.subproj/IFImageView.m: (-[IFImageView dealloc]): Call [super dealloc].
  • WebView.subproj/IFRenderNode.mm: (-[IFRenderNode dealloc]): Call [super dealloc].
  • WebView.subproj/IFHTMLRepresentation.h: Moved variables into a private structure so this class can be made public.
  • WebView.subproj/IFHTMLRepresentationPrivate.h: Added. Has _bridge method.
  • WebView.subproj/IFHTMLRepresentation.mm: (-[IFHTMLRepresentation init]): Call [super init]. Also use the new private structure, and allocate the IFWebCoreBridge. (-[IFHTMLRepresentation dealloc]): Release the private structure and the IFWebCoreBridge. Also, call [super dealloc]. (-[IFHTMLRepresentation _bridge]): Private method to get to the bridge. (-[IFHTMLRepresentation receivedData:withDataSource:]): Use IFWebCoreBridge.
  • WebView.subproj/IFWebViewPrivate.h: Add _setMarginWidth and _setMarginHeight.
  • WebView.subproj/IFWebDataSourcePrivate.h: Tweak.
  • WebView.subproj/IFWebDataSource.mm: Tweak.
  • History.subproj/IFWebHistoryPrivate.m: Tweak.


Worked on eliminating calls to WebKit. About 3/4 done.

  • WebCore.exp: Export new WebCoreBridge class, fewer other things.
  • WebCorePrefix.h: #include <ostream> in debug builds; we couldn't before because of a PFE bug that has since been fixed (2920556).
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Add a comment explaining our latest change here.
  • khtml/khtml_part.cpp: (KHTMLPart::~KHTMLPart): Fix storage leak by deleting m_hostExtension.
  • khtml/misc/loader.h: Set type properly on client member so we don't have to do so much casting.
  • kwq/KWQKHTMLPartImpl.h: Add getBridge and setBridge, remove setDataSource.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Eliminate m_dataSource. (KWQKHTMLPartImpl::openURLInFrame): Use WebCoreBridge. (KWQKHTMLPartImpl::urlSelected): Use WebCoreBridge. (KWQKHTMLPartImpl::requestFrame): Use WebCoreBridge. (KWQKHTMLPartImpl::requestObject): Move WebCoreViewFactory code here; we don't need an entire WCPluginWidget file just for this function. (KWQKHTMLPartImpl::submitForm): Use WebCoreBridge. (KWQKHTMLPartImpl::frameExists): Use WebCoreBridge. (KWQKHTMLPartImpl::frames): Use WebCoreBridge. (KWQKHTMLPartImpl::setTitle): Use WebCoreBridge. (KWQKHTMLPartImpl::getDataSource): Use WebCoreBridge. (KWQKHTMLPartImpl::parentPart): Use WebCoreBridge.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Use WebCoreBridge.
  • kwq/KWQKloader.mm: Move the part of external.h that we still use in here, with the expectation of eliminating it soon. Also renamed URLLoadClient to KWQURLLoadClient so we don't hog namespace.
  • kwq/qt/qscrollview.h:
  • kwq/KWQScrollView.mm: Used helper functions to do the "documentView" selector thing more consistently.
  • kwq/KWQWidget.mm: Get interface for changing the cursor from WebCoreViewFactory.h instead of from external.h.
  • kwq/WebCoreViewFactory.h:
  • kwq/Makefile.am: Remove WCPluginWidget.mm, add WebCoreBridge.mm.
  • kwq/WCPluginWidget.h: Removed.
  • kwq/WCPluginWidget.mm: Removed.
  • kwq/WebCoreBridge.h: Added.
  • kwq/WebCoreBridge.mm: Added.
  • kwq/qt/qarray.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qcstring.h: Remove <iostream> include since we include <qarray.h>.
  • kwq/qt/qdatetime.h: Replace unconditional <iostream> include with a conditional <ostream> include. Also made streaming operators conditional.
  • kwq/qt/qlist.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qmap.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qpoint.h: Use <iosfwd> instead of <iostream>.
  • kwq/qt/qsize.h: Use <iosfwd> instead of <iostream>.
  • kwq/qt/qvaluelist.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qvector.h: Replace unconditional <iostream> include with a conditional <ostream> include. Also made streaming operators conditional.
3:26 PM Changeset in webkit [1356] by rjw
  • 32 edits in trunk

Lots of frame related cleanup. Added attempt to get
nested scrollbars to work correctly with window's resize
corner. Still not quite right.

Name change [IFWebFrame view] -> [IFWebFrame webView].

  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): (-[IFHTMLView viewDidEndLiveResize]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController initWithView:provisionalDataSource:]): (-[IFWebController createFrameNamed:for:inParent:inScrollView:]): (-[IFWebController _frameForView:fromFrame:]): (-[IFWebController frameForView:]): (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate _clearControllerReferences:]):
  • WebView.subproj/IFWebFrame.h:
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame init]): (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): (-[IFWebFrame setWebView:]): (-[IFWebFrame webView]): (-[IFWebFrame setProvisionalDataSource:]): (-[IFWebFrame reset]):
  • WebView.subproj/IFWebFramePrivate.h:
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate dealloc]): (-[IFWebFramePrivate setWebView:]): (-[IFWebFrame _timedLayout:]): (-[IFWebFrame _transitionProvisionalToCommitted]): (-[IFWebFrame _setState:]): (-[IFWebFrame _isLoadComplete]):

Name change [IFWebFrame view] -> [IFWebFrame webView].

  • BrowserDocument.m: (-[BrowserDocument mainWebView]): (-[BrowserDocument setMainWebView:]):
  • BrowserWindow.m: (-[BrowserWindow frameLoadStarted:]): (-[BrowserWindow frameLoadCommitted:]): (-[BrowserWindow frameLoadRedirected:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _scrollToTop]): (-[LocationChangeHandler _restoreScrollPosition]):

Name change view -> webView.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame):
  • kwq/external.h:
1:54 PM Changeset in webkit [1355] by cblu
  • 4 edits in trunk/WebCore

Put #ifndef APPLE_CHANGES around one line that
was causing EMBED and OBJECT tags to not have render objects.

  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach):
12:58 PM Changeset in webkit [1354] by rjw
  • 8 edits in trunk/WebKit
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]):

Added notification so we can intelligently add/remove
mouse move observation when the window becomes/resigns
main. Also added window close observation so we can
clean up other observers.

(-[IFHTMLView viewWillStartLiveResize]):\

Backed out removal of scroll bars during resize.

(-[IFHTMLView viewDidEndLiveResize]):

Backed out removal of scroll bars during resize.

(-[IFHTMLView windowWillClose:]):
Clean up observers.
(-[IFHTMLView windowDidBecomeMain:]):
Add mouse move observer.
(-[IFHTMLView windowDidResignMain:]):
Remove mouse move observer.
(-[IFHTMLView mouseMovedNotification:]):

Only pay attention to mouse moves for this window.

  • WebView.subproj/IFImageView.m: (-[IFImageView layout]):

Removed unnecessary scroll view setDrawBackground calls.

  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):

Added calls to scroll view setDrawBackground when the view
rect is valid.

11:22 AM Changeset in webkit [1353] by cblu
  • 64 edits in trunk

Enabled displaying of text, images and RTF
Fixed drag & drop
Committing Richard's changes to KWQPainter
Upated types that Alex can open.
Uncommented textFromDOM call.

Jun 13, 2002:

3:46 PM Changeset in webkit [1352]
  • 5 copies
    2 deletes in tags/JavaScriptCore-5_1

This commit was manufactured by cvs2svn to create tag

3:46 PM Changeset in webkit [1351] by mjs
  • 3 edits in branches/jaguar-branch/JavaScriptCore
3:24 PM Changeset in webkit [1350]
  • 5 copies
    2 deletes in tags/JavaScriptCore-5~1

This commit was manufactured by cvs2svn to create tag

3:24 PM Changeset in webkit [1349] by mjs
  • 4 edits in branches/jaguar-branch/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Remove C++ warning flags that a


making JavaScriptCore die in the B & I build.

12:31 PM Changeset in webkit [1348] by sullivan
  • 11 edits
    4 adds in trunk/WebKit

Various changes to better support the pasteboard.

  • Bookmarks.subproj/IFBookmark.h,
  • Bookmarks.subproj/IFBookmark.m: (+[IFBookmark bookmarkOfType:]): New method.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf init]): start out with a non-nil _entry (-[IFBookmarkLeaf setTitle:]): added assert (-[IFBookmarkLeaf setURLString:]): added assert
  • History.subproj/IFURLsWithTitles.h,
  • History.subproj/IFURLsWithTitles.m: (+[IFURLsWithTitles arrayWithIFURLsWithTitlesPboardType]), (+[IFURLsWithTitles writeURLs:andTitles:toPasteboard:]), (+[IFURLsWithTitles titlesFromPasteboard:]), (+[IFURLsWithTitles URLsFromPasteboard:]): New file with methods for reading/writing pasteboard entry representing a list of URLs with associated titles. Used by Bookmarks window and History window in Alexander.
  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate removeEntryForURLString:]): refactored to turn a WEBKITDEBUG into a more-appropriate WEBKIT_ASSERT.
  • WebKit.pbproj/project.pbxproj: Updated for new files.

Many changes for copy/paste & dragging support, and random little tweaks.

  • fixed 2927606 -- Should be able to drag items from History window to Bookmarks
  • BookmarksController.m: (-[BookmarksController _droppablePasteboardTypes]), (-[BookmarksController _pasteablePasteboardTypes]): Added IFURLsWithTitlesPboardType and NSURLPboardType.

(-[BookmarksController _selectedBookmarks]): Renamed from
_selectedBookmarksWithoutRedundantDescendants, and removed the descendant-filtering
code from here (used by some callers instead).
(-[BookmarksController removeSelectedBookmarks:]): Filter results of _selectedBookmarks.
(-[BookmarksController outlineView:writeItems:toPasteboard:]): Added support for writing
BookmarkDictionaryListPboardType, IFURLsWithTitlesPboardType, NSURLPboardType, and
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]):
Split code that sets the drag operation from code that retargets the drop; added support
for NSURLPboardType and IFURLsWithTitlesPboardType.
(+[BookmarksController _addBookmarksFromURLsWithTitlesOnPasteboard:to:]):
New convenience routine.
(-[BookmarksController paste:]),
(-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Add support for
NSURLPboardType and IFURLsWithTitlesPboardType.
(-[BookmarksController copy:]): Just calls outlineView:writeItems:toPasteboard: now
instead of duplicating code.
(-[BookmarksController validateMenuItem:]),
(-[BookmarksController validateUserInterfaceItem:]): Removed all code that modified titles
of Cut/Copy/Paste/Clear items after realizing that this can't work with the Cocoa
responder chain model (no guarantee that the modified titles will be unmodified in other

  • BrowserWindow.m: (-[BrowserWindow windowWillHandleKeyEvent:]): Returns NO always now; this means that BrowserWindow will no longer try to handle Page Up/Down, arrow keys, etc. We can remove this method entirely (and some other stuff) when 2955757 is addressed.
  • GlobalHistory.m: (-[GlobalHistory _entriesFromMixedItems:collapseDates:]): New convenience method that returns an array of history entries from an array containing a potential mix of history entries and calendar dates. (-[GlobalHistory outlineView:writeItems:toPasteboard:]): New method, writes these types to pasteboard: IFURLsWithTitlesPboardType, NSURLPboardType, NSStringPboardType (-[GlobalHistory _selectedItems]), (-[GlobalHistory removeSelectedItems:]): Broke _selectedItems out of removeSelectedItems. (-[GlobalHistory copy:]): New method, calls outlineView:writeItems:toPasteboard: with the selected items. (-[GlobalHistory validateUserInterfaceItem:]): Enable "Copy" if at least one item is selected.
  • LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): Swapped NSURLPboardType and NSStringPboardType so that NSURLPboardType is preferred. (-[LocationFieldEditor concludeDragOperation:]): Use #defines for pasteboard types instead of strings; fix broken use of NSURLPboardType.
  • ResourceProgressEntry.m: (-[ResourceProgressEntry setProgress:]): Improved an error message.
9:12 AM Changeset in webkit [1347] by kocienda
  • 2 edits in trunk/WebKit

2002-06-13 Kenneth Kocienda <kocienda@apple.com>

Fixed typo in ChangeLog comment.

9:00 AM Changeset in webkit [1346] by kocienda
  • 5 edits in trunk/WebKit

2002-06-13 Kenneth Kocienda <kocienda@apple.com>

Fixed uninitialized varible that broke the build.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:])
3:53 AM Changeset in webkit [1345] by rjw
  • 4 edits in trunk/WebCore

More cleanup to deal with special case of provisional view
not being in a scrollview.

3:32 AM Changeset in webkit [1344] by rjw
  • 6 edits in trunk/WebCore
  • kwq/KWQWidget.mm: (QWidget::setCursor): restored code
  • kwq/external.h: removed definitions no longer needed
  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): tweaked size
3:31 AM Changeset in webkit [1343] by rjw
  • 23 edits in trunk/WebKit

Lots of cleanup. Fixed most regressions.
Added removal of scrollbars during resizing,
not sure if it's the correct behavior, but it makes resizing
much smoother. Let's see what people think.

1:22 AM Changeset in webkit [1342] by cblu
  • 3 edits
    4 adds
    1 delete in trunk/WebKit

Removed MIME.subproj. Moved IFDownloadHandler to Misc.

  • MIME.subproj/IFDownloadHandler.h: Removed.
  • MIME.subproj/IFDownloadHandler.mm: Removed.
  • Misc.subproj/IFDownloadHandler.h: Added.
  • Misc.subproj/IFDownloadHandler.mm: Added. (-[IFDownloadHandler initWithDataSource:]): (-[IFDownloadHandler dealloc]): (-[IFDownloadHandler receivedData:isComplete:]): (-[IFDownloadHandler cancel]):
  • WebKit.pbproj/project.pbxproj:
1:13 AM Changeset in webkit [1341] by cblu
  • 11 edits
    6 deletes in trunk/WebKit

Fixed downloads.
Now write out download files as data comes in.
Removed useless lproj's.

  • Dutch.lproj/InfoPlist.strings: Removed.
  • Dutch.lproj/Localizable.strings: Removed.
  • French.lproj/InfoPlist.strings: Removed.
  • French.lproj/Localizable.strings: Removed.
  • German.lproj/InfoPlist.strings: Removed.
  • German.lproj/Localizable.strings: Removed.
  • Italian.lproj/InfoPlist.strings: Removed.
  • Italian.lproj/Localizable.strings: Removed.
  • Japanese.lproj/InfoPlist.strings: Removed.
  • Japanese.lproj/Localizable.strings: Removed.
  • MIME.subproj/IFDownloadHandler.h:
  • MIME.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler dealloc]): (-[IFDownloadHandler receivedData:isComplete:]): added (-[IFDownloadHandler cancel]): added
  • Spanish.lproj/InfoPlist.strings: Removed.
  • Spanish.lproj/Localizable.strings: Removed.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:]): removed unused BOOL (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):

Jun 12, 2002:

8:33 PM Changeset in webkit [1340] by cblu
  • 75 edits
    34 adds
    4 deletes in trunk

Couldn't run ChangeLog because it hung with the massize diffs, so here's
a hand-made one.

Changes to support inline views.

Modified Files:

WebBrowser/Debug/DebugUtilities.m WebCore/WebCore.exp
WebCore/kwq/KWQKloader.mm WebCore/kwq/KWQScrollView.mm
WebCore/kwq/KWQView.h WebCore/kwq/KWQView.mm
WebCore/kwq/KWQWidget.mm WebCore/kwq/external.h
WebKit/ChangeLog WebKit/Plugins.subproj/IFNullPluginView.mm



Added Files:


Removed Files:




3:09 PM Changeset in webkit [1339] by kocienda
  • 7 edits in trunk

2002-06-12 Kenneth Kocienda <kocienda@apple.com>

Made assertion failure console message bolder and easier to see.

  • WebFoundation/Misc.subproj/WebFoundationDebug.h
  • WebKit/Misc.subproj/WebKitDebug.h
  • WebCore/kwq/kwqdebug.h
9:26 AM Changeset in webkit [1338] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/nodes.cpp: (Node::finalCheck): A bit of APPLE_CHANGES so we can compile with KJS_DEBUG_MEM defined if we want to.

Jun 11, 2002:

4:52 PM Changeset in webkit [1337] by darin
  • 7 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: Add lots of assertions that allowed me to find the "leak the world" bug that Ken fixed in WebFoundation. These are a good idea anyway.
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream initWithURL:pluginPointer:notifyData:attributes:]): Use cStringLength to get the length for the cString rather than assuming that length will be right. (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Add a FIXME.
4:51 PM Changeset in webkit [1336] by darin
  • 3 edits in trunk/WebCore

Change log should have said: Remove the workaround for CFURL bug 2891336.

4:48 PM Changeset in webkit [1335] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQKURL.mm: (RelativeURLKeyRetainCallBack): Use a ref count. (RelativeURLKeyReleaseCallBack): Use a ref count instead of assuming there will never be more than one reference. (KURL::normalizeRelativeURLString): Use a ref count. (operator==): Don't put URLs on the autorelease pool just to compare them.
2:16 PM Changeset in webkit [1334] by sullivan
  • 16 edits in trunk/WebKit

Made methods that convert bookmarks to and from
property-list-compatible dictionaries public so they
can be used in the Bookmarks window for cut/paste.

  • Bookmarks.subproj/IFBookmark.h:
  • Bookmarks.subproj/IFBookmark.m: (+[IFBookmark bookmarkFromDictionaryRepresentation:withGroup:]): New method

(-[IFBookmark initFromDictionaryRepresentation:withGroup:]):
(-[IFBookmark dictionaryRepresentation]):

  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _loadBookmarkGroupGuts]): (-[IFBookmarkGroup _saveBookmarkGroupGuts]):
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkLeaf dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkList dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmarkSeparator.m: (-[IFBookmarkSeparator initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkSeparator dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmark_Private.h: Removed leading underscores from _initFromDictionaryRepresentation and _dictionaryRepresentation, and made them public.

-fixed 2921580 -- Need Cut/Copy/Paste support in Bookmarks window
-fixed 2952869 -- Alexander offers to undo Bookmark address change
when nothing changed
-made Activity, Bookmarks, and History window set the initial first
responder to their outline views, so Select All and keyboard navigation
work without requiring an initial click.
-eliminated unsightly gray line above outline views in Activity, Bookmarks,
and History windows

  • ActivityViewer.m: (-[ActivityViewer _setUpWindow]): Make outline view be first responder.
  • BookmarksController.h: Add ivars for _droppablePasteboardTypes and _pasteablePasteboardTypes; maybe these will be the same eventually.
  • BookmarksController.m: (-[BookmarksController _droppablePasteboardTypes]), (-[BookmarksController _pasteablePasteboardTypes]): Return array of the types we handle, lazily creating the array if necessary. (-[BookmarksController windowDidLoad]): Use _droppablePasteboardTypes; make outline view be first responder. (-[BookmarksController dealloc]): release new ivars (-[BookmarksController _selectedBookmarksWithoutRedundantDescendants]), (-[BookmarksController removeSelectedBookmarks:]): Extracted _selectedBookmarks... from removeSelectedBookmarks. (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): Fixed copy/paste error that was the cause of 2952869 (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): Call [NSPasteboard availableTypeFromArray:] instead of making dangerous assumptions. (-[BookmarksController _setSelectionToBookmarks:]), (-[BookmarksController outlineView:acceptDrop:item:childIndex:]): extracted _setSelectionToBookmarks: into its own function, and used availableTypeFromArray:

(-[BookmarksController copy:]),
(-[BookmarksController paste:]),
(-[BookmarksController clear:]),
(-[BookmarksController cut:]): New methods; the last three are Undoable

(-[BookmarksController _numberOfBookmarksOnPasteboard:]): New helper method used
to set title of Paste menu item.

(-[BookmarksController validateMenuItem:]): New method, used for items whose titles
change (i.e. Cut/Copy/Paste/Clear)
(-[BookmarksController validateUserInterfaceItem:]): No change, just moved.

  • English.lproj/ActivityViewer.nib,
  • English.lproj/Bookmarks.nib,
  • English.lproj/History.nib: Made outline views one pixel taller to avoid unsightly gray line at top.
  • GlobalHistory.h:
  • GlobalHistory.m: (-[selectAll:]): Removed unnecessary method. (-[GlobalHistory validateUserInterfaceItem:]): Removed validation for selectAll; let outline view handle it. (-[GlobalHistory showWindow:]): Make outline view be first responder.
1:50 PM Changeset in webkit [1333] by darin
  • 5 edits
    10 adds in trunk/WebKit


  • WebView.subproj/IFDOMNode.h: Added.
  • WebView.subproj/IFDOMNode.mm: Added.
  • WebView.subproj/IFRenderNode.h: Added.
  • WebView.subproj/IFRenderNode.mm: Added. These contain all the interesting bits of the code for the render and DOM tree viewers, mostly moved here from WebBrowser.
  • WebView.subproj/IFWebViewPrivate.mm: Remove the methods in here that aren't declared in the header and are only used for the render and DOM tree viewers.
  • WebKit.pbproj/project.pbxproj: Add new files.


Removed all C and Objective C++, making this all Objective C again, which
helps make build times faster.

  • _CFA2UC.c: Removed.
  • WebBrowserPrefix.h: Removed code to handle non-Objective C, and also removed <config.h>.
  • Debug/DOMTree.m: Renamed from DOMTree.mm. Also changed to use IFDOMNode from WebKit for all the interesting bits.
  • Debug/DOMTree.mm: Renamed to DOMTree.m.
  • Debug/DOMTree.h: Put dataSource in object as a step toward making this not leak some day.
  • Debug/RenderTree.m: Renamed from RenderTree.mm. Also changed to use IFRenderNode from WebKit for all the interesting bits.
  • Debug/RenderTree.mm: Renamed to RenderTree.m.
  • Debug/RenderTree.h: Put dataSource in object as a step toward making this not leak some day.
  • WebBrowser.pbproj/project.pbxproj: Change files around. Add warnings that weren't allowed in C++; this project is now all Objective C. Remove C and Objective C++ from PFE dialects list. Remove header search paths.
  • main.m: Use "../config.h" to get at config.h. In the long run, we can just get rid of this.
  • Debug/DebugUtilities.m: Unimportant tweaks.

Jun 10, 2002:

5:05 PM Changeset in webkit [1332] by darin
  • 5 edits
    1 add in trunk/WebKit
  • Makefile.am: Do a clean before building if the force-clean-timestamp file is newer than the previous-clean-timestamp. Edit force-clean-timestamp (doesn't matter what you change as long as you change it) to force a clean build in WebKit.
  • force-clean-timestamp: Added.
  • .cvsignore: Ignore previous-clean-timestamp.
3:18 PM Changeset in webkit [1331] by darin
  • 6 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.h: Remove the flavor of floatWidthForCharacters without the applyRounding boolean.
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Remove logic about characters in the 0x7F-0xA0 range, since it's already handled by the time we get around to drawing. (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]): Pass in the applyRounding boolean when calling through to slowFloatWidthForCharacters. Move logic about characters in the 0x7F-0xA0 range from here into [extendCharacterToGlyphMapToInclude:]. (-[IFTextRenderer widthForCharacters:length:]): Call the version of floatWidthForCharacters that takes the applyRounding parameter; this was the only client of the flavor that didn't take the parameter. (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Add the logic about characters in the 0x7F-0xA0 range into here.
1:45 PM Changeset in webkit [1330] by darin
  • 4 edits in trunk/WebCore
  • khtml/css/cssstyleselector.cpp: Fix uninitialized variable warning.
1:09 PM Changeset in webkit [1329] by rjw
  • 8 edits in trunk/WebKit

i Tweaks to new rounding code.

Added Cocoa-exact width measurement emulation flag to support IFStringTruncator.

Remove code that was already conditionally excluded calls to support
non-specified advance drawing (we now depend on tweaked advances).

  • Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/IFTextRenderer.h:
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer initWithFont:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer slowFloatWidthForCharacters:length:applyRounding:]): (-[IFTextRenderer slowFloatWidthForCharacters:length:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:length:]): (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]):
1:08 PM Changeset in webkit [1328]
  • 1 copy
    112 deletes in branches/unlabeled-1.4.56

This commit was manufactured by cvs2svn to create branch

1:08 PM Changeset in webkit [1327]
  • 1 copy
    111 deletes in branches/unlabeled-1.3.56

This commit was manufactured by cvs2svn to create branch

1:08 PM Changeset in webkit [1326] by darin
  • 141 edits
    1 add in trunk


Merged in changes from KDE 3.0.1.

  • kjs/collector.cpp:
  • kjs/date_object.cpp:
  • kjs/function.cpp:
  • kjs/internal.cpp:
  • kjs/lookup.h:
  • kjs/object.cpp:
  • kjs/operations.cpp:
  • kjs/regexp.cpp:
  • kjs/regexp_object.cpp:
  • kjs/regexp_object.h:
  • kjs/string_object.cpp:
  • kjs/testkjs.cpp:
  • kjs/ustring.cpp:
  • kjs/value.cpp:
  • kjs/value.h: Do the merge, and add APPLE_CHANGES as needed to make things compile.
  • kjs/date_object.lut.h: Re-generated.


Merged in changes from KDE 3.0.1.

  • kwq/kdecore/kurl.h:
  • kwq/KWQKURL.mm: (operator==): New, needed by some 3.0.1 code.
  • kwq/qt/qpalette.h: Add QPalette::NColorGroups and QColorGroup::NColorRoles.
  • kwq/KWQPalette.mm: Simplify by getting rid of "private" indirection. (QPalette::color): New, needed by some 3.0.1 code.
  • kwq/KWQColorGroup.mm: Simplify by getting rid of "private" indirection.
  • kwq/qt/qstring.h:
  • kwq/KWQString.mm: (QConstString::QConstString): Change parameter to const QChar * to match Qt so we compile.
  • kwq/qt/qtextedit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setTabStopWidth): Add unimplemented placeholder, needed by some 3.0.1 code.
  • kwq/qt/qvaluelist.h:
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: Simplify implementation.
  • WebCore-tests.exp: Update for changes in QValueList implementation.
  • kwq/kdecore/klibloader.h: Add include of <kio/global.h> to make something compile.
  • kwq/khtml/java/kjavaappletcontext.h: Add JType and constructor that takes DCOPObject*.
  • kwq/kio/global.h: Add KIO::CacheControl.
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp:
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/css/html4.css:
  • khtml/dom/css_rule.cpp:
  • khtml/dom/css_rule.h:
  • khtml/dom/css_stylesheet.cpp:
  • khtml/dom/css_stylesheet.h:
  • khtml/dom/css_value.cpp:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_range.cpp:
  • khtml/dom/dom2_range.h:
  • khtml/dom/dom2_views.cpp:
  • khtml/dom/dom_doc.cpp:
  • khtml/dom/dom_element.cpp:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_node.cpp:
  • khtml/dom/dom_string.cpp:
  • khtml/dom/dom_text.cpp:
  • khtml/dom/dom_xml.cpp:
  • khtml/dom/html_base.cpp:
  • khtml/dom/html_block.cpp:
  • khtml/dom/html_document.cpp:
  • khtml/dom/html_element.cpp:
  • khtml/dom/html_element.h:
  • khtml/dom/html_form.cpp:
  • khtml/dom/html_head.cpp:
  • khtml/dom/html_image.cpp:
  • khtml/dom/html_inline.cpp:
  • khtml/dom/html_list.cpp:
  • khtml/dom/html_misc.cpp:
  • khtml/dom/html_object.cpp:
  • khtml/dom/html_table.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_proxy.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp:
  • khtml/misc/helper.cpp:
  • khtml/misc/khtmllayout.h:
  • khtml/misc/loader.cpp:
  • khtml/misc/loader.h:
  • khtml/misc/loader_client.h:
  • khtml/misc/shared.h: Added.
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/break_lines.cpp:
  • khtml/rendering/font.cpp:
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_applet.h:
  • khtml/rendering/render_container.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_image.cpp:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_root.cpp:
  • khtml/rendering/render_style.cpp:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp:
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.cpp:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/xml_tokenizer.h: Merge in 3.0.1 changes and add APPLE_CHANGES as necessary to get it to compile.
12:44 PM Changeset in webkit [1325] by darin
  • 2 edits
    1 delete in trunk/WebKit
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Removed.
10:21 AM Changeset in webkit [1324] by sullivan
  • 4 edits in trunk/WebKit

Fixed leaks in History mechanism, found by overriding
release, retain, autorelease, and dealloc and watching
the spam fly.

  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate addEntry:]): Make autoreleased array for entries on a given date. (-[IFWebHistoryPrivate _loadHistoryGuts:]): autorelease entries as they are generated from data on disk.

Added workaround for NSOutlineView leak, by collapsing items
just before removing them from the history view.

  • GlobalHistory.m: (-[GlobalHistory removeSelectedItems:]):
9:47 AM Changeset in webkit [1323]
  • 16 copies in tags/KDE_3_0_1

This commit was manufactured by cvs2svn to create tag 'KDE_3_0_1'.

9:47 AM Changeset in webkit [1322] by darin
  • 1 add in branches/kde/WebCore/khtml/misc/shared.h

File that's new in 3.0.1

9:20 AM Changeset in webkit [1321] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Fix a typo where I left the S off of DRAW_WITHOUT_ADVANCES.
9:14 AM Changeset in webkit [1320] by darin
  • 217 edits in branches/kde

Check in the KDE 3.0.1 sources.

9:01 AM Changeset in webkit [1319] by darin
  • 1 delete in branches/kde/WebCore/khtml/java

Remove java subdir from kde branch.

9:00 AM Changeset in webkit [1318] by darin
  • 1 delete in branches/kde/WebCore/src

Get rid of old-location files from the kde branch.

3:23 AM Changeset in webkit [1317] by rjw
  • 4 edits in trunk/WebKit

90% solution to round-off problem. khtml breaks measures text on space
boundaries during layout. It assumes integer measurement, CG uses float
measurements. Some common fonts have non-integer space width. So,
differences in between drawing advances and measurement of space characters
can easily accumulate enough to be visually apparent. We may still accumulate
differences across words, although it's much less visible than for spaces.
As a next step we can fudge the advances of words to force
integer widths, although I think, given how khtml work, just accounting for
consistency in measuring and drawing spaces may be sufficient.
Many sites that looked flaky before now render correctly.

  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]):

Force rounding of advance for space characters.

(-[IFTextRenderer floatWidthForCharacters:length:]):

Force rounding of measurement for space characters.

Note: See TracTimeline for information about the timeline view.