Context Navigation

WebView.subproj/WebControllerPrivate.h: Add an enum, UserAgentStringType, with values Safari, MacIE, and WinIE. Also add NumUserAgentStringTypes and turn the userAgent and userAgentWhenPretendingToBeMacIE strings into an array indexed by type.

WebView.subproj/WebController.m: (-[WebController setApplicationNameForUserAgent:]): Use a loop to discard the user agent strings, since we have an array now. (-[WebController userAgentForURL:]): Change user agent algorithm to check two strings rather than once against the spoof table, allowing two dots in the "domain name", which is needed for "abcnews.go.com". Get a user agent string type from the table rather than just a boolean "pretend to be MacIE". Store a string per type rather than one for normalcy and one for MacIE. Add a case for WinIE to the user agent computations.

English.lproj/StringsNotToBeLocalized.txt: Update for change above.

WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Use a loop to discard the user agent strings, since we have an array now. (-[WebController _defaultsDidChange]): Ditto.

WebView.subproj/WebUserAgentSpoofTable.gperf: Add a UserAgentStringType field to the struct. Add MacIE to each existing table entry, and add a new one that says WinIE for abcnews.go.com.

Makefile.am: Pass "-F ,0" to gperf so that we don't get warnings compiling empty entries in the hash table.

WebView.subproj/WebUserAgentSpoofTable.c: Re-generated.

other changes

WebView.subproj/WebHTMLView.m: Removed some old, dead, #if 0'd code.

10:43 AM Changeset in webkit [3306] by darin

9 edits in trunk/JavaScriptCore

Reviewed by John.

changes inspired by things I noticed reviewing diffs vs. KDE when preparing the tarball

kjs/function.cpp: (GlobalFuncImp::call): Use strtol when strtoll is not available. Do #ifndef NDEBUG, not #if !NDEBUG.
kjs/function.h: Do #ifndef NDEBUG, not #if !NDEBUG.
kjs/internal.cpp: (InterpreterImp::initGlobalObject): Do #ifndef NDEBUG, not #if !NDEBUG. (KJS::printInfo): Remove case for ListType and remove default case that just ends up suppressing the "missing case" warning and does no good.
kjs/interpreter.cpp: (Interpreter::evaluate): Do #ifndef NDEBUG, not #if !NDEBUG.
kjs/nodes.cpp: (Node::finalCheck): Fix accidentally-deleted code in an ifdef we never compile. (FunctionCallNode::evaluate): Remove bogus XXX comment. Maciej put this comment in, and together we determined it's not needed. (TypeOfNode::evaluate): Ditto.
kjs/object.cpp: Remove assert that refers to ListType.
kjs/value.h: Remove ListType.

10:41 AM Changeset in webkit [3305] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

minor cleanup of plug-in-related classes in ECMA directory

khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions ref() and deref(). Instead just make Plugin and MimeType both derive from PluginBase and remove APPLE_CHANGES. (Navigator::getValueProperty): Don't use "Konqueror" for the fallback. Just return Undefined() for that case since we will never reach it anyway.

simplify the logic in khtmlMoveMouseEvent so it's easier to decipher

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two identical if statements, the logic of this function becomes much clearer.

9:05 AM Changeset in webkit [3304] by darin

6 edits in trunk/WebCore

Reviewed by Dave.

fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.

khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): Changed !x == y to x != y. In each case, there's a reason that this does not create any problem in practice, which is why we didn't rush to get this in for beta 1.

9:01 AM Changeset in webkit [3303] by darin

7 edits in trunk/WebCore

Reviewed by John.

fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu

khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than waiting until the parser is destroyed. This fixes the bug because when the parser is destroyed, the document is already destroyed, so we have a dangling current pointer to an already-destroyed node.

fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer

The bug was caused by an erroneous clicked signal that was being emitted by
QListBox at just the wrong time.

kwq/KWQListBox.h: Added _changingSelection boolean.
kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false. (QListBox::setSelected): Set _changingSelection to true. (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked" signal if _changingSelection is false.

khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false. (HTMLTokenizer::write): Set inWrite to true. (HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.

Jan 11, 2003:

9:13 PM Changeset in webkit [3302] by darin

3 edits in trunk/WebKit

Reviewed by John.

fixed 3144479 -- put TITLE from links in status bar

WebKit.exp: Add _WebElementLinkTitleKey and also sort this file.

WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above to have any effect, so update the copyright date here.

5:17 PM Changeset in webkit [3301] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3136944 -- mouseover feedback over non-mapped part of image map claims link to current page

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct from an empty ATTR_HREF). Did a similar cleanup on the image code.

Jan 10, 2003:

12:20 AM Changeset in webkit [3300] by darin

11 edits in trunk

JavaScriptCore:

JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass.

English.lproj/InfoPlist.strings: Updated to match above changes.

WebFoundation:

WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass.

English.lproj/InfoPlist.strings: Update to match above.

WebCore:

WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL that was in the Info plist instead of project settings.

English.lproj/InfoPlist.strings: Update to match above.

WebKit:

WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass.

English.lproj/InfoPlist.strings: Updated to match above changes.

WebBrowser:

WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions to 0.8.1 and 52u to keep up with the branch.

English.lproj/InfoPlist.strings: Update to match above.

Jan 9, 2003:

11:08 PM Changeset in webkit [3299]

16 copies in tags/Alexander-51

This commit was manufactured by cvs2svn to create tag 'Alexander-51'.

11:08 PM Changeset in webkit [3298] by kocienda

5 edits in branches/Alexander-48-branch

Setting version to Alexander-51

10:44 PM Changeset in webkit [3297] by darin

3 edits in branches/Alexander-48-branch

Version fixes for 51.

8:01 PM Changeset in webkit [3296]

16 copies in tags/Alexander-50

This commit was manufactured by cvs2svn to create tag 'Alexander-50'.

8:01 PM Changeset in webkit [3295] by sheridan

8 edits in branches/Alexander-48-branch

Alexander-48-branch, aka Safari-50 versions

7:57 PM Changeset in webkit [3294] by darin

3 edits in trunk

Lets call this 51u, not 50u.

7:56 PM Changeset in webkit [3293] by darin

2 edits in trunk/WebKit

WebKit:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
English.lproj/Localizable.strings: Regenerate.

7:47 PM Changeset in webkit [3292] by kocienda

1 edit in branches/Alexander-48-branch/WebKit/ChangeLog

2003-01-09 Ken Kocienda <kocienda@apple.com>

Reviewed by me

Added missing ChangeLog comment for a file I merged

ChangeLog

7:21 PM Changeset in webkit [3291] by kocienda

6 edits in branches/Alexander-48-branch/WebKit

2003-01-09 Ken Kocienda <kocienda@apple.com>

Changes merged from trunk onto the branch to patch critical data loss problems.

WebKit:

Reviewed by Everybody

Changes merged from trunk onto the branch to patch critical data loss problems.

2003-01-09 Trey Matteson <trey@apple.com>

Reviewed by Richard.

3142201 - home directory nuked during power download session

We add checks for various error cases that could combine to cause this problem. While we
never got a reproducible case, we are confident that this is the only file removal done
in the download code, and its ability to wreak havoc has been clipped.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): Only nuke the partial download if in fact we created a new download file. Never nuke a directory. (-[WebDownloadHandler createFileIfNecessary]): Don't add "." to the foo-1 filenames we generate if the original filename doesn't have any extension.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to overwrite the user's home directory.

2003-01-09 Darin Adler <Darin Adler>

Reviewed by Chris.

second pass on 3143332 - we still need a test case to be sure this is right

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for "/". Also report the failure instead of just hanging on forever.

2003-01-09 Trey Matteson <trey@apple.com>

Reviewed by Darin

WebKit:

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against a download location that is not an absolute path.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Bail on download if we don't have a abs path to write to.

WebBrowser:

Reviewed by Everybody

Changes merged from trunk onto the branch to patch critical data loss problems.

2003-01-09 Trey Matteson <trey@apple.com>

Reviewed by Darin

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against slashes and leading periods, as well as handling empty filenames.

BrowserWebController.m: (-[BrowserWebController saveFilenameForResponse:andRequest:]): Check results of [response filename] carefully

2003-01-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

fixed 3143311 - Create /tmp link on startup if it's missing

main.m: (main): Make the /tmp symlink if it's missing.

2003-01-09 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed 3143417 - store last version run in the preferences

added a new user default that stores the version (source version).

PreferenceKeys.h: Put in a new preference key for the "last version run".
main.m: (main): Call storeVersionInPreferences. (storeVersionInPreferences): Store the source version in "last version run".

6:06 PM Changeset in webkit [3290] by rjw

2 edits in trunk/WebKit

Fixed 3143361. This was a regression introduced with some image
rendering optimizations. Don't bypass the tiling code path if
the image needs to be rendered out-of-phase.

Reviewed by hyatt.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:]):

5:33 PM Changeset in webkit [3289] by darin

2 edits in trunk/WebKit

Reviewed by Chris.

second pass on 3143332 - we still need a test case to be sure this is right

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for "/". Also report the failure instead of just hanging on forever.

5:12 PM Changeset in webkit [3288] by darin

2 edits in trunk/WebKit

Reviewed by Richard.

fixed 3143332 -- if path returned is empty string (or "." or "..") it will trash the /tmp symlink

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for empty string, ".", and "..", and don't create files by those names.

5:04 PM Changeset in webkit [3287] by trey

3 edits in trunk/WebKit

WebKit:

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against a download location that is not an absolute path.

Reviewed by Darin

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Bail on download if we don't have a abs path to write to.

WebBrowser:

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against slashes and leading periods, as well as handling empty filenames.

Reviewed by Darin

BrowserWebController.m: (-[BrowserWebController saveFilenameForResponse:andRequest:]): Check results of [response filename] carefully

4:14 PM Changeset in webkit [3286] by mjs

3 edits in trunk/WebCore

Reviewed by Dave.

fixed Radar 3143013 - hang trying to load spiny.com/software

khtml/rendering/render_table.cpp: (RenderTable::layoutRows): Check for the render root as a loop termination condition, to avoid an infinite loop for an absolute but non-fixed table cell.

4:06 PM Changeset in webkit [3285] by hyatt

3 edits in trunk/WebCore

The "flow-mode" quirk for lists is just that - a quirk, and should
not be applied when in strict mode.

Fixes diveintomark.org's navigation bar on the front page (issue #2
on his list).

Reviewed by darin and maciej

khtml/css/html4.css:

3:25 PM Changeset in webkit [3284]

5 copies
2 deletes in tags/JavaScriptCore-49~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-49~1'.

3:25 PM Changeset in webkit [3283] by mjs

4 edits in branches/su-jag-pink-branch/JavaScriptCore

Updated versions for 49.1.

English.lproj/InfoPlist.strings: Updated to 49.1 and 0.8.
JavaScriptCore.pbproj/project.pbxproj: Likewise.

10:52 AM Changeset in webkit [3282] by hyatt

4 edits in trunk/WebCore

Finish the KONQBLOCK removal and make sure that table rows and
cells encountered inside stray content cause the stray content to
close so that the rows and cells can be part of the table.

This fixes the versiontracker bug. #3142319.

Reviewed by darin.

khtml/html/htmlparser.cpp: (KHTMLParser::reset): (isTableRelatedTag): (KHTMLParser::insertNode): (KHTMLParser::popOneBlock):
khtml/html/htmlparser.h:

Jan 8, 2003:

11:50 PM Changeset in webkit [3281] by trey

5 edits in trunk/WebKit

3142201 - home directory nuked during power download session

We add checks for various error cases that could combine to cause this problem. While we
never got a reproducible case, we are confident that this is the only file removal done
in the download code, and its ability to wreak havoc has been clipped.

Reviewed by Richard.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): Only nuke the partial download if in fact we created a new download file. Never nuke a directory. (-[WebDownloadHandler createFileIfNecessary]): Don't add "." to the foo-1 filenames we generate if the original filename doesn't have any extension.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to overwrite the user's home directory.

11:07 PM Changeset in webkit [3280] by hyatt

4 edits in trunk/WebCore

Revert the redundancy that dirk noticed.

Fixing issue #3 on diveintomark.org's list, which actually involved
merging calcAbsoluteVertical to KHTML's trunk and then fixing
a math error in the bottom computation.

Reviewed by NOBODY (OOPS!).

khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):

6:08 PM Changeset in webkit [3279] by cblu

6 edits in trunk

WebCore:

Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html

Reviewed by dave.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): call [_bridge frameRequiredForMIMEType:] to determine if we should create a plug-in view or iframe
kwq/WebCoreBridge.h: add frameRequiredForMIMEType:

WebKit:

Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html

Reviewed by dave.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]): added, returns YES for non-plug-in views

1:33 PM Changeset in webkit [3278] by trey

3 edits in trunk/WebCore

3136213 - Page loads stopped by backtracking don't finish when moving forward

We need to remove the entry from the KHTML image cache when a load
has an error, so it will be reloaded next time we try.

Reviewed by Darin,

khtml/misc/loader.cpp: (Loader::slotFinished): Remove cache entry on job error.

12:17 PM Changeset in webkit [3277] by darin

8 edits in trunk/WebCore

Reviewed by Dave.

fixed 96/72 dpi snafu; no need to do something different for AppKit, because it always uses pixel sizes, not font size

khtml/css/css_valueimpl.cpp:
khtml/css/css_valueimpl.h:
khtml/css/cssstyleselector.cpp:
kwq/KWQPaintDeviceMetrics.mm: Rolled out change from 2002-12-05

a cut at implementing heretofore unimplemented QTextStream classes

kwq/KWQTextStream.h:
kwq/KWQTextStream.mm: First cut implementation.

11:47 AM Changeset in webkit [3276] by cblu

2 edits in trunk/WebKit

FIXED: 3128098 - flash performance weak!!!

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.m: Don't throttle plug-in when in an active window.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed