Context Navigation

← Previous Period
Next Period →

Timeline

Jan 27, 2003:

8:55 PM Changeset in webkit [3472] by trey

5 edits in trunk/WebCore

3157146 REGRESSION: using a pop-up menu turns the cursor into an I-beam

A hack for the benefit of AK's PopUpButton, which uses the Carbon menu

manager, which thus eats all subsequent events after it is starts its
modal tracking loop. After the interaction is done, we call a new routine
to fix things up in the khtml event world. We post a fake mouse up to balance
the mouse down we started with. In addition, we post a fake mouseMoved to get
the cursor in sync with whatever we happen to be over after the tracking is done.

Reviewed by Darin.

kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Call part after NSPopUp's modal tracking consumes events.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::doFakeMouseUpAfterWidgetTracking): New routine to allow widgets to get out event state fixed up after a modal tracking loop.

5:15 PM Changeset in webkit [3471] by mjs

1 edit in trunk/WebKit/ChangeLog

WebFoundation:

Reviewed by Darin and Ken.

fixed 3153098 - Implement "simple retry" when Safari fails to validate a certifcate

Misc.subproj/WebError.h:
Misc.subproj/WebError.m: (classInitialize): Added new "unknown root cert" error.
English.lproj/Localizable.strings: Updated.
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler setCertificatePolicyOnStream]): If the request says to allow unknown roots, do so.
ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Report unknown root error properly.
ProtocolHandlers.subproj/WebHTTPResourceRequest.h:
ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest setAllowSSLCertificatesWithUnknownRoots:]): New method to allow unknown root certs on a per-request basis. (-[WebResourceRequest allowSSLCertificatesWithUnknownRoots]): Corresponding getter. (-[WebHTTPResourceRequestParameters copyWithZone:]): Account for new field. (-[WebHTTPResourceRequestParameters isEqual:]): Likewise.

WebKit:

Reviewed by Darin and Ken.

English.lproj/StringsNotToBeLocalized.txt: Removed unused exception.

WebBrowser:

Reviewed by Darin and Ken.

fixed 3153098 - Implement "simple retry" when Safari fails to validate a certifcate

LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): If the error was unknown root certificate, put up a sheet asking whether the user wants to continue (actually retry for now).
English.lproj/Localizable.strings: Updated.

4:12 PM Changeset in webkit [3470] by cblu

10 edits in trunk

WebCore:

Fixed: 3152053 - Safari: Java 141: Only visible applets are instantiated on web page

Reviewed by dave.

khtml/rendering/render_applet.cpp: (RenderApplet::layout): move the widget before calling showApplet
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet): add the java view to the main view immediately instead of waiting for first paint
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionImage]): tweak

WebKit:

Fixed: 3156230 - REGRESSION: Java 141: Safari Does Not Stop Applets When Browser Window Closes

Reviewed by dave.

Plugins.subproj/WebPluginController.h:
Plugins.subproj/WebPluginController.m: (-[WebPluginController destroyAllPlugins]): renamed from HTMLViewWillBeDeallocated because it may get called before the dealloc
WebView.subproj/WebHTMLView.m: (-[WebHTMLView addWindowObservers]): observe NSWindowWillCloseNotification (-[WebHTMLView removeWindowObservers]): remove observer for NSWindowWillCloseNotification (-[WebHTMLView windowWillClose:]): call destroyAllPlugins
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): call destroyAllPlugins

3:50 PM Changeset in webkit [3469] by rjw

6 edits in trunk/WebKit

Fixed 3139909. Fake the resource load delegate messages (minus willSendRequest)
when a page is loaded from a the page cache.

Reviewed by john.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _addResponse:]): (-[WebDataSource _responses]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]):

3:33 PM Changeset in webkit [3468] by trey

2 edits in trunk/WebKit

3157104 - reproducible assert in _continueFragmentScrollAfterNavigationPolicy

Remove assertion, and it turns out the existing code will handle the case.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):

2:59 PM Changeset in webkit [3467] by mjs

7 edits in trunk/WebCore

Reviewed by Darin.

fixed 3156461 - SECURITY: contentDocument of iframe from other domain can be accessed
fixed 3156462 - SECURITY: can invoke setTimeout on other window
fixed 3156469 - SECURITY: can add an event listener on another protected window
fixed 3156527 - SECURITY: Can access HTML document from different domain in another frame
fixed 3156535 - SECURITY: Can access XML document from different domain in another frame

These fixes are merged from or inspired by security fixes in upstream khtml.

khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_dom.cpp: (KJS::checkNodeSecurity): Prototype new method used to check whether a document is allowed to access the contents of a node.
khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): Apply security check to getting the contentDocument of an iframe or object.
khtml/ecma/kjs_window.cpp: (Window::get): Make sure addEventListener/removeEventListener, and all timer related functions are protocted from cross-domain calls. (WindowFunc::tryCall): Make sure this is true even if they are detached from one window and called on another.
khtml/khtml_part.cpp: (KHTMLPart::checkEmitLoadEvent): When setting frames to the domain of the parent document, don't force it, so the usual suffix check rule will apply.

2:13 PM Changeset in webkit [3466] by rjw

6 edits in trunk

WebKit:

Make emptying the page cache synchronous when "Empty Cache"
is selected from menu. More bulletproofing to ensure that
3155781 doesn't happen.

Reviewed by trey.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList clearPageCache]):

WebCore:

Reviewed by trey.

Added ASSERT trap to help track down non-repro crash reported
by 3144546.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):

Remove assert that caused 3155781. We believe this was happening
because of a delayed release of the page cache after emptying cache
from "Empty Cache" menu item.

kwq/KWQPageState.mm: (-[KWQPageState dealloc]):

*.lut.h changes are spurious.
*.c changes are spurious.

1:00 PM Changeset in webkit [3465] by hyatt

7 edits in trunk/WebCore

Fix text dragging so that text inside floats paints when you
drag the selection.

Reviewed by cblu

ChangeLog:
khtml/rendering/render_flow.cpp: (RenderFlow::paintObject): (RenderFlow::paintFloats):
khtml/rendering/render_flow.h:

11:55 AM Changeset in webkit [3464] by cblu

2 edits in trunk/WebKit

Fixed: 3156235 - change throttle for plug-in null events to 50 frames per second (when frontmost)

Reviewed by dave.

Plugins.subproj/WebBaseNetscapePluginView.m:

11:37 AM Changeset in webkit [3463] by rjw

5 edits in trunk/WebKit

WebKit:

Fixed 3151241. Cleanly handle nil return from resource:willSendRequest:fromDataSource:.

Reviewed by trey.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:complete:]):

Tests:

Removed unneeded local variable that shadowed ivar.

Reviewed by me.

SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]):

11:31 AM Changeset in webkit [3462] by sullivan

2 edits in trunk/WebKit

fixed 3156744 -- REGRESSION: Renaming bookmarks dragged into bookmark bar does not work at first

Reviewed by Darin

Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList insertChild:atIndex:]): was adding self to its own group (a no-op), instead of adding the new child to self's group. This was a typo from the refactoring to fix 3152427.

10:43 AM Changeset in webkit [3461] by cblu

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Updated for changes I previously made.

Jan 26, 2003:

11:41 PM Changeset in webkit [3460] by cblu

7 edits in trunk

WebCore:

Fixed: 3156725 - Partially selected links show extra underlining when dragged
Fixed: 3156962 - Text drag image sometimes doesn't include last selected text node

Reviewed by darin.

khtml/rendering/render_root.cpp: (RenderRoot::selectionRect): include all nodes that are selected
khtml/rendering/render_text.cpp: (TextSlave::paintDecoration): removed stray ";" (RenderText::paintObject): call paintDecoration with default parameters for "from" and "to" when not painting the selection only
khtml/rendering/render_text.h:

WebKit:

Fixed: 3156725 - Partially selected links show extra underlining when dragged

Reviewed by darin.

WebCoreSupport.subproj/WebTextRenderer.m: (drawLineForCharacters...): don't ignore "from" "to" parameters

11:33 PM Changeset in webkit [3459] by darin

8 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3126431 -- failed assertion `!attached()' at silkair.net

khtml/rendering/render_image.h: Fix isImage which for some strange reason was returning false. Not important because no one calls it. Added dispatchLoadEvent and detach member functions.
khtml/rendering/render_image.cpp: (RenderImage::notifyFinished): Instead of dispatching the load or error event immediately, call dispatchImageLoadEventSoon on the document. (RenderImage::dispatchLoadEvent): Added. Moved the code to do the actual event dispatch in here. (RenderImage::detach): Remove the image from the document in case it has a pending event that was not delivered yet before calling the base class detach.

khtml/xml/dom_docimpl.h: Add dispatchImageLoadEventSoon, dispatchImageLoadEventsNow, removeImage, and an override of timerEvent. Moved APPLE_CHANGES code to a better place.
khtml/xml/dom_docimpl.cpp: Moved APPLE_CHANGES code to a better place and made these changes: (DocumentImpl::DocumentImpl): Initialize m_imageLoadEventTimer to 0. (DocumentImpl::detach): Redo the APPLE_CHANGES to make them easier to read. Empty out the m_imageLoadEventDispatchSoonList and the m_imageLoadEventDispatchingList to avoid an O(n^{2) operation as we detach each image and remove it from the list.
(DocumentImpl::dispatchImageLoadEventSoon): Added. Adds image to list and sets up timer.
(DocumentImpl::removeImage): Added. Removes image from lists, and cancels timer if needed.
(DocumentImpl::dispatchImageLoadEventsNow): Added. Copies list, and call images to dispatch load events.
(DocumentImpl::timerEvent): Added. Calls dispatchImageLoadEventsNow.}

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Dispatch all pending image load events before dispatching the document load.

force-clean-timestamp: Force rebuild because Project Builder doesn't do header dependencies well enough to deal with changes to the document class.

3:53 PM Changeset in webkit [3458] by hyatt

3 edits in trunk/WebCore

Fix :active to behave just like :hover. It was being
restricted and only allowed to match <a> tags, when :active
should be applicable to any element (e.g., like images).

Fixes the :active feedback on numerous blog sites (e.g.,
the photo image buttons on joehewitt.com).

Reviewed by gramps

khtml/css/cssstyleselector.cpp:

Jan 25, 2003:

9:04 PM Changeset in webkit [3457] by darin

15 edits in trunk

WebCore:

Reviewed by Maciej.

fixed 3126211 -- "go back" buttons that use "history.go(-1)" doesn't work (verizonwireless.com is an example)
fixed 2950618 -- JavaScript window.history object name prints blank

khtml/ecma/kjs_window.cpp: (FrameArray::toString): Added. Returns "[object FrameArray]". (History::getValueProperty): Removed #if APPLE_CHANGES to turn more code on. (History::toString): Added. Returns "[object History]".

kwq/KWQKPartsBrowserExtension.h: Make browserInterface a pure virtual function instead of always returning 0.
kwq/KWQKHTMLPartBrowserExtension.h: Added browserInterface() function. Also replaced m_part with a _part that is a KWQKHTMLPart to simplify code.
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): Create the browser interface object when the browser extension object is created. (KHTMLPartBrowserExtension::openURLRequest): Use _part instead of KWQ(m_part). (KHTMLPartBrowserExtension::createNewWindow): Use _part instead of KWQ(m_part). (KHTMLPartBrowserExtension::setIconURL): Use _part instead of KWQ(m_part). (KHTMLPartBrowserExtension::setTypedIconURL): Use _part instead of KWQ(m_part).

kwq/KWQKPartsBrowserInterface.h: Add a constructor, property() function, and _part data member.
kwq/KWQKPartsBrowserInterface.mm: (BrowserInterface::property): Added. Handles historyLength property by calling the historyLength method on the bridge. (BrowserInterface::callMethod): Handles goHistory(int) by calling the goBackOrForward: method on the bridge.

kwq/WebCoreBridge.h: Added historyLength and goBackOrForward: methods.

kwq/KWQVariant.h: Added Int to the variant enum, added int and uint contructors, and added toInt() member function.
kwq/KWQVariant.mm: (QVariant::QVariant): Implemented int and uint constructors. (QVariant::toBool): Added Int case, sorted alphabetically. (QVariant::toInt): Added. (QVariant::toUInt): Added Int case, sorted alphabetically. (QVariant::asString): Added Int case, sorted alphabetically.

WebKit:

Reviewed by Maciej.

fixed 3126211 -- "go back" buttons that use "history.go(-1)" doesn't work (verizonwireless.com is an example)

Implemented new bridge functions for use by the history object.

History.subproj/WebBackForwardList.h: Added backListCount and entryAtIndex:.
History.subproj/WebBackForwardList.m: (-[WebBackForwardList backListCount]): Added. (-[WebBackForwardList entryAtIndex:]): Added.
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge historyLength]): Added. Calls backListCount. (-[WebBridge goBackOrForward:]): Added. Calls entryAtIndex: and then goBackOrForwardToItem:.

8:38 PM Changeset in webkit [3456] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

kjs/Makefile.am: Add dependencies so the .lut.h files get rebuilt if the script changes.

2:37 PM Changeset in webkit [3455] by cblu

23 edits
1 delete in trunk

WebCore:

Fixed: 3153605 - Drag image when dragging text should be the actual text

Reviewed by darin.

khtml/rendering/font.cpp: (Font::drawLineForText): take a "from" and "to" so only selected portions of text draw lines
khtml/rendering/font.h:
khtml/rendering/render_layer.cpp: (RenderLayer::paint): handle the selection-only case
khtml/rendering/render_layer.h:
khtml/rendering/render_root.cpp: (RenderRoot::selectionRect): new, computes bounding box of the selection
khtml/rendering/render_root.h:
khtml/rendering/render_text.cpp: (TextSlave::paintDecoration): take a "from" and "to" so only selected portions of text draw lines (RenderText::paintObject): when only drawing the selection, only draw selected text and no selection background (RenderText::paint): handle the selection-only case
khtml/rendering/render_text.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): handle the selection-only case (KWQKHTMLPart::selectionRect): new, returns the bounding box of the selection
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawLineForText): take a "from" and "to" so only selected portions of text draw lines
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): handle the selection-only case (-[WebCoreBridge selectionRect]): new, returns the bounding box of the selection clipped to visible (-[WebCoreBridge selectionImage]): new, returns the image of the selection

WebKit:

Fixed: 3153605 - Drag image when dragging text should be the actual text

Reviewed by darin.

Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_dissolveToFraction:]): handle non-flipped images
Misc.subproj/WebNSViewExtras.h: moved some constants around
Misc.subproj/WebNSViewExtras.m:
Resources/text_clipping.tiff: Removed.
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): cleaned-up, get text drag image from WebCore

1:57 PM Changeset in webkit [3454] by darin

2 edits in trunk/WebKit

Plugins.subproj/WebBaseNetscapePluginView.m: Replace some tabs with spaces.

Jan 24, 2003:

3:46 PM Changeset in webkit [3453] by rjw

2 edits in trunk/WebKit

Cleaned up some stray comments.

Reviewed by kocienda.

Misc.subproj/WebUnicode.m: (getShape): (nextChar): (glyphVariantLogical): (shapedString):

3:36 PM Changeset in webkit [3452] by hyatt

3 edits in trunk/WebCore

Fix for 3153260, tables used as height spacers don't get the
specified height.

Reviewed by rjw

khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

3:20 PM Changeset in webkit [3451] by trey

9 edits in trunk

WebCore:

Chris pointed out a FIXME that led to a more contained way to make sure the cursor
is correct during and after image/text/URL dragging.

Reviewed by Chris.

kwq/KWQKHTMLPart.h: Back out just-added resetCursor method.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Reset cursor to arrow when image drag starts.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: Back out just-added resetCursor method, which is no longer needed by WebKit.

WebKit:

Chris pointed out a FIXME that led to a more contained way to make sure the cursor
is correct during and after image/text/URL dragging.

Reviewed by Chris.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggedImage:endedAt:operation:]): No need to reset the cursor at the end of dragging. WC deals with it.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): No need to set the cursor to arrow, WC deals with it.

2:23 PM Changeset in webkit [3450] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3058229 -- two failures in DOM test page for HTMLSelectElement
fixed 3138938 -- choose another member name on .Mac signup not working as expected
fixed 3155763 -- Safari autoselects first item in a WOBrowser/<select>

khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::value): Return "" rather than null when nothing is selected. (HTMLSelectElementImpl::recalcListItems): Don't automatically select a first item in the single selection case.

12:48 PM Changeset in webkit [3449] by hyatt

2 edits in trunk/WebCore

Fix for 3146066, messed up lists on dictionary.com. Make
sure that a marker in an anonymous box with no other line box
parent available just stays where it is, rather than removing
itself from the anonymous box (causing that box to be deleted
and recreated ad infinitum).

Reviewed by darin

khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation):

12:45 PM Changeset in webkit [3448] by hyatt

3 edits in trunk/WebCore

Fix for 3146066, messed up lists on dictionary.com. Make
sure that a marker in an anonymous box with no other line box
parent available just stays where it is, rather than removing
itself from the anonymous box (causing that box to be deleted
and recreated ad infinitum).

Reviewed by darin

khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation):

12:36 PM Changeset in webkit [3447] by darin

8 edits in trunk

WebCore:

Reviewed by Dave.

fixed 3142852 -- frame content repeatedly requested

The bug was that JavaScript document.referrer was totally wrong.

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): Use the new incomingReferrer() rather than referrer(), because referrer() is the referrer to use for new loads in the part, not the one that was used to load the document.

kwq/KWQKHTMLPart.h: Added incomingReferrer(). Also removed referrer() which has been totally redundant since we made KWQKHTMLPart a subclass of KHTMLPart.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::incomingReferrer): Added. Uses the bridge.

kwq/WebCoreBridge.h: Added incomingReferrer.

WebKit:

Reviewed by Dave.

fixed 3142852 -- frame content repeatedly requested

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge incomingReferrer]): Added a way to get the referrer across the bridge, needed for bug fix.

11:55 AM Changeset in webkit [3446] by voas

2 edits in trunk/WebKit

Netscape plugins were being improperly positioned. I noticed this when I
put the web view into a window with borders around it (Carbon metal window,
but I would imagine Cocoa metal would do it too).

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):

11:14 AM Changeset in webkit [3445] by trey

8 edits in trunk

WebCore:

3155162 - cursor changes to I-beam after dragging image
3154468 - no mouseup event comes through after text snippet drag

Export a means to reset the cursor to WebKit, which is used to fix these bugs.

Reviewed by Darin.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::resetCursor): New method that just calls through to khtmlview's private resetCursor method.
kwq/WebCoreBridge.h: Add new method.
kwq/WebCoreBridge.mm: (-[WebCoreBridge resetCursor]): Call view's reset cursor.

WebKit:

3155162 - cursor changes to I-beam after dragging image
3154468 - no mouseup event comes through after text snippet drag

During AK dragging the system takes over the event stream and we never get any mouse
move or up events. It also changes the cursor behind out back. When done
cached state that thinks it knows the current cursor is wrong.

The fix is that after the drag we reset the cursor and synthesize a mouseup event,
which then sets the cursor based on what we're really over.

Reviewed by Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggedImage:endedAt:operation:]): After the drag, reset the cursor, fake up a mouseup event.

10:40 AM Changeset in webkit [3444] by trey

3 edits in trunk/WebCore

I ran our KURL tests and found that my previous fix for "localhost" urls, fixed too much.
This now passes all the tests.

Reviewed by Darin.

kwq/KWQKURL.mm: (KURL::parse): Use different logic for deciding to add authority to the URL and stripping localhost off of file URLs.

10:38 AM Changeset in webkit [3443] by sullivan

2 edits in trunk/WebKit

Reviewed by Trey

WebView.subproj/WebHTMLView.m: (-[WebHTMLView takeFindStringFromSelection:]): Now uses new _web_setFindPasteboardString:withOwner: to share code.

9:53 AM Changeset in webkit [3442] by sullivan

4 edits in trunk

WebKit:

Reviewed by Trey

Misc.subproj/WebNSPasteboardExtras.h:
Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_setFindPasteboardString:withOwner:]): New method to put text on the Find pasteboard.

WebBrowser:

fixed 3147083 -- Text in the "Google" field should be placed in the find pasteboard
fixed 3148130 -- Safari's Find submenu should use ellipses instead of three dots
fixed 3149466 -- There's no tooltip for the Home icon
fixed 3153618 -- Text drags appears to be accepted by the bookmarks bar

Reviewed by Trey

BrowserWindowController.m: (-[BrowserWindowController performQuickSearch:]): Use _web_setFindPasteboardString:withOwner: to put search string on find pasteboard

English.lproj/Browser.nib: added tooltip "Go to the home page."

English.lproj/MainMenu.nib: replaced all dot dot dots with ellipses

FavoritesBar.m: (-[FavoritesBar updateDropTarget:]): Bail out right away if there are no bookmarks on the pasteboard. This was being checked only at drop time.

FindPanelController.m: (-[FindPanelController controlTextDidEndEditing:]): Now uses _web_setFindPasteboardString:withOwner: (which was extracted from the code here).

9:46 AM Changeset in webkit [3441] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed null view and hang part of 3153612 -- REGRESSION: null view and hang loading cycleworld.com

khtml/xml/xml_tokenizer.cpp: (XMLHandler::XMLHandler): Initialize the line number to 0 so we can detect the case where we didn't get a fatal error callback. (XMLTokenizer::finish): Construct an error page without an XML excerpt if the line number if 0.

9:23 AM Changeset in webkit [3440] by darin

4 edits in trunk/WebCore

Reviewed by John.

fixed 3140945 -- crash viewing www.nextthing.org

khtml/rendering/render_container.cpp: (RenderContainer::removeLeftoverAnonymousBoxes): Change this function so it will never remove a table cell. Although a table cell that is created automatically is anonymous, it is not an anonymous box in the sense that this function is trying to deal with. Maybe there will be a better way to fix this some day, but this is the best Dave and I could come up with.

fixed 3155700 -- nil-dereference in khtml::RenderTableRow::detach shortly after visiting www.alltheweb.com

khtml/rendering/render_table.cpp: (RenderTableRow::detach): Check for nil before calling setNeedCellRecalc in case we are being detached after our parent is already nil.

Jan 23, 2003:

8:04 PM Changeset in webkit [3439] by rjw

3 edits in trunk/WebCore

Fix for 3152494. Set the default iframe width to 300 and
height to 150. This copies the behavior of mozilla and IE.

Reviewed by hyatt.

khtml/css/html4.css:

7:46 PM Changeset in webkit [3438] by rjw

5 edits in trunk/WebCore

WebCore:

Fixed whitespace exclusion code. Fixes many sites
that have problems that were exposed after
fixing 3119777.

Reviewed by hyatt.

khtml/rendering/bidi.cpp: (RenderFlow::bidiReorderLine): (RenderFlow::findNextLineBreak):
khtml/rendering/break_lines.cpp:
khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):

Test:

Tests for the fix above.

7:18 PM Changeset in webkit [3437] by hyatt

4 edits in trunk/WebCore

Dump textslaves in the regression tests.

Reviewed by rjw.

kwq/KWQRenderTreeDebug.cpp: (operator<<): (write):

7:05 PM Changeset in webkit [3436] by mjs

3 edits in trunk/WebKit

Reviewed by Trey.

WebView.subproj/WebController.h: Remove unneeded declaration in sample code.

4:52 PM Changeset in webkit [3435] by cblu

7 edits in trunk/WebKit

WebKit:

Made WebTextView use the same format for context menus as the rest of WebKit.
Implemented "Copy" context menu.

Reviewed by john.

English.lproj/Localizable.strings:
WebView.subproj/WebControllerPrivate.m: (-[WebController _menuForElement:]): tweak.
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): added "Copy" context menu.
WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): added asserts
WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]): implemented

WebBrowser:

Implemented context menus "Copy", "Google Search" and "Go To Address" context menus for selected text.

Reviewed by john.

BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController searchForString:]): new, does what chooseSearchString but takes a string (-[BrowserWindowController chooseSearchString:]): call searchForString
ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): added "Copy", "Google Search" and "Go To Address" (-[ContextMenuHandler search:]): calls searchForString (-[ContextMenuHandler goToAddress:]): does what it says
English.lproj/Localizable.strings:

3:33 PM Changeset in webkit [3434] by hyatt

5 edits in trunk/WebCore

Fix for 3144763, inlines clear too many floats, and jump all the
way to the end of the lowest float instead of only moving as far
down as they have to in order to fit.

Reviewed by darin

khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):
khtml/rendering/render_flow.cpp: (RenderFlow::nearestFloatBottom):
khtml/rendering/render_flow.h:

2:51 PM Changeset in webkit [3433] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3144560 -- non-reproducible nil-dereference in HTMLFrameElementImpl::updateForNewURL at macfixit

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Add check for nil view.

2:38 PM Changeset in webkit [3432] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3154647 -- Triple clicked on a line of text (to select entire line), crashola

khtml/khtml_part.cpp: (firstSlaveAt): Loop instead of using recursion for siblings. (lastSlaveAt): Ditto, only backwards.

1:54 PM Changeset in webkit [3431] by hyatt

2 edits in trunk/WebCore

Fix for 3142124.

When pseudo-elements have display:none, they should not generate
rendering objects.

Reviewed by rjw, kocienda.

khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):

1:54 PM Changeset in webkit [3430] by mjs

3 edits in trunk/WebKit

Reviewed by Darin.

WebView.subproj/WebController.m: Add missing static.

1:52 PM Changeset in webkit [3429] by hyatt

3 edits in trunk/WebCore

Fix for 3142124.

When pseudo-elements have display:none, they should not generate
rendering objects.

Reviewed by darin.

khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):

1:29 PM Changeset in webkit [3428] by darin

9 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3129556 -- can't search on japanese string at yahoo.co.jp

The key to fixing this was to look up character sets in a way that does not
pay attention to punctuation. Only alphanumeric characters count. Also did
a little belt tightening and speeding up while I was at it.

kwq/KWQCharsets.h: Use const char * instead of CFStringRef.
kwq/KWQCharsets.mm: (buildDictionaries): Store const char * in the dictionaries instead of CFStringRef, and use the key compare and hash functions that obey only alphanumeric characters. (KWQCFStringEncodingFromIANACharsetName): Use const char * directly. (KWQCFStringEncodingFromMIB): Tweak code a bit. (KWQCFStringEncodingToIANACharsetName): Use const char * directly. (KWQCFStringEncodingToMIB): Tweak code a bit. (encodingNamesEqual): Added. Compares two names, ignoring non-alphanumeric characters. (encodingNameHash): Added.

kwq/KWQKCharsets.h: Take a const char * instead of a QString. Also overload for QCString. This fixes conversion back and forth from QString that was happening before.
kwq/KWQKCharsets.mm: (KCharsets::codecForName): Update for above parameter change.

kwq/KWQTextCodec.mm: (codecForCFStringEncoding): Add check for kCFStringEncodingInvalidId. (QTextCodec::codecForMib): Simplify because of above check. (QTextCodec::codecForName): Simplify because we don't need to make a CFStringRef, and because of above check. (QTextCodec::name): No need to convert the CFStringRef back to a const char * now.

kwq/WebCoreBridge.mm: (-[WebCoreBridge textEncoding]): Convert character set name to a const char * to pass in. (+[WebCoreBridge stringWithData:textEncodingName:]): Ditto.
kwq/WebCoreEncodings.mm: (+[WebCoreEncodings charsetNameForEncoding:]): Convert character set name to an NSString to use as a return value. (+[WebCoreEncodings encodingForCharsetName:]): Convert character set name to a const char * to pass in.

1:25 PM Changeset in webkit [3427] by cblu

3 edits in trunk/WebCore

Fixed a divide by zero problem.

Reviewed by darin.

WebCore.pbproj/project.pbxproj:
khtml/rendering/render_image.cpp: (RenderImage::calcReplacedWidth): (RenderImage::calcReplacedHeight):

1:20 PM Changeset in webkit [3426] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

fixed last minute screwup in my last patch fixing onchange

kwq/KWQTextField.mm: (-[KWQTextField fieldEditorWillBecomeFirstResponder]): Renamed from fieldWillBecomeFirstResponder. (-[KWQTextField fieldEditorWillResignFirstResponder]): Renamed from fieldWillResignFirstResponder.

1:13 PM Changeset in webkit [3425] by mjs

3 edits in trunk/WebCore

Reviewed by Trey.

fixed 3151442 - mac.com homepage editing - selection and clicking with mouse don't work

khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Only allow a false return value to prevent default if this is an html event handler, rather than one set with addEventListener or the like.

12:23 PM Changeset in webkit [3424] by cblu

23 edits in trunk/WebCore

Replaced the paint phase constants with the PaintAction enum. Added PaintActionSelection as a paint action. This will eventually allow us to only paint selected objects. This is needed for the text dragging image.

Reviewed by dave.

khtml/rendering/render_box.cpp: (RenderBox::paint):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::paint): (RenderFlow::paintObject): (RenderFlow::paintFloats):
khtml/rendering/render_flow.h:
khtml/rendering/render_html.cpp: (RenderHtml::paint):
khtml/rendering/render_html.h:
khtml/rendering/render_image.cpp: (RenderImage::paintObject):
khtml/rendering/render_image.h:
khtml/rendering/render_layer.cpp: (RenderLayer::paint):
khtml/rendering/render_list.cpp: (RenderListItem::paint): (RenderListItem::paintObject): (RenderListMarker::paint): (RenderListMarker::paintObject):
khtml/rendering/render_list.h:
khtml/rendering/render_object.cpp: (RenderObject::paint):
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): (RenderWidget::paintObject):
khtml/rendering/render_replaced.h:
khtml/rendering/render_root.cpp: (RenderRoot::paint): (RenderRoot::paintObject):
khtml/rendering/render_root.h:
khtml/rendering/render_table.cpp: (RenderTable::paint): (RenderTableSection::paint): (RenderTableCell::paint):
khtml/rendering/render_table.h:
khtml/rendering/render_text.cpp: (RenderText::paintObject): (RenderText::paint):
khtml/rendering/render_text.h:

12:03 PM Changeset in webkit [3423] by darin

9 edits in trunk/WebKit

WebFoundation:

Reviewed by John.

Misc.subproj/WebNSFileManagerExtras.h: Change the too broad "FinderInfo" to the accurate "FinderFlags". The property does not contain all the FinderInfo, rather just the flags.

Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_createFileAtPath:contents:attributes:]): Update for the FinderFlags name change. (-[NSFileManager _web_carbonPathForPath:]): Use fileSystemRepresentation instead of fileSystemRepresentationWithPath: because it's simpler and there's no good reason to use the other one.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

Reviewed by John.

Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder fileAttributes]):
Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder fileAttributes]): Use "FinderFlags" instead of "FinderInfo" as appropriate, since these are just the Finder flags, not all the Finder info.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]):
Misc.subproj/WebNSWorkspaceExtras.m: (-[NSWorkspace _web_noteFileChangedAtPath:]):
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage load]): Use fileSystemRepresentation instead of fileSystemRepresentationWithPath: because it's simpler and there's no good reason to use the other one.

WebView.subproj/WebUserAgentSpoofTable.gperf: Improved one of the motivating comments.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

Reviewed by John.

BrowserNSWorkspaceExtras.m: (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:event:]): Use fileSystemRepresentation instead of fileSystemRepresentationWithPath: because it's simpler and there's no good reason to use the other one.

11:54 AM Changeset in webkit [3422] by hyatt

4 edits in trunk/WebCore

Fix for 3147995, empty <li> tags don't render bullets.

Reviewed by john.

khtml/rendering/render_list.cpp: (RenderListItem::layout):
khtml/rendering/render_list.h:

11:42 AM Changeset in webkit [3421] by hyatt

4 edits in trunk/WebCore

Fix for 3134613, bullets overlapping text on weather.com. Make
sure min/max widths get updated when the marker moves around.

Reviewed by john

khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): (RenderListItem::calcMinMaxWidth): (RenderListItem::layout):
khtml/rendering/render_list.h:

11:38 AM Changeset in webkit [3420] by sheridan

3 edits in trunk

55u versions

11:25 AM Changeset in webkit [3419]

3 copies in tags/Safari-54

This commit was manufactured by cvs2svn to create tag 'Safari-54'.

11:25 AM Changeset in webkit [3418] by sheridan

8 edits in trunk

Safari-54 stamp

9:33 AM Changeset in webkit [3417] by darin

5 edits in trunk/WebCore

Reviewed by Dave.

fixed 3154575 -- REGRESSION: Right sidebar on Yahoo! page in base PLT renders incorrectly

khtml/rendering/break_lines.cpp: (isBreakable): Pass kUCTextBreakLineMask to the UC calls, which looks for places where line breaks are allowed, instead of kUCTextBreakWordMask, which finds all word breaks instead. We still pass all the layout tests, so I think this means Japanese word breaking is still OK.

fixed 3154416 -- images that specify width but not height should keep aspect ratio (example at thegods.org.uk)

khtml/rendering/render_image.h: Declared new member functions.
khtml/rendering/render_image.cpp: (RenderImage::widthSpecified): Added helper function. (RenderImage::heightSpecified): Added helper function. (RenderImage::calcReplacedWidth): Added. Derives width from height keeping aspect ratio if we have a specified height and no width. (RenderImage::calcReplacedHeight): Added. Same thing in the opposite direction.

1:03 AM Changeset in webkit [3416] by trey

3 edits in trunk/WebCore

3153313 cursor changes during text selection when we cross links

Reviewed by Dave.

khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Remember mouse is down. (KHTMLView::viewportMouseMoveEvent): Use ibeam while mouse down. (KHTMLView::viewportMouseReleaseEvent): Remember that it's up.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed