Context Navigation

← Previous Period
Next Period →

Timeline

Sep 27, 2004:

6:08 PM Changeset in webkit [7704] by sullivan

4 edits in trunk/WebKit

fixed <rdar://problem/3814705> 8A266: Safari authentication dialog "remember password" text should match Mail

Panels.subproj/English.lproj/WebAuthenticationPanel.nib: changed "Remember this password" to "Remember this password in my keychain"; this will need to go through CCC for this week's build.

6:01 PM Changeset in webkit [7703] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

5:58 PM Changeset in webkit [7702] by hyatt

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Don't allow nested headers when only inlines are in between them. Fixes a hang related to pathological nesting
on magicmethodsonline.com.

Reviewed by darin

khtml/html/htmlparser.cpp: (KHTMLParser::parseToken): (KHTMLParser::processCloseTag): (KHTMLParser::isHeaderTag): (KHTMLParser::popNestedHeaderTag):
khtml/html/htmlparser.h:

5:57 PM Changeset in webkit [7701] by hyatt

2 edits in trunk/WebCore/khtml/html

ChangeLog

4:17 PM Changeset in webkit [7700] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3594754> change null event interval from 20 ms to 10 ms to match speed on Windows

Reviewed by NOBODY (OOPS!).

Plugins.subproj/WebBaseNetscapePluginView.m:

3:56 PM Changeset in webkit [7699] by cblu

1 edit in trunk/WebKit/ChangeLog

WebKit:

Fixed previous reviewer line.

ChangeLog:

WebBrowser:

Fixed typo.

ChangeLog:

3:22 PM Changeset in webkit [7698] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3502138> text files don't remember scroll position when going back or reloading

Reviewed by .

WebView.subproj/WebTextView.m: (-[WebTextView layout]): implemented, call sizeToFit, without this scrollPoint: won't work

2:30 PM Changeset in webkit [7697] by sullivan

6 edits in trunk/WebKit

WebKit:

Reviewed by Ken.

WebKit part of fix for <rdar://problem/3734466> ER: Support standard editing keystrokes like Cmd-B while editing rich text

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _toggleBold]): new method, toggles font-weight from "bold" to "normal" (-[WebHTMLView _toggleItalic]): new method, toggles font-style from "italic" to "normal" (-[WebHTMLView _handleStyleKeyEquivalent:]): new method, if the new preference is set and we're in an editable state, check for standard key equivalents for toggling styles (just command-B and command-I for now). (-[WebHTMLView performKeyEquivalent:]): Moved in file, now calls _handleStyleKeyEquivalent:

WebView.subproj/WebPreferenceKeysPrivate.h: new preference key WebKitRespectStandardStyleKeyEquivalentsPreferenceKey
WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): initial value of WebKitRespectStandardStyleKeyEquivalentsPreferenceKey is NO (maybe we'll change our minds about this, but this is more guaranteed to be backward-compatible) (-[WebPreferences respectStandardStyleKeyEquivalents]): read WebKitRespectStandardStyleKeyEquivalentsPreferenceKey (-[WebPreferences setRespectStandardStyleKeyEquivalents:]): write WebKitRespectStandardStyleKeyEquivalentsPreferenceKey

WebView.subproj/WebPreferencesPrivate.h: declare getter and setter

English.lproj/StringsNotToBeLocalized.txt: updated for these and other recent changes

WebBrowser:

Reviewed by Ken.

WebBrowser part of fix for <rdar://problem/3734466> ER: Support standard editing keystrokes like Cmd-B while editing rich text

AppController.m: (-[AppController applicationDidFinishLaunching:]): turn on the new WebKit preference that makes command-B and command-I toggle styles in editable text.

11:41 AM Changeset in webkit [7696] by cblu

2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3806649> assertion failure after control-click of webcam

Reviewed by john.

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate contextMenuItemsForElement:]): don't provide "Copy Image" if the image is not fully loaded

WebBrowser:

Fixed: Fixed: <rdar://problem/3806649> assertion failure after control-click of webcam

Reviewed by john.

ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): don't provide "Save Image", "Copy Image" and "Add Image to iPhoto Library" if the image is not fully loaded. Provide "Download Image" instead.

11:39 AM Changeset in webkit [7695] by hyatt

1 edit in trunk/LayoutTests/fast/frames/contentWindow_Frame-expected.txt

land fixed frame result.

11:35 AM Changeset in webkit [7694] by hyatt

1 edit in trunk/LayoutTests/fast/overflow/003-expected.txt

Land fixed overflow result.

11:00 AM Changeset in webkit [7693] by kdecker

2 edits in trunk/WebCore

Reviewed by John.

khtml/css/css_base.cpp: (CSSSelector::selectorText): changed another ATTR_CLASS case to properly return class selector names.

10:52 AM Changeset in webkit [7692] by hyatt

8 edits in trunk/WebCore

Fix style sharing so that it doesn't share when it shouldn't. Partially fixes 3671516, table cells don't update
their color on macosx.apple.com.

Fix 3521639, iframe mispositioned on bidi page. Make sure that when the width of a line exceeds the available line
width that the spillage out of the block is determined by the direction of the block and not by the text-align value.

Partial fix for 3762962, make sure the image cells with specified widths but percentage heights don't just get a minwidth
of 0.

Fix for 3533878, framesets that use percentages that add up to a value > 100% should normalize those percentages.

Reviewed by john

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::locateCousinList): (khtml::CSSStyleSelector::elementsCanShareStyle): (khtml::CSSStyleSelector::locateSharedStyle):
khtml/css/cssstyleselector.h:
khtml/html/html_elementimpl.h: (DOM::HTMLNamedAttrMapImpl::hasMappedAttributes): (DOM::HTMLElementImpl::inlineStyleDecl):
khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine):
khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::inlineStyleDecl): (DOM::ElementImpl::hasMappedAttributes):

10:49 AM Changeset in webkit [7691] by kocienda

18 edits
3 adds in trunk

Reviewed by John

Removed closestRenderedPosition function from Position class and gave this work
to VisiblePosition instead. However, in order to make the transfer possible,
VisiblePosition needed upstream and downstream affinities added to its
constructors. Also moved the EAffinity enum into its own file. Also moved it
to the khtml namespace.

Updated several functions which used closestRenderedPosition to use VisiblePosition
instead.

Also deleted Position::equivalentShallowPosition. This was unused.

ForwardingHeaders/editing/text_affinity.h: Added.
ForwardingHeaders/editing/visible_position.h: Added.
WebCore.pbproj/project.pbxproj: Added new files.
khtml/editing/selection.cpp: (khtml::Selection::validate): Use VisiblePosition instead of closestRenderedPosition.
khtml/editing/selection.h:
khtml/editing/text_affinity.h: Added.
khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): (khtml::VisiblePosition::initUpstream): New helper for finding upstream visible position. (khtml::VisiblePosition::initDownstream): Was old init function that unconditionally did downstream checks for visible position. Renamed to describe this more clearly.
khtml/editing/visible_position.h:
khtml/editing/visible_units.cpp: (khtml::previousWordBoundary): Use VisiblePosition instead of closestRenderedPosition. (khtml::nextWordBoundary): Use VisiblePosition instead of closestRenderedPosition.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Use VisiblePosition instead of closestRenderedPosition.
khtml/xml/dom_position.cpp: (DOM::Position::closestRenderedPosition): Removed.
khtml/xml/dom_position.h: Removed two functions mentioned above.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection) Use VisiblePosition instead of closestRenderedPosition.:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): Use VisiblePosition instead of closestRenderedPosition.
layout-tests/editing/deleting/delete-block-merge-contents-012-expected.txt: Updated expected results.
layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt: Ditto.
layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt: Ditto.
layout-tests/editing/selection/move-by-character-004-expected.txt: Ditto.

9:36 AM Changeset in webkit [7690] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3814810> REGRESSION (125-164): Exception adding nil to dictionary in dragging code

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setMouseDownEvent:]): new (-[WebHTMLView acceptsFirstMouse:]): call _setMouseDownEvent (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto (-[WebHTMLView mouseDown:]): ditto (-[WebHTMLView _delegateDragSourceActionMask]): removed temp fix, assert that the mouse event is not nil

8:30 AM Changeset in webkit [7689] by darin

2 edits in trunk/WebKit

WebKit.pbproj/project.pbxproj: Added WebDashboardRegion.h as a private header.

7:44 AM Changeset in webkit [7688] by kocienda

13 edits
3 deletes in trunk/WebCore

Reviewed by Darin and Maciej

Removed EditCommand smart pointer wrappers from htmlediting.cpp/.h, save for the one
at the root of the hierarchy, and this one has been renamed EditCommandPtr. Renamed
each of the XXXCommandImpl classes, removing the Impl suffix from each, and rolled
these into the htmlediting.cpp/.h files. The htmlediting_impl.cpp/.h files have
been emptied and are being removed.

For the remainder of files, perform the mechanical changes necessary to make everything
compile and run as before.

WebCore.pbproj/project.pbxproj
khtml/editing/htmlediting.cpp
khtml/editing/htmlediting.h
khtml/editing/htmlediting_impl.cpp: Removed.
khtml/editing/htmlediting_impl.h: Removed.
khtml/editing/jsediting.cpp
khtml/khtml_part.cpp (KHTMLPart::openURL) (KHTMLPart::lastEditCommand) (KHTMLPart::appliedEditing) (KHTMLPart::unappliedEditing) (KHTMLPart::reappliedEditing) (KHTMLPart::applyStyle):
khtml/khtml_part.h
khtml/khtmlpart_p.h
kwq/KWQEditCommand.h
kwq/KWQEditCommand.mm (-[KWQEditCommand initWithEditCommandImpl:]) (+[KWQEditCommand commandWithEditCommandImpl:]) (-[KWQEditCommand impl])
kwq/KWQKHTMLPart.h
kwq/KWQKHTMLPart.mm (KWQKHTMLPart::registerCommandForUndo) (KWQKHTMLPart::registerCommandForRedo)
kwq/WebCoreBridge.mm (-[WebCoreBridge undoEditing:]) (-[WebCoreBridge redoEditing:]) (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:smartReplace:]) (-[WebCoreBridge moveSelectionToDragCaret:smartMove:]) (-[WebCoreBridge deleteSelectionWithSmartDelete:])

Sep 26, 2004:

9:59 PM Changeset in webkit [7687] by darin

5 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3816170> image.width/height not available from Image objects (works in Firefox)

khtml/ecma/kjs_html.h: Added width and height.
khtml/ecma/kjs_html.cpp: (Image::getValueProperty): Added width and height.
khtml/ecma/kjs_html.lut.h: Regenerated.

unrelated change; changed ordering of use count manipulation just in case we decide some day to do something when the use count hits 0

khtml/rendering/render_image.cpp: (RenderImage::setPixmap): Increment use count on new object before decrementing use count on old object.

7:07 PM Changeset in webkit [7686] by darin

10 adds in trunk/LayoutTests/fast

New layout tests for the bugs I just fixed.

6:54 PM Changeset in webkit [7685] by darin

2 edits in trunk/JavaScriptCore

kjs/string_object.cpp: (StringProtoFuncImp::call): Remove strange use of high() and low() to get Unicode value of character, and just use unicode().

6:52 PM Changeset in webkit [7684] by darin

2 edits in trunk/JavaScriptCore

refine charAt/charCodeAt fix slightly

kjs/string_object.cpp: (StringProtoFuncImp::call): Treat undefined the same was as an omitted parameter, as we do everywhere else, and as other browsers do here.

6:02 PM Changeset in webkit [7683] by darin

8 edits in trunk/WebCore

Reviewed by Kevin.

fixed <rdar://problem/3812771> document.implementation.hasFeature returns false for a lot of features we implement

khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature): Added all the DOM features that we implemented as part of the HTML editing work.

khtml/dom/dom_node.cpp: (Node::isSupported): Changed this to call DOMImplementationImpl::hasFeature to share code. Later this might need to be different per-node, but at the moment that does not seem to be so.

khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Pass a null string if the parameter is omitted, undefined, or null. This is better than having a special case for the string "null" in the DOM implementation. (DOMDOMImplementationProtoFunc::tryCall): Ditto.

fixed <rdar://problem/3814605> REGRESSION: fast/table/039 layout test is failing due to extra trailing whitespace in innerText

khtml/editing/visible_text.cpp: (khtml::TextIterator::advance): Check for the case where we are at the end of iteration, and don't call exitNode in that case. This prevents us from getting some unwanted trailing \n characters.

fixed <rdar://problem/3813253> method cloneNode() does not clone dynamically-set style attributes correctly

khtml/html/html_elementimpl.h: Added cloneNode override.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Added. Copies m_inlineStyleDecl. (HTMLElementImpl::parseHTMLAttribute): Changed to use getInlineStyleDecl(). (HTMLElementImpl::innerText): Changed to do the same thing with fewer lines of code. (HTMLElementImpl::outerText): Tweaked comment.

other cleanup

khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Removed an uneeded type cast. (XMLElementImpl::cloneNode): Ditto.

6:01 PM Changeset in webkit [7682] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Kevin.

fixed <rdar://problem/3816097> REGRESSION: mailblocks, and presumably many other pages, failing because variable not found

kjs/internal.cpp: (InterpreterImp::evaluate): Process variable declarations before executing the program. We were doing this properly for functions, but not entire programs.

fixed <rdar://problem/3814706> REGRESSION: text fields in mailblocks wizards do not accept keystrokes due to use of charCodeAt()

kjs/string_object.cpp: (StringProtoFuncImp::call): Changed the implementation of charAt and charCodeAt to treat a missing parameter as an index of 0, rather than an invalid index.

tests/mozilla/expected.html: Update for two tests that now pass with these changes.

Sep 24, 2004:

5:44 PM Changeset in webkit [7681] by kdecker

2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/3799334> DIG: Safari does not properly return style names [DigCSS.htm]

khtml/css/css_base.cpp: (CSSSelector::selectorText): Properly returns Class Selector names. Before we would get *[CLASS"foo"] instead of .foo

4:27 PM Changeset in webkit [7680] by kocienda

2 edits
2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3814660> REGRESSION (8A200-8A259): Select All has no effect on livepage.apple.com

khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Move the selection start and end to rendered positions before passing off to the RenderCanvas for drawing.
layout-tests/editing/selection/select-all-004-expected.txt: Added.
layout-tests/editing/selection/select-all-004.html: Added.

4:23 PM Changeset in webkit [7679] by sullivan

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3528339> Turn on full keyboard access shows invisible <input> elements

khtml/html/html_formimpl.cpp: (DOM::HTMLGenericFormElementImpl::isFocusable): reject elements that have zero width or height, even if they aren't hidden

4:09 PM Changeset in webkit [7678] by mjs

2 edits in trunk/WebCore

fixed deployment build

Reviewed by Ken.

khtml/dom/dom_string.cpp: put implementation of ascii() in #ifdef !NDEBUG to match prototype.

3:38 PM Changeset in webkit [7677] by hyatt

1 edit in trunk/LayoutTests/fast/table/037.xml

Fix layout test 37.

3:14 PM Changeset in webkit [7676] by hyatt

2 edits in trunk/WebCore

Fix for 3800316, test 37 for tables is failing on the layout tests. Make sure we don't incorrectly match
non-HTML elements with HTML tag selectors in CSS.

Reviewed by rjw

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):

3:09 PM Changeset in webkit [7675] by hyatt

4 edits in trunk/WebCore

Fix for 3601920, CSS "tabs" not switching properly on zen garden design. Improve the repainting to account
for layer changes of z-index that necessitate an invalidation.

Reviewed by kocienda

khtml/rendering/render_object.cpp: (RenderObject::setStyle):
khtml/rendering/render_style.cpp: (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::RenderStyle::):

2:44 PM Changeset in webkit [7674] by cblu

7 edits in trunk

WebCore:

Made markup copying 5 times faster. Unfortunately, this still doesn't fix:
<rdar://problem/3794799> Tiger8A252: copying a bunch o' text is so slow it seems like a hang

Reviewed by rjw.

khtml/dom/dom_string.h:
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): serialize the range by iterating through the range
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::startMarkup): new, factored out from recursive_toString (NodeImpl::endMarkup): ditto (NodeImpl::recursive_toString): call factored out methods
khtml/xml/dom_nodeimpl.h:

WebKit:

Reviewed by rjw.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedArchive]): added timing code for copying markup

2:42 PM Changeset in webkit [7673] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (v166u)

2:31 PM Changeset in webkit [7672]

3 copies in tags/Safari-165

This commit was manufactured by cvs2svn to create tag 'Safari-165'.

2:31 PM Changeset in webkit [7671] by vicki

6 edits in trunk

Safari-165 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (165 for both).

1:34 PM Changeset in webkit [7670] by cblu

2 edits in trunk/WebKit

Temp fix for: <rdar://problem/3814810> REGRESSION (125-164): Exception adding nil to dictionary in dragging code

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _delegateDragSourceActionMask]): return none if the mouse down event is nil

11:12 AM Changeset in webkit [7669] by kocienda

3 edits in trunk

Reviewed by me

Hyatt made an improvement in the render tree which caused the results
to get a little thinner.

layout-tests/editing/deleting/delete-block-merge-contents-001-expected.txt.
layout-tests/editing/deleting/delete-block-merge-contents-008-expected.txt.

10:51 AM Changeset in webkit [7668] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3812939> REGRESSION: move-between-blocks-no-001 editing layout test fails in DeleteSelectionCommandImpl

khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild): Hyatt said this regression was caused by a bad merge. Found by code inspection.

10:49 AM Changeset in webkit [7667] by kocienda

3 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3813917> REGRESSION (125-163): The font panel will change the font of any web page

We were doing a laughably bad job at preventing edits in documents that were not editable.
This change fixes the specific case of the bug mentioned above, and makes an attempt to
fix similar bugs by checking for whether the view is in editing mode before making edits.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canEdit]): Renamed from _canType. Used in many more places in the code now. (-[WebHTMLView _isMoveDrag]): Change around code to make the meaning more clear. This one was actually performing a correct check before. (-[WebHTMLView keyDown:]): Renamed _canType to _canEdit. (-[WebHTMLView paste:]): Don't beep if can't paste. This matches AppKit. Any paste-related beeps will come from failure to handle key equivalent. Menu validation will kick in to dim menu. (-[WebHTMLView _applyStyleToSelection:]): Bail if !_canEdit. (-[WebHTMLView pasteAsPlainText:]): Ditto. (-[WebHTMLView _alignSelectionUsingCSSValue:]): Ditto. (-[WebHTMLView insertNewline:]): Ditto. (-[WebHTMLView insertParagraphSeparator:]): Ditto. (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto. (-[WebHTMLView _deleteWithDirection:granularity:killRing:]): Ditto. (-[WebHTMLView complete:]): Ditto. (-[WebHTMLView _changeSpellingToWord:]): Ditto. Some code rearranging to eliminate bridge local variable. (-[WebHTMLView ignoreSpelling:]): Ditto. (-[WebHTMLView yank:]): Bail if !_canEdit. (-[WebHTMLView yankAndSelect:]): Ditto. (-[WebHTMLView deleteToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto. (-[WebHTMLView transpose:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto. Some code rearranging to eliminate bridge local variable. (-[WebHTMLView setMarkedText:selectedRange:]): Bail if !_canEdit. (-[WebHTMLView _insertText:selectInsertedText:]): Ditto. Some code rearranging to eliminate bridge local variable.
WebView.subproj/WebHTMLViewPrivate.h: Renamed _canType to _canEdit.

9:37 AM Changeset in webkit [7666] by kocienda

2 edits in trunk/WebKit

Reviewed by me

WebCoreSupport.subproj/WebDashboardRegion.h: Check in file copied from WebCore.

8:35 AM Changeset in webkit [7665] by sullivan

2 adds in trunk/LayoutTests/fast/tokenizer

Layout tests for acceptable and unacceptable values of "language" and "type" attributes for <script> tags.

Sep 23, 2004:

7:20 PM Changeset in webkit [7664] by sullivan

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3551850> hang caused by interpreting bad javascript guarded by a deliberately bogus "language" attribute (www.riibe.com)

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): Check for language attribute of <script> tag in a way that matches WinIE. Previously we were far too permissive.

5:27 PM Changeset in webkit [7663] by hyatt

2 edits in trunk/WebCore

Fix for 3685234 and 3548444, the x-offset for frame borders was off by 1 pixel, causing mojibake to occur when
repainting happened.

khtml/rendering/render_canvas.cpp: (RenderCanvas::repaintViewRectangle):

5:17 PM Changeset in webkit [7662] by rjw

12 edits in trunk/WebCore

Fixed <rdar://problem/3813271> dashboard-region-circle and dashboard-region-rectangle should be collapsed into dashboard-region
Fixed <rdar://problem/3813289> dashboard regions need to correctly account for overflow/scrolling

Reviewed by Chris.

khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText):
khtml/css/css_valueimpl.h:
khtml/css/cssparser.cpp: (CSSParser::parseValue): (skipCommaInDashboardRegion): (CSSParser::parseDashboardRegions):
khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::updateDashboardRegions):
khtml/khtmlview.h:
khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset):
khtml/rendering/render_object.cpp: (RenderObject::addDashboardRegions):
khtml/rendering/render_object.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dashboardRegionsChanged):
kwq/WebDashboardRegion.h:
kwq/WebDashboardRegion.m: (-[WebDashboardRegion initWithRect:clip:type:]): (-[WebDashboardRegion dashboardRegionClip]): (-[WebDashboardRegion description]):

5:05 PM Changeset in webkit [7661] by kocienda

2 edits in trunk/WebCore

Reviewed by Richard

khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent): Make the "empty block" check the same as the one use in visible position. This fixes a recent regression which broke up and down arrowing between blocks with an empty block in between.

2:25 PM Changeset in webkit [7660] by mjs

4 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/3685235> REGRESSION (Mail): links are not properly editable

khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): If this element is editable, then follow the normal focus rules so the link does not swallow focus when you arrow key or drag-select into it.

WebKit:

Reviewed by Darin.

<rdar://problem/3685235> REGRESSION (Mail): links are not properly editable

WebView.subproj/WebDefaultUIDelegate.m: By default, don't allow link dragging if the element under the mouse pointer is editable. This way, you can drag-select starting inside a link.

10:56 AM Changeset in webkit [7659] by sullivan

3 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

WebKit part of fix for <rdar://problem/3415264> Default encoding should initially be set to current system encoding

WebView.subproj/WebPreferences.m: (-[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): new SPI that sets the initial value of the default text encoding to be the system encoding, with a special-case conversion of MacRoman->Latin1. This is not done automatically for WebKit clients for fear of breaking them.

WebView.subproj/WebPreferencesPrivate.h: declare new SPI

WebBrowser:

Reviewed by Chris.

WebBrowser part of fix for <rdar://problem/3415264> Default encoding should initially be set to current system encoding

AppController.m: (-[AppController applicationDidFinishLaunching:]): call new SPI -[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]

10:47 AM Changeset in webkit [7658] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_block.cpp

* empty log message *

10:29 AM Changeset in webkit [7657] by darin

1 edit
2 adds in trunk

added test for the DOM::Range bug fixed recently

layout-tests/fast/dom/clone-contents-0-end-offset-expected.txt: Added.
layout-tests/fast/dom/clone-contents-0-end-offset.html: Added.

10:22 AM Changeset in webkit [7656] by hyatt

4 edits in trunk/WebCore

Fix for hitlist bug, crash when deleting.

Also fix repaint bug when inlines are inside overflow:auto/scroll regions.

Reviewed by kocienda

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::DeleteSelectionCommandImpl): (khtml::DeleteSelectionCommandImpl::doApply):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):
khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):

9:52 AM Changeset in webkit [7655] by sullivan

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3527840> reproducible crash at johnbrown.v32.qikker.com (nil-deref in NodeImpl::dispatchEvent)

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent): guard against document or document->document() being nil

9:10 AM Changeset in webkit [7654] by darin

6 edits
2 adds in trunk/WebCore

Reviewed by Ken.

added new VisibleRange class; not used yet

WebCore.pbproj/project.pbxproj: Added visible_range.h and visible_range.cpp.
khtml/editing/visible_range.cpp: Added.
khtml/editing/visible_range.h: Added.

tweaks

kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Use switch statement instead of if statement so we get a warning if we ever add a new granularity.

khtml/editing/selection.h: khtml, not DOM, namespace
khtml/editing/visible_position.h: Ditto.

9:08 AM Changeset in webkit [7653] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3812758> 8S266: attaching mutation events to an editable div crashes Safari

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent): Added ref/deref so this works if passed a "floating" event object. (NodeImpl::dispatchGenericEvent): Ditto. (NodeImpl::dispatchHTMLEvent): Removed unneeded ref/deref now that dispatchEvent takes care of it. (NodeImpl::dispatchMouseEvent): Ditto. (NodeImpl::dispatchUIEvent): Ditto.

9:05 AM Changeset in webkit [7652] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed some minor mistakes discovered by code inspection

khtml/khtml_part.cpp: (KHTMLPart::setSelection): Changed to not grab focus if clearing the selection. Grabbing focus when we get the selection is also probably something that should be conditional, since you can use a WebView in a mode where it can have selection even when not first responder, ala NSTextView. (KHTMLPart::setCaretVisible): Changed to not grab focus if making the caret invisible. Not sure if it's ever important to grab focus when making the caret visible, but by code inspection it seemed that was unlikely to do harm.

9:03 AM Changeset in webkit [7651] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3790595> "ERROR: unimplemented propertyID: 97" logged to console when copying selection (table-layout)

khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added CSS_PROP_TABLE_LAYOUT case.

9:02 AM Changeset in webkit [7650] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3809600> REGRESSION: text in search field doesn't disappear when clicked at developer.apple.com

Reversing the order of scope caused us to get and set too many properties in the window
object; in the case of this bug setting value ended up setting a window.value property
instead of the value of the <input> element.

khtml/ecma/kjs_window.h: Removed bogus hasProperty function that always returns true. Testing shows that MacIE and Gecko match our behavior when we remove this, despite the "need this to match IE behavior" comment in the file, which I believe is incorrect.
khtml/ecma/kjs_window.cpp: Ditto.

8:58 AM Changeset in webkit [7649] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3812471> -[DOMRange cloneContents] clones too much in some cases where endOffset is 0

khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::processContents): Added some nil checks to prevent this function from crashing if offsets are greater than the number of child nodes. Added a special case for offset 0 in one case that has a loop that won't work correctly for that case.

8:50 AM Changeset in webkit [7648] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3811890> when selecting and moving the caret, some words aren't spell-checked (test case included)

This was mostly fixed by changes I made recently, but using the test case in the bug
I discovered one regression I introduced and another problem that wasn't fixed yet.
This change fixes both.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::markMisspellingsInSelection): Removed unneeded inRenderedContent() check. It was returning false in cases involving a <br> at the end of line, and the check isn't all that helpful now that we use VisiblePosition, which takes care of that sort of thing for you. Changed code to determine the range to check to use the two different flavors of word boundary to expand to words we touch in both directions. (KWQKHTMLPart::updateSpellChecking): Changed to use the same logic about word boundaries. By being consistent, the anomalies reported in the bug report go away.

8:22 AM Changeset in webkit [7647] by darin

3 edits in trunk/WebKit

Reviewed by Ken.

fixed <rdar://problem/3811584> REGRESSION (85-125): iframe.document undefined in function called from button onclick; works from img onclick

The fix is to not let "defers callbacks" have any effect on loading "about:blank".
I also had to fix one bug in WebCore that could then be reproduced by going to "about:blank"
while using a button.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): Loosen asserts to allow this callback for the specific case of "about:blank" even if the defers callbacks flag is true. (-[WebMainResourceClient connectionDidFinishLoading:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Added NSURLRequest return value. Loosened asserts as above. Changed code to return a new request if we get a new request back that is not empty when the defers callbacks flag is true. (-[WebMainResourceClient loadWithRequest:]): If the defers callbacks flag is set, but the URL is one that gives us an empty document, then do the work right away, don't defer it.

8:21 AM Changeset in webkit [7646] by darin