Timeline



Apr 7, 2005:

5:02 PM Changeset in webkit [8996] by sullivan
  • 8 edits in branches/experimental-ui-branch

WebCore:

WebCore support for find-as-you-type; needed an additional parameter
to findString and searchFor:...

Reviewed by Dave Hyatt.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): new findInSelection parameter; if true, start from the beginning of the selection when searching forward, or the end of the selection when searching backward
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:findInSelection:]): new findInSelection parameter; passed through to findString

WebKit:

WebKit support for find-as-you-type. Needed an additional parameter on
a method from WebDocumentSearching protocol. Since that's a public protocol,
I couldn't just add the parameter. For now I hacked it with an undeclared
internal method that's discovered via respondsToSelector. Probably the right
long-term approach is to deprecate the WebDocumentSearching protocol and introduce
a replacement that has a more flexible set of parameters for possible future
expansion.

Reviewed by Dave Hyatt.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): now calls new one-more-parameter version passing NO for new parameter to match old behavior (-[WebHTMLView _searchFor:direction:caseSensitive:wrap:findInSelection:]): new method, adds findInSelection parameter and passes it through to bridge
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): now calls new one-more-parameter version passing NO for new parameter to match old behavior (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]): new method, adds findInSelection parameter and passes it through

WebBrowser:

Fixed problem where each letter typed in find-as-you-type would jump to
the next instance of the text to find, instead of extending the selection
when appropriate.

Reviewed by Dave Hyatt.

  • FindBanner.m: (-[FindBanner _doSearchForString:direction:caseSensitive:findInSelection:inTarget:]): added findInSelection parameter, passes through to WebKit (-[FindBanner _findWithDirection:caseSensitive:findInSelection:]): added findInSelection parameter, passes through to _doSearchForString: (-[FindBanner findFromSearchField:]): pass YES for findInSelection parameter (-[FindBanner findNext:]): pass NO for findInSelection parameter (-[FindBanner findPrevious:]): pass NO for findInSelection parameter
11:33 AM Changeset in webkit [8995] by sullivan
  • 4 edits in branches/experimental-ui-branch/WebKit

WebKit:

WebKit support to allow clients to control whether the selection is still
drawn when the first responder is elsewhere. Formerly this was hardwired
to be true only when -[WebView isEditable] was true.

Reviewed by Darin.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView maintainsInactiveSelection]): check [WebView maintainsInactiveSelection] rather than just [WebView isEditable]
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebView.m: (-[WebView maintainsInactiveSelection]): new method for clients to override, returns -[self isEditable]

WebBrowser:

First draft at search-as-you-type using the Find banner. There are some
obvious flaws, perhaps the most obvious being that adding a letter will start
the new search from the end of the current selection. But it works well enough
to start seeing the flaws, so that's a good thing.

Reviewed by Darin.

  • BrowserDocument.h: declare findNext: and findPrevious: methods
  • BrowserDocument.m: (-[BrowserDocument findNext:]): call through to FindBanner (or AppController if the pref is set to not use banner) (-[BrowserDocument findPrevious:]): ditto (-[BrowserDocument validateUserInterfaceItem:]): findNext: and findPrevious: are enabled if the Find banner returns YES for readyToFind
  • BrowserWebController.h: the findInPageBanner is now declared as a FindBanner*
  • BrowserWebController.m: (-[BrowserWebView findInPageBanner]): now returns a FindBanner* rather than just a WebPageBanner* (-[BrowserWebView maintainsInactiveSelection]): override this new WebView method to return YES if the first responder is in a banner on the page.
  • English.lproj/FindBanner.nib: Turn off the "sendsWholeSearchString" bit so the searching is as-you-type
  • English.lproj/MainMenu.nib: make "Find Again" and "Find Previous" target the first responder rather than the AppController, so BrowserDocument can intercept them.
  • FindBanner.h: made -readyToFind public so it can be used in -[BrowserDocument validateUserInterfaceItem:]
  • FindBanner.m: (-[FindBanner _findWithDirection:caseSensitive:]): remove the #if guards around the code that forces the first responder to stay in the textfield as you type.

Apr 5, 2005:

4:41 PM Changeset in webkit [8994] by hyatt
  • 3 edits in trunk/WebCore

Fix for 4077106, make sure that mouse wheeling in overflow sections uses 40 rather than 10 as the base line
step.

Reviewed by darin

  • khtml/rendering/render_layer.cpp: (RenderLayer::positionScrollbars):
  • kwq/KWQScrollBar.mm: (QScrollBar::scroll):
4:38 PM Changeset in webkit [8993] by hyatt
  • 2 edits in trunk/WebKit

Fix for 4077106, wheel scroll amount smaller in Tiger. All along wheeling should have been 4x the default
line height of 10 (just as arrow keys did). Scroll arrows should have done this too for scroll views (they did
already for overflow sections). This patch puts the override into the scrollview itself, and removes the
multipliers in the private frame methods.

Reviewed by darin

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): (-[WebFrameView initWithFrame:]): (-[WebFrameView _horizontalKeyboardScrollDistance]):

Apr 4, 2005:

11:01 PM Changeset in webkit [8992] by vicki
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3871669> no focus or blur methods on HTML button elements
  • khtml/dom/html_form.cpp: (HTMLButtonElement::focus): (HTMLButtonElement::blur):
  • khtml/dom/html_form.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLButtonElementImpl::blur): (DOM::HTMLButtonElementImpl::focus):
  • khtml/html/html_formimpl.h:
Note: See TracTimeline for information about the timeline view.