Timeline



May 9, 2005:

9:40 PM Changeset in webkit [9149] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Kevin.

  • remove more isFirst/isLast functions and use isStart/isEnd verions instead
  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): (khtml::InsertTextCommand::input): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded):
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): (khtml::setAffinityUsingLinePosition): (khtml::isFirstVisiblePositionInNode):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::endOfLine): (khtml::previousLinePosition):
  • khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): (DOM::Position::nextCharacterPosition):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge smartInsertForString:replacingRange:beforeString:afterString:]):
9:03 PM Changeset in webkit [9148] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Kevin.

  • remove isFirstVisiblePositionInBlock and isLastVisiblePositionInBlock, in favor of isStartOfBlock and isEndOfBlock

It turned out that both isEndOfBlock and isLastVisiblePositionInBlock had (different) bugs,
and there was code relying on the bugs of each. So in addition I fixed isEndOfBlock and fixed
the parts of the code relying on buggy behavior.

I also removed the includeEndOfLine parameter to endOfBlock since no one used it and it's not
clear if it would ever be useful.

  • khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::doApply): Use new calls. (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Don't gratuitously make an UPSTREAM VisiblePosition, as this will cause trouble comparing it to end of block. (khtml::InsertParagraphSeparatorCommand::doApply): Use new calls. (khtml::ReplaceSelectionCommand::doApply): Use new calls. Also, don't make a position <BR,0> and test if it is the end of a block, that can never be true, although the buggy code in isLastVisiblePositionInBlock would say it is. Make <BR,1> instead.
  • khtml/editing/markup.cpp: (khtml::createMarkup): Instead of checking isEndOfBlock on the start position, check if the start's next is in a different block, to avoid relying on the buggy old isEndOfBlock behavior.
  • khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInParagraph): Use isStartOfBlock. (khtml::isLastVisiblePositionInParagraph): Use isEndOfBlock.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::endOfBlock): Greatly simplify, and no longer consider the start of a descendant block to be the end of the block. That's inconsistent with how startOfBlock works. Also remove include end of line parameter. (khtml::isEndOfBlock): Don't pass unneeded parameter.
  • khtml/editing/visible_units.h:
6:15 PM Changeset in webkit [9147] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4110775> from TOT.

2005-05-09 Adele Peterson <​adele@apple.com>

fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.
6:04 PM Changeset in webkit [9146] by adele
  • 3 edits
    8 adds in trunk

fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.
  • layout-tests/fast/dom/outerText-no-element.html: Added. Tests case where you try to set outerText on an element no longer in the DOM tree.
  • layout-tests/fast/dom/outerText-no-element-expected.txt: Added.
  • layout-tests/fast/dynamic/outerHTML-doc.html: Added. Tests case where someone tries to set outerHTML on the document.
  • layout-tests/fast/dynamic/outerHTML-doc-expected.txt: Added..
  • layout-tests/fast/dynamic/outerHTML-no-element.html: Added. Tests case where you try to set outerHTML on an element no longer in the DOM tree.
  • layout-tests/fast/dynamic/outerHTML-no-element-expected.txt: Added.
  • layout-tests/fast/dynamic/outerHTML-img.html: moved images to resources directory
  • layout-tests/fast/dynamic/resources/apple.gif: Added.
  • layout-tests/fast/dynamic/resources/mozilla.gif: Added.
4:57 PM Changeset in webkit [9145] by darin
  • 14 edits in trunk/JavaScriptCore

Reviewed by John.

  • turn on conservative GC unconditionally and start on SPI changes to eliminate the now-unneeded smart pointers since we don't ref count any more
  • kjs/value.h: Removed macros to turn conservative GC on and off. Removed ref and deref functions. (KJS::ValueImp::ValueImp): Removed non-conservative-GC code path. (KJS::ValueImp::isUndefined): Added. New SPI to make it easier to deal with ValueImp directly. (KJS::ValueImp::isNull): Ditto. (KJS::ValueImp::isBoolean): Ditto. (KJS::ValueImp::isNumber): Ditto. (KJS::ValueImp::isString): Ditto. (KJS::ValueImp::isObject): Ditto. (KJS::Value::Value): Removed non-conservative-GC code path and made constructor no longer explicit so we can quietly create Value wrappers from ValueImp *; inexpensive with conservative GC and eases the transition. (KJS::Value::operator ValueImp *): Added. Quietly creates ValueImp * from Value. (KJS::ValueImp::marked): Removed non-conservative-GC code path.
  • kjs/value.cpp: (KJS::ValueImp::mark): Removed non-conservative-GC code path. (KJS::ValueImp::isUndefinedOrNull): Added. New SPI to make it easier to deal with ValueImp directly. (KJS::ValueImp::isBoolean): Ditto. (KJS::ValueImp::isNumber): Ditto. (KJS::ValueImp::isString): Ditto. (KJS::ValueImp::asString): Ditto. (KJS::ValueImp::isObject): Ditto. (KJS::undefined): Ditto. (KJS::null): Ditto. (KJS::boolean): Ditto. (KJS::string): Ditto. (KJS::zero): Ditto. (KJS::one): Ditto. (KJS::two): Ditto. (KJS::number): Ditto.
  • kjs/object.h: Made constructor no longer explicit so we can quietly create Object wrappers from ObjectImp *; inexpensive with conservative GC and eases the transition. (KJS::Object::operator ObjectImp *): Added. Quietly creates ObjectImp * from Object. (KJS::ValueImp::isObject): Added. Implementation of new object-related ValueImp function. (KJS::ValueImp::asObject): Ditto.
  • kjs/object.cpp: (KJS::ObjectImp::setInternalValue): Remove non-conservative-GC code path. (KJS::ObjectImp::putDirect): Ditto. (KJS::error): Added. Function in the new SPI style to create an error object.
  • kjs/internal.h: Added the new number-constructing functions as friends of NumberImp. There may be a more elegant way to do this later; what's important now is the new SPI.
  • kjs/collector.h: Remove non-conservative-GC code path and also take out some unneeded APPLE_CHANGES.
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): Remove non-conservative-GC code path. (KJS::Bindings::removeNativeReference): Ditto. (RootObject::removeAllNativeReferences): Ditto.
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): Ditto. (KJS::Bindings::RootObject::setRootObjectImp): Ditto.
  • kjs/collector.cpp: (KJS::Collector::allocate): Ditto. (KJS::Collector::collect): Ditto. (KJS::Collector::numGCNotAllowedObjects): Ditto. (KJS::Collector::numReferencedObjects): Ditto. (KJS::Collector::rootObjectClasses): Ditto.
  • kjs/internal.cpp: (NumberImp::create): Ditto. (InterpreterImp::globalInit): Ditto. (InterpreterImp::globalClear): Ditto.
  • kjs/list.cpp: (KJS::List::markProtectedLists): Ditto. (KJS::List::clear): Ditto. (KJS::List::append): Ditto.
  • kjs/list.h: (KJS::List::List): Ditto. (KJS::List::deref): Ditto. (KJS::List::operator=): Ditto.
  • kjs/protect.h: (KJS::gcProtect): Ditto. (KJS::gcUnprotect): Ditto.
2:03 PM Changeset in webkit [9144] by mjs
  • 9 edits in trunk/WebCore

Reviewed by Kevin.

  • remove code for DoNotStayInBlock variant of upstream/downstream and make the methods take no parameters
  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::fixupWhitespace): (khtml::InsertLineBreakCommand::insertNodeAfterPosition): (khtml::InsertLineBreakCommand::insertNodeBeforePosition): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/selection.cpp: (khtml::Selection::toRange): (khtml::Selection::validate):
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): (khtml::isFirstVisiblePositionInParagraph): (khtml::isFirstVisiblePositionInBlock): (khtml::isLastVisiblePositionInParagraph):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition):
  • khtml/xml/dom_position.cpp: (DOM::isStreamer): (DOM::Position::upstream): (DOM::Position::downstream): (DOM::Position::leadingWhitespacePosition): (DOM::Position::trailingWhitespacePosition):
  • khtml/xml/dom_position.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge smartDeleteRangeForProposedRange:]):
1:31 PM Changeset in webkit [9143] by cblu
  • 5 edits in trunk/WebKit

Turned assertion into error message to prevent crash when encountering this bug:
<rdar://problem/4067625> connection:willCacheResponse: is called inside of [NSURLConnection initWithRequest:delegate:]

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): set flag to track when we're initializing the connection (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): log error
12:04 PM Changeset in webkit [9142] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • remove remaining uses of upstream/downstream DoNotStayInBlock
  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/visible_position.cpp: (khtml::enclosingBlockFlowElement): New helper function.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::inSameBlock): Check enclosing block flows instead of comparing visible block starts. Two nested blocks may have the same visible start but different visible ends, so the old check would give false positives.
12:01 PM Changeset in webkit [9141] by harrison
  • 1 edit
    2 adds in trunk

Add layout test for <rdar://problem/4110366>.

  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-011.html: Added.
11:46 AM Changeset in webkit [9140] by cblu
  • 2 edits in trunk/JavaScriptCore

Workaround gcc 3.3 internal compiler errors.

Reviewed by darin.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject stringRepresentation]): call [NSString stringWithCString:encoding] rather than using @""
9:23 AM Changeset in webkit [9139] by darin
  • 1 edit
    1 add in trunk
  • checked in a result for the Flash replacement test that Dave added
  • layout-tests/fast/dynamic/flash-replacement-test-expected.txt: Added. Hope it's right! If not, Dave can update it.
9:10 AM Changeset in webkit [9138] by darin
  • 7 edits in trunk

top level:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • configure.in: Ditto.

Tools:

  • CommitLogEditor/Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • HotSpotFinder/Makefile.am: Ditto.
  • jst/Makefile.am: Ditto.

JavaScriptCore:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.

Tests:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • TestBindingsPlugin/Makefile.am: Ditto.

WebCore:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • WebCore.pbproj/project.pbxproj: Remove unneeded $(DSTROOT) in framework paths.

WebKit:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.

WebBrowser:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.

May 8, 2005:

2:02 PM Changeset in webkit [9137] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Kevin.

  • remove some of the uses of upstream/downstream DoNotStayInBlock
  • khtml/editing/markup.cpp: (khtml::createMarkup): Instead of using upstream to decide if a line break should be added at the end, use inSameParagraph.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Remove the code to print upstream and downstream, the selection endpoints themselves are adequate for debugging and are what we use for layout tests.
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition): Skip a possible paragraph break at the start of the selection in a more explicit way to avoid DoNotStayInBlock.

May 7, 2005:

10:53 AM Changeset in webkit [9136]
  • 34 copies
    2 deletes in tags/WebCore-415~5

This commit was manufactured by cvs2svn to create tag
'WebCore-415~5'.

10:53 AM Changeset in webkit [9135] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiAtlanta - WebCore-415.5 (skipping the .4)

10:46 AM Changeset in webkit [9134] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4110366> from TOT for SUTiAtlanta

2005-05-07 David Harrison <​harrison@apple.com>

Reviewed by John.

<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
10:37 AM Changeset in webkit [9133] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
5:24 AM Changeset in webkit [9132] by harrison
  • 2 edits in trunk/WebCore

Remove workaround for <rdar://problem/4103339>.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData):
12:02 AM Changeset in webkit [9131] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • make StayInBlock vs DoNotStayInBlock explicit in all calls to upstream/downstream, in preparation for phasing out the DoNotStayInBlock variant.
  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/markup.cpp: (khtml::createMarkup):
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition):
  • khtml/xml/dom_position.h:

May 6, 2005:

5:45 PM Changeset in webkit [9130] by harrison
  • 11 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej, Darin.

<rdar://problem/4103339> VisiblePosition and PositionIterator iterators do not return positions in order

  • WebCore.pbproj/project.pbxproj: Removed dom_positioniterator.h and dom_positioniterator.cpp.
  • khtml/editing/htmlediting.cpp: Removed unused include of dom_positioniterator.h and "using" of PositionIterator.
  • khtml/editing/selection.cpp: Removed unused include of dom_positioniterator.h.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of duplicated code.
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::maxDeepOffset): Added to support Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::previous): (DOM::Position::next): (DOM::Position::atStart): (DOM::Position::atEnd): Moved here, replacing VisiblePosition's duplicate and PositionIterator. Fixed to return positions in order and not skip positions.

(DOM::Position::previousCharacterPosition):
(DOM::Position::nextCharacterPosition):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

(DOM::isStreamer):
(DOM::Position::upstream):
(DOM::Position::downstream):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

  • khtml/xml/dom_positioniterator.cpp: Removed.
  • khtml/xml/dom_positioniterator.h: Removed. Removed in favor of Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
1:40 PM Changeset in webkit [9129] by mjs
  • 12 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4058167> Unit Converter and Weather widgets crashed in KJS::Collector::markCurrentThreadConservatively

Avoid possibly allocating new prototype objects as parameters to
superclass constructors - there may be an allocated but
uninitilized object so this is a bad time to allocate. Instead,
set the prototype in the constructor body, since the object is
happily allocated by then.

  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (DOMMediaList::DOMMediaList): (DOMCSSStyleSheet::DOMCSSStyleSheet): (DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (DOMCSSValueList::DOMCSSValueList):
  • khtml/ecma/kjs_css.h: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMCSSValue::DOMCSSValue):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::DOMNode): (DOMDocument::DOMDocument): (DOMElement::DOMElement): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (DOMNamedNodesCollection::DOMNamedNodesCollection): (DOMCharacterData::DOMCharacterData): (DOMText::DOMText):
  • khtml/ecma/kjs_dom.h: (KJS::NodeConstructor::NodeConstructor): (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
  • khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): (Clipboard::Clipboard):
  • khtml/ecma/kjs_html.cpp: (HTMLCollection::HTMLCollection):
  • khtml/ecma/kjs_range.cpp: (DOMRange::DOMRange):
  • khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::DOMNodeIterator): (DOMNodeFilter::DOMNodeFilter): (DOMTreeWalker::DOMTreeWalker):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializer::XMLSerializer):
12:39 PM Changeset in webkit [9128] by darin
  • 6 edits in trunk

top level:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • configure.in: Update code to set up Xcode build directory instead of setting the Project Builder build directory.
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

Tools:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • CommitLogEditor/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • HotSpotFinder/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • jst/Makefile.am: Set up Xcode build directory before invoking xcodebuild.

JavaScriptCore:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

Tests:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • TestBindingsPlugin/Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebCore:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebKit:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebBrowser:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

May 5, 2005:

1:24 PM Changeset in webkit [9127] by hyatt
  • 3 edits in trunk/WebCore

Eliminate the FOUCS on wired.com. innerWidth and innerHeight on window should not do a layout that ignores
pending stylesheets, since even if stylesheets are loading the correct window dimensions can be determined with
a normal layout.

The radar # is 4109888.

Reviewed by rjw

  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::updateLayout):
  • khtml/ecma/kjs_window.h:
11:35 AM Changeset in webkit [9126] by hyatt
  • 3 edits
    1 add in trunk

Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.

The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.

Reviewed by John Sullivan

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
  • khtml/xml/dom_docimpl.h:
  • layout-tests/fast/dynamic/flash-replacement-test.html: Added.
11:28 AM Changeset in webkit [9125]
  • 34 copies
    2 deletes in tags/WebCore-415~3

This commit was manufactured by cvs2svn to create tag
'WebCore-415~3'.

11:28 AM Changeset in webkit [9124] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiAtlanta - WebCore-415.3

11:27 AM Changeset in webkit [9123] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merging fix for <rdar://problem/4109564> from TOT for SUTiAtlanta.

2005-05-05 Darin Adler <Darin Adler>

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4109564> REGRESSION (Atlanta): maps.google.com doesn't always center California correctly
  • khtml/ecma/kjs_events.cpp: (offsetFromTarget): Fix two places that said X where they should say Y.
11:13 AM Changeset in webkit [9122]
  • 15 copies
    2 deletes in tags/WebCore-315~3

This commit was manufactured by cvs2svn to create tag
'WebCore-315~3'.

11:13 AM Changeset in webkit [9121] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Oracle Seed - WebCore-315.3

11:11 AM Changeset in webkit [9120] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4065447> from TOT for Oracle Seed.

2005-04-20 Vicki Murley <​vicki@apple.com>

Reviewed by hyatt.

  • fixed <rdar://problem/4065447> support outerHTML on IMG elements
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):
10:55 AM Changeset in webkit [9119] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4109564> REGRESSION (Atlanta): maps.google.com doesn't always center California correctly
  • khtml/ecma/kjs_events.cpp: (offsetFromTarget): Fix two places that said X where they should say Y.
10:01 AM Changeset in webkit [9118] by harrison
  • 2 edits in trunk/WebCore

Reviewed by me.

Restore fixed setEndingSelection. Fixed method was ifdef'd out
because change was at end of Tiger development, but method is
unused. You just can never be _too_ safe.

  • khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::setEndingSelection):
9:09 AM Changeset in webkit [9117] by sullivan
  • 2 edits in branches/experimental-ui-branch/WebCore

Reviewed by Chris.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerRect]): Get corner rect from enclosing clipView, rather than using visibleRect. VisibleRect would return the wrong result when the textarea was clipped by the bottom of the window, leading to redraw schmutz among other things.
Note: See TracTimeline for information about the timeline view.