Timeline



Jun 7, 2005:

5:41 PM Changeset in webkit [9337] by hyatt
  • 2 edits in trunk/WebCore

Patch from Brian Campbell. Make sure the min and max values of slider properly update.
Fixes bugilla bug 3323, internal Radar # is 4098892.

Reviewed by hyatt

Test cases added: (Not testable with a layout test)

  • kwq/KWQSlider.mm: (QSlider::setMinValue): (QSlider::setMaxValue):
5:27 PM Changeset in webkit [9336] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Adele Peterson.

  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Added Deployment build style.
  • Scripts/build-dumprendertree: For now, always use Deployment build style. This may fix things so we can run tests with Xcode 2.1.
3:51 PM Changeset in webkit [9335]
  • 53 copies
    2 deletes in tags/WebCore-415~10

This commit was manufactured by cvs2svn to create tag
'WebCore-415~10'.

3:51 PM Changeset in webkit [9334] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.10

3:46 PM Changeset in webkit [9333] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Oops, forgot to use Adele's married name.

3:45 PM Changeset in webkit [9332] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Adele Amchan.

  • Scripts/run-webkit-tests: Pass -L to find command to follow symlinks. This allows symlinks in the layout-tests directory to include additional sets of tests.
3:42 PM Changeset in webkit [9331] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4139800> from TOT to Safari-2-0-branch

2005-06-07 Adele Peterson <​adele@apple.com>

Change by Darin, reviewed by Maciej and me.

  • fixed <rdar://problem/4139800> REGRESSION: Safari crashes at bebe.com

There were cases where the DOMNode mark function would end up not even
marking the node that it was called on. The old code tried to skip any
subtrees that were already marked, but that code was wrong.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): Changed three things: 1) Instead of a boolean, keep a set of trees that we are marking, that

prevents problems if we mark things that have references between
separate trees of DOM nodes.

2) Don't do the "outermost node with a wrapper" check, just start marking

at the root of the entire tree, because there's no way to have an
unreachable node pointing to a reachable node.

3) Handle the unusual case where the document's wrapper dictionary is

gone by marking just this node explicitly.

This passes the layout tests, still fixes the Dashboard memory leak from
bug 4125222, and makes bebe.com work again.

3:12 PM Changeset in webkit [9330] by adele
  • 2 edits in trunk/WebCore

Change by Darin, reviewed by Maciej and me.

  • fixed <rdar://problem/4139800> REGRESSION: Safari crashes at bebe.com

There were cases where the DOMNode mark function would end up not even
marking the node that it was called on. The old code tried to skip any
subtrees that were already marked, but that code was wrong.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): Changed three things: 1) Instead of a boolean, keep a set of trees that we are marking, that

prevents problems if we mark things that have references between
separate trees of DOM nodes.

2) Don't do the "outermost node with a wrapper" check, just start marking

at the root of the entire tree, because there's no way to have an
unreachable node pointing to a reachable node.

3) Handle the unusual case where the document's wrapper dictionary is

gone by marking just this node explicitly.

This passes the layout tests, still fixes the Dashboard memory leak from
bug 4125222, and makes bebe.com work again.

3:02 PM Changeset in webkit [9329] by darin
  • 5 edits in trunk/WebKitTools
  • checkout: Added license.
  • Scripts/build-dumprendertree: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
2:58 PM Changeset in webkit [9328] by darin
  • 3 edits in trunk/WebKitTools

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • Scripts/build-webkit: Changes so you can build with Xcode 2.1. (I also added a license to this file.)
  • Scripts/run-safari: Ditto.
2:48 PM Changeset in webkit [9327] by darin
  • 2 edits in trunk/WebCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • WebCore.pbproj/project.pbxproj: Allow bison 2.0, which generates the file with a different name.
11:34 AM Changeset in webkit [9326] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • JavaScriptCore.pbproj/project.pbxproj: Allow bison 2.0, which generates the file with a different name.
9:07 AM Changeset in webkit [9325] by darin
  • 2 edits in trunk/WebKit

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Reviewed by me.

  • WebKit.pbproj/project.pbxproj: Quote DERIVED_FILE_DIR when it is substituted into FRAMEWORK_SEARCH_PATHS, and SYMROOT when into HEADER_SEARCH_PATHS.
9:05 AM Changeset in webkit [9324] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fixed name in ChangeLog.

9:00 AM Changeset in webkit [9323] by darin
  • 2 edits in trunk/WebCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • WebCore.pbproj/project.pbxproj: Add quotes to make LIBRARY_SEARCH_PATHS work even when the path has a space in it.
8:55 AM Changeset in webkit [9322] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • kjs/grammar.y: Remove bogus extra line from grammar.y. Toby got this change from KDE KJS.
8:34 AM Changeset in webkit [9321] by hyatt
  • 2 edits in trunk/WebCore

Patch from Mark Rowe to fix a minor memory leak in WebCoreSettings.

Reviewed by hyatt

  • kwq/WebCoreSettings.mm: (-[WebCoreSettings dealloc]):

Jun 6, 2005:

10:25 PM Changeset in webkit [9320] by darin
  • 2 edits in trunk/JavaScriptCore
  • tests/mozilla/run-mozilla-tests: Wrote a perl version of this so we don't require the "jst" tool to run the tests.
10:21 PM Changeset in webkit [9319] by mjs
  • 2 edits in trunk

purify the ChangeLog's essence

9:07 PM Changeset in webkit [9318] by darin
  • 2 edits in trunk/WebKit
  • Info.plist: Bumped version to 412+. For some reason it was set to 312.1!
8:07 PM Changeset in webkit [9317] by mjs
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: run ranlib on libWebKitSystemInterface.a
7:54 PM Changeset in webkit [9316] by mjs
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: Chop newline off of $productDir to avoid problems with logic to copy files ther.
7:26 PM Changeset in webkit [9315] by mjs
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: Install WebKitSystemInterface stuff into build products dir.
6:48 PM Changeset in webkit [9314] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Remove mention of SPI removal work from ChangeLog per request.

5:54 PM Changeset in webkit [9313] by mjs
  • 2 edits in trunk/WebKit
  • fix crashing problem in last change
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _setupFont]):
5:51 PM Changeset in webkit [9312] by mjs
  • 2 edits in trunk/WebKitLibraries
  • updated for crashing bugfix
  • libWebKitSystemInterface.a:
5:37 PM Changeset in webkit [9311] by mjs
  • 3 edits in trunk/WebKit
  • removed carbon and text SPI
  • Carbon.subproj/HIWebView.m: (-[MenuItemProxy initWithAction:]): (-[MenuItemProxy action]): (-[MenuItemProxy tag]): (GetWindowRef): (Click): (MouseUp): (MouseMoved): (MouseDragged): (MouseWheelMoved): (WindowHandler): (HIWebViewEventHandler): (UpdateObserver):
  • WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer finalize]): (-[WebTextRenderer _substituteFontForString:families:]): (-[WebTextRenderer _convertCharacters:length:toGlyphs:]): (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _setupFont]): (_drawGlyphs): (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _initializeATSUStyle]): (fillStyleWithAttributes):
5:35 PM Changeset in webkit [9310] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
7:53 AM Changeset in webkit [9309] by mjs
  • 2 edits in trunk/WebKit
  • remove plugin-related SPI calls
  • Plugins.subproj/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView initialize]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView tellQuickTimeToChill]):
7:51 AM Changeset in webkit [9308] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
6:47 AM Changeset in webkit [9307] by mjs
  • 2 edits in trunk/WebKit
  • remove graphics SPI use
  • WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setFocusRingStyle:radius:color:]): (-[WebGraphicsBridge setDraggingImage:at:]):
6:45 AM Changeset in webkit [9306] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
6:26 AM Changeset in webkit [9305] by mjs
  • 3 edits in trunk/WebKit
  • more SPI removal, for font cache and CFStream
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (getLCDScaleParameters): (+[WebTextRendererFactory createSharedFactory]):
  • WebView.subproj/WebFormDataStream.m: (formCanRead): (formEventCallback): (webSetHTTPBody):
6:24 AM Changeset in webkit [9304] by mjs
  • 3 edits in trunk/WebKitLibraries

Reviewed by NOBODY (OOPS!).

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
5:48 AM Changeset in webkit [9303] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
5:48 AM Changeset in webkit [9302] by mjs
  • 2 edits in trunk/WebKit
  • remove use of AX SPI
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory objectIsTextMarker:]): (-[WebViewFactory objectIsTextMarkerRange:]): (-[WebViewFactory textMarkerWithBytes:length:]): (-[WebViewFactory getBytes:fromTextMarker:length:]): (-[WebViewFactory textMarkerRangeWithStart:end:]): (-[WebViewFactory startOfTextMarkerRange:]): (-[WebViewFactory endOfTextMarkerRange:]): (-[WebViewFactory accessibilityHandleFocusChanged]): (-[WebViewFactory AXUIElementForElement:]): (-[WebViewFactory unregisterUniqueIdForUIElement:]):
5:16 AM Changeset in webkit [9301] by mjs
  • 3 edits in trunk/WebKit
  • removed more SPI
  • Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _postFlagsChangedEvent:]): (-[WebHTMLView _autoscroll]): (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView _interceptEditingKeyEvent:]):
5:14 AM Changeset in webkit [9300] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:43 AM Changeset in webkit [9299] by mjs
  • 8 edits in trunk/WebKit
  • more SPI use removal
  • Misc.subproj/WebDownload.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]):
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]):
  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
4:42 AM Changeset in webkit [9298] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:16 AM Changeset in webkit [9297] by mjs
  • 2 edits in trunk/WebKit
  • remove unneeded header include
  • WebCoreSupport.subproj/WebImageRenderer.m:
4:12 AM Changeset in webkit [9296] by mjs
  • 8 edits in trunk/WebKit
  • removed even more SPI use
  • Misc.subproj/WebDownload.m:
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (WebCGColorSpaceCreateRGB): (WebCGColorSpaceCreateGray):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate setDefersCallbacks:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didReceiveResponse:]): (-[WebMainResourceClient didReceiveData:lengthReceived:]): (-[WebMainResourceClient didFinishLoading]): (-[WebMainResourceClient didFailWithError:]):
4:11 AM Changeset in webkit [9295] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:

Jun 5, 2005:

11:05 PM Changeset in webkit [9294] by darin
  • 4 edits
    1 add in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Tweak, simplify.
  • Scripts/build-dumprendertree: Added.
  • Scripts/build-webkit: Build All in the JavaScriptCore directory.
  • Scripts/run-webkit-tests: Build DumpRenderTree before running.
10:46 PM Changeset in webkit [9293] by hyatt
  • 2 edits
    2 adds in trunk/LayoutTests/fast/css-generated-content

Change layout test #10 to use a smaller bullet image.

10:15 PM Changeset in webkit [9292] by darin
  • 3 edits in trunk/WebKit

Reviewed by Hyatt.

  • fixed hang we were seeing in Safari and layout tests
  • Misc.subproj/WebNSUserDefaultsExtras.m: (+[NSUserDefaults _webkit_ensureAndLockPreferredLanguageLock]): Change name to avoid conflict with Foundation function. This was causing the hang. (+[NSUserDefaults _webkit_defaultsDidChange]): Update caller. (+[NSUserDefaults _webkit_preferredLanguageCode]): Ditto.
  • WebCoreSupport.subproj/WebGraphicsBridge.m: Remove some unneeded includes.
8:44 PM Changeset in webkit [9291] by darin
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • fixed crash in Acid2 layout test
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Added nil check for CFBundleRef.
8:25 PM Changeset in webkit [9290] by darin
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • remove more SPI usage
  • Carbon.subproj/CarbonWindowAdapter.m: Remove a bunch of stuff. (+[CarbonWindowAdapter frameViewClassForStyleMask:]): (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]): (-[CarbonWindowAdapter _oldPlaceWindow:]): (-[CarbonWindowAdapter _termWindowIfOwner]): (-[CarbonWindowAdapter _windowMovedToRect:]): (-[CarbonWindowAdapter makeKeyWindow]):
7:39 PM Changeset in webkit [9289] by mjs
  • 2 edits in trunk/WebKit
  • remove another forgotten include
  • Plugins.subproj/WebPluginDatabase.m:
7:27 PM Changeset in webkit [9288] by mjs
  • 2 edits in trunk/WebKit
  • remove include that I forgot in last checkin
  • Misc.subproj/WebNSPasteboardExtras.m:
7:21 PM Changeset in webkit [9287] by mjs
  • 3 edits in trunk/WebKitLibraries
  • added a few more bits of SPI
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
7:21 PM Changeset in webkit [9286] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Don.

  • remove more SPI usage
  • fix <rdar://problem/3446192> CoreTranslation SPI is going away
  • History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releasePageCache:]):
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _setupFont]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]):
7:00 PM Changeset in webkit [9285] by mjs
  • 1 delete in trunk/WebKit/WebKitSecurityDummy.c

* empty log message *

5:34 PM Changeset in webkit [9284] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-safari: Fix path to Safari executable. Add check for frameworks.
5:15 PM Changeset in webkit [9283] by mjs
  • 16 edits in trunk/WebKit

Reviewed by Darin.

  • use WebKitSystemInterface wrappers for NSURLFileTypeMappings and NSURLResponse SPI
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]):
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]):
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForExtension:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): (-[WebBridge determineObjectFromMIMEType:URL:]): (-[WebBridge MIMETypeForPath:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _commitIfReady:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView resourceForData:preferredFilename:]):
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebView.m: (+[WebView _supportedFileExtensions]): (+[WebView suggestedFileExtensionForMIMEType:]): (+[WebView _MIMETypeForFile:]):
5:12 PM Changeset in webkit [9282] by mjs
  • 3 edits in trunk/WebKitLibraries
  • added file type and NSURLResponse caching SPI
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:34 PM Changeset in webkit [9281] by darin
  • 1 edit
    7 adds in trunk/WebKitTools
  • add run-webkit-tests script; not working yet but the pieces are there
  • Scripts/run-webkit-tests: Added.
  • DumpRenderTree/DumpRenderTree.m: Added.
  • DumpRenderTree/DumpRenderTree.xcode/.cvsignore: Added.
  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Added.
  • DumpRenderTree/DumpRenderTreePrefix.h: Added.
4:14 PM Changeset in webkit [9280] by darin
  • 7 adds in trunk/WebKitTools
  • created module, first cut at Web Kit Open Source Project scripts
  • ChangeLog: Added.
  • Scripts/build-webkit: Added.
  • Scripts/run-safari: Added.
  • Scripts/update-webkit: Added.
  • checkout: Added.
2:17 PM Changeset in webkit [9279] by mjs
  • 4 adds in trunk/WebKitLibraries
  • initial checkin of WebKitSystemInterface binary
  • WebKitSystemInterface.h: Added.
  • libWebKitSystemInterface.a: Added.
1:57 PM Changeset in webkit [9278] by darin
  • 7 edits in trunk/WebKit

Reviewed by Hyatt.

  • fixed build that I broke with the license change (some includes of WebException were still around)
  • WebKit.pbproj/project.pbxproj: Removed references to WebException.h/m.
  • WebView.subproj/WebDataSource.m: Removed include of WebException.h.
  • WebView.subproj/WebHTMLView.m: Ditto.
  • WebView.subproj/WebView.m: Ditto.
  • fixed build under gcc 4.0 (some code moved here from Foundation had warnings)
  • Misc.subproj/WebNSDataExtras.m: (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use char instead of UInt8. (-[NSData _webkit_guessedMIMEType]): Use char instead of UInt8, and take out now- unneeded type casts.
1:42 PM Changeset in webkit [9277] by mjs
  • 3 edits
    2 deletes in trunk/WebKit

Reviewed by Don.

  • remove security code and use the stuff from WebKitSystemInterface instead
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
  • WebCoreSupport.subproj/WebNewKeyGeneration.c: Removed.
  • WebCoreSupport.subproj/WebNewKeyGeneration.h: Removed.
  • WebKit.pbproj/project.pbxproj:
10:54 AM Changeset in webkit [9276] by darin
  • 268 edits
    1 add
    4 deletes in trunk/WebKit
  • added appropriate license headers to most files and updated copyright to reflect publication dates
  • LICENSE: Added.
  • <lots of files>: Added license header.
  • WebKit.pbproj/project.pbxproj: Removed references to NP_objc.h.
  • API-Issues.rtf: Removed.
  • Misc.subproj/WebException.h: Removed.
  • Misc.subproj/WebException.m: Removed.
  • Plugins.subproj/NP_objc.h: Removed.
2:22 AM Changeset in webkit [9275] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Hyatt.

  • link against libWebKitSystemInterface and use the first function in it.
  • Misc.subproj/WebNSUserDefaultsExtras.m: (-[NSString _webkit_HTTPStyleLanguageCode]): use WKCopyCFLocalizationPreferredName
  • Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage preferredLocalizationName]): ditto
  • WebKit.pbproj/project.pbxproj: link in libWebKitSystemInterface.a and find headers.
12:06 AM Changeset in webkit [9274] by darin
  • 9 edits
    19 adds in trunk

WebCore:

Reviewed by Don.

  • got rid of the rest of the dependencies on Apple Internal headers
  • kwq/WebCoreBridge.mm: Remove include of unused SPI header.
  • kwq/KWQAccObjectCache.h: Remove include of SPI header. Change use of AXTextMarkerRef to use WebCoreTextMarker instead. Also ifdef less.
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::textMarkerForVisiblePosition): Change types, call new WebCoreViewFactory methods. (KWQAccObjectCache::visiblePositionForTextMarker): Ditto. (KWQAccObjectCache::handleFocusedUIElementChanged): Ditto.
  • kwq/WebCoreViewFactory.h: Add new methods we can use instead of Accessibility SPI.
  • kwq/KWQAccObject.mm: (-[KWQAccObject detach]): Call new WebCoreViewFactory method instead of SPI. (-[KWQAccObject accessibilityAttributeNames]): Use strings instead of constants only in SPI header. (-[KWQAccObject textMarkerRangeFromMarkers:andEndMarker:]): Change parameter types from SPI type to a new type defined by WebCoreViewFactory, use WebCoreViewFactory method. (-[KWQAccObject textMarkerForVisiblePosition:]): Ditto. (-[KWQAccObject visiblePositionForTextMarker:]): Ditto. (-[KWQAccObject visiblePositionForStartOfTextMarkerRange:]): Ditto. (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): Ditto. (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]): Just change type. (-[KWQAccObject textMarkerRange]): Ditto. (-[KWQAccObject accessibilityAttributeValue:]): String instead of constant. (-[KWQAccObject accessibilityParameterizedAttributeNames]): Ditto. (-[KWQAccObject doAXUIElementForTextMarker:]): Just change type. (-[KWQAccObject doAXLineForTextMarker:]): Ditto. (-[KWQAccObject doAXStringForTextMarkerRange:]): Ditto. (-[KWQAccObject doAXBoundsForTextMarkerRange:]): Ditto. (AXAttributeStringSetElement): Call new method. (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]): Just change type. (-[KWQAccObject doAXTextMarkerRangeForUnorderedTextMarkers:]): Ditto. (-[KWQAccObject doAXNextTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXSentenceTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXParagraphTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXLengthForTextMarkerRange:]): Ditto. (-[KWQAccObject accessibilityAttributeValue:forParameter:]): Change types, use new methods, use strings instead of constants. (-[KWQAccObject accessibilityIsAttributeSettable:]): String instead of constant. (-[KWQAccObject doSetAXSelectedTextMarkerRange:]): New type. (-[KWQAccObject accessibilitySetValue:forAttribute:]): New types, methods.

WebKit:

Reviewed by Don.

  • did some work to move SPI use from WebCore here (to be moved from here into WebKitSystemInterface)
  • fixed so we can compile ICU includes without Apple Internal headers installed
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory objectIsTextMarker:]): Added. (-[WebViewFactory objectIsTextMarkerRange:]): Added. (-[WebViewFactory textMarkerWithBytes:length:]): Added. (-[WebViewFactory getBytes:fromTextMarker:length:]): Added. (-[WebViewFactory textMarkerRangeWithStart:end:]): Added. (-[WebViewFactory startOfTextMarkerRange:]): Added. (-[WebViewFactory endOfTextMarkerRange:]): Added. (-[WebViewFactory accessibilityHandleFocusChanged]): Added. (-[WebViewFactory AXUIElementForElement:]): Added. (-[WebViewFactory unregisterUniqueIdForUIElement:]): Added.
  • WebKit.pbproj/project.pbxproj: Added icu to the header search files. Removed bogus DSTROOT thing from the framework paths (I meant to remove that a while back).
  • icu/README: Added.
  • icu/unicode/parseerr.h: Added.
  • icu/unicode/platform.h: Added.
  • icu/unicode/uchar.h: Added.
  • icu/unicode/uconfig.h: Added.
  • icu/unicode/uidna.h: Added.
  • icu/unicode/uiter.h: Added.
  • icu/unicode/umachine.h: Added.
  • icu/unicode/unorm.h: Added.
  • icu/unicode/urename.h: Added.
  • icu/unicode/uscript.h: Added.
  • icu/unicode/utf.h: Added.
  • icu/unicode/utf16.h: Added.
  • icu/unicode/utf8.h: Added.
  • icu/unicode/utf_old.h: Added.
  • icu/unicode/utypes.h: Added.
  • icu/unicode/uversion.h: Added.

Jun 4, 2005:

5:44 PM Changeset in webkit [9273] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix silly ChangeLog typo.

5:42 PM Changeset in webkit [9272] by darin
  • 2 edits
    22 adds in trunk/WebCore

Reviewed by Maciej.

  • first fix on the road to can compile without Apple Internal headers installed
  • WebCore.pbproj/project.pbxproj: Added icu directory to header search path.
  • icu/README: Added.
  • icu/unicode/parseerr.h: Added.
  • icu/unicode/platform.h: Added.
  • icu/unicode/putil.h: Added.
  • icu/unicode/ubrk.h: Added.
  • icu/unicode/uchar.h: Added.
  • icu/unicode/uconfig.h: Added.
  • icu/unicode/uenum.h: Added.
  • icu/unicode/uidna.h: Added.
  • icu/unicode/uiter.h: Added.
  • icu/unicode/uloc.h: Added.
  • icu/unicode/umachine.h: Added.
  • icu/unicode/urename.h: Added.
  • icu/unicode/ustring.h: Added.
  • icu/unicode/utf.h: Added.
  • icu/unicode/utf16.h: Added.
  • icu/unicode/utf8.h: Added.
  • icu/unicode/utf_old.h: Added.
  • icu/unicode/utypes.h: Added.
  • icu/unicode/uversion.h: Added.
5:41 PM Changeset in webkit [9271] by darin
  • 2 edits
    14 adds in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed so we can compile without Apple Internal headers installed
  • JavaScriptCore.pbproj/project.pbxproj: Added icu directory to header search path.
  • icu/README: Added.
  • icu/unicode/platform.h: Added.
  • icu/unicode/uchar.h: Added.
  • icu/unicode/uconfig.h: Added.
  • icu/unicode/umachine.h: Added.
  • icu/unicode/urename.h: Added.
  • icu/unicode/utf.h: Added.
  • icu/unicode/utf16.h: Added.
  • icu/unicode/utf8.h: Added.
  • icu/unicode/utf_old.h: Added.
  • icu/unicode/utypes.h: Added.
  • icu/unicode/uversion.h: Added.
3:46 PM Changeset in webkit [9270] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Vicki.

  • replace more use of CGCompositeOperation that I missed.
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage _PDFDrawFromRect:toRect:operation:alpha:flipped:]):

Jun 3, 2005:

4:25 PM Changeset in webkit [9269] by mjs
  • 5 edits in trunk/WebKit

Reviewed by NOBODY (OOPS!).

  • replace use of CGCompositeOperation SPI with NSCompositingOperation API
  • WebCoreSupport.subproj/WebImageData.h:
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory CGCompositeOperationInContext:]): (-[WebImageRendererFactory setCGCompositeOperation:inContext:]): (-[WebImageRendererFactory setCGCompositeOperationFromString:inContext:]):
2:34 PM Changeset in webkit [9268]
  • 53 copies
    2 deletes in tags/WebCore-415~9

This commit was manufactured by cvs2svn to create tag
'WebCore-415~9'.

2:34 PM Changeset in webkit [9267] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiCambridge - WebCore-415.9

2:11 PM Changeset in webkit [9266] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4109667> from TOT for SUTiCambridge.
Our fix for the Cingular bug (<rdar://problem/4121747>)relies on this.

2005-05-05 David Hyatt <​hyatt@apple.com>

Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.

The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.

Reviewed by John Sullivan

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
  • khtml/xml/dom_docimpl.h:
Note: See TracTimeline for information about the timeline view.