Timeline



Jun 12, 2005:

8:28 PM Changeset in webkit [9374] by darin
  • 13 edits in trunk/WebKit

Changes by Nick Zitzmann.
Reviewed by me.

  • fixed init methods that don't handle return values from the init methods they call
  • WebView.subproj/WebArchive.m: (-[WebArchive init]): Use value returned by init, check it for nil too. (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Ditto. (-[WebArchive _initWithPropertyList:]): Ditto. (-[WebArchive initWithCoder:]): Ditto.
  • WebView.subproj/WebClipView.m: (-[WebClipView initWithFrame:]): Ditto.
  • WebView.subproj/WebDebugDOMNode.m: (-[WebDebugDOMNode initWithName:value:source:children:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFormState initWithForm:values:sourceFrame:]): Ditto. (-[WebFrame initWithName:webFrameView:webView:]): Ditto.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView initWithFrame:]): Ditto.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Ditto.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Ditto. (-[WebTextCompleteController initWithHTMLView:]): Ditto.
  • WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): Ditto.
  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithIdentifier:]): Ditto.
  • WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): Ditto.
  • WebView.subproj/WebResource.m: (-[WebResource init]): Ditto. (-[WebResource initWithCoder:]): Ditto.
  • WebView.subproj/WebView.m: (-[WebViewPrivate init]): Call super init. (-[_WebSafeForwarder initWithTarget:defaultTarget:templateClass:]): Use value returned by init, check it for nil too. (-[WebView initWithFrame:]): Ditto.
8:26 PM Changeset in webkit [9373] by darin
  • 7 edits in trunk/WebKitTools

Changes by Stuart Morgan.
Reviewed by me.

  • Scripts/cvs-abandon: Use cwd instead of pwd.
  • Scripts/cvs-apply: Ditto.
  • Scripts/cvs-create-patch: Ditto.
  • Scripts/cvs-unapply: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/webkitdirs.pm: Ditto. Also improve handling when there's no "Configuration" file.
8:12 PM Changeset in webkit [9372] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/cvs-apply: Handle case of an empty patch better.
  • Scripts/cvs-unapply: Ditto.
7:45 PM Changeset in webkit [9371] by darin
  • 2 edits in trunk/WebKitTools

Changes by Michael Gaiman.
Reviewed by me.

  • Scripts/webkitdirs.pm: Chomp off the result of pwd, and don't die when no Configuration file.
5:55 PM Changeset in webkit [9370] by darin
  • 1 edit
    3 adds in trunk
  • added expected test results for new tests
  • layout-tests/fast/selectors/159-expected.txt: Added.
  • layout-tests/fast/selectors/177a-expected.txt: Added.
  • layout-tests/fast/selectors/177b-expected.txt: Added.
5:40 PM Changeset in webkit [9369]
  • 13 copies
    3 deletes in tags/WebKit-412~5

This commit was manufactured by cvs2svn to create tag 'WebKit-412~5'.

5:40 PM Changeset in webkit [9368] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.5

5:10 PM Changeset in webkit [9367] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/update-webkit: Make this script work when called from any directory.
3:48 PM Changeset in webkit [9366] by darin
  • 7 edits
    1 add in trunk/WebKitTools

Reviewed by Maciej.
Includes changes by Stuart Morgan as well as my own.

  • Scripts/build-dumprendertree: Call the new setConfiguration function, and use XcodeOptions instead of symrootXcodeOptions to set the -buildstyle option.
  • Scripts/build-webkit: Ditto. Also remove the old way of supporting Xcode 2.1 and the old --debug option. The new --development option does the same thing.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
  • Scripts/set-webkit-configuration: Added. Sets the default configuration to Development or Deployment.
  • Scripts/webkitdirs.pm: use FindBin to find the WebKit directory; works no matter what the current directory is when invoking a script. Add code to determine the Xcode version so we can do the right thing for 2.0 and 2.1. Change the productDir function to return the appropriate per-configuration product directory. Read the default configuration from a file, overridable by a passed-in command-line option.
2:06 PM Changeset in webkit [9365] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg.

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data source before swapping in the provisional. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only the provisional load here, we would not want to stop loading if this navigation later turns into a download or is cancelled before being committed. (-[WebFrame stopLoading]): Factored a bit. (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load, and cancel any pending policy deicions. (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main load.
1:27 PM Changeset in webkit [9364] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data source before swapping in the provisional. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only the provisional load here, we would not want to stop loading if this navigation later turns into a download or is cancelled before being committed. (-[WebFrame stopLoading]): Factored a bit. (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load, and cancel any pending policy deicions. (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main load.

Jun 11, 2005:

10:56 PM Changeset in webkit [9363] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/cvs-create-patch: Improve handling of directories with mixed CVS roots by going into each directory to execute the cvs diff commands.
10:41 PM Changeset in webkit [9362] by darin
  • 1 edit
    4 adds in trunk/WebKitTools
  • added first cuts at some cvs scripts

cvs-abandon is for throwing away changes; discards any local changes, reverting to the state in CVS
cvs-create-patch is for making patches; runs cvs diff with all the right options and handles added/deleted files
cvs-apply is for applying patches; runs patch and cvs add and cvs rm
cvs-unapply is for unapplying patches; does the opposite of cvs-apply

An argument against these is "waste of time if we switch to Subversion", but they should be good for a while.

  • Scripts/cvs-abandon: Added.
  • Scripts/cvs-apply: Added.
  • Scripts/cvs-create-patch: Added.
  • Scripts/cvs-unapply: Added.
9:07 PM Changeset in webkit [9361] by mjs
  • 5 edits
    3 adds in trunk

Patch from Nicholas Shanks <​contact@nickshanks.com>, by me.

Merge of svn log -v -r 399829 ​svn://anonsvn.kde.org/home/kde

Test cases added: Added the following from CSS selector test suite,
unfortunately 159 and 117a do not show any difference with and without the
patch since layout tests do not dump selection style (yet).

  • layout-tests/fast/selectors/159.html: Added.
  • layout-tests/fast/selectors/177a.html: Added.
  • layout-tests/fast/selectors/177b.html: Added.
  • khtml/css/css_base.cpp: (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
  • khtml/css/css_base.h: (DOM::CSSSelector::): (DOM::CSSSelector::pseudoType):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/css/parser.y:
2:51 AM Changeset in webkit [9360] by mjs
  • 2 edits
    2 adds in trunk

Patch from Timothy Hatcher <​timothy@colloquy.info>, reviewed by me.

Test cases added:

  • layout-tests/fast/dom/children-nodes-expected.txt: Added.
  • layout-tests/fast/dom/children-nodes.html: Added.
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::traverseNextItem): For "children" collection, use nextSibling() instead of traverseNextNext() to avoid doing deep traversal.
2:41 AM Changeset in webkit [9359] by mjs
  • 1 edit
    1 add in trunk

Added missing expected results from the background image patch.

  • layout-tests/fast/backgrounds/001-expected.txt: Added.

Jun 10, 2005:

10:31 PM Changeset in webkit [9358] by hyatt
  • 5 edits
    2 adds in trunk

Fix for bugzilla bug 3335, add support for the CSS3 indirect adjacent sibling selector. Patch merge
from KHTML tree by Nick Shanks.

Reviewed by hyatt

Test cases added: fast/selectors/046.html

  • khtml/css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/css/css_base.h: (DOM::CSSSelector::):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector):
  • khtml/css/parser.y:
  • layout-tests/fast/selectors/046-expected.txt: Added.
  • layout-tests/fast/selectors/046.html: Added.
10:01 PM Changeset in webkit [9357] by hyatt
  • 2 edits
    2 adds in trunk

Fix for 3237, background image repeats when it shouldn't. The Radar bug is 4005553. Patch from
Nate Cook.

Reviewed by darin and hyatt

Test cases added: fast/backgrounds/001.html

  • khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended):
  • layout-tests/fast/backgrounds/001.html: Added.
6:58 PM Changeset in webkit [9356] by hyatt
  • 3 edits in trunk/WebCore

Merge Allan Jensen's fix for 3236.

Reviewed by hyatt

Test cases added: None, test case already added for the bug.

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/render_style.cpp: (RenderStyle::setContent):
5:42 PM Changeset in webkit [9355] by sullivan
  • 2 edits in trunk/WebKit

reviewed by Dave Harrison (first & second drafts) and Darin Adler (third draft)

  • WebKit part of fix for <rdar://problem/4145214> REGRESSION (412+): Can't drag URLs from the location bar
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): Reinstate variation of old code that uses CreatePasteboardFlavorTypeName to set up our new pasteboard types. The newfangled way didn't work.
5:40 PM Changeset in webkit [9354] by sullivan
  • 2 edits in trunk/WebKitLibraries

Updated copies of WebKitSystemInterface.h and libWebKitSystemInterface.a that include the new functions needed to fix 3446192.

11:02 AM Changeset in webkit [9353] by darin
  • 1 edit
    2 adds in trunk

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Refined and reviewed by me.

  • layout-tests/fast/js/exception-linenums-expected.txt: Added.
  • layout-tests/fast/js/exception-linenums.html: Added.
11:02 AM Changeset in webkit [9352] by darin
  • 3 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Reviewed by me.

  • further improvements to exception file/line number fix
  • kjs/nodes.h: Added setExceptionDetailsIfNeeded function.
  • kjs/nodes.cpp: Updated macros to call the new setExceptionDetailsIfNeeded function. (Node::setExceptionDetailsIfNeeded): Added.

Jun 9, 2005:

11:47 PM Changeset in webkit [9351] by hyatt
  • 2 edits
    2 adds in trunk

Fix from Carston Guenther for bugzilla bug 3236.

attr(x) should work even if x is not present on the element.

This is Radar bug #3584466

Reviewed by hyatt

Test cases added: fast/css-generated-content/013.html

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • layout-tests/fast/css-generated-content/013-expected.txt: Added.
  • layout-tests/fast/css-generated-content/013.html: Added.
9:27 PM Changeset in webkit [9350] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Tested by Mark Rowe.

  • layout-tests/fast/js/date-parse-test.html: Updated this test to use a time zone offset for one of the test cases that's time zone dependent; was working in CA, US, failing in NZ.
9:23 PM Changeset in webkit [9349] by darin
  • 2 edits in trunk

Tested by Brian Dash.

  • layout-tests/fast/js/date-parse-test.html: Updated this test to use a time zone offset for one of the test cases that's time zone dependent; was working in CA, US, failing in NZ.
4:17 PM Changeset in webkit [9348] by darin
  • 5 edits in trunk/WebKitTools

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Change type from "folder" to "wrapper.framework" for Foundation.framework. How was it ever wrong?
  • finally, I tested making the default build directory work; it works now
  • Scripts/webkitdirs.pm: Changed structure of the code a little bit, added symrootXcodeOptions function that sets SYMROOT on the command line in case there's no product directory set in Xcode preferences.
  • Scripts/build-webkit: Pass symrootXcodeOptions when invoking Xcode.
  • Scripts/build-dumprendertree: Ditto.
6:03 AM Changeset in webkit [9347] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>
Reviewed by me.

  • kjs/nodes.cpp: Get rid of unneeded this->.
6:03 AM Changeset in webkit [9346] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Another try at making the default build directory of ~/WebKitBuild work. Someone should try building without setting the Xcode build product directory now, and let me know if it works.

Jun 8, 2005:

11:14 PM Changeset in webkit [9345] by darin
  • 6 edits in trunk/WebKitTools
  • quick fix to try to get build scripts working again
  • Scripts/build-dumprendertree: Add FindBin.
  • Scripts/build-webkit: Ditto.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
10:43 PM Changeset in webkit [9344] by darin
  • 6 edits
    1 add in trunk/WebKitTools

Reviewed by Maciej.

  • some build script enhancements
  • Scripts/build-dumprendertree: Changed to use webkitdirs.
  • Scripts/build-webkit: Changed to use webkitdirs, also only copy files from WebKitLibraries if they are newer.
  • Scripts/run-safari: Reduce number of log messages, change to respect "-d" flag and get Development before Deplyment in that case.
  • Scripts/run-webkit-tests: Changed to use webkitdirs.
  • Scripts/update-webkit: Changed to use webkitdirs.
  • Scripts/webkitdirs.pm: Added.
2:55 AM Changeset in webkit [9343] by mjs
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Oops, i missed the project file changes too.

2:16 AM Changeset in webkit [9342]
  • 7 copies in tags/Safari-1-3-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-3-anchor'.

2:16 AM Changeset in webkit [9341] by mjs
  • 2 adds in trunk/WebCore/khtml/ecma

Add new files that I forgot to check in with the last change.

2:00 AM Changeset in webkit [9340] by mjs
  • 2 edits in trunk/WebKitTools

Code change by Toby Peterson <​toby@opendarwin.org>
Reviewed by me.

  • Scripts/run-safari: Fix to work with Xcode 2.0 again. The script would get confused because build-webkit now makes even 2.0 build directories look like 2.1.
1:39 AM Changeset in webkit [9339] by mjs
  • 3 edits
    4 adds in trunk

Reviewed and committed by Maciej.

<rdar://problem/3533735> implement Mozilla "DOMParser" extension for use with XMLHTTPRequest

Test cases added:

  • layout-tests/fast/dom/dom-parse-serialize-display-expected.txt: Added.
  • layout-tests/fast/dom/dom-parse-serialize-display.html: Added.
  • layout-tests/fast/dom/dom-parse-serialize-expected.txt: Added.
  • layout-tests/fast/dom/dom-parse-serialize.html: Added.
  • khtml/ecma/domparser.h:
  • khtml/ecma/domparser.cpp: Add files implementing the DOMParser object.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: Expose DOMParser object.
12:09 AM Changeset in webkit [9338] by mjs
  • 2 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>
Reviewed by me.

  • kjs/nodes.cpp: Include source file and line number when making exception in KJS_CHECKEXCEPTIONVALUE.
Note: See TracTimeline for information about the timeline view.