Context Navigation

got ready to make m_parent private by removing references to it also removed tabs (and used spaces instead) to files I touched
fixed code that initialized m_parent twice

khtml/css/css_base.cpp: (StyleBaseImpl::checkLoaded): Use parent(). (StyleBaseImpl::stylesheet): Ditto.
khtml/css/css_base.h: (DOM::StyleBaseImpl::StyleBaseImpl): Initialize base TreeShared with the appropriate parent instead of first setting m_parent to 0 and then to the correct value. Also removed setParent, since the base class setParent works fine.
khtml/css/css_ruleimpl.cpp: (DOM::CSSRuleImpl::parentStyleSheet): Use parent(). (DOM::CSSRuleImpl::parentRule): Ditto.
khtml/css/css_stylesheetimpl.cpp: (StyleSheetImpl::parentStyleSheet): Ditto. (MediaListImpl::parentStyleSheet): Ditto. (MediaListImpl::parentRule): Ditto.
khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::parentRule): Ditto.
khtml/rendering/render_replaced.cpp: Reformatting only, and removed some APPLE_CHANGES-only instead.
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isContentEditable): Use parent().
khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::parentNode): Ditto.
khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLImportRuleImpl::parentStyleSheet): Ditto.

4:46 PM Changeset in webkit [10944] by darin

5 edits in trunk/LayoutTests

changed a test to use a GIF instead of a PNG to avoid issues with color correction also, it was using an image that's part of OS X, and it's nicer to have a standalone test

fast/dynamic/genContentDestroyChildren-expected.checksum:
fast/dynamic/genContentDestroyChildren-expected.png:
fast/dynamic/genContentDestroyChildren-expected.txt:
fast/dynamic/genContentDestroyChildren.html:

4:38 PM Changeset in webkit [10943] by darin

3 edits in trunk/WebKit

Reviewed by Geoff.

change internal methods in WebTextRenderer to be functions in case this has any effect on speed (also makes things a bit clearer, in my opinion)

WebCoreSupport.subproj/WebTextRenderer.h: Made all fields public, which is OK since this is really a private class. Made setAlwaysUseATSU: class method public too for the same reason.

WebCoreSupport.subproj/WebTextRenderer.m: Change all methods to functions. (destroy): Function name for method free. (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Removed code to first subtract lineSpacing - descent, then later add it back. (getSmallCapsRenderer): Function name for method smallCapsRenderer. (findSubstituteFont): Function name for method substituteFontForString:families:. (findSubstituteRenderer): Function name for method substituteRendererForCharacters:length:families:. (updateGlyphMapEntry): Function name for method updateGlyphEntryForCharacter:glyphID:substituteRenderer:. (extendGlyphMap): Function name for method extendCharacterToGlyphMapToInclude:. (extendWidthMap): Function name for method extendGlyphToWidthMapToInclude:. (getTextBounds): Function name for method trapezoidForRun:style:atPoint:.

4:23 PM Changeset in webkit [10942] by darin

4 edits in trunk/LayoutTests

fixed results for http://bugzilla.opendarwin.org/show_bug.cgi?id=5415

Mitz's patch removed some strange code about 1-character runs and rounding.
It affected the results of this one test. Here are new results.

fast/text/international/bidi-explicit-embedding-expected.checksum:
fast/text/international/bidi-explicit-embedding-expected.png:
fast/text/international/bidi-explicit-embedding-expected.txt:

3:59 PM Changeset in webkit [10941] by hyatt

2 edits
2 adds in trunk

Fix for 5485, make sure generated content's "rightmost selector"
check does not apply once you move to another selector in the
compound selector chain.

Reviewed by mjs

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector):

3:51 PM Changeset in webkit [10940] by bdakin

4 edits
4 adds in trunk

* empty log message *

3:43 PM Changeset in webkit [10939] by hyatt

2 edits
2 adds in trunk

Make sure the button's generated text using the value with
the default label so that Submit/Reset buttons aren't blank.

Reviewed by mjs

Added fast/forms/blankbuttons.html

khtml/rendering/render_button.cpp: (khtml::RenderButton::updateFromElement):

3:33 PM Changeset in webkit [10938] by mjs

11 edits in trunk

LayoutTests:

Re-landing Dave Hyatt's changes from when the tree was closed.

fast/clip/008-expected.txt:
fast/css/acid2-expected.txt:
fast/css/acid2-pixel-expected.txt:
fast/table/overflowHidden-expected.txt:

WebCore:

Re-landing Dave Hyatt's changes from when the tree was closed.

khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::destroyLeftoverAnonymousChildren):
khtml/rendering/render_container.h:
khtml/rendering/render_flow.cpp: (RenderFlow::destroy):
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent): (khtml::RenderLayer::paintLayer): (khtml::isOverflowOnly): (khtml::compare): (khtml::sortByZOrder):
khtml/rendering/render_layer.h:

2:52 PM Changeset in webkit [10937] by thatcher

2 edits in trunk/WebCore

Reviewed by Darin Adler.
Commited by Tim Hatcher.

fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=5484 REGRESSION: reproducible crash in CachedCSSStyleSheet::setCharset

khtml/misc/loader.cpp: (CachedCSSStyleSheet::setCharset): (CachedScript::setCharset):

2:42 PM Changeset in webkit [10936] by harrison

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5449
"OBJECT should be accessible by id/name as document property only if its only children are PARAMs"

fast/js/object-by-name-or-id-expected.txt: Added.
fast/js/object-by-name-or-id.html: Added.

2:42 PM Changeset in webkit [10935] by harrison

4 edits in trunk/WebCore

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5449
"OBJECT should be accessible by id/name as document property only if its only children are PARAMs"

Test added:

fast/js/object-by-name-or-id-expected.txt: Added.
fast/js/object-by-name-or-id.html: Added.

Files changed:

khtml/html/html_miscimpl.cpp: (DOM::HTMLNameCollectionImpl::traverseNextItem):
khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLObjectElementImpl::insertedIntoDocument): (DOM::HTMLObjectElementImpl::removedFromDocument): (DOM::HTMLObjectElementImpl::childrenChanged): (DOM::HTMLObjectElementImpl::updateDocNamedItem):
khtml/html/html_objectimpl.h: (DOM::HTMLObjectElementImpl::isDocNamedItem):
manual-tests/drag_select_highlighting.html: Added.

2:34 PM Changeset in webkit [10934] by harrison

1 edit
1 add in trunk/WebCore

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5415
"Left border of selection highlight leaves behind a trail"

(Code changes are in WebKit)

manual-tests/drag_select_highlighting.html: Added.

2:22 PM Changeset in webkit [10933] by sullivan

3 edits in trunk/JavaScriptCore

Reviewed by Darin Adler. Code changes by Alexey Proskuryakov.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4931 Unicode format characters (Cf) should be removed from JavaScript source

kjs/lexer.cpp: include <unicode/uchar.h> (Lexer::Lexer): use KJS::UChar instead of UChar to avoid ambiguity caused by new include (Lexer::setCode): ditto; also, use shift(4) to skip first 4 chars to take advantage of new logic there. (Lexer::shift): skip chars of type U_FORMAT_CHAR (Lexer::convertUnicode): use KJS::UChar instead of UChar to avoid ambiguity caused by new include (Lexer::record16): ditto (Lexer::makeIdentifier): ditto (Lexer::makeUString): ditto

tests/mozilla/ecma/Array/15.4.5.1-1.js: updated to skip soft hyphens

1:45 PM Changeset in webkit [10932] by sullivan

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler. Code changes by George Staikos/Geoff Garen.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4142 Date object does not always adjust daylight savings correctly

kjs/date_object.cpp: (KJS::makeTime): Fix the case where a time change crosses the daylight savings start/end dates.

12:40 PM Changeset in webkit [10931] by harrison

2 edits in trunk/WebKit

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5415
"Left border of selection highlight leaves behind a trail"

manual-tests/drag_select_highlighting.html: Added. (this test case was added to WebCore)

WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): (-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer ATSU_drawHighlightForRun:style:geometry:]): (advanceWidthIterator):

12:36 PM Changeset in webkit [10930] by vicki

2 edits in trunk/WebCore

Changes by Mitz Pettel, reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5306 (KHTMLPart::requestObject doesn't destroy old plugin content)

khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::recalcStyle):

11:58 AM Changeset in webkit [10929] by vicki

3 edits in trunk/WebCore

Changes by Alexey Proskuryakov, reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5140 (CachedObject loading ignores charset from HTTP headers)

khtml/misc/loader.cpp: (CachedCSSStyleSheet::setCharset): (CachedScript::setCharset): (CachedXSLStyleSheet::setCharset): (CachedXSLStyleSheet::data): (CachedXBLDocument::CachedXBLDocument): (CachedXBLDocument::setCharset): (CachedXBLDocument::data): (Loader::slotReceivedResponse):
khtml/misc/loader.h:

10:47 AM Changeset in webkit [10928] by bdakin

3 edits
4 adds in trunk

* empty log message *

12:25 AM Changeset in webkit [10927] by eseidel

7 edits in trunk/LayoutTests

Bug #: 5317
Submitted by: darin
Reviewed by: hyatt

Updated tests after fixing QName validation.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5317

dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement-expected.txt:
dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement1-expected.txt:
dom/xhtml/level3/core/canonicalform06-expected.txt:
dom/xhtml/level3/core/infoset06-expected.txt:
dom/xhtml/level3/core/wellformed01-expected.txt:
dom/xhtml/level3/core/wellformed02-expected.txt:

12:24 AM Changeset in webkit [10926] by eseidel

4 edits in trunk/WebCore

Bug #: 5317
Submitted by: darin
Reviewed by: hyatt

Fix Qualified Name parsing to match spec.
xhtml dom tests cover these cases.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5317

khtml/xml/dom_docimpl.cpp: (isValidNameStart): (isValidNamePart): (qualifiedNameIsMalformed): (DOMImplementationImpl::createDocumentType): (DOMImplementationImpl::createDocument): (DocumentImpl::createElementNS): (DocumentImpl::isValidName): (DocumentImpl::parseQualifiedName):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNS):

Oct 23, 2005:

11:55 PM Changeset in webkit [10925] by eseidel

8 edits in trunk

Bug #: 5361
Submitted by: Julien Palmas <julien.palmas@gmail.com>
Reviewed by: eseidel

Finally fix pattern "userspaceonuse" support.
Several test cases already cover this.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5361

kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw):
svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.checksum:
svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:

11:31 PM Changeset in webkit [10924] by eseidel

115 edits
1 add in trunk

Bug #: 5391
Submitted by: Julien Palmas <julien.palmas@gmail.com>
Reviewed by: eseidel

Merged over Shared -> Shared<T> change from kdom.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5391

WebCore.xcodeproj/project.pbxproj:
kdom/Shared.h: (KDOM::Shared::Shared): (KDOM::Shared::~Shared): (KDOM::Shared::refCount): (KDOM::Shared::ref): (KDOM::Shared::deref):
kdom/SharedPtr.h: Added. (KDOM::SharedPtr::SharedPtr): (KDOM::SharedPtr::~SharedPtr): (KDOM::SharedPtr::isNull): (KDOM::SharedPtr::notNull): (KDOM::SharedPtr::reset): (KDOM::SharedPtr::get): (KDOM::SharedPtr::operator!): (KDOM::SharedPtr::operator bool): (KDOM::SharedPtr::operator==): (KDOM::::operator):
kdom/TreeShared.h: (KDOM::TreeShared::TreeShared): (KDOM::TreeShared::~TreeShared): (KDOM::TreeShared::refCount): (KDOM::TreeShared::ref): (KDOM::TreeShared::deref): (KDOM::TreeShared::parent): (KDOM::TreeShared::setParent):
kdom/core/DOMConfigurationImpl.cpp: (DOMConfigurationImpl::DOMConfigurationImpl):
kdom/core/DOMConfigurationImpl.h:
kdom/core/DOMErrorHandlerImpl.cpp: (DOMErrorHandlerImpl::DOMErrorHandlerImpl):
kdom/core/DOMErrorHandlerImpl.h:
kdom/core/DOMErrorImpl.cpp: (DOMErrorImpl::DOMErrorImpl):
kdom/core/DOMErrorImpl.h: (KDOM::):
kdom/core/DOMExceptionImpl.cpp: (DOMExceptionImpl::DOMExceptionImpl):
kdom/core/DOMExceptionImpl.h:
kdom/core/DOMList.h: (KDOM::DOMList::DOMList): (KDOM::DOMList::~DOMList):
kdom/core/DOMLocatorImpl.cpp: (DOMLocatorImpl::DOMLocatorImpl):
kdom/core/DOMLocatorImpl.h:
kdom/core/DOMObjectImpl.cpp: (DOMObjectImpl::DOMObjectImpl):
kdom/core/DOMObjectImpl.h:
kdom/core/DOMStringImpl.cpp: (DOMStringImpl::DOMStringImpl):
kdom/core/DOMStringImpl.h:
kdom/core/DOMUserDataImpl.cpp: (DOMUserDataImpl::DOMUserDataImpl):
kdom/core/DOMUserDataImpl.h:
kdom/core/NamedNodeMapImpl.cpp: (NamedNodeMapImpl::NamedNodeMapImpl):
kdom/core/NamedNodeMapImpl.h:
kdom/core/NodeImpl.h:
kdom/core/NodeListImpl.cpp: (NodeListImpl::NodeListImpl):
kdom/core/NodeListImpl.h:
kdom/core/TypeInfoImpl.cpp: (TypeInfoImpl::TypeInfoImpl):
kdom/core/TypeInfoImpl.h:
kdom/css/CSSRuleListImpl.cpp: (CSSRuleListImpl::CSSRuleListImpl):
kdom/css/CSSRuleListImpl.h:
kdom/css/CounterImpl.cpp: (CounterImpl::CounterImpl):
kdom/css/CounterImpl.h:
kdom/css/RGBColorImpl.cpp: (RGBColorImpl::RGBColorImpl):
kdom/css/RGBColorImpl.h:
kdom/css/RectImpl.cpp: (RectImpl::RectImpl):
kdom/css/RectImpl.h:
kdom/css/RenderStyle.cpp: (RenderStyle::RenderStyle):
kdom/css/RenderStyle.h: (KDOM::RenderStyle::RenderStyle):
kdom/css/RenderStyleDefs.cpp: (StyleSurroundData::StyleSurroundData): (StyleBoxData::StyleBoxData): (StyleVisualData::StyleVisualData): (StyleBackgroundData::StyleBackgroundData): (StyleMarqueeData::StyleMarqueeData): (StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (StyleCSS3InheritedData::StyleCSS3InheritedData): (StyleInheritedData::StyleInheritedData):
kdom/css/RenderStyleDefs.h: (KDOM::BorderData::BorderData):
kdom/css/StyleSheetListImpl.cpp: (StyleSheetListImpl::StyleSheetListImpl):
kdom/css/StyleSheetListImpl.h:
kdom/events/EventExceptionImpl.cpp: (EventExceptionImpl::EventExceptionImpl):
kdom/events/EventExceptionImpl.h:
kdom/events/EventImpl.cpp: (EventImpl::EventImpl):
kdom/events/EventImpl.h:
kdom/events/EventListenerImpl.cpp: (EventListenerImpl::EventListenerImpl):
kdom/events/EventListenerImpl.h:
kdom/ls/LSExceptionImpl.cpp: (LSExceptionImpl::LSExceptionImpl):
kdom/ls/LSExceptionImpl.h:
kdom/ls/LSInputImpl.cpp: (LSInputImpl::LSInputImpl):
kdom/ls/LSInputImpl.h:
kdom/ls/LSOutputImpl.cpp: (LSOutputImpl::LSOutputImpl):
kdom/ls/LSOutputImpl.h:
kdom/ls/LSParserFilterImpl.cpp: (LSParserFilterImpl::LSParserFilterImpl):
kdom/ls/LSParserFilterImpl.h:
kdom/ls/LSResourceResolverImpl.cpp: (LSResourceResolverImpl::LSResourceResolverImpl):
kdom/ls/LSResourceResolverImpl.h:
kdom/ls/LSSerializerImpl.cpp: (LSSerializerImpl::LSSerializerImpl):
kdom/ls/LSSerializerImpl.h:
kdom/range/RangeExceptionImpl.cpp: (RangeExceptionImpl::RangeExceptionImpl):
kdom/range/RangeExceptionImpl.h:
kdom/range/RangeImpl.cpp: (RangeImpl::RangeImpl):
kdom/range/RangeImpl.h:
kdom/traversal/NodeFilterImpl.cpp: (NodeFilterImpl::NodeFilterImpl):
kdom/traversal/NodeFilterImpl.h: (KDOM::NodeFilterCondition::NodeFilterCondition): (KDOM::NodeFilterCondition::~NodeFilterCondition): (KDOM::NodeFilterCondition::acceptNode):
kdom/traversal/TraversalImpl.cpp: (TraversalImpl::TraversalImpl):
kdom/traversal/TraversalImpl.h:
kdom/views/AbstractViewImpl.cpp: (AbstractViewImpl::AbstractViewImpl):
kdom/views/AbstractViewImpl.h:
kdom/xpath/XPathExceptionImpl.h:
kdom/xpath/XPathExpressionImpl.h:
kdom/xpath/XPathNSResolverImpl.h:
kdom/xpath/XPathResultImpl.h:
kdom/xpointer/NBCImpl.cpp: (NBCImpl::NBCImpl):
kdom/xpointer/NBCImpl.h:
kdom/xpointer/PointerPartImpl.cpp: (PointerPartImpl::PointerPartImpl):
kdom/xpointer/PointerPartImpl.h:
kdom/xpointer/XPointerExceptionImpl.cpp: (XPointerExceptionImpl::XPointerExceptionImpl):
kdom/xpointer/XPointerExceptionImpl.h:
kdom/xpointer/XPointerExpressionImpl.cpp: (XPointerExpressionImpl::XPointerExpressionImpl):
kdom/xpointer/XPointerExpressionImpl.h:
kdom/xpointer/XPointerResultImpl.cpp: (XPointerResultImpl::XPointerResultImpl):
kdom/xpointer/XPointerResultImpl.h:
ksvg2/css/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleClipData::StyleClipData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
ksvg2/css/SVGRenderStyleDefs.h:
ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::SVGAngleImpl):
ksvg2/svg/SVGAngleImpl.h:
ksvg2/svg/SVGAnimatedBooleanImpl.cpp: (SVGAnimatedBooleanImpl::SVGAnimatedBooleanImpl):
ksvg2/svg/SVGAnimatedBooleanImpl.h:
ksvg2/svg/SVGAnimatedEnumerationImpl.cpp: (SVGAnimatedEnumerationImpl::SVGAnimatedEnumerationImpl):
ksvg2/svg/SVGAnimatedEnumerationImpl.h:
ksvg2/svg/SVGAnimatedIntegerImpl.cpp: (SVGAnimatedIntegerImpl::SVGAnimatedIntegerImpl):
ksvg2/svg/SVGAnimatedIntegerImpl.h:
ksvg2/svg/SVGAnimatedNumberImpl.cpp: (SVGAnimatedNumberImpl::SVGAnimatedNumberImpl):
ksvg2/svg/SVGAnimatedNumberImpl.h:
ksvg2/svg/SVGAnimatedTemplate.h: (KSVG::SVGAnimatedTemplate::SVGAnimatedTemplate):
ksvg2/svg/SVGExceptionImpl.cpp: (SVGExceptionImpl::SVGExceptionImpl):
ksvg2/svg/SVGExceptionImpl.h:
ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::SVGLengthImpl):
ksvg2/svg/SVGLengthImpl.h:
ksvg2/svg/SVGMatrixImpl.cpp: (SVGMatrixImpl::SVGMatrixImpl):
ksvg2/svg/SVGMatrixImpl.h:
ksvg2/svg/SVGNumberImpl.cpp: (SVGNumberImpl::SVGNumberImpl):
ksvg2/svg/SVGNumberImpl.h:
ksvg2/svg/SVGPathSegImpl.cpp: (SVGPathSegImpl::SVGPathSegImpl):
ksvg2/svg/SVGPathSegImpl.h:
ksvg2/svg/SVGPointImpl.cpp: (SVGPointImpl::SVGPointImpl):
ksvg2/svg/SVGPointImpl.h:
ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
ksvg2/svg/SVGPreserveAspectRatioImpl.h:
ksvg2/svg/SVGRectImpl.cpp: (SVGRectImpl::SVGRectImpl):
ksvg2/svg/SVGRectImpl.h:
ksvg2/svg/SVGTransformImpl.cpp: (SVGTransformImpl::SVGTransformImpl):
ksvg2/svg/SVGTransformImpl.h:

11:14 PM Changeset in webkit [10923] by eseidel

2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: No review, build fix only.

WebCore.xcodeproj/project.pbxproj: added RenderButton.cpp

7:13 PM Changeset in webkit [10922] by tomernic

4 edits in trunk/WebKit

Bug #: <http://bugzilla.opendarwin.org/show_bug.cgi?id=5365>
Submitted by: mitzpettel
Reviewed by: Dave Hyatt

Send -webPlugInStop (or -pluginStop) and -webPluginDestroy (or -pluginDestroy)
to complying plugins right when they're removed from the WebHTMLView, and also
release them from the plugin controller's arrays.

I think this patch makes WebKit behave more like plugins expect it to, which is
the way it already behaves with Netscape plugins.

I expect complying plugins to stop making noise when receiving the stop
message, but QuickTime doesn't. If it's lucky, then it will be deallocated
because of the release and will stop then. However, JS, for one, can retain the
plugin (e.g. if you execute <javascript:document.getElementById('obj').width;>
before clicking Remove OBJECT), in which case it will just keep playing.

6:43 PM Changeset in webkit [10921] by ggaren

2 edits in trunk/WebKit

Reviewed by Maciej.

For better abstraction, made the tokenizer -- instead of the
data source -- responsible for calling [WebFrame _checkLoadComplete]
when the tokenizer stops.

WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]):

6:39 PM Changeset in webkit [10920] by ggaren

3 edits in trunk/WebCore

Reviewed by Maciej.

Removed early return from stopLoading because it prevented
onunload events from firing.

Also, for better abstraction, made the tokenizer -- instead of the
data source -- responsible for calling [WebFrame _checkLoadComplete]
when the tokenizer stops.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::stopParsing):
khtml/khtml_part.cpp: (KHTMLPart::stopLoading):

11:00 AM Changeset in webkit [10919] by eseidel

2 edits in trunk/WebCore

Bug #: 5462
Submitted by: Julien Palmas <julien.palmas@gmail.com>
Reviewed by: mjs

WebCore+SVG/xml_kdomtokenizer.cpp: (KDOMTokenizer::KDOMTokenizer): build fix. http://bugzilla.opendarwin.org/show_bug.cgi?id=5462

8:24 AM Changeset in webkit [10918] by thatcher

1 edit
4 adds in trunk/LayoutTests

Layout test to go with fix for bugzilla bug 3442
Adds support for :first-of-type CSS3 pseudo-selectors

fast/selectors/034-expected.checksum: Added.
fast/selectors/034-expected.png: Added.
fast/selectors/034-expected.txt: Added.
fast/selectors/034.html: Added.

8:12 AM Changeset in webkit [10917] by thatcher

4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3442
Adds support for :first-of-type CSS3 pseudo-selectors
And builds foundations for :last-of-type and :only-of-type

khtml/css/css_base.cpp: (CSSSelector::extractPseudoType):
khtml/css/css_base.h: (DOM::CSSSelector::CSSSelector): (DOM::CSSSelector::~CSSSelector): (DOM::CSSSelector::): (DOM::CSSSelector::pseudoType): (DOM::StyleBaseImpl::StyleBaseImpl): (DOM::StyleBaseImpl::~StyleBaseImpl): (DOM::StyleBaseImpl::isStyleSheet): (DOM::StyleBaseImpl::isCSSStyleSheet): (DOM::StyleBaseImpl::isStyleSheetList): (DOM::StyleBaseImpl::isMediaList): (DOM::StyleBaseImpl::isRuleList): (DOM::StyleBaseImpl::isRule): (DOM::StyleBaseImpl::isStyleRule): (DOM::StyleBaseImpl::isCharetRule): (DOM::StyleBaseImpl::isImportRule): (DOM::StyleBaseImpl::isMediaRule): (DOM::StyleBaseImpl::isFontFaceRule): (DOM::StyleBaseImpl::isPageRule): (DOM::StyleBaseImpl::isUnknownRule): (DOM::StyleBaseImpl::isStyleDeclaration): (DOM::StyleBaseImpl::isValue): (DOM::StyleBaseImpl::isPrimitiveValue): (DOM::StyleBaseImpl::isValueList): (DOM::StyleBaseImpl::isValueCustom): (DOM::StyleBaseImpl::setParent): (DOM::StyleBaseImpl::parseString): (DOM::StyleBaseImpl::setStrictParsing): (DOM::StyleBaseImpl::useStrictParsing): (DOM::StyleListImpl::StyleListImpl): (DOM::StyleListImpl::length): (DOM::StyleListImpl::item): (DOM::StyleListImpl::append):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):

Oct 22, 2005:

3:55 PM Changeset in webkit [10916] by darin

17 edits
56 adds in trunk/LayoutTests

updated pixel results for tests with results that changed recently

editing/selection/3690703-2-expected.checksum:
editing/selection/3690703-2-expected.png:
editing/selection/3690703-expected.checksum:
editing/selection/3690703-expected.png:
editing/selection/3690719-expected.checksum:
editing/selection/3690719-expected.png:
fast/forms/001-expected.checksum:
fast/forms/001-expected.png:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/formmove3-expected.checksum:
fast/forms/formmove3-expected.png:
fast/forms/input-value-expected.checksum:
fast/forms/input-value-expected.png:
fast/selectors/064-expected.checksum:
fast/selectors/064-expected.png:

added pixel results for a bunch of tests that, for whatever reason, didn't have them

dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Added.
dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Added.
dom/xhtml/level2/html/HTMLBodyElement01-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBodyElement01-expected.png: Added.
dom/xhtml/level2/html/HTMLBodyElement02-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBodyElement02-expected.png: Added.
dom/xhtml/level2/html/HTMLBodyElement03-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBodyElement03-expected.png: Added.
dom/xhtml/level2/html/HTMLBodyElement04-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBodyElement04-expected.png: Added.
dom/xhtml/level2/html/HTMLBodyElement05-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBodyElement05-expected.png: Added.
dom/xhtml/level2/html/HTMLBodyElement06-expected.checksum: Added.
dom/xhtml/level2/html/HTMLBodyElement06-expected.png: Added.
dom/xhtml/level2/html/body01-expected.checksum: Added.
dom/xhtml/level2/html/body01-expected.png: Added.
dom/xhtml/level2/html/frame-expected.checksum: Added.
dom/xhtml/level2/html/frame-expected.png: Added.
dom/xhtml/level2/html/iframe-expected.checksum: Added.
dom/xhtml/level2/html/iframe-expected.png: Added.
dom/xhtml/level3/core/canonicalform08-expected.checksum: Added.
dom/xhtml/level3/core/canonicalform08-expected.png: Added.
dom/xhtml/level3/core/canonicalform09-expected.checksum: Added.
dom/xhtml/level3/core/canonicalform09-expected.png: Added.
dom/xhtml/level3/core/documentgetinputencoding03-expected.checksum: Added.
dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
dom/xhtml/level3/core/documentgetxmlencoding03-expected.checksum: Added.
dom/xhtml/level3/core/documentgetxmlencoding03-expected.png: Added.
dom/xhtml/level3/core/entitygetinputencoding02-expected.checksum: Added.
dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
dom/xhtml/level3/core/entitygetxmlversion02-expected.checksum: Added.
dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri05-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri07-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri09-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri10-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri11-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri15-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri17-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
dom/xhtml/level3/core/nodegetbaseuri18-expected.checksum: Added.
dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.checksum: Added.
dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
dom/xhtml/level3/core/nodelookupprefix19-expected.checksum: Added.
dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
fast/forms/button-sizes-expected.checksum: Added.
fast/forms/button-sizes-expected.png: Added.

2:32 PM Changeset in webkit [10915] by hyatt

1 edit in trunk/LayoutTests/fast/forms/001-expected.txt

check in revised results for forms minwidth test

12:59 PM Changeset in webkit [10914]

343 copies
34 deletes in branches/Ti-2005-009-branch

This commit was manufactured by cvs2svn to create branch
'Ti-2005-009-branch'.

12:59 PM Changeset in webkit [10913]

343 copies
34 deletes in tags/Ti-2005-009-anchor

This commit was manufactured by cvs2svn to create tag
'Ti-2005-009-anchor'.

12:59 PM Changeset in webkit [10912]

343 copies
34 deletes in tags/Safari-2~0~2

This commit was manufactured by cvs2svn to create tag 'Safari-2~0~2'.

12:59 PM Changeset in webkit [10911] by thatcher

1 edit in branches/Safari-Den-branch/WebCore/ChangeLog-2005-12-19

Added the radar to my last commit in the ChangeLog
<rdar://problem/4310534> Denver Regression: Removing empty lines at end of signature crashes Mail

11:24 AM Changeset in webkit [10910] by hyatt

3 edits in trunk/LayoutTests/editing/selection

Land updated editing layout tests for buttons.

11:19 AM Changeset in webkit [10909] by hyatt

11 edits in trunk/WebCore

Reviewed by darin

khtml/css/cssstyleselector.cpp: Add support for the GrayText CSS2 system color to represent the disabled text color for controls.

khtml/css/html4.css: Make sure that the default cursor is set for all types of buttons and not just the HTML4 button.

Set the foreground color for buttons using the CSS2 system color.
Set the disabled text color using the CSS2 system color.

Move the default padding for buttons into the CSS file. It will
get overridden by Aqua buttons but be honored by all other types
of buttons. This allows the author to override it as well when
customizing.

khtml/rendering/render_block.h: Make paintChildren virtual so that RenderButton can push a clip and pop a clip when painting children.

khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations): Let the theme now decide whether the border/background should still be painted after the theme has painted. This allows buttons to paint custom borders but still use a pretty OS X background for the button face.

khtml/rendering/render_button.cpp: (khtml::RenderButton::paintChildren): Overridden to push/pop a clip so that the contents of a button don't ever spill out.

khtml/rendering/render_button.h: Added paintChildren method.

khtml/rendering/render_style.h: (khtml::BorderData::hasBorder): Fixed a regression in hasBorder. The border-image logic was inverted, resulting in hasBorder being true for every element!

khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint): Patched to return a boolean indicating whether or not the border/background should be painted.

khtml/rendering/render_theme.h:
khtml/rendering/render_theme_mac.h:
khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustRepaintRect): Forgot to include radio and button in this method so that repaint rects would be correct.

(khtml::RenderThemeMac::paintCheckbox):
(khtml::RenderThemeMac::paintRadio):
Adjusted to return the boolean to indicate that painting of
border/background should not occur.

(khtml::RenderThemeMac::adjustButtonStyle):
Added support for border/background/colors. Also locked
white-space to nowrap for Aqua buttons to avoid line wrapping.

(khtml::RenderThemeMac::setButtonCellState):
(khtml::RenderThemeMac::paintButton):
More support for custom border/background/color.

Oct 21, 2005:

9:38 PM Changeset in webkit [10908] by hyatt

1 edit in trunk/WebCore/khtml/khtml_part.cpp

Put back in the hasRef() check for jumping to anchors to fix the regression (bug 5457)

8:07 PM Changeset in webkit [10907]

210 copies
15 deletes in tags/WebCore-416~13

This commit was manufactured by cvs2svn to create tag
'WebCore-416~13'.

8:07 PM Changeset in webkit [10906] by thatcher

2 edits in branches/Safari-Den-branch/WebCore

Versioning just in case to WebCore-416.13

8:06 PM Changeset in webkit [10905] by thatcher

2 edits in branches/Safari-Den-branch/WebCore

Reviewed by Justin Garcia.

If node is an ancestor of refNode, use the highest non-common ancestor instead
(otherwise we would be trying to append refNode's ancestor after refNode)

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode):

6:42 PM Changeset in webkit [10904] by ggaren

2 edits in trunk/WebKit

Reviewed by darin.

WebKit side of the fix for <rdar://problem/4184719> window.print() followed by
window.close() causes world leak

No test case added because I have another reviewed patch that will include a test
for this bug as well as many others.

Under some conditions, [WebDataSource stopLoading] did not set [WebDataSource isLoading]
to false, so the didFInishLoad delegates never fired.

The reason isLoading didn't become false was that the tokenizer was still running.
The fix here is to move the call to [WebCoreBridge stopLoading] above the early return
inside [WebDataSource stopLoading] -- since the tokenizer may still be running even if the
loader is finished loading -- and then to call [WebFrame _checkLoadComplete] to
give the frame a chance to fire its delegates.

WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]):

6:41 PM Changeset in webkit [10903] by ggaren

7 edits in trunk/WebCore

Reviewed by darin.

WebCore side of fix for <rdar://problem/4184719> window.print() followed by window.close()
causes world leak

No test case added because I have another reviewed patch that will include a test
for this bug as well as many others.

Under some conditions, [WebDataSource stopLoading] did not set [WebDataSource isLoading]
to false, so the didFInishLoad delegates never fired.

The reason isLoading didn't become false was that the tokenizer was still running.
The fix here is to add a call to Tokenizer::stopParsing inside HTMLPart::stopLoading.

Since the WebKit side of the fix eliminates an early return that used to protect
HTMLPart::stopLoading from multiple calls, I added an early return inside
HTMLPart::stopLoading.

I also merged stopped and stopLoading, and merged the way XMLTokenizer and HTMLTokenizer
track whether they're in a stopped state, because anything less would be uncivilized.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::stopParsing): (khtml::HTMLTokenizer::processToken):
khtml/html/htmltokenizer.h:
khtml/khtml_part.cpp: (KHTMLPart::stopLoading): (KHTMLPart::endIfNotLoading): (KHTMLPart::stop):
khtml/xml/xml_tokenizer.cpp: (khtml::Tokenizer::Tokenizer): (khtml::Tokenizer::finishedParsing): (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::endElementNs): (khtml::XMLTokenizer::characters): (khtml::XMLTokenizer::error): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::cdataBlock): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::stopParsing):
khtml/xml/xml_tokenizer.h: (khtml::Tokenizer::stopParsing):
kwq/KWQSignalStubs.mm: (Loader::requestStarted):

6:10 PM Changeset in webkit [10902] by bdakin

3 edits
4 adds in trunk

* empty log message *

5:11 PM Changeset in webkit [10901] by bdakin

2 edits
4 adds in trunk

* empty log message *

5:06 PM Changeset in webkit [10900] by mjs

3 edits in trunk/LayoutTests

Reviewed by Eric, landed by Maciej.

fixed xmlhttprequest test to not depend on property enumeration order

fast/js/xmlhttprequest-get-expected.txt:
fast/js/xmlhttprequest-get.xhtml:

4:35 PM Changeset in webkit [10899] by mjs

8 edits
2 deletes in trunk/LayoutTests

temporarily reverted test changes corresponding to reverted changes

dom/xhtml/level3/core/nodeissamenode01-expected.txt:
dom/xhtml/level3/core/nodeissamenode02-expected.txt:
dom/xhtml/level3/core/nodeissamenode03-expected.txt:
dom/xhtml/level3/core/nodeissamenode04-expected.txt:
dom/xhtml/level3/core/nodeissamenode05-expected.txt:
dom/xhtml/level3/core/nodeissamenode06-expected.txt:
dom/xhtml/level3/core/nodeissamenode10-expected.txt:
fast/js/for-in-expected.txt: Removed.
fast/js/for-in.html: Removed.

4:13 PM Changeset in webkit [10898] by vicki

1 add in trunk/WebCore/manual-tests/linkjump-1.html

forgot to add this file in my previous commit

4:11 PM Changeset in webkit [10897] by vicki

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/4304213> sometimes have to click twice to jump to top, on href=""

manual-tests/linkjump-1.html: Added.
khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): remove check for m_url.hasRef() - encodedHtmlRef and gotoAnchor handle empty strings for scrolling to the top of the document

3:55 PM Changeset in webkit [10896] by bdakin

1 edit
4 adds in trunk/LayoutTests

Bug #:
Submitted by:
Reviewed by:

3:49 PM Changeset in webkit [10895] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:45 PM Changeset in webkit [10894] by sullivan

2 edits in trunk/WebCore

No test cases added.

khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setButtonPaddingFromControlSize): fix deployment build by adding default: statement to button-size switch statement

3:17 PM Changeset in webkit [10893]

52 copies
22 deletes in tags/WebKit-417~3

This commit was manufactured by cvs2svn to create tag 'WebKit-417~3'.

3:17 PM Changeset in webkit [10892] by thatcher

2 edits in branches/Safari-2-0-branch/WebKit

Versioning WebKit to 417.3

3:04 PM Changeset in webkit [10891] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

2:43 PM Changeset in webkit [10890] by hyatt

2 adds in trunk/LayoutTests/fast/forms

add new test of html4 button font sizes.

2:41 PM Changeset in webkit [10889] by hyatt

8 edits in trunk/LayoutTests/fast

Update the fast layout tests to have the new buttons.

2:27 PM Changeset in webkit [10888] by hyatt

19 edits
2 adds
5 deletes in trunk/WebCore

Land the new "NSView-less" buttons. With this landing both
<input type=button> and <button> will now look like OS X-style
widgets. Customization of background and border is not yet
enabled, but this is still a big improvement over the old
AppKit widgets.

Reviewed by mjs

ForwardingHeaders/qpushbutton.h: Removed.
WebCore.xcodeproj/project.pbxproj:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
khtml/css/cssstyleselector.h: (khtml::CSSStyleSelector::paintMetrics):
khtml/css/cssvalues.in:
khtml/css/html4.css:
khtml/html/html_formimpl.cpp: (DOM::HTMLButtonElementImpl::createRenderer): (DOM::HTMLInputElementImpl::click): (DOM::HTMLInputElementImpl::createRenderer):
khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::isTextButton):
khtml/rendering/render_button.cpp: Added. (khtml::m_inner): (khtml::RenderButton::~RenderButton): (khtml::RenderButton::addChild): (khtml::RenderButton::removeChild): (khtml::RenderButton::setStyle): (khtml::RenderButton::updateFromElement):
khtml/rendering/render_button.h: Added. (khtml::RenderButton::removeLeftoverAnonymousBoxes): (khtml::RenderButton::renderName):
khtml/rendering/render_form.cpp:
khtml/rendering/render_form.h: (khtml::RenderFileButton::calcReplacedHeight): (khtml::RenderFileButton::isEditable):
khtml/rendering/render_style.h: (khtml::):
khtml/rendering/render_theme.cpp: (khtml::RenderTheme::adjustStyle): (khtml::RenderTheme::paint): (khtml::RenderTheme::adjustCheckboxStyle): (khtml::RenderTheme::adjustRadioStyle): (khtml::RenderTheme::adjustButtonStyle):
khtml/rendering/render_theme.h: (khtml::RenderTheme::setButtonSize):
khtml/rendering/render_theme_mac.h:
khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setSizeFromFont): (khtml::RenderThemeMac::setFontFromControlSize): (khtml::RenderThemeMac::addIntrinsicMargins): (khtml::RenderThemeMac::setButtonPaddingFromControlSize): (khtml::RenderThemeMac::adjustButtonStyle): (khtml::RenderThemeMac::buttonSizes): (khtml::RenderThemeMac::buttonMargins): (khtml::RenderThemeMac::setButtonSize): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
kwq/KWQAccObject.mm: (-[KWQAccObject actionElement]): (-[KWQAccObject role]): (-[KWQAccObject title]):
kwq/KWQButton.h: Removed.
kwq/KWQButton.mm: Removed.
kwq/KWQComboBox.mm:
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm:
kwq/KWQPushButton.h: Removed.
kwq/KWQPushButton.mm: Removed.

2:20 PM Changeset in webkit [10887]

203 copies
15 deletes in tags/WebCore-417~4

This commit was manufactured by cvs2svn to create tag
'WebCore-417~4'.

2:20 PM Changeset in webkit [10886]

69 copies
5 deletes in tags/JavaScriptCore-417~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~3'.

2:20 PM Changeset in webkit [10885] by thatcher

4 edits in branches/Safari-2-0-branch

Versioning WebCore and JavaScriptCore-417.3

2:04 PM Changeset in webkit [10884] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_binding.cpp

Rolling out some local test changes that CVS wasn't suppose to commit.

1:58 PM Changeset in webkit [10883] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-19 Adele Peterson <adele@apple.com>

Reviewed by Hyatt.

Fixed <rdar://problem/4243807> Denver Regression: DOM returns lower case strings for tags in empty document

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLDocumentImpl): initialize hMode to Html4.

11:43 AM Changeset in webkit [10882] by ggaren

2 edits in trunk/WebKit

Patch by TimO, Reviewed by hyatt, tested and landed by me.

Found what appears to be a misguided optimization that actually causes a measurable performance problem.
A fixed-size buffer was allocated on the stack to pass into CFURLGetBytes(), presumably to avoid malloc()
for URLs less than 2048 bytes. There was also a fallback which malloc()'ed a buffer in case the fixed-size
buffer was too small to hold the URL's bytes. This malloc()'ed buffer was then wrapped in an NSData using
+dataWithBytesNoCopy:length:, avoiding a memory copy (yay!)

The problem with this approach is two-fold:

Regardless of how the buffer was allocated and filled, it is immediately wrapped in an NSData using +dataWithBytes:length:, which copies the input bytes. This is pretty much unavoidable; we need to get the data into a malloc()'ed buffer to return it to the caller, unless the caller provides its own storage (which would be super inconvenient).

The size of the fixed buffer was large enough that it fit most (if not all) URLs involved in our Page Load Test. This means the unintentionally-inefficient case was by far the most *common* case!

My fix is to malloc() the buffer from the start, and then use +[NSData dataWithBytes:length:freeWhenDone:]
to wrap the buffer in an NSData. This avoids a memory copy for the normal case where a URL is less than
2048 bytes, and keeps the efficient behavior for the uncommon long URL case.

Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_originalData]):

9:35 AM Changeset in webkit [10881] by darin

2 edits in trunk/WebKit

Reviewed and landed by Darin.

fixed a couple regressions caused by my last check-in http://bugzilla.opendarwin.org/show_bug.cgi?id=5437 http://bugzilla.opendarwin.org/show_bug.cgi?id=5443

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]): Compute background width correctly, by subtracting position after run from position before run. (addDirectionalOverride): Make the range include only the characters between the directional override characters, not the directional override characters themselves. (initializeWidthIterator): Correctly compute "widthToStart" based on the offset to the beginning of the run, not to the end of the run!

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed